Cleanup, simplify, fix typos

This commit is contained in:
Roy Nieterau 2018-02-20 18:24:51 +01:00
parent 806c37c742
commit 01ec54651d

View file

@ -6,10 +6,10 @@ import pyblish.api
class ValidateFilenameHasExtension(pyblish.api.InstancePlugin): class ValidateFilenameHasExtension(pyblish.api.InstancePlugin):
"""Ensure the Saver has an extension in the filename path """Ensure the Saver has an extension in the filename path
This is to counter any possible file being written as `filename` instead This disallows files written as `filename` instead of `filename.frame.ext`.
of `filename.frame.ext`. Fusion does not always set an extension for your filename when
Fusion does not set an extension for your filename changing the file format of the saver.
when changing the file format of the saver.
""" """
order = pyblish.api.ValidatorOrder order = pyblish.api.ValidatorOrder
@ -20,7 +20,7 @@ class ValidateFilenameHasExtension(pyblish.api.InstancePlugin):
def process(self, instance): def process(self, instance):
invalid = self.get_invalid(instance) invalid = self.get_invalid(instance)
if invalid: if invalid:
raise RuntimeError("Found Saver(s) without a extesions") raise RuntimeError("Found Saver without an extension")
@classmethod @classmethod
def get_invalid(cls, instance): def get_invalid(cls, instance):
@ -29,9 +29,8 @@ class ValidateFilenameHasExtension(pyblish.api.InstancePlugin):
fname, ext = os.path.splitext(path) fname, ext = os.path.splitext(path)
if not ext: if not ext:
cls.log.error("%s has no extension specified" % tool = instance[0]
instance[0].Name) cls.log.error("%s has no extension specified" % tool.Name)
# Return the tool return [tool]
return [instance[0]]
return [] return []