From 08f43824093f6ef7b15e6f5debcd264a5378c452 Mon Sep 17 00:00:00 2001
From: iLLiCiTiT <jakub.trllo@gmail.com>
Date: Thu, 16 Sep 2021 15:01:21 +0200
Subject: [PATCH] use args as list where possible

---
 .../plugins/publish/extract_review.py         |  6 +++--
 .../publish/extract_trim_video_audio.py       | 25 +++++++++++--------
 2 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/openpype/hosts/photoshop/plugins/publish/extract_review.py b/openpype/hosts/photoshop/plugins/publish/extract_review.py
index b52078fd5f..1c53c3a2ef 100644
--- a/openpype/hosts/photoshop/plugins/publish/extract_review.py
+++ b/openpype/hosts/photoshop/plugins/publish/extract_review.py
@@ -60,7 +60,8 @@ class ExtractReview(openpype.api.Extractor):
         # Generate thumbnail.
         thumbnail_path = os.path.join(staging_dir, "thumbnail.jpg")
         args = [
-            "{}".format(ffmpeg_path), "-y",
+            ffmpeg_path,
+            "-y",
             "-i", output_image_path,
             "-vf", "scale=300:-1",
             "-vframes", "1",
@@ -78,7 +79,8 @@ class ExtractReview(openpype.api.Extractor):
         # Generate mov.
         mov_path = os.path.join(staging_dir, "review.mov")
         args = [
-            ffmpeg_path, "-y",
+            ffmpeg_path,
+            "-y",
             "-i", output_image_path,
             "-vf", "pad=ceil(iw/2)*2:ceil(ih/2)*2",
             "-vframes", "1",
diff --git a/openpype/hosts/standalonepublisher/plugins/publish/extract_trim_video_audio.py b/openpype/hosts/standalonepublisher/plugins/publish/extract_trim_video_audio.py
index 059ac9603c..4d482825bc 100644
--- a/openpype/hosts/standalonepublisher/plugins/publish/extract_trim_video_audio.py
+++ b/openpype/hosts/standalonepublisher/plugins/publish/extract_trim_video_audio.py
@@ -59,27 +59,30 @@ class ExtractTrimVideoAudio(openpype.api.Extractor):
                     if "trimming" not in fml
                 ]
 
-            args = [
-                f"\"{ffmpeg_path}\"",
+            ffmpeg_args = [
+                ffmpeg_path,
                 "-ss", str(start / fps),
-                "-i", f"\"{video_file_path}\"",
+                "-i", video_file_path,
                 "-t", str(dur / fps)
             ]
             if ext in [".mov", ".mp4"]:
-                args.extend([
+                ffmpeg_args.extend([
                     "-crf", "18",
-                    "-pix_fmt", "yuv420p"])
+                    "-pix_fmt", "yuv420p"
+                ])
             elif ext in ".wav":
-                args.extend([
-                    "-vn -acodec pcm_s16le",
-                    "-ar 48000 -ac 2"
+                ffmpeg_args.extend([
+                    "-vn",
+                    "-acodec", "pcm_s16le",
+                    "-ar", "48000",
+                    "-ac", "2"
                 ])
 
             # add output path
-            args.append(f"\"{clip_trimed_path}\"")
+            ffmpeg_args.append(clip_trimed_path)
 
-            self.log.info(f"Processing: {args}")
-            ffmpeg_args = " ".join(args)
+            joined_args = " ".join(ffmpeg_args)
+            self.log.info(f"Processing: {joined_args}")
             openpype.api.run_subprocess(
                 ffmpeg_args, shell=True, logger=self.log
             )