Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-24 21:04:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Kitsu: Slightly less strict with instance data (#4678)

Browse source 
* Match family and families

* Allow kitsu note to not have set comment and capture it without erroring in IntegrateKitsuReview

* Allow fallback to context for instance `task`

* Shush hound

* Refactor variable names
This commit is contained in:
Roy Nieterau 2023-03-23 12:06:05 +01:00 • committed by GitHub
parent 4d53e4f5fb
commit 0a085c7001
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
openpype/modules/kitsu/plugins/publish/collect_kitsu_entities.py
View file

@ -29,7 +29,7 @@ class CollectKitsuEntities(pyblish.api.ContextPlugin):
if not zou_asset_data:
raise ValueError("Zou asset data not found in OpenPype!")
task_name = instance.data.get("task")
task_name = instance.data.get("task", context.data.get("task"))
if not task_name:
continue

5
openpype/modules/kitsu/plugins/publish/integrate_kitsu_note.py
View file

@ -48,7 +48,10 @@ class IntegrateKitsuNote(pyblish.api.ContextPlugin):
def process(self, context):
for instance in context:
# Check if instance is a review by checking its family
if "review" not in instance.data["families"]:
# Allow a match to primary family or any of families
families = set([instance.data["family"]] +
instance.data.get("families", []))
if "review" not in families:
continue
kitsu_task = instance.data.get("kitsu_task")

8
openpype/modules/kitsu/plugins/publish/integrate_kitsu_review.py
View file

@ -12,17 +12,17 @@ class IntegrateKitsuReview(pyblish.api.InstancePlugin):
optional = True
def process(self, instance):
task = instance.data["kitsu_task"]["id"]
comment = instance.data["kitsu_comment"]["id"]
# Check comment has been created
if not comment:
comment_id = instance.data.get("kitsu_comment", {}).get("id")
if not comment_id:
self.log.debug(
"Comment not created, review not pushed to preview."
)
return
# Add review representations as preview of comment
task_id = instance.data["kitsu_task"]["id"]
for representation in instance.data.get("representations", []):
# Skip if not tagged as review
if "kitsureview" not in representation.get("tags", []):
@ -31,6 +31,6 @@ class IntegrateKitsuReview(pyblish.api.InstancePlugin):
self.log.debug("Found review at: {}".format(review_path))
gazu.task.add_preview(
task, comment, review_path, normalize_movie=True
task_id, comment_id, review_path, normalize_movie=True
)
self.log.info("Review upload on comment")