From 0d9ea4aa266a25d35f555a0b7eb1e1d13aa1f41e Mon Sep 17 00:00:00 2001
From: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Date: Fri, 28 Jul 2023 15:46:32 +0200
Subject: [PATCH] Applications: Environment variables order (#5245)

* apply project environemnts after context environments are set

* make asset and task environments optional

* added more conditions for host environemnts

* validate context for host

* fix double negative
---
 openpype/lib/applications.py | 33 +++++++++++++++++++++------------
 1 file changed, 21 insertions(+), 12 deletions(-)

diff --git a/openpype/lib/applications.py b/openpype/lib/applications.py
index f47e11926c..fbde59ced5 100644
--- a/openpype/lib/applications.py
+++ b/openpype/lib/applications.py
@@ -1640,11 +1640,7 @@ def prepare_context_environments(data, env_group=None, modules_manager=None):
     project_doc = data["project_doc"]
     asset_doc = data["asset_doc"]
     task_name = data["task_name"]
-    if (
-        not project_doc
-        or not asset_doc
-        or not task_name
-    ):
+    if not project_doc:
         log.info(
             "Skipping context environments preparation."
             " Launch context does not contain required data."
@@ -1657,18 +1653,16 @@ def prepare_context_environments(data, env_group=None, modules_manager=None):
     system_settings = get_system_settings()
     data["project_settings"] = project_settings
     data["system_settings"] = system_settings
-    # Apply project specific environments on current env value
-    apply_project_environments_value(
-        project_name, data["env"], project_settings, env_group
-    )
 
     app = data["app"]
     context_env = {
         "AVALON_PROJECT": project_doc["name"],
-        "AVALON_ASSET": asset_doc["name"],
-        "AVALON_TASK": task_name,
         "AVALON_APP_NAME": app.full_name
     }
+    if asset_doc:
+        context_env["AVALON_ASSET"] = asset_doc["name"]
+        if task_name:
+            context_env["AVALON_TASK"] = task_name
 
     log.debug(
         "Context environments set:\n{}".format(
@@ -1676,9 +1670,25 @@ def prepare_context_environments(data, env_group=None, modules_manager=None):
         )
     )
     data["env"].update(context_env)
+
+    # Apply project specific environments on current env value
+    # - apply them once the context environments are set
+    apply_project_environments_value(
+        project_name, data["env"], project_settings, env_group
+    )
+
     if not app.is_host:
         return
 
+    data["env"]["AVALON_APP"] = app.host_name
+
+    if not asset_doc or not task_name:
+        # QUESTION replace with log.info and skip workfile discovery?
+        # - technically it should be possible to launch host without context
+        raise ApplicationLaunchFailed(
+            "Host launch require asset and task context."
+        )
+
     workdir_data = get_template_data(
         project_doc, asset_doc, task_name, app.host_name, system_settings
     )
@@ -1716,7 +1726,6 @@ def prepare_context_environments(data, env_group=None, modules_manager=None):
                 "Couldn't create workdir because: {}".format(str(exc))
             )
 
-    data["env"]["AVALON_APP"] = app.host_name
     data["env"]["AVALON_WORKDIR"] = workdir
 
     _prepare_last_workfile(data, workdir, modules_manager)