Merge branch 'develop' into enhancement/allow_color_management_profile_to_disable_management

This commit is contained in:
Roy Nieterau 2025-11-28 23:11:39 +01:00 committed by GitHub
commit 1238d8a18c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 117 additions and 6 deletions

View file

@ -1232,6 +1232,14 @@ def oiio_color_convert(
# Handle the different conversion cases # Handle the different conversion cases
# Source view and display are known # Source view and display are known
if source_view and source_display: if source_view and source_display:
color_convert_args = None
ocio_display_args = None
oiio_cmd.extend([
"--ociodisplay:inverse=1:subimages=0",
source_display,
source_view,
])
if target_colorspace: if target_colorspace:
# This is a two-step conversion process since there's no direct # This is a two-step conversion process since there's no direct
# display/view to colorspace command # display/view to colorspace command
@ -1241,22 +1249,25 @@ def oiio_color_convert(
elif source_display != target_display or source_view != target_view: elif source_display != target_display or source_view != target_view:
# Complete display/view pair conversion # Complete display/view pair conversion
# - go through a reference space # - go through a reference space
color_convert_args = (target_display, target_view) ocio_display_args = (target_display, target_view)
else: else:
color_convert_args = None
logger.debug( logger.debug(
"Source and target display/view pairs are identical." "Source and target display/view pairs are identical."
" No color conversion needed." " No color conversion needed."
) )
if color_convert_args: if color_convert_args:
# Use colorconvert for colorspace target
oiio_cmd.extend([ oiio_cmd.extend([
"--ociodisplay:inverse=1:subimages=0",
source_display,
source_view,
"--colorconvert:subimages=0", "--colorconvert:subimages=0",
*color_convert_args *color_convert_args
]) ])
elif ocio_display_args:
# Use ociodisplay for display/view target
oiio_cmd.extend([
"--ociodisplay:subimages=0",
*ocio_display_args
])
elif target_colorspace: elif target_colorspace:
# Standard color space to color space conversion # Standard color space to color space conversion

View file

@ -163,7 +163,8 @@ class ExtractReview(pyblish.api.InstancePlugin):
"flame", "flame",
"unreal", "unreal",
"batchdelivery", "batchdelivery",
"photoshop" "photoshop",
"substancepainter",
] ]
settings_category = "core" settings_category = "core"

View file

@ -1584,6 +1584,105 @@ DEFAULT_PUBLISH_VALUES = {
"fill_missing_frames": "closest_existing" "fill_missing_frames": "closest_existing"
} }
] ]
},
{
"product_types": [],
"hosts": ["substancepainter"],
"task_types": [],
"outputs": [
{
"name": "png",
"ext": "png",
"tags": [
"ftrackreview",
"kitsureview",
"webreview"
],
"burnins": [],
"ffmpeg_args": {
"video_filters": [],
"audio_filters": [],
"input": [],
"output": []
},
"filter": {
"families": [
"render",
"review",
"ftrack"
],
"product_names": [],
"custom_tags": [],
"single_frame_filter": "single_frame"
},
"overscan_crop": "",
# "overscan_color": [0, 0, 0],
"overscan_color": [0, 0, 0, 0.0],
"width": 1920,
"height": 1080,
"scale_pixel_aspect": True,
"bg_color": [0, 0, 0, 0.0],
"letter_box": {
"enabled": False,
"ratio": 0.0,
"fill_color": [0, 0, 0, 1.0],
"line_thickness": 0,
"line_color": [255, 0, 0, 1.0]
},
"fill_missing_frames": "only_rendered"
},
{
"name": "h264",
"ext": "mp4",
"tags": [
"burnin",
"ftrackreview",
"kitsureview",
"webreview"
],
"burnins": [],
"ffmpeg_args": {
"video_filters": [],
"audio_filters": [],
"input": [
"-apply_trc gamma22"
],
"output": [
"-pix_fmt yuv420p",
"-crf 18",
"-c:a aac",
"-b:a 192k",
"-g 1",
"-movflags faststart"
]
},
"filter": {
"families": [
"render",
"review",
"ftrack"
],
"product_names": [],
"custom_tags": [],
"single_frame_filter": "multi_frame"
},
"overscan_crop": "",
# "overscan_color": [0, 0, 0],
"overscan_color": [0, 0, 0, 0.0],
"width": 0,
"height": 0,
"scale_pixel_aspect": True,
"bg_color": [0, 0, 0, 0.0],
"letter_box": {
"enabled": False,
"ratio": 0.0,
"fill_color": [0, 0, 0, 1.0],
"line_thickness": 0,
"line_color": [255, 0, 0, 1.0]
},
"fill_missing_frames": "only_rendered"
}
]
} }
] ]
}, },