diff --git a/pype/settings/entities/base_entity.py b/pype/settings/entities/base_entity.py index cab9f205ec..0a079be231 100644 --- a/pype/settings/entities/base_entity.py +++ b/pype/settings/entities/base_entity.py @@ -162,10 +162,6 @@ class BaseEntity: def set_override_state(self, state): pass - @abstractmethod - def on_value_change(self): - pass - @abstractmethod def on_change(self): pass @@ -510,11 +506,6 @@ class RootEntity(BaseEntity): self.__class__.__name__ )) - def on_value_change(self): - raise TypeError("{} does not support `on_value_change`".format( - self.__class__.__name__ - )) - def on_change(self): for callback in self.on_change_callbacks: callback() diff --git a/pype/settings/entities/dict_immutable_keys_entity.py b/pype/settings/entities/dict_immutable_keys_entity.py index c512298822..8d867e00d4 100644 --- a/pype/settings/entities/dict_immutable_keys_entity.py +++ b/pype/settings/entities/dict_immutable_keys_entity.py @@ -41,11 +41,6 @@ class DictImmutableKeysEntity(ItemEntity): def items(self): return self.non_gui_children.items() - def on_value_change(self): - raise NotImplementedError( - "{} - on_value_change".format(self.__class__.__name__) - ) - def schema_validations(self): if self.checkbox_key: checkbox_child = self.non_gui_children.get(self.checkbox_key) diff --git a/pype/settings/entities/dict_mutable_keys_entity.py b/pype/settings/entities/dict_mutable_keys_entity.py index 038a340979..2ffadb65f8 100644 --- a/pype/settings/entities/dict_mutable_keys_entity.py +++ b/pype/settings/entities/dict_mutable_keys_entity.py @@ -231,6 +231,7 @@ class DictMutableKeysEntity(ItemEntity): return metadata def set_value(self, value): + # TODO pop keys not in value and add new keys from value for _key, _value in value.items(): self.set_value_for_key(_key, _value, True) self.on_value_change() diff --git a/pype/settings/entities/item_entities.py b/pype/settings/entities/item_entities.py index 6f17d7b92e..afa2508e82 100644 --- a/pype/settings/entities/item_entities.py +++ b/pype/settings/entities/item_entities.py @@ -193,7 +193,7 @@ class GUIEntity(ItemEntity): _discard_changes = None on_change = None on_child_change = None - on_value_change = None + settings_value = None remove_overrides = None reset_to_pype_default = None @@ -328,9 +328,6 @@ class PathEntity(ItemEntity): return self.child_obj.settings_value() - def on_value_change(self): - raise NotImplementedError(self.__class__.__name__) - def on_change(self): for callback in self.on_change_callbacks: callback()