Harmony: refresh code for current Deadline (#5493)

* Explicitly set Python3 for Harmony OP plugin

* Fix method call

Without it it would always return True

* Explicitly set render instance to farm

* Added Harmony 22 executable

This plugin might not be necessary anymore for current Harmonies (at least for 22 works original Harmony plugin in DL)

* Removed logging

* fix - remove explicit disabling of review

instance.data["review"] could be False only if review shouldn't be explicitly done. This is not possible in old publisher.
TODO must be implemented in NP.

openpype/hosts/harmony/plugins/publish/collect_farm_render.py

@@ -147,13 +147,13 @@ class CollectFarmRender(publish.AbstractCollectRender):
                 attachTo=False,
                 setMembers=[node],
                 publish=info[4],
-                review=False,
                 renderer=None,
                 priority=50,
                 name=node.split("/")[1],
 
                 family="render.farm",
                 families=["render.farm"],
+                farm=True,
 
                 resolutionWidth=context.data["resolutionWidth"],
                 resolutionHeight=context.data["resolutionHeight"],

openpype/modules/deadline/plugins/publish/submit_harmony_deadline.py

@@ -265,7 +265,7 @@ class HarmonySubmitDeadline(
         job_info.SecondaryPool = self._instance.data.get("secondaryPool")
         job_info.ChunkSize = self.chunk_size
         batch_name = os.path.basename(self._instance.data["source"])
-        if is_in_tests:
+        if is_in_tests():
             batch_name += datetime.now().strftime("%d%m%Y%H%M%S")
         job_info.BatchName = batch_name
         job_info.Department = self.department

openpype/modules/deadline/repository/custom/plugins/HarmonyOpenPype/HarmonyOpenPype.param

@@ -77,4 +77,22 @@ CategoryOrder=0
 Index=4
 Label=Harmony 20 Render Executable
 Description=The path to the Harmony Render executable file used for rendering. Enter alternative paths on separate lines.
-Default=c:\Program Files (x86)\Toon Boom Animation\Toon Boom Harmony 20 Premium\win64\bin\HarmonyPremium.exe;/Applications/Toon Boom Harmony 20 Premium/Harmony Premium.app/Contents/MacOS/Harmony Premium;/usr/local/ToonBoomAnimation/harmonyPremium_20/lnx86_64/bin/HarmonyPremium
+Default=c:\Program Files (x86)\Toon Boom Animation\Toon Boom Harmony 20 Premium\win64\bin\HarmonyPremium.exe;/Applications/Toon Boom Harmony 20 Premium/Harmony Premium.app/Contents/MacOS/Harmony Premium;/usr/local/ToonBoomAnimation/harmonyPremium_20/lnx86_64/bin/HarmonyPremium
+
+[Harmony_RenderExecutable_21]
+Type=multilinemultifilename
+Category=Render Executables
+CategoryOrder=0
+Index=4
+Label=Harmony 21 Render Executable
+Description=The path to the Harmony Render executable file used for rendering. Enter alternative paths on separate lines.
+Default=c:\Program Files (x86)\Toon Boom Animation\Toon Boom Harmony 21 Premium\win64\bin\HarmonyPremium.exe;/Applications/Toon Boom Harmony 21 Premium/Harmony Premium.app/Contents/MacOS/Harmony Premium;/usr/local/ToonBoomAnimation/harmonyPremium_21/lnx86_64/bin/HarmonyPremium
+
+[Harmony_RenderExecutable_22]
+Type=multilinemultifilename
+Category=Render Executables
+CategoryOrder=0
+Index=4
+Label=Harmony 22 Render Executable
+Description=The path to the Harmony Render executable file used for rendering. Enter alternative paths on separate lines.
+Default=c:\Program Files (x86)\Toon Boom Animation\Toon Boom Harmony 22 Premium\win64\bin\HarmonyPremium.exe;/Applications/Toon Boom Harmony 22 Premium/Harmony Premium.app/Contents/MacOS/Harmony Premium;/usr/local/ToonBoomAnimation/harmonyPremium_22/lnx86_64/bin/HarmonyPremium

openpype/modules/deadline/repository/custom/plugins/HarmonyOpenPype/HarmonyOpenPype.py

@@ -1,3 +1,4 @@
+#!/usr/bin/env python3
 from System import *
 from System.Diagnostics import *
 from System.IO import *