From 22296aeb6e8ae078cde738cea8f3c38d47c3a76b Mon Sep 17 00:00:00 2001
From: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Date: Thu, 15 Jun 2023 14:32:53 +0200
Subject: [PATCH] Pack project: Raise exception with reasonable message (#5145)

* raise exception with reasonable message

* raise errors at better places
---
 openpype/lib/project_backpack.py | 11 +++++++++++
 openpype/pype_commands.py        |  7 +++++++
 2 files changed, 18 insertions(+)

diff --git a/openpype/lib/project_backpack.py b/openpype/lib/project_backpack.py
index 674eaa3b91..55a96664d8 100644
--- a/openpype/lib/project_backpack.py
+++ b/openpype/lib/project_backpack.py
@@ -113,6 +113,12 @@ def pack_project(
             project_name
         ))
 
+    if only_documents and not destination_dir:
+        raise ValueError((
+            "Destination directory must be defined"
+            " when only documents should be packed."
+        ))
+
     root_path = None
     source_root = {}
     project_source_path = None
@@ -141,6 +147,11 @@ def pack_project(
     if not destination_dir:
         destination_dir = root_path
 
+    if not destination_dir:
+        raise ValueError(
+            "Project {} does not have any roots.".format(project_name)
+        )
+
     destination_dir = os.path.normpath(destination_dir)
     if not os.path.exists(destination_dir):
         os.makedirs(destination_dir)
diff --git a/openpype/pype_commands.py b/openpype/pype_commands.py
index 6a24cb0ebc..56a0fe60cd 100644
--- a/openpype/pype_commands.py
+++ b/openpype/pype_commands.py
@@ -356,6 +356,13 @@ class PypeCommands:
     def pack_project(self, project_name, dirpath, database_only):
         from openpype.lib.project_backpack import pack_project
 
+        if database_only and not dirpath:
+            raise ValueError((
+                "Destination dir must be defined when using --dbonly."
+                " Use '--dirpath {output dir path}' flag"
+                " to specify directory."
+            ))
+
         pack_project(project_name, dirpath, database_only)
 
     def unpack_project(self, zip_filepath, new_root, database_only):