Publisher: Windows reduce command window pop-ups during Publishing (#4672)

* Avoid command pop-ups during publishing (tip by @iLLiCiTiT)

* No need to pass creationflags because it's already done in `run_subprocess`

* Hide command window for `shell=True` calls

* Update openpype/lib/execute.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

---------

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
This commit is contained in:
Roy Nieterau 2023-03-22 12:13:21 +01:00 committed by GitHub
parent cc75f2ea21
commit 28b424bf2f
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
4 changed files with 15 additions and 13 deletions

View file

@ -345,12 +345,6 @@ class ModifiedBurnins(ffmpeg_burnins.Burnins):
"stderr": subprocess.PIPE,
"shell": True,
}
if platform.system().lower() == "windows":
kwargs["creationflags"] = (
subprocess.CREATE_NEW_PROCESS_GROUP
| getattr(subprocess, "DETACHED_PROCESS", 0)
| getattr(subprocess, "CREATE_NO_WINDOW", 0)
)
proc = subprocess.Popen(command, **kwargs)
_stdout, _stderr = proc.communicate()