From 29dbc8b8cf50cd72825d61964d17e601733c47d0 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Date: Mon, 27 Jan 2025 17:37:14 +0100
Subject: [PATCH] set the placeholder on widgets

---
 client/ayon_core/tools/attribute_defs/widgets.py    |  6 +++++-
 .../tools/utils/multiselection_combobox.py          |  4 ++--
 client/ayon_core/tools/utils/widgets.py             | 13 ++++++++++---
 3 files changed, 17 insertions(+), 6 deletions(-)

diff --git a/client/ayon_core/tools/attribute_defs/widgets.py b/client/ayon_core/tools/attribute_defs/widgets.py
index 93f63730f5..635855863c 100644
--- a/client/ayon_core/tools/attribute_defs/widgets.py
+++ b/client/ayon_core/tools/attribute_defs/widgets.py
@@ -640,11 +640,15 @@ class EnumAttrWidget(_BaseAttrDefWidget):
         return self.attr_def.multiselection
 
     def _ui_init(self):
+        placeholder = self.attr_def.placeholder
         if self.multiselection:
-            input_widget = MultiSelectionComboBox(self)
+            input_widget = MultiSelectionComboBox(
+                self, placeholder=placeholder
+            )
 
         else:
             input_widget = CustomTextComboBox(self)
+            input_widget.set_placeholder(placeholder)
             combo_delegate = QtWidgets.QStyledItemDelegate(input_widget)
             input_widget.setItemDelegate(combo_delegate)
             self._combo_delegate = combo_delegate
diff --git a/client/ayon_core/tools/utils/multiselection_combobox.py b/client/ayon_core/tools/utils/multiselection_combobox.py
index 34361fca17..b90838267b 100644
--- a/client/ayon_core/tools/utils/multiselection_combobox.py
+++ b/client/ayon_core/tools/utils/multiselection_combobox.py
@@ -61,7 +61,7 @@ class MultiSelectionComboBox(QtWidgets.QComboBox):
         self._block_mouse_release_timer = QtCore.QTimer(self, singleShot=True)
         self._initial_mouse_pos = None
         self._separator = separator
-        self._placeholder_text = placeholder
+        self._placeholder_text = placeholder or ""
         delegate = ComboItemDelegate(self)
         self.setItemDelegate(delegate)
 
@@ -74,7 +74,7 @@ class MultiSelectionComboBox(QtWidgets.QComboBox):
         return self._placeholder_text
 
     def set_placeholder_text(self, text):
-        self._placeholder_text = text
+        self._placeholder_text = text or ""
         self._update_size_hint()
 
     def set_custom_text(self, text):
diff --git a/client/ayon_core/tools/utils/widgets.py b/client/ayon_core/tools/utils/widgets.py
index 4c2b418c41..8d5a11b811 100644
--- a/client/ayon_core/tools/utils/widgets.py
+++ b/client/ayon_core/tools/utils/widgets.py
@@ -54,7 +54,7 @@ class ComboBox(QtWidgets.QComboBox):
     """
 
     def __init__(self, *args, **kwargs):
-        super(ComboBox, self).__init__(*args, **kwargs)
+        super().__init__(*args, **kwargs)
         delegate = QtWidgets.QStyledItemDelegate()
         self.setItemDelegate(delegate)
         self.setFocusPolicy(QtCore.Qt.StrongFocus)
@@ -63,7 +63,7 @@ class ComboBox(QtWidgets.QComboBox):
 
     def wheelEvent(self, event):
         if self.hasFocus():
-            return super(ComboBox, self).wheelEvent(event)
+            return super().wheelEvent(event)
 
 
 class CustomTextComboBox(ComboBox):
@@ -71,7 +71,14 @@ class CustomTextComboBox(ComboBox):
 
     def __init__(self, *args, **kwargs):
         self._custom_text = None
-        super(CustomTextComboBox, self).__init__(*args, **kwargs)
+        self._placeholder = placeholder
+        super().__init__(*args, **kwargs)
+
+    def set_placeholder(self, placeholder: Optional[str]):
+        if placeholder == self._placeholder:
+            return
+        self.lineEdit().setPlaceholderText(placeholder)
+        self.repaint()
 
     def set_custom_text(self, text=None):
         if self._custom_text != text: