From 2f09bfee8700762aed96476aa134e9e8aa5c1096 Mon Sep 17 00:00:00 2001 From: iLLiCiTiT Date: Wed, 4 Sep 2019 11:10:52 +0200 Subject: [PATCH] pype subprocess returns output and log out error when subprocess crashed --- pype/lib.py | 2 ++ pype/plugins/global/publish/extract_burnin.py | 3 ++- pype/plugins/global/publish/extract_review.py | 5 +++-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/pype/lib.py b/pype/lib.py index c097ad1f10..6a7f274169 100644 --- a/pype/lib.py +++ b/pype/lib.py @@ -31,7 +31,9 @@ def _subprocess(args): output = proc.communicate()[0] if proc.returncode != 0: + log.error(output) raise ValueError("\"{}\" was not successful: {}".format(args, output)) + return output def get_hierarchy(asset_name=None): diff --git a/pype/plugins/global/publish/extract_burnin.py b/pype/plugins/global/publish/extract_burnin.py index 1ffda4fdfa..b1569aaa45 100644 --- a/pype/plugins/global/publish/extract_burnin.py +++ b/pype/plugins/global/publish/extract_burnin.py @@ -94,7 +94,8 @@ class ExtractBurnin(pype.api.Extractor): args = [executable, scriptpath, json_data] self.log.debug("Executing: {}".format(args)) - pype.api.subprocess(args) + output = pype.api.subprocess(args) + self.log.debug("Output: {}".format(output)) repre_update = { "files": movieFileBurnin, diff --git a/pype/plugins/global/publish/extract_review.py b/pype/plugins/global/publish/extract_review.py index bf53fa87d4..7e67ef7bab 100644 --- a/pype/plugins/global/publish/extract_review.py +++ b/pype/plugins/global/publish/extract_review.py @@ -170,8 +170,9 @@ class ExtractReview(pyblish.api.InstancePlugin): subprcs_cmd = " ".join(mov_args) # run subprocess - self.log.debug("{}".format(subprcs_cmd)) - pype.api.subprocess(subprcs_cmd) + self.log.debug("Executing: {}".format(subprcs_cmd)) + output = pype.api.subprocess(subprcs_cmd) + self.log.debug("Output: {}".format(output)) # create representation data repre_new.update({