Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-25 05:14:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #223 from BigRoy/REN-62

Browse source 
Fix Yeti callback validation (compare with stripped commands)
This commit is contained in:
Roy Nieterau 2019-01-15 17:49:18 +01:00 • committed by GitHub
commit 2f644dc0a6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 36 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

64
colorbleed/plugins/maya/publish/validate_yeti_renderscript_callbacks.py
View file

@ -25,6 +25,17 @@ class ValidateYetiRenderScriptCallbacks(pyblish.api.InstancePlugin):
hosts = ["maya"]
families = ["colorbleed.renderlayer"]
# Settings per renderer
callbacks = {
"vray": {
"pre": "catch(`pgYetiVRayPreRender`)",
"post": "catch(`pgYetiVRayPostRender`)"
},
"arnold": {
"pre": "pgYetiPreRender"
}
}
def process(self, instance):
invalid = self.get_invalid(instance)
@ -35,14 +46,6 @@ class ValidateYetiRenderScriptCallbacks(pyblish.api.InstancePlugin):
@classmethod
def get_invalid(cls, instance):
# lookup per render
render_scripts = {"vray":
{"pre": "catch(`pgYetiVRayPreRender`)",
"post": "catch(`pgYetiVRayPostRender`)"},
"arnold":
{"pre": "pgYetiPreRender"}
}
yeti_loaded = cmds.pluginInfo("pgYetiMaya", query=True, loaded=True)
renderer = instance.data["renderer"]
@ -50,25 +53,29 @@ class ValidateYetiRenderScriptCallbacks(pyblish.api.InstancePlugin):
cls.log.info("Redshift ignores any pre and post render callbacks")
return False
callback_lookup = render_scripts.get(renderer, {})
callback_lookup = cls.callbacks.get(renderer, {})
if not callback_lookup:
cls.log.warning("Renderer '%s' is not supported in this plugin"
% renderer)
return False
pre_mel_attr = "defaultRenderGlobals.preMel"
post_mel_attr = "defaultRenderGlobals.postMel"
pre_mel = cmds.getAttr("defaultRenderGlobals.preMel") or ""
post_mel = cmds.getAttr("defaultRenderGlobals.postMel") or ""
pre_render_callback = cmds.getAttr(pre_mel_attr) or ""
post_render_callback = cmds.getAttr(post_mel_attr) or ""
if pre_mel.strip():
cls.log.debug("Found pre mel: `%s`" % pre_mel)
pre_callbacks = pre_render_callback.split(";")
post_callbacks = post_render_callback.split(";")
if post_mel.strip():
cls.log.debug("Found post mel: `%s`" % post_mel)
# Strip callbacks and turn into a set for quick lookup
pre_callbacks = {cmd.strip() for cmd in pre_mel.split(";")}
post_callbacks = {cmd.strip() for cmd in post_mel.split(";")}
pre_script = callback_lookup.get("pre", "")
post_script = callback_lookup.get("post", "")
# If not loaded
# If Yeti is not loaded
invalid = False
if not yeti_loaded:
if pre_script and pre_script in pre_callbacks:
@ -80,18 +87,19 @@ class ValidateYetiRenderScriptCallbacks(pyblish.api.InstancePlugin):
cls.log.error("Found post render callback '%s which is "
"not used!" % post_script)
invalid = True
else:
if pre_script:
if pre_script not in pre_callbacks:
cls.log.error(
"Could not find required pre render callback "
"`%s`" % pre_script)
invalid = True
if post_script:
if post_script not in post_callbacks:
cls.log.error("Could not find required post render callback"
" `%s`" % post_script)
invalid = True
# If Yeti is loaded
else:
if pre_script and pre_script not in pre_callbacks:
cls.log.error(
"Could not find required pre render callback "
"`%s`" % pre_script)
invalid = True
if post_script and post_script not in post_callbacks:
cls.log.error(
"Could not find required post render callback"
" `%s`" % post_script)
invalid = True
return invalid