From 30800c1c2ca5cd910772632a62ac269f0a9e2f40 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 7 Dec 2023 15:06:20 +0100
Subject: [PATCH] Refactor transcoding and thumbnail extraction code

- Removed the unused `additional_input_args` parameter from the `convert_colorspace` function in `transcoding.py`
- Renamed the `additional_input_args` parameter to `additional_command_args` in the `ExtractThumbnail` class in `extract_thumbnail.py`

These changes improve code clarity and remove unnecessary parameters.
---
 openpype/lib/transcoding.py                   | 5 -----
 openpype/plugins/publish/extract_thumbnail.py | 2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/openpype/lib/transcoding.py b/openpype/lib/transcoding.py
index 37709f45e0..316dedbd3d 100644
--- a/openpype/lib/transcoding.py
+++ b/openpype/lib/transcoding.py
@@ -1103,7 +1103,6 @@ def convert_colorspace(
     target_colorspace=None,
     view=None,
     display=None,
-    additional_input_args=None,
     additional_command_args=None,
     logger=None,
 ):
@@ -1125,7 +1124,6 @@ def convert_colorspace(
             both 'view' and 'display' must be filled (if 'target_colorspace')
         display (str): name for display-referred reference space (ocio valid)
             both 'view' and 'display' must be filled (if 'target_colorspace')
-        additional_input_args (list): arguments for input file
         additional_command_args (list): arguments for oiiotool (like binary
             depth for .dpx)
         logger (logging.Logger): Logger used for logging.
@@ -1140,9 +1138,6 @@ def convert_colorspace(
     # Collect channels to export
     input_arg, channels_arg = get_oiio_input_and_channel_args(input_info)
 
-    if additional_input_args:
-        input_arg = "{} {}".format(input_arg, " ".join(additional_input_args))
-
     # Prepare subprocess arguments
     oiio_cmd = get_oiio_tool_args(
         "oiiotool",
diff --git a/openpype/plugins/publish/extract_thumbnail.py b/openpype/plugins/publish/extract_thumbnail.py
index c782bda73e..206ad76707 100644
--- a/openpype/plugins/publish/extract_thumbnail.py
+++ b/openpype/plugins/publish/extract_thumbnail.py
@@ -371,7 +371,7 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
                 display=repre_display or oiio_default_display,
                 view=repre_view or oiio_default_view,
                 target_colorspace=oiio_default_colorspace,
-                additional_input_args=resolution_arg,
+                additional_command_args=resolution_arg,
                 logger=self.log,
             )
         except Exception: