From 3932b19ea94637d2023acde3a039b59db5c4e5a7 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakub@orbi.tools>
Date: Wed, 7 Oct 2020 17:52:36 +0200
Subject: [PATCH] fix(nuke): improving names of render targets

---
 pype/hosts/nuke/lib.py                         | 14 +++++++++-----
 pype/plugins/nuke/publish/collect_instances.py |  6 +++---
 2 files changed, 12 insertions(+), 8 deletions(-)

diff --git a/pype/hosts/nuke/lib.py b/pype/hosts/nuke/lib.py
index d896bfe1ef..8fd84b8555 100644
--- a/pype/hosts/nuke/lib.py
+++ b/pype/hosts/nuke/lib.py
@@ -389,24 +389,28 @@ def create_write_node(name, data, input=None, prenodes=None, review=True):
     # imprinting group node
     avalon.nuke.imprint(GN, data["avalon"])
 
-    divider = nuke.Text_Knob('')
-    GN.addKnob(divider)
+    # add divider
+    GN.addKnob(nuke.Text_Knob(''))
 
     add_rendering_knobs(GN)
 
     if review:
         add_review_knob(GN)
 
+    # add divider
+    GN.addKnob(nuke.Text_Knob(''))
+
     # Add linked knobs.
     linked_knob_names = ["Render", "use_limit", "first", "last"]
     for name in linked_knob_names:
         link = nuke.Link_Knob(name)
         link.makeLink(write_node.name(), name)
         link.setName(name)
+        link.setFlag(0x1000)
         GN.addKnob(link)
 
-    divider = nuke.Text_Knob('')
-    GN.addKnob(divider)
+    # add divider
+    GN.addKnob(nuke.Text_Knob(''))
 
     # adding write to read button
     add_button_write_to_read(GN)
@@ -432,7 +436,7 @@ def add_rendering_knobs(node):
     '''
     if "render" not in node.knobs():
         knob = nuke.Enumeration_Knob("render", "Render", [
-            "Do Not Render", "Locally", "On Farm"])
+            "Use existing frames", "Local", "On farm"])
         knob.setFlag(0x1000)
         node.addKnob(knob)
     return node
diff --git a/pype/plugins/nuke/publish/collect_instances.py b/pype/plugins/nuke/publish/collect_instances.py
index f1e7f2bdde..069c8d6c22 100644
--- a/pype/plugins/nuke/publish/collect_instances.py
+++ b/pype/plugins/nuke/publish/collect_instances.py
@@ -77,15 +77,15 @@ class CollectNukeInstances(pyblish.api.ContextPlugin):
                 # only alter families for render family
                 if "write" in families_ak:
                     target = node["render"].value()
-                    if target == "Do Not Render":
+                    if target == "Use existing frames":
                         # Local rendering
                         self.log.info("flagged for no render")
                         families.append("render")
-                    elif target == "Locally":
+                    elif target == "Local":
                         # Local rendering
                         self.log.info("flagged for local render")
                         families.append("{}.local".format("render"))
-                    elif target == "On Farm":
+                    elif target == "On farm":
                         # Farm rendering
                         self.log.info("flagged for farm render")
                         instance.data["transfer"] = False