From 4095c7bd008923f288c8b16f5ce94e0c0aacca99 Mon Sep 17 00:00:00 2001
From: Kayla Man <moonyuet2008@hotmail.com>
Date: Wed, 10 May 2023 22:51:52 +0800
Subject: [PATCH] use rt.rendpickupframe and ondrej's comment

---
 openpype/hosts/max/api/lib.py                 |  6 ++---
 .../max/plugins/publish/collect_render.py     |  8 +++---
 .../plugins/publish/validate_frame_range.py   | 26 +++++++++++--------
 3 files changed, 23 insertions(+), 17 deletions(-)

diff --git a/openpype/hosts/max/api/lib.py b/openpype/hosts/max/api/lib.py
index 1673fc5ab8..b21ce0f789 100644
--- a/openpype/hosts/max/api/lib.py
+++ b/openpype/hosts/max/api/lib.py
@@ -150,10 +150,10 @@ def set_render_frame_range(start_frame, end_frame):
     Todo:
         Current type is hard-coded, there should be a custom setting for this.
     """
-    rt.rendTimeType = 3
+    rt.rendTimeType = 4
     if start_frame is not None and end_frame is not None:
-        rt.rendStart = int(start_frame)
-        rt.rendEnd = int(end_frame)
+        frame_range = "{0}-{1}".format(start_frame, end_frame)
+        rt.rendPickupFrames = frame_range
 
 
 def get_multipass_setting(project_setting=None):
diff --git a/openpype/hosts/max/plugins/publish/collect_render.py b/openpype/hosts/max/plugins/publish/collect_render.py
index 9d93a40021..2742c36fc8 100644
--- a/openpype/hosts/max/plugins/publish/collect_render.py
+++ b/openpype/hosts/max/plugins/publish/collect_render.py
@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 """Collect Render"""
 import os
+import re
 import pyblish.api
 
 from pymxs import runtime as rt
@@ -46,7 +47,8 @@ class CollectRender(pyblish.api.InstancePlugin):
 
         self.log.debug(f"Setting {version_int} to context.")
         context.data["version"] = version_int
-
+        pattern = r"^(?P<start>-?[0-9]+)(?:(?:-)(?P<end>-?[0-9]+))?$"
+        match = re.match(pattern, rt.rendPickupFrames)
         # setup the plugin as 3dsmax for the internal renderer
         data = {
             "subset": instance.name,
@@ -59,8 +61,8 @@ class CollectRender(pyblish.api.InstancePlugin):
             "source": filepath,
             "expectedFiles": render_layer_files,
             "plugin": "3dsmax",
-            "frameStart": int(rt.rendStart),
-            "frameEnd": int(rt.rendEnd),
+            "frameStart": int(match.group("start")),
+            "frameEnd": int(match.group("end")),
             "version": version_int,
             "farm": True
         }
diff --git a/openpype/hosts/max/plugins/publish/validate_frame_range.py b/openpype/hosts/max/plugins/publish/validate_frame_range.py
index e07c6390c1..4cc9cb530c 100644
--- a/openpype/hosts/max/plugins/publish/validate_frame_range.py
+++ b/openpype/hosts/max/plugins/publish/validate_frame_range.py
@@ -44,19 +44,23 @@ class ValidateFrameRange(pyblish.api.InstancePlugin,
         inst_frame_start = int(instance.data.get("frameStart"))
         inst_frame_end = int(instance.data.get("frameEnd"))
 
+        errors = []
         if frame_start != inst_frame_start:
-            raise PublishValidationError(
-                "startFrame on instance does not match"
-                " with startFrame from the context data."
-                " You can use repair action to fix it")
-
+            errors.append(
+                f"Start frame ({inst_frame_start}) on instance does not match "
+                f"with the start frame ({frame_start}) set on the asset data. ")
         if frame_end != inst_frame_end:
-            raise PublishValidationError(
-                "endFrame on instance does not match"
-                " with endFrame from the context data."
-                " You can use repair action to fix it")
+            errors.append(
+                f"End frame ({inst_frame_end}) on instance does not match "
+                f"with the end frame ({frame_start}) from the asset data. ")
+
+        if errors:
+            errors.append("You can use repair action to fix it.")
+            raise PublishValidationError("\n".join(errors))
 
     @classmethod
     def repair(cls, instance):
-        rt.rendStart = instance.context.data.get("frameStart")
-        rt.rendEnd = instance.context.data.get("frameEnd")
+        start = instance.context.data.get("frameStart")
+        end = instance.context.data.get("frameEnd")
+        frame_range = "{0}-{1}".format(start, end)
+        rt.rendPickupFrames = frame_range