From 40bf199f6e87dc7103acff078a2480645264ede3 Mon Sep 17 00:00:00 2001 From: Roy Nieterau Date: Fri, 23 Nov 2018 18:01:05 +0100 Subject: [PATCH] Use collected cameras in validation, instead of collecting again. --- .../publish/validate_render_no_default_cameras.py | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/colorbleed/plugins/maya/publish/validate_render_no_default_cameras.py b/colorbleed/plugins/maya/publish/validate_render_no_default_cameras.py index b7c1cbbeb8..fbfb50bd4e 100644 --- a/colorbleed/plugins/maya/publish/validate_render_no_default_cameras.py +++ b/colorbleed/plugins/maya/publish/validate_render_no_default_cameras.py @@ -3,7 +3,6 @@ from maya import cmds import pyblish.api import colorbleed.api import colorbleed.maya.action -import colorbleed.maya.lib as lib class ValidateRenderNoDefaultCameras(pyblish.api.InstancePlugin): @@ -18,19 +17,14 @@ class ValidateRenderNoDefaultCameras(pyblish.api.InstancePlugin): @staticmethod def get_invalid(instance): - layer = instance.data["setMembers"] + renderable = set(instance.data["cameras"]) # Collect default cameras cameras = cmds.ls(type='camera', long=True) - defaults = [cam for cam in cameras if - cmds.camera(cam, query=True, startupCamera=True)] + defaults = set(cam for cam in cameras if + cmds.camera(cam, query=True, startupCamera=True)) - invalid = [] - for cam in defaults: - if lib.get_attr_in_layer(cam + ".renderable", layer=layer): - invalid.append(cam) - - return invalid + return [cam for cam in renderable if cam in defaults] def process(self, instance): """Process all the cameras in the instance"""