Fix burnin frame range + add support for focal length in burnin (incl. animated focal length)

openpype/hosts/houdini/plugins/publish/collect_review_data.py

@@ -0,0 +1,52 @@
+import hou
+import pyblish.api
+
+
+class CollectHoudiniReviewData(pyblish.api.InstancePlugin):
+    """Collect Review Data."""
+
+    label = "Collect Review Data"
+    order = pyblish.api.CollectorOrder + 0.1
+    hosts = ["houdini"]
+    families = ["review"]
+
+    def process(self, instance):
+
+        # This fixes the burnin having the incorrect start/end timestamps
+        # because without this it would take it from the context instead
+        # which isn't the actual frame range that this instance renders.
+        instance.data["handleStart"] = 0
+        instance.data["handleEnd"] = 0
+
+        # Get the camera from the rop node to collect the focal length
+        ropnode_path = instance.data["instance_node"]
+        ropnode = hou.node(ropnode_path)
+
+        try:
+            camera = ropnode.parm("camera").evalAsNode()
+        except TypeError:
+            # Not a valid node path set
+            self.log.error("No valid camera node found on review node: "
+                           "{}".format(ropnode.path()))
+            return
+
+        # Collect focal length.
+        focal_length_parm = camera.parm("focal")
+        if not focal_length_parm:
+            self.log.warning("No 'focal' (focal length) parameter found on "
+                             "camera: {}".format(camera.path()))
+            return
+
+        if focal_length_parm.isTimeDependent():
+            start = instance.data["frameStart"]
+            end = instance.data["frameEnd"] + 1
+            focal_length = [
+                focal_length_parm.evalAsFloatAtFrame(t)
+                for t in range(int(start), int(end))
+            ]
+        else:
+            focal_length = focal_length_parm.evalAsFloat()
+
+        # Store focal length in `burninDataMembers`
+        burnin_members = instance.data.setdefault("burninDataMembers", {})
+        burnin_members["focalLength"] = focal_length