logger keyword argument is skipped in function definition but is popped from kwargs

This commit is contained in:
iLLiCiTiT 2020-10-16 11:07:33 +02:00
parent a9aff3b030
commit 4b742faddd

View file

@ -81,7 +81,7 @@ def get_ffmpeg_tool_path(tool="ffmpeg"):
# Special naming case for subprocess since its a built-in method.
def _subprocess(*args, logger=None, **kwargs):
def _subprocess(*args, **kwargs):
"""Convenience method for getting output errors for subprocess.
Entered arguments and keyword arguments are passed to subprocess Popen.
@ -107,8 +107,7 @@ def _subprocess(*args, logger=None, **kwargs):
filtered_env = {k: str(v) for k, v in env.items()}
# Use lib's logger if was not passed with kwargs.
if not logger:
logger = log
logger = kwargs.pop("logger", log)
# set overrides
kwargs['stdout'] = kwargs.get('stdout', subprocess.PIPE)