diff --git a/openpype/hosts/maya/plugins/load/load_vrayproxy.py b/openpype/hosts/maya/plugins/load/load_vrayproxy.py index 3112a37c19..d5d4a941e3 100644 --- a/openpype/hosts/maya/plugins/load/load_vrayproxy.py +++ b/openpype/hosts/maya/plugins/load/load_vrayproxy.py @@ -146,7 +146,8 @@ class VRayProxyLoader(api.Loader): name = os.path.splitext(os.path.basename(filename))[0] parent = cmds.createNode("transform", name=name) - proxy = cmds.createNode("VRayProxy", name=name + "Shape", parent=parent) + proxy = cmds.createNode( + "VRayProxy", name="{}Shape".format(name), parent=parent) cmds.setAttr(proxy + ".fileName", filename, type="string") cmds.connectAttr("time1.outTime", proxy + ".currentFrame") @@ -182,4 +183,4 @@ class VRayProxyLoader(api.Loader): self.log.debug("File: {}".format(self.fname)) return file_name - return None + return "" diff --git a/openpype/tools/mayalookassigner/commands.py b/openpype/tools/mayalookassigner/commands.py index 974f68ba33..2add5d3499 100644 --- a/openpype/tools/mayalookassigner/commands.py +++ b/openpype/tools/mayalookassigner/commands.py @@ -140,7 +140,7 @@ def create_items_from_nodes(nodes): path = cmds.getAttr("{}.fileName".format(vp)) ids = vray_proxies.get_alembic_ids_cache(path) parent_id = {} - for k, n in ids.items(): + for k, _ in ids.items(): pid = k.split(":")[0] if not parent_id.get(pid): parent_id.update({pid: [vp]}) diff --git a/openpype/tools/mayalookassigner/vray_proxies.py b/openpype/tools/mayalookassigner/vray_proxies.py index ecc7de1330..d2f345e628 100644 --- a/openpype/tools/mayalookassigner/vray_proxies.py +++ b/openpype/tools/mayalookassigner/vray_proxies.py @@ -192,7 +192,8 @@ def load_look(version_id): # Load file loaders = api.loaders_from_representation(api.discover(api.Loader), representation_id) - loader = next((i for i in loaders if i.__name__ == "LookLoader"), None) + loader = next( + (i for i in loaders if i.__name__ == "LookLoader"), None) if loader is None: raise RuntimeError("Could not find LookLoader, this is a bug") @@ -274,8 +275,12 @@ def vrayproxy_assign_look(vrayproxy, subset="lookDefault"): # Get only the node ids and paths related to this asset # And get the shader edits the look supplies - asset_nodes_by_id = {node_id: nodes_by_id[node_id] for node_id in node_ids} - edits = list(lib.iter_shader_edits(relationships, shadernodes, asset_nodes_by_id)) + asset_nodes_by_id = { + node_id: nodes_by_id[node_id] for node_id in node_ids + } + edits = list( + lib.iter_shader_edits( + relationships, shadernodes, asset_nodes_by_id)) # Create assignments assignments = {} @@ -287,7 +292,8 @@ def vrayproxy_assign_look(vrayproxy, subset="lookDefault"): print("Skipping non-shader: %s" % shader) continue - inputs = cmds.listConnections(shader + ".surfaceShader", source=True) + inputs = cmds.listConnections( + shader + ".surfaceShader", source=True) if not inputs: print("Shading engine missing material: %s" % shader) @@ -295,11 +301,12 @@ def vrayproxy_assign_look(vrayproxy, subset="lookDefault"): for i, node in enumerate(nodes): if "." in node: log.warning( - "Converting face assignment to full object assignment. This conversion can be lossy: %s" % node) + ("Converting face assignment to full object " + "assignment. This conversion can be lossy: " + "{}").format(node)) nodes[i] = node.split(".")[0] material = inputs[0] assignments[material] = nodes assign_vrayproxy_shaders(vrayproxy, assignments) -