mirror of
https://github.com/ynput/ayon-core.git
synced 2025-12-24 21:04:40 +01:00
Apply suggestions from code review
Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
This commit is contained in:
parent
0e8690e848
commit
5b163fe84d
6 changed files with 11 additions and 12 deletions
|
|
@ -220,8 +220,8 @@ class IWorkfileHost:
|
|||
Default implementation keeps workdir untouched.
|
||||
|
||||
Warnings:
|
||||
We must handle this modification with more sophisticated way because
|
||||
this can't be called out of DCC so opening of last workfile
|
||||
We must handle this modification with more sophisticated way
|
||||
because this can't be called out of DCC so opening of last workfile
|
||||
(calculated before DCC is launched) is complicated. Also breaking
|
||||
defined work template is not a good idea.
|
||||
Only place where it's really used and can make sense is Maya. There
|
||||
|
|
|
|||
|
|
@ -42,7 +42,8 @@ class ValidateMvLookContents(pyblish.api.InstancePlugin):
|
|||
resources = instance.data.get("resources", [])
|
||||
for resource in resources:
|
||||
files = resource["files"]
|
||||
self.log.debug("Resource '{}', files: [{}]".format(resource, files))
|
||||
self.log.debug(
|
||||
"Resource '{}', files: [{}]".format(resource, files))
|
||||
node = resource["node"]
|
||||
if len(files) == 0:
|
||||
self.log.error("File node '{}' uses no or non-existing "
|
||||
|
|
|
|||
|
|
@ -791,8 +791,6 @@ class PublishClip:
|
|||
self.tag_data.update({"reviewTrack": self.review_layer})
|
||||
else:
|
||||
self.tag_data.update({"reviewTrack": None})
|
||||
|
||||
|
||||
def _solve_tag_hierarchy_data(self, hierarchy_formatting_data):
|
||||
""" Solve tag data from hierarchy data and templates. """
|
||||
# fill up clip name and hierarchy keys
|
||||
|
|
|
|||
|
|
@ -158,8 +158,8 @@ class ProcessSubmittedJobOnFarm(pyblish.api.InstancePlugin):
|
|||
# regex for finding frame number in string
|
||||
R_FRAME_NUMBER = re.compile(r'.+\.(?P<frame>[0-9]+)\..+')
|
||||
|
||||
# mapping of instance properties to be transferred to new instance for every
|
||||
# specified family
|
||||
# mapping of instance properties to be transferred to new instance
|
||||
# for every specified family
|
||||
instance_transfer = {
|
||||
"slate": ["slateFrames", "slate"],
|
||||
"review": ["lutPath"],
|
||||
|
|
|
|||
|
|
@ -2584,8 +2584,8 @@ class SyncEntitiesFactory:
|
|||
#
|
||||
# ent_dict = self.entities_dict[found_by_name_id]
|
||||
|
||||
# TODO report - CRITICAL entity with same name already exists in
|
||||
# different hierarchy - can't recreate entity
|
||||
# TODO report - CRITICAL entity with same name already exists
|
||||
# in different hierarchy - can't recreate entity
|
||||
continue
|
||||
|
||||
_vis_parent = deleted_entity["data"]["visualParent"]
|
||||
|
|
|
|||
|
|
@ -1700,9 +1700,9 @@ class PercentValueRelativeSource(_OverscanValue):
|
|||
class OverscanCrop:
|
||||
"""Helper class to read overscan string and calculate output resolution.
|
||||
|
||||
It is possible to enter single value for both width and height or two values
|
||||
for width and height. Overscan string may have a few variants. Each variant
|
||||
define output size for input size.
|
||||
It is possible to enter single value for both width and height, or
|
||||
two values for width and height. Overscan string may have a few variants.
|
||||
Each variant define output size for input size.
|
||||
|
||||
### Example
|
||||
For input size: 2200px
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue