Apply suggestions from code review

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

client/ayon_core/pipeline/create/creator_plugins.py

@@ -862,8 +862,11 @@ class Creator(BaseCreator):
 
         # TODO: confirm feature
         publish_settings = self.project_settings["core"]["publish"]
-        anatomy_settings = publish_settings["CollectAnatomyInstanceData"]
-        follow_workfile_version = anatomy_settings["follow_workfile_version"]
+        follow_workfile_version = (
+            publish_settings
+            ["CollectAnatomyInstanceData"]
+            ["follow_workfile_version"]
+        )
         if follow_workfile_version:
             current_workfile = self.create_context.get_current_workfile_path()
             workfile_version = get_version_from_path(current_workfile)
@@ -871,8 +874,8 @@ class Creator(BaseCreator):
 
         staging_dir_info = get_staging_dir_info(
             create_ctx.get_current_project_entity(),
-            create_ctx.get_current_folder_entity(),
-            create_ctx.get_current_task_entity(),
+            create_ctx.get_folder_entity(folder_path),
+            create_ctx.get_task_entity(folder_path, instance.get("task")),
             product_type,
             product_name,
             create_ctx.host_name,

client/ayon_core/pipeline/staging_dir.py

@@ -8,7 +8,10 @@ from .anatomy import Anatomy
 from .tempdir import get_temp_dir
 
 
-StagingDir = namedtuple("StagingDir", ["dir", "persistent"])
+@dataclass
+class StagingDir:
+    directory: str
+    persistent: bool
 
 
 def get_staging_dir_config(
@@ -78,10 +81,9 @@ def get_staging_dir_config(
 
     if not template:
         # template should always be found either from anatomy or from profile
-        raise ValueError(
-            "Staging dir profile is misconfigured! "
-            f"No template was found for profile: {profile}! "
-            "Check your project settings at: "
+        raise KeyError(
+            f"Staging template '{template_name}' was not found."
+            "Check project anatomy or settings at: "
             "'ayon+settings://core/tools/publish/custom_staging_dir_profiles'"
         )
 
@@ -98,10 +100,8 @@ def _validate_template_name(project_name, template_name, anatomy):
     """
     if template_name not in anatomy.templates["staging"]:
         raise ValueError(
-            (
-                'Anatomy of project "{}" does not have set'
-                ' "{}" template key at Staging Dir section!'
-            ).format(project_name, template_name)
+            f'Anatomy of project "{project_name}" does not have set'
+            f' "{template_name}" template key at Staging Dir category!'
         )
 
 
@@ -131,14 +131,14 @@ def get_staging_dir_info(
     Arguments:
         host_name (str): Name of host.
         project_entity (Dict[str, Any]): Project entity.
-        folder_entity (Dict[str, Any]): Folder entity.
-        task_entity (Dict[str, Any]): Task entity.
+        folder_entity (Optional[Dict[str, Any]]): Folder entity.
+        task_entity (Optional[Dict[str, Any]]): Task entity.
         product_type (str): Type of product.
         product_name (str): Name of product.
-        anatomy (ayon_core.pipeline.Anatomy): Anatomy object.
+        anatomy (Optional[Anatomy]): Anatomy object.
         project_settings (Optional[Dict[str, Any]]): Prepared project settings.
-        template_data (Optional[Dict[str, Any]]): Data for formatting staging
-            dir template.
+        template_data (Optional[Dict[str, Any]]): Additional data for
+            formatting staging dir template.
         always_return_path (Optional[bool]): If True, staging dir will be
             created as tempdir if no staging dir profile is found. Input value
             False will return None if no staging dir profile is found.
@@ -152,7 +152,6 @@ def get_staging_dir_info(
         Optional[StagingDir]: Staging dir info data
 
     """
-    task_entity = task_entity or {}
     log = logger or Logger.get_logger("get_staging_dir_info")
 
     if anatomy is None:
@@ -185,12 +184,16 @@ def get_staging_dir_info(
     # add additional template formatting data
     if template_data:
         ctx_data.update(template_data)
+    task_name = task_type = None
+    if task_entity:
+        task_name = task_entity["name"]
+        task_type = task_entity["taskType"]
 
     # get staging dir config
     staging_dir_config = get_staging_dir_config(
         project_entity["name"],
-        task_entity.get("taskType"),
-        task_entity.get("name"),
+        task_type,
+        task_name ,
         product_type,
         product_name,
         host_name,
@@ -200,11 +203,9 @@ def get_staging_dir_info(
     )
 
     if staging_dir_config:
+        dir_template = staging_dir_config["template"]["directory"]
         return StagingDir(
-            StringTemplate.format_template(
-                str(staging_dir_config["template"]["directory"]),
-                ctx_data
-            ),
+            dir_template.format_strict(ctx_data),
             staging_dir_config["persistence"],
         )
 

client/ayon_core/pipeline/tempdir.py

@@ -36,7 +36,8 @@ def get_temp_dir(
         str: Path to staging dir of instance.
 
     """
-    prefix = prefix or "ay_tmp_"
+    if prefix is None:
+        prefix = "ay_tmp_"
     suffix = suffix or ""
 
     if use_local_temp: