From 820fd54a567881bc386a05e69986c7b33a6c9b12 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
Date: Thu, 3 Oct 2024 17:39:10 +0200
Subject: [PATCH] remove pyblish exception logfrom records

---
 .../tools/publisher/models/publish.py         | 22 +++++++++++++++----
 1 file changed, 18 insertions(+), 4 deletions(-)

diff --git a/client/ayon_core/tools/publisher/models/publish.py b/client/ayon_core/tools/publisher/models/publish.py
index 6dfda38885..97a956b18f 100644
--- a/client/ayon_core/tools/publisher/models/publish.py
+++ b/client/ayon_core/tools/publisher/models/publish.py
@@ -32,17 +32,20 @@ PLUGIN_ORDER_OFFSET = 0.5
 class MessageHandler(logging.Handler):
     def __init__(self, *args, **kwargs):
         super().__init__(*args, **kwargs)
-        self.records = []
+        self._records = []
 
     def clear_records(self):
-        self.records = []
+        self._records = []
 
     def emit(self, record):
         try:
             record.msg = record.getMessage()
         except Exception:
             record.msg = str(record.msg)
-        self.records.append(record)
+        self._records.append(record)
+
+    def get_records(self):
+        return self._records
 
 
 class PublishErrorInfo:
@@ -1328,7 +1331,18 @@ class PublishModel:
                 plugin, self._publish_context, instance
             )
             if log_handler is not None:
-                result["records"] = log_handler.records
+                records = log_handler.get_records()
+                exception = result.get("error")
+                if exception is not None and records:
+                    last_record = records[-1]
+                    if (
+                        last_record.name == "pyblish.plugin"
+                        and last_record.levelno == logging.ERROR
+                    ):
+                        # Remove last record made by pyblish
+                        # - `log.exception(formatted_traceback)`
+                        records.pop(-1)
+                result["records"] = records
 
         exception = result.get("error")
         if exception: