converted tvpaintconverted aftereffects harmony photoshop tvpaint and unreal to define default environments

openpype/hosts/aftereffects/__init__.py

@@ -0,0 +1,9 @@
+def add_implementation_envs(env):
+    """Modify environments to contain all required for implementation."""
+    defaults = {
+        "OPENPYPE_LOG_NO_COLORS": "True",
+        "WEBSOCKET_URL": "ws://localhost:8097/ws/"
+    }
+    for key, value in defaults.items():
+        if not env.get(key):
+            env[key] = value

openpype/hosts/harmony/__init__.py

@@ -0,0 +1,10 @@
+import os
+
+
+def add_implementation_envs(env):
+    """Modify environments to contain all required for implementation."""
+    openharmony_path = os.path.join(
+        os.environ["OPENPYPE_REPOS_ROOT"], "pype", "vendor", "OpenHarmony"
+    )
+    # TODO check if is already set? What to do if is already set?
+    env["LIB_OPENHARMONY_PATH"] = openharmony_path

openpype/hosts/photoshop/__init__.py

@@ -0,0 +1,9 @@
+def add_implementation_envs(env):
+    """Modify environments to contain all required for implementation."""
+    defaults = {
+        "OPENPYPE_LOG_NO_COLORS": "True",
+        "WEBSOCKET_URL": "ws://localhost:8099/ws/"
+    }
+    for key, value in defaults.items():
+        if not env.get(key):
+            env[key] = value

openpype/hosts/tvpaint/__init__.py

@@ -0,0 +1,8 @@
+def add_implementation_envs(env):
+    """Modify environments to contain all required for implementation."""
+    defaults = {
+        "OPENPYPE_LOG_NO_COLORS": "True"
+    }
+    for key, value in defaults.items():
+        if not env.get(key):
+            env[key] = value

openpype/hosts/unreal/__init__.py

@@ -0,0 +1,18 @@
+import os
+
+
+def add_implementation_envs(env):
+    """Modify environments to contain all required for implementation."""
+    # Set AVALON_UNREAL_PLUGIN required for Unreal implementation
+    unreal_plugin_path = os.path.join(
+        os.environ["OPENPYPE_REPOS_ROOT"], "repos", "avalon-unreal-integration"
+    )
+    env["AVALON_UNREAL_PLUGIN"] = unreal_plugin_path
+
+    # Set default environments if are not set via settings
+    defaults = {
+        "OPENPYPE_LOG_NO_COLORS": "True"
+    }
+    for key, value in defaults.items():
+        if not env.get(key):
+            env[key] = value

openpype/settings/defaults/system_settings/applications.json

@@ -890,8 +890,7 @@
         "icon": "{}/app_icons/harmony.png",
         "host_name": "harmony",
         "environment": {
-            "AVALON_HARMONY_WORKFILES_ON_LAUNCH": "1",
+            "AVALON_HARMONY_WORKFILES_ON_LAUNCH": "1"
-            "LIB_OPENHARMONY_PATH": "{OPENPYPE_REPOS_ROOT}/pype/vendor/OpenHarmony"
         },
         "variants": {
             "20": {
@@ -935,9 +934,7 @@
         "label": "TVPaint",
         "icon": "{}/app_icons/tvpaint.png",
         "host_name": "tvpaint",
-        "environment": {
+        "environment": {},
-            "OPENPYPE_LOG_NO_COLORS": "True"
-        },
         "variants": {
             "animation_11-64bits": {
                 "use_python_2": false,
@@ -984,8 +981,6 @@
         "host_name": "photoshop",
         "environment": {
             "AVALON_PHOTOSHOP_WORKFILES_ON_LAUNCH": "1",
-            "OPENPYPE_LOG_NO_COLORS": "Yes",
-            "WEBSOCKET_URL": "ws://localhost:8099/ws/",
             "WORKFILES_SAVE_AS": "Yes"
         },
         "variants": {
@@ -1034,8 +1029,6 @@
         "host_name": "aftereffects",
         "environment": {
             "AVALON_AFTEREFFECTS_WORKFILES_ON_LAUNCH": "1",
-            "OPENPYPE_LOG_NO_COLORS": "Yes",
-            "WEBSOCKET_URL": "ws://localhost:8097/ws/",
             "WORKFILES_SAVE_AS": "Yes"
         },
         "variants": {
@@ -1109,10 +1102,7 @@
         "label": "Unreal Editor",
         "icon": "{}/app_icons/ue4.png'",
         "host_name": "unreal",
-        "environment": {
+        "environment": {},
-            "AVALON_UNREAL_PLUGIN": "{OPENPYPE_REPOS_ROOT}/repos/avalon-unreal-integration",
-            "OPENPYPE_LOG_NO_COLORS": "True"
-        },
         "variants": {
             "4-26": {
                 "use_python_2": false,