From 69b0012fd9427c554df753f7c2fdc43fc1c60bea Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakub@orbi.tools>
Date: Fri, 4 Mar 2022 13:46:32 +0100
Subject: [PATCH] nuke: subset filtering on baking presets

---
 .../publish/extract_review_data_mov.py        | 26 ++++++++++++++++++-
 .../defaults/project_settings/nuke.json       |  3 ++-
 .../schemas/schema_nuke_publish.json          |  6 +++++
 3 files changed, 33 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/nuke/plugins/publish/extract_review_data_mov.py b/openpype/hosts/nuke/plugins/publish/extract_review_data_mov.py
index 5bbc88266a..1071834497 100644
--- a/openpype/hosts/nuke/plugins/publish/extract_review_data_mov.py
+++ b/openpype/hosts/nuke/plugins/publish/extract_review_data_mov.py
@@ -1,4 +1,5 @@
 import os
+import re
 import pyblish.api
 import openpype
 from openpype.hosts.nuke.api import plugin
@@ -25,6 +26,7 @@ class ExtractReviewDataMov(openpype.api.Extractor):
     def process(self, instance):
         families = instance.data["families"]
         task_type = instance.context.data["taskType"]
+        subset = instance.data["subset"]
         self.log.info("Creating staging dir...")
 
         if "representations" not in instance.data:
@@ -46,6 +48,7 @@ class ExtractReviewDataMov(openpype.api.Extractor):
             for o_name, o_data in self.outputs.items():
                 f_families = o_data["filter"]["families"]
                 f_task_types = o_data["filter"]["task_types"]
+                f_subsets = o_data["filter"]["sebsets"]
 
                 # test if family found in context
                 test_families = any([
@@ -69,11 +72,25 @@ class ExtractReviewDataMov(openpype.api.Extractor):
                     bool(not f_task_types)
                 ])
 
+                # test subsets from filter
+                test_subsets = any([
+                    # check if any of subset filter inputs
+                    # converted to regex patern is not found in subset
+                    # we keep strict case sensitivity
+                    bool(next((
+                        s for s in f_subsets
+                        if re.search(re.compile(s), subset)
+                    ), None)),
+                    # but if no subsets were set then make this acuntable too
+                    bool(not f_subsets)
+                ])
+
                 # we need all filters to be positive for this
                 # preset to be activated
                 test_all = all([
                     test_families,
-                    test_task_types
+                    test_task_types,
+                    test_subsets
                 ])
 
                 # if it is not positive then skip this preset
@@ -120,6 +137,13 @@ class ExtractReviewDataMov(openpype.api.Extractor):
         if generated_repres:
             # assign to representations
             instance.data["representations"] += generated_repres
+        else:
+            instance.data["families"].remove("review")
+            self.log.info((
+                "Removing `review` from families. "
+                "Not available baking profile."
+            ))
+            self.log.debug(instance.data["families"])
 
         self.log.debug(
             "_ representations: {}".format(
diff --git a/openpype/settings/defaults/project_settings/nuke.json b/openpype/settings/defaults/project_settings/nuke.json
index e30296d0ad..6992fb6e3e 100644
--- a/openpype/settings/defaults/project_settings/nuke.json
+++ b/openpype/settings/defaults/project_settings/nuke.json
@@ -116,7 +116,8 @@
                 "baking": {
                     "filter": {
                         "task_types": [],
-                        "families": []
+                        "families": [],
+                        "sebsets": []
                     },
                     "extension": "mov",
                     "viewer_process_override": "",
diff --git a/openpype/settings/entities/schemas/projects_schema/schemas/schema_nuke_publish.json b/openpype/settings/entities/schemas/projects_schema/schemas/schema_nuke_publish.json
index 4c94801796..1636a8d700 100644
--- a/openpype/settings/entities/schemas/projects_schema/schemas/schema_nuke_publish.json
+++ b/openpype/settings/entities/schemas/projects_schema/schemas/schema_nuke_publish.json
@@ -195,6 +195,12 @@
                                         "label": "Families",
                                         "type": "list",
                                         "object_type": "text"
+                                    },
+                                    {
+                                        "key": "sebsets",
+                                        "label": "Subsets",
+                                        "type": "list",
+                                        "object_type": "text"
                                     }
                                 ]
                             },