♻️ modify UE launching to use executable from settings

openpype/hosts/unreal/hooks/pre_workfile_preparation.py

@@ -24,7 +24,7 @@ class UnrealPrelaunchHook(PreLaunchHook):
     """Hook to handle launching Unreal.
 
     This hook will check if current workfile path has Unreal
-    project inside. IF not, it initialize it and finally it pass
+    project inside. IF not, it initializes it, and finally it pass
     path to the project by environment variable to Unreal launcher
     shell script.
 
@@ -141,6 +141,7 @@ class UnrealPrelaunchHook(PreLaunchHook):
     def execute(self):
         """Hook entry method."""
         workdir = self.launch_context.env["AVALON_WORKDIR"]
+        executable = str(self.launch_context.executable)
         engine_version = self.app_name.split("/")[-1].replace("-", ".")
         try:
             if int(engine_version.split(".")[0]) < 4 and \
@@ -152,7 +153,7 @@ class UnrealPrelaunchHook(PreLaunchHook):
             # there can be string in minor version and in that case
             # int cast is failing. This probably happens only with
             # early access versions and is of no concert for this check
-            # so lets keep it quite.
+            # so let's keep it quiet.
             ...
 
         unreal_project_filename = self._get_work_filename()
@@ -183,26 +184,6 @@ class UnrealPrelaunchHook(PreLaunchHook):
             f"[ {engine_version} ]"
         ))
 
-        detected = unreal_lib.get_engine_versions(self.launch_context.env)
-        detected_str = ', '.join(detected.keys()) or 'none'
-        self.log.info((
-            f"{self.signature} detected UE versions: "
-            f"[ {detected_str} ]"
-        ))
-        if not detected:
-            raise ApplicationNotFound("No Unreal Engines are found.")
-
-        engine_version = ".".join(engine_version.split(".")[:2])
-        if engine_version not in detected.keys():
-            raise ApplicationLaunchFailed((
-                f"{self.signature} requested version not "
-                f"detected [ {engine_version} ]"
-            ))
-
-        ue_path = unreal_lib.get_editor_exe_path(
-            Path(detected[engine_version]), engine_version)
-
-        self.launch_context.launch_args = [ue_path.as_posix()]
         project_path.mkdir(parents=True, exist_ok=True)
 
         # Set "OPENPYPE_UNREAL_PLUGIN" to current process environment for
@@ -217,7 +198,9 @@ class UnrealPrelaunchHook(PreLaunchHook):
         if self.launch_context.env.get(env_key):
             os.environ[env_key] = self.launch_context.env[env_key]
 
-        engine_path: Path = Path(detected[engine_version])
+        # engine_path points to the specific Unreal Engine root
+        # so, we are going up from the executable itself 3 levels.
+        engine_path: Path = Path(executable).parents[3]
 
         if not unreal_lib.check_plugin_existence(engine_path):
             self.exec_plugin_install(engine_path)

openpype/hosts/unreal/lib.py

@@ -23,6 +23,8 @@ def get_engine_versions(env=None):
     Location can be overridden by `UNREAL_ENGINE_LOCATION` environment
     variable.
 
+    .. deprecated:: 3.15.4
+
     Args:
         env (dict, optional): Environment to use.
 
@@ -103,6 +105,8 @@ def _win_get_engine_versions():
     This file is JSON file listing installed stuff, Unreal engines
     are marked with `"AppName" = "UE_X.XX"`` like `UE_4.24`
 
+    .. deprecated:: 3.15.4
+
     Returns:
         dict: version as a key and path as a value.
 
@@ -122,6 +126,8 @@ def _darwin_get_engine_version() -> dict:
 
     It works the same as on Windows, just JSON file location is different.
 
+    .. deprecated:: 3.15.4
+
     Returns:
         dict: version as a key and path as a value.
 
@@ -144,6 +150,8 @@ def _darwin_get_engine_version() -> dict:
 def _parse_launcher_locations(install_json_path: str) -> dict:
     """This will parse locations from json file.
 
+    .. deprecated:: 3.15.4
+
     Args:
         install_json_path (str): Path to `LauncherInstalled.dat`.