From 6e56ba2cc17a384dff0f27ed96e00dd2d7e54e22 Mon Sep 17 00:00:00 2001
From: Mustafa-Zarkash <mustafataherzaky@outlook.com>
Date: Thu, 5 Oct 2023 14:49:34 +0300
Subject: [PATCH] Bigroy's comments and  update attribute def label and tip

---
 openpype/hosts/houdini/api/lib.py             |  8 +++----
 .../publish/collect_rop_frame_range.py        | 24 ++++++++++---------
 2 files changed, 17 insertions(+), 15 deletions(-)

diff --git a/openpype/hosts/houdini/api/lib.py b/openpype/hosts/houdini/api/lib.py
index 3c39b32b0d..711fae7cc4 100644
--- a/openpype/hosts/houdini/api/lib.py
+++ b/openpype/hosts/houdini/api/lib.py
@@ -564,20 +564,20 @@ def get_frame_data(node, asset_data=None, log=None):
     if log is None:
         log = self.log
 
+    data = {}
+
     if node.parm("trange") is None:
         log.debug(
             "Node has no 'trange' parameter: {}".format(node.path())
         )
-        return
+        return data
 
     if node.evalParm("trange") == 0:
         log.debug(
             "Node '{}' has 'Render current frame' set. "
             "Time range data ignored.".format(node.path())
         )
-        return
-
-    data = {}
+        return data
 
     data["frameStartHandle"] = node.evalParm("f1")
     data["handleStart"] = asset_data.get("handleStart", 0)
diff --git a/openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py b/openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py
index 75c101ed0f..1f65d4eea6 100644
--- a/openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py
+++ b/openpype/hosts/houdini/plugins/publish/collect_rop_frame_range.py
@@ -30,7 +30,7 @@ class CollectRopFrameRange(pyblish.api.InstancePlugin,
         asset_data = instance.context.data["assetEntity"]["data"]
 
         attr_values = self.get_attr_values_from_data(instance.data)
-        if attr_values.get("reset_handles"):
+        if not attr_values.get("use_handles"):
             asset_data["handleStart"] = 0
             asset_data["handleEnd"] = 0
 
@@ -42,17 +42,17 @@ class CollectRopFrameRange(pyblish.api.InstancePlugin,
         # Log artist friendly message about the collected frame range
         message = ""
 
-        if attr_values.get("reset_handles"):
-            message += (
-                "Reset frame handles is activated for this instance, "
-                "start and end handles are set to 0.\n"
-            )
-        else:
+        if attr_values.get("use_handles"):
             message += (
                 "Full Frame range with Handles "
                 "{0[frameStartHandle]} - {0[frameEndHandle]}\n"
                 .format(frame_data)
             )
+        else:
+            message += (
+                "Use handles is deactivated for this instance, "
+                "start and end handles are set to 0.\n"
+            )
 
         message += (
             "Frame range {0[frameStart]} - {0[frameEnd]}"
@@ -76,8 +76,10 @@ class CollectRopFrameRange(pyblish.api.InstancePlugin,
     @classmethod
     def get_attribute_defs(cls):
         return [
-            BoolDef("reset_handles",
-                    tooltip="Set frame handles to zero",
-                    default=False,
-                    label="Reset frame handles")
+            BoolDef("use_handles",
+                    tooltip="Disable this if you don't want the publisher"
+                    " to ignore start and end handles specified in the asset data"
+                    " for this publish instance",
+                    default=True,
+                    label="Use asset handles")
         ]