ftrack module modify application launch environments in module instead of in prelaunch hook

openpype/modules/base.py

@@ -450,14 +450,14 @@ class OpenPypeModule:
 
         return {}
 
-    def modify_application_launch_arguments(self, app, env):
+    def modify_application_launch_arguments(self, application, env):
         """Give option to modify launch environments before application launch.
 
         Implementation is optional. To change environments modify passed
         dictionary of environments.
 
         Args:
-            app (Application): Application that is launcher.
+            application (Application): Application that is launched.
             env (dict): Current environemnt variables.
         """
 

openpype/modules/ftrack/ftrack_module.py

@@ -88,6 +88,40 @@ class FtrackModule(
         """Implementation of `ILaunchHookPaths`."""
         return os.path.join(FTRACK_MODULE_DIR, "launch_hooks")
 
+    def modify_application_launch_arguments(self, application, env):
+        if not application.use_python_2:
+            return
+
+        self.log.info("Adding Ftrack Python 2 packages to PYTHONPATH.")
+
+        # Prepare vendor dir path
+        python_2_vendor = os.path.join(FTRACK_MODULE_DIR, "python2_vendor")
+
+        # Add Python 2 modules
+        python_paths = [
+            # `python-ftrack-api`
+            os.path.join(python_2_vendor, "ftrack-python-api", "source"),
+            # `arrow`
+            os.path.join(python_2_vendor, "arrow"),
+            # `builtins` from `python-future`
+            # - `python-future` is strict Python 2 module that cause crashes
+            #   of Python 3 scripts executed through OpenPype
+            #   (burnin script etc.)
+            os.path.join(python_2_vendor, "builtins"),
+            # `backports.functools_lru_cache`
+            os.path.join(
+                python_2_vendor, "backports.functools_lru_cache"
+            )
+        ]
+
+        # Load PYTHONPATH from current launch context
+        python_path = env.get("PYTHONPATH")
+        if python_path:
+            python_paths.append(python_path)
+
+        # Set new PYTHONPATH to launch context environments
+        env["PYTHONPATH"] = os.pathsep.join(python_paths)
+
     def connect_with_modules(self, enabled_modules):
         for module in enabled_modules:
             if not hasattr(module, "get_ftrack_event_handler_paths"):

openpype/modules/ftrack/launch_hooks/pre_python2_vendor.py

@@ -1,43 +0,0 @@
-import os
-from openpype.lib import PreLaunchHook
-from openpype_modules.ftrack import FTRACK_MODULE_DIR
-
-
-class PrePython2Support(PreLaunchHook):
-    """Add python ftrack api module for Python 2 to PYTHONPATH.
-
-    Path to vendor modules is added to the beggining of PYTHONPATH.
-    """
-
-    def execute(self):
-        if not self.application.use_python_2:
-            return
-
-        self.log.info("Adding Ftrack Python 2 packages to PYTHONPATH.")
-
-        # Prepare vendor dir path
-        python_2_vendor = os.path.join(FTRACK_MODULE_DIR, "python2_vendor")
-
-        # Add Python 2 modules
-        python_paths = [
-            # `python-ftrack-api`
-            os.path.join(python_2_vendor, "ftrack-python-api", "source"),
-            # `arrow`
-            os.path.join(python_2_vendor, "arrow"),
-            # `builtins` from `python-future`
-            # - `python-future` is strict Python 2 module that cause crashes
-            #   of Python 3 scripts executed through OpenPype (burnin script etc.)
-            os.path.join(python_2_vendor, "builtins"),
-            # `backports.functools_lru_cache`
-            os.path.join(
-                python_2_vendor, "backports.functools_lru_cache"
-            )
-        ]
-
-        # Load PYTHONPATH from current launch context
-        python_path = self.launch_context.env.get("PYTHONPATH")
-        if python_path:
-            python_paths.append(python_path)
-
-        # Set new PYTHONPATH to launch context environments
-        self.launch_context.env["PYTHONPATH"] = os.pathsep.join(python_paths)