From 746819ef517e84f049b83ffcb67746a3061ed5aa Mon Sep 17 00:00:00 2001 From: MustafaJafar Date: Mon, 4 Mar 2024 21:40:53 +0200 Subject: [PATCH] better variable/setting naming and add description for it --- .../plugins/publish/collect_files_for_cleaning_up.py | 4 ++-- server_addon/houdini/server/settings/publish.py | 8 ++++++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/client/ayon_core/hosts/houdini/plugins/publish/collect_files_for_cleaning_up.py b/client/ayon_core/hosts/houdini/plugins/publish/collect_files_for_cleaning_up.py index 02ee5f940e..501e8d4f85 100644 --- a/client/ayon_core/hosts/houdini/plugins/publish/collect_files_for_cleaning_up.py +++ b/client/ayon_core/hosts/houdini/plugins/publish/collect_files_for_cleaning_up.py @@ -70,7 +70,7 @@ class CollectFilesForCleaningUp(pyblish.api.InstancePlugin, # aovs.values() is a list of lists files.extend(sum(aovs.values(), [])) - # Intermediate render files. + # Intermediate exported render files. # TODO 1:For products with split render enabled, # We need to calculate all exported frames. as. # `ifdFile` should be a list of files. @@ -78,7 +78,7 @@ class CollectFilesForCleaningUp(pyblish.api.InstancePlugin, # Karma has more intermediate files # e.g. USD and checkpoint ifdFile = instance.data.get("ifdFile") - if self.include_intermediate_files and ifdFile: + if self.intermediate_exported_render and ifdFile: files.append(ifdFile) # Non Render Products with no frames diff --git a/server_addon/houdini/server/settings/publish.py b/server_addon/houdini/server/settings/publish.py index 2f32553382..c340dbeb27 100644 --- a/server_addon/houdini/server/settings/publish.py +++ b/server_addon/houdini/server/settings/publish.py @@ -44,7 +44,11 @@ class CollectFilesForCleaningUpModel(BaseSettingsModel): enabled: bool = SettingsField(title="Enabled") optional: bool = SettingsField(title="Optional") active: bool = SettingsField(title="Active") - include_intermediate_files: bool = SettingsField(title="Include Intermediate Render Files") + intermediate_exported_render: bool = SettingsField( + title="Include Intermediate Exported Render Files", + description="Include intermediate exported render scenes for cleanup" + " (.idf, .ass, .usd, .rs) for render instances.", + ) families: list[str] = SettingsField( default_factory=list, enum_resolver=product_types_enum, @@ -120,7 +124,7 @@ DEFAULT_HOUDINI_PUBLISH_SETTINGS = { "enabled": False, "optional": True, "active": True, - "include_intermediate_files": False, + "intermediate_exported_render": False, "families" : [] }, "ValidateContainers": {