From 74984afc7be1e0d707b0742fa594bc75396a8eee Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 5 Jan 2023 18:11:49 +0100
Subject: [PATCH] added new 'LoadError' to avoid showing traceback

---
 openpype/pipeline/load/__init__.py |  1 +
 openpype/pipeline/load/utils.py    | 10 ++++++++
 openpype/tools/loader/widgets.py   | 38 ++++++++++++++++++------------
 3 files changed, 34 insertions(+), 15 deletions(-)

diff --git a/openpype/pipeline/load/__init__.py b/openpype/pipeline/load/__init__.py
index e96f64f2a4..8bd09876bf 100644
--- a/openpype/pipeline/load/__init__.py
+++ b/openpype/pipeline/load/__init__.py
@@ -1,6 +1,7 @@
 from .utils import (
     HeroVersionType,
 
+    LoadError,
     IncompatibleLoaderError,
     InvalidRepresentationContext,
 
diff --git a/openpype/pipeline/load/utils.py b/openpype/pipeline/load/utils.py
index 784d4628f3..e2b3675115 100644
--- a/openpype/pipeline/load/utils.py
+++ b/openpype/pipeline/load/utils.py
@@ -60,6 +60,16 @@ class HeroVersionType(object):
         return self.version.__format__(format_spec)
 
 
+class LoadError(Exception):
+    """Known error that happened during loading.
+
+    A message is shown to user (without traceback). Make sure an artist can
+    understand the problem.
+    """
+
+    pass
+
+
 class IncompatibleLoaderError(ValueError):
     """Error when Loader is incompatible with a representation."""
     pass
diff --git a/openpype/tools/loader/widgets.py b/openpype/tools/loader/widgets.py
index 826c7110da..b0b43c1e40 100644
--- a/openpype/tools/loader/widgets.py
+++ b/openpype/tools/loader/widgets.py
@@ -29,6 +29,7 @@ from openpype.pipeline.load import (
     load_with_repre_context,
     load_with_subset_context,
     load_with_subset_contexts,
+    LoadError,
     IncompatibleLoaderError,
 )
 from openpype.tools.utils import (
@@ -1577,6 +1578,7 @@ def _load_representations_by_loader(loader, repre_contexts,
                 repre_context,
                 options=options
             )
+
         except IncompatibleLoaderError as exc:
             print(exc)
             error_info.append((
@@ -1588,10 +1590,13 @@ def _load_representations_by_loader(loader, repre_contexts,
             ))
 
         except Exception as exc:
-            exc_type, exc_value, exc_traceback = sys.exc_info()
-            formatted_traceback = "".join(traceback.format_exception(
-                exc_type, exc_value, exc_traceback
-            ))
+            formatted_traceback = None
+            if not isinstance(exc, LoadError):
+                exc_type, exc_value, exc_traceback = sys.exc_info()
+                formatted_traceback = "".join(traceback.format_exception(
+                    exc_type, exc_value, exc_traceback
+                ))
+
             error_info.append((
                 str(exc),
                 formatted_traceback,
@@ -1616,7 +1621,7 @@ def _load_subsets_by_loader(loader, subset_contexts, options,
     error_info = []
 
     if options is None:  # not load when cancelled
-        return
+        return error_info
 
     if loader.is_multiple_contexts_compatible:
         subset_names = []
@@ -1631,13 +1636,14 @@ def _load_subsets_by_loader(loader, subset_contexts, options,
                 subset_contexts,
                 options=options
             )
+
         except Exception as exc:
-            exc_type, exc_value, exc_traceback = sys.exc_info()
-            formatted_traceback = "".join(
-                traceback.format_exception(
+            formatted_traceback = None
+            if not isinstance(exc, LoadError):
+                exc_type, exc_value, exc_traceback = sys.exc_info()
+                formatted_traceback = "".join(traceback.format_exception(
                     exc_type, exc_value, exc_traceback
-                )
-            )
+                ))
             error_info.append((
                 str(exc),
                 formatted_traceback,
@@ -1657,13 +1663,15 @@ def _load_subsets_by_loader(loader, subset_contexts, options,
                     subset_context,
                     options=options
                 )
+
             except Exception as exc:
-                exc_type, exc_value, exc_traceback = sys.exc_info()
-                formatted_traceback = "\n".join(
-                    traceback.format_exception(
+                formatted_traceback = None
+                if not isinstance(exc, LoadError):
+                    exc_type, exc_value, exc_traceback = sys.exc_info()
+                    formatted_traceback = "".join(traceback.format_exception(
                         exc_type, exc_value, exc_traceback
-                    )
-                )
+                    ))
+
                 error_info.append((
                     str(exc),
                     formatted_traceback,