From 76bc7799f1dbcc993b5dbd2868f9309bd3e7e234 Mon Sep 17 00:00:00 2001
From: Ondrej Samohel <ondrej.samohel@orbi.tools>
Date: Fri, 25 Mar 2022 10:52:54 +0100
Subject: [PATCH] add top node validator

---
 .../publish/extract_unreal_staticmesh.py      |  5 +--
 .../help/validate_skeletalmesh_hierarchy.xml  | 14 ++++++++
 .../validate_skeletalmesh_hierarchy.py        | 36 +++++++++++++++++++
 3 files changed, 53 insertions(+), 2 deletions(-)
 create mode 100644 openpype/hosts/maya/plugins/publish/help/validate_skeletalmesh_hierarchy.xml
 create mode 100644 openpype/hosts/maya/plugins/publish/validate_skeletalmesh_hierarchy.py

diff --git a/openpype/hosts/maya/plugins/publish/extract_unreal_staticmesh.py b/openpype/hosts/maya/plugins/publish/extract_unreal_staticmesh.py
index c3cc322a29..92fa1b5933 100644
--- a/openpype/hosts/maya/plugins/publish/extract_unreal_staticmesh.py
+++ b/openpype/hosts/maya/plugins/publish/extract_unreal_staticmesh.py
@@ -22,8 +22,9 @@ class ExtractUnrealStaticMesh(openpype.api.Extractor):
     families = ["staticMesh"]
 
     def process(self, instance):
-        geo = instance.data.get("geometryMembers", [])
-        members = geo + instance.data.get("collisionMembers", [])
+        members = instance.data.get("geometryMembers", [])
+        if instance.data.get("collisionMembers"):
+            members = members + instance.data.get("collisionMembers")
 
         fbx_exporter = fbx.FBXExtractor(log=self.log)
 
diff --git a/openpype/hosts/maya/plugins/publish/help/validate_skeletalmesh_hierarchy.xml b/openpype/hosts/maya/plugins/publish/help/validate_skeletalmesh_hierarchy.xml
new file mode 100644
index 0000000000..d30c4cb69d
--- /dev/null
+++ b/openpype/hosts/maya/plugins/publish/help/validate_skeletalmesh_hierarchy.xml
@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<root>
+<error id="main">
+<title>Skeletal Mesh Top Node</title>
+<description>## Skeletal meshes needs common root
+
+Skeletal meshes and their joints must be under one common root.
+
+### How to repair?
+
+Make sure all geometry and joints resides under same root.
+</description>
+</error>
+</root>
diff --git a/openpype/hosts/maya/plugins/publish/validate_skeletalmesh_hierarchy.py b/openpype/hosts/maya/plugins/publish/validate_skeletalmesh_hierarchy.py
new file mode 100644
index 0000000000..dda7e063f6
--- /dev/null
+++ b/openpype/hosts/maya/plugins/publish/validate_skeletalmesh_hierarchy.py
@@ -0,0 +1,36 @@
+# -*- coding: utf-8 -*-
+import pyblish.api
+import openpype.api
+from openpype.pipeline import PublishXmlValidationError
+
+from maya import cmds
+
+
+class ValidateSkeletalMeshHierarchy(pyblish.api.InstancePlugin):
+    """Adheres to the content of 'model' family
+
+    - Must have one top group. (configurable)
+    - Must only contain: transforms, meshes and groups
+
+    """
+
+    order = openpype.api.ValidateContentsOrder
+    hosts = ["maya"]
+    families = ["skeletalMesh"]
+    label = "Skeletal Mesh Top Node"
+
+    def process(self, instance):
+        geo = instance.data.get("geometry")
+        joints = instance.data.get("joints")
+        joints_parents = cmds.ls(joints, long=True)[0].split("|")[1:-1]
+        geo_parents = cmds.ls(geo, long=True)[0].split("|")[1:-1]
+
+        self.log.info(joints_parents)
+        self.log.info(geo_parents)
+        self.log.info(set(joints_parents + geo_parents))
+
+        if len(set(joints_parents + geo_parents)) != 1:
+            raise PublishXmlValidationError(
+                self,
+                "Multiple roots on geometry or joints."
+            )