From 7c29aa2f7b72dd0a94a5a3531bc8a65c6d1cd3bb Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Tue, 5 Sep 2023 00:00:03 +0200
Subject: [PATCH] Improve errors e.g. raise PublishValidationError or cosmetics

---
 .../houdini/plugins/publish/collect_output_node.py    |  6 ++++--
 .../plugins/publish/validate_animation_settings.py    |  3 ++-
 .../plugins/publish/validate_remote_publish.py        | 11 +++++------
 .../publish/validate_usd_render_product_names.py      |  2 +-
 4 files changed, 12 insertions(+), 10 deletions(-)

diff --git a/openpype/hosts/houdini/plugins/publish/collect_output_node.py b/openpype/hosts/houdini/plugins/publish/collect_output_node.py
index 601ed17b39..0b27678ed0 100644
--- a/openpype/hosts/houdini/plugins/publish/collect_output_node.py
+++ b/openpype/hosts/houdini/plugins/publish/collect_output_node.py
@@ -1,5 +1,7 @@
 import pyblish.api
 
+from openpype.pipeline.publish import KnownPublishError
+
 
 class CollectOutputSOPPath(pyblish.api.InstancePlugin):
     """Collect the out node's SOP/COP Path value."""
@@ -58,8 +60,8 @@ class CollectOutputSOPPath(pyblish.api.InstancePlugin):
         elif node_type == "Redshift_Proxy_Output":
             out_node = node.parm("RS_archive_sopPath").evalAsNode()
         else:
-            raise ValueError(
-                "ROP node type '%s' is" " not supported." % node_type
+            raise KnownPublishError(
+                "ROP node type '{}' is not supported.".format(node_type)
             )
 
         if not out_node:
diff --git a/openpype/hosts/houdini/plugins/publish/validate_animation_settings.py b/openpype/hosts/houdini/plugins/publish/validate_animation_settings.py
index 4878738ed3..79387fbef5 100644
--- a/openpype/hosts/houdini/plugins/publish/validate_animation_settings.py
+++ b/openpype/hosts/houdini/plugins/publish/validate_animation_settings.py
@@ -1,5 +1,6 @@
 import pyblish.api
 
+from openpype.pipeline.publish import PublishValidationError
 from openpype.hosts.houdini.api import lib
 import hou
 
@@ -30,7 +31,7 @@ class ValidateAnimationSettings(pyblish.api.InstancePlugin):
 
         invalid = self.get_invalid(instance)
         if invalid:
-            raise RuntimeError(
+            raise PublishValidationError(
                 "Output settings do no match for '%s'" % instance
             )
 
diff --git a/openpype/hosts/houdini/plugins/publish/validate_remote_publish.py b/openpype/hosts/houdini/plugins/publish/validate_remote_publish.py
index 4e8e5fc0e8..4f71d79382 100644
--- a/openpype/hosts/houdini/plugins/publish/validate_remote_publish.py
+++ b/openpype/hosts/houdini/plugins/publish/validate_remote_publish.py
@@ -36,11 +36,11 @@ class ValidateRemotePublishOutNode(pyblish.api.ContextPlugin):
         if node.parm("shellexec").eval():
             self.raise_error("Must not execute in shell")
         if node.parm("prerender").eval() != cmd:
-            self.raise_error(("REMOTE_PUBLISH node does not have "
-                              "correct prerender script."))
+            self.raise_error("REMOTE_PUBLISH node does not have "
+                             "correct prerender script.")
         if node.parm("lprerender").eval() != "python":
-            self.raise_error(("REMOTE_PUBLISH node prerender script "
-                              "type not set to 'python'"))
+            self.raise_error("REMOTE_PUBLISH node prerender script "
+                             "type not set to 'python'")
 
     @classmethod
     def repair(cls, context):
@@ -48,5 +48,4 @@ class ValidateRemotePublishOutNode(pyblish.api.ContextPlugin):
         lib.create_remote_publish_node(force=True)
 
     def raise_error(self, message):
-        self.log.error(message)
-        raise PublishValidationError(message, title=self.label)
+        raise PublishValidationError(message)
diff --git a/openpype/hosts/houdini/plugins/publish/validate_usd_render_product_names.py b/openpype/hosts/houdini/plugins/publish/validate_usd_render_product_names.py
index 02c44ab94e..1daa96f2b9 100644
--- a/openpype/hosts/houdini/plugins/publish/validate_usd_render_product_names.py
+++ b/openpype/hosts/houdini/plugins/publish/validate_usd_render_product_names.py
@@ -24,7 +24,7 @@ class ValidateUSDRenderProductNames(pyblish.api.InstancePlugin):
 
             if not os.path.isabs(filepath):
                 invalid.append(
-                    "Output file path is not " "absolute path: %s" % filepath
+                    "Output file path is not absolute path: %s" % filepath
                 )
 
         if invalid: