From 5c321a67473f8b00cac7a06551f949b5cb26fb48 Mon Sep 17 00:00:00 2001 From: Jakub Jezek Date: Wed, 20 Nov 2019 09:23:42 +0100 Subject: [PATCH 1/3] feat(global): cleanup is now turned on only if successful publishing --- pype/plugins/global/publish/cleanup.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/pype/plugins/global/publish/cleanup.py b/pype/plugins/global/publish/cleanup.py index 34123b31cf..6f761ca83c 100644 --- a/pype/plugins/global/publish/cleanup.py +++ b/pype/plugins/global/publish/cleanup.py @@ -40,6 +40,15 @@ class CleanUp(pyblish.api.InstancePlugin): active = True def process(self, instance): + # Get the errored instances + failed = [] + for result in instance.context.data["results"]: + if (result["error"] is not None and result["instance"] is not None + and result["instance"] not in failed): + failed.append(result["instance"]) + assert instance not in failed, ("Result of '{}' instance " + "were not success".format(instance.data["name"])) + if [ef for ef in self.exclude_families if instance.data["family"] in ef]: return From 20270715cc2e75984ff68249fce3ed576110f070 Mon Sep 17 00:00:00 2001 From: Jakub Jezek Date: Wed, 20 Nov 2019 09:24:19 +0100 Subject: [PATCH 2/3] fix(global): removing duplicity in families --- pype/plugins/global/publish/integrate_new.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pype/plugins/global/publish/integrate_new.py b/pype/plugins/global/publish/integrate_new.py index 0443e10f57..5032e593a6 100644 --- a/pype/plugins/global/publish/integrate_new.py +++ b/pype/plugins/global/publish/integrate_new.py @@ -57,7 +57,6 @@ class IntegrateAssetNew(pyblish.api.InstancePlugin): "render", "imagesequence", "review", - "render", "rendersetup", "rig", "plate", From ba5796ebd84707cc280aba8ef3396f82fa91314d Mon Sep 17 00:00:00 2001 From: Jakub Jezek Date: Wed, 20 Nov 2019 09:25:02 +0100 Subject: [PATCH 3/3] doc(nuke): improving assert message --- pype/plugins/nuke/publish/increment_script_version.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pype/plugins/nuke/publish/increment_script_version.py b/pype/plugins/nuke/publish/increment_script_version.py index 2e33e65528..6e3ce08276 100644 --- a/pype/plugins/nuke/publish/increment_script_version.py +++ b/pype/plugins/nuke/publish/increment_script_version.py @@ -14,7 +14,7 @@ class IncrementScriptVersion(pyblish.api.ContextPlugin): def process(self, context): assert all(result["success"] for result in context.data["results"]), ( - "Atomicity not held, aborting.") + "Publishing not succesfull so version is not increased.") instances = context[:]