Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-24 12:54:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Refactor LoadClip plugin to set colorspace to read node

Browse source 
The commit refactors the LoadClip plugin by introducing a new method `set_colorspace_to_node` that sets the colorspace of the read node. The method retrieves the colorspace data from both the version and representation documents, as well as from the file's filerules. It then validates and sets the appropriate colorspace for the read node.

This change improves code readability and maintainability by separating concerns related to setting colorspace into a dedicated method.
This commit is contained in:
Jakub Jezek 2024-02-14 11:57:20 +01:00
parent 2f8b54aaf6
commit 7ffed6b807
No known key found for this signature in database
GPG key ID: 730D7C02726179A7
1 changed files with 75 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

106
client/ayon_core/hosts/nuke/plugins/load/load_clip.py
View file

@ -9,7 +9,10 @@ from ayon_core.client import (
)
from ayon_core.pipeline import (
get_current_project_name,
get_representation_path,
get_representation_path
)
from ayon_core.pipeline.colorspace import (
get_imageio_file_rules_colorspace_from_filepath
)
from ayon_core.hosts.nuke.api.lib import (
get_imageio_input_colorspace,
@ -101,7 +104,6 @@ class LoadClip(plugin.NukeLoader):
filepath = self.filepath_from_context(context)
filepath = filepath.replace("\\", "/")
self.log.debug("_ filepath: {}".format(filepath))
start_at_workfile = options.get(
"start_at_workfile", self.options_defaults["start_at_workfile"])
@ -154,8 +156,8 @@ class LoadClip(plugin.NukeLoader):
with viewer_update_and_undo_stop():
read_node["file"].setValue(filepath)
used_colorspace = self._set_colorspace(
read_node, version_data, representation["data"], filepath)
self.set_colorspace_to_node(
read_node, filepath, version, representation)
self._set_range_to_node(read_node, first, last, start_at_workfile)
@ -180,8 +182,6 @@ class LoadClip(plugin.NukeLoader):
colorspace = representation["data"].get(key)
colorspace = colorspace or version_data.get(key)
data_imprint["db_colorspace"] = colorspace
if used_colorspace:
data_imprint["used_colorspace"] = used_colorspace
else:
value_ = context["version"]['data'].get(
key, str(None))
@ -302,8 +302,8 @@ class LoadClip(plugin.NukeLoader):
# to avoid multiple undo steps for rest of process
# we will switch off undo-ing
with viewer_update_and_undo_stop():
used_colorspace = self._set_colorspace(
read_node, version_data, representation["data"], filepath)
self.set_colorspace_to_node(
read_node, filepath, version_doc, representation)
self._set_range_to_node(read_node, first, last, start_at_workfile)
@ -320,10 +320,6 @@ class LoadClip(plugin.NukeLoader):
"author": version_data.get("author")
}
# add used colorspace if found any
if used_colorspace:
updated_dict["used_colorspace"] = used_colorspace
last_version_doc = get_last_version_by_subset_id(
project_name, version_doc["parent"], fields=["_id"]
)
@ -350,6 +346,36 @@ class LoadClip(plugin.NukeLoader):
self.set_as_member(read_node)
def set_colorspace_to_node(
self,
read_node,
filepath,
version_doc,
representation_doc,
):
"""Set colorspace to read node.
Sets colorspace with available names validation.
Args:
read_node (nuke.Node): The nuke's read node
filepath (str): file path
version_doc (dict): version document
representation_doc (dict): representation document
"""
used_colorspace = self._get_colorspace_data(
version_doc, representation_doc, filepath)
if (
used_colorspace
and colorspace_exists_on_node(read_node, used_colorspace)
):
self.log.info(f"Used colorspace: {used_colorspace}")
read_node["colorspace"].setValue(used_colorspace)
else:
self.log.info("Colorspace not set...")
def remove(self, container):
read_node = container["node"]
assert read_node.Class() == "Read", "Must be Read"
@ -450,25 +476,43 @@ class LoadClip(plugin.NukeLoader):
return self.node_name_template.format(**name_data)
def _set_colorspace(self, node, version_data, repre_data, path):
output_color = None
path = path.replace("\\", "/")
# get colorspace
colorspace = repre_data.get("colorspace")
colorspace = colorspace or version_data.get("colorspace")
def _get_colorspace_data(self, version_doc, representation_doc, filepath):
"""Get colorspace data from version and representation documents
Args:
version_doc (dict): version document
representation_doc (dict): representation document
filepath (str): file path
Returns:
Any[str,None]: colorspace name or None
"""
# first set backward compatible colorspace key
colorspace = representation_doc["data"].get("colorspace")
self.log.debug(f"Colorspace representation: {colorspace}")
# secondly backward compatible version data key
colorspace = colorspace or version_doc["data"].get("colorspace")
self.log.debug(f"Colorspace version data: {colorspace}")
# thirdly set colorspace from representation colorspaceData
colorspace_data = representation_doc["data"].get("colorspaceData")
if colorspace_data:
colorspace = str(colorspace_data["colorspace"])
self.log.debug(f"Colorspace data: {colorspace}")
# check if any filerules are not applicable
new_parsed_colorspace = get_imageio_file_rules_colorspace_from_filepath( # noqa
filepath, "nuke", get_current_project_name()
)
self.log.debug(f"Colorspace new filerules: {new_parsed_colorspace}")
# colorspace from `project_settings/nuke/imageio/regexInputs`
iio_colorspace = get_imageio_input_colorspace(path)
old_parsed_colorspace = get_imageio_input_colorspace(filepath)
self.log.debug(f"Colorspace old filerules: {old_parsed_colorspace}")
# Set colorspace defined in version data
if (
colorspace is not None
and colorspace_exists_on_node(node, str(colorspace))
):
node["colorspace"].setValue(str(colorspace))
output_color = str(colorspace)
elif iio_colorspace is not None:
node["colorspace"].setValue(iio_colorspace)
output_color = iio_colorspace
return output_color
return (
new_parsed_colorspace
or old_parsed_colorspace
or colorspace
)