From 1428963e5f42810b8bf33a3d3fba0c105e0e42ca Mon Sep 17 00:00:00 2001 From: karimmozilla Date: Wed, 6 Oct 2021 13:31:33 +0200 Subject: [PATCH 1/5] crop to reformat --- openpype/hosts/nuke/api/lib.py | 4 ++-- openpype/hosts/nuke/plugins/create/create_write_render.py | 6 +++--- .../nuke/plugins/publish/validate_output_resolution.py | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/openpype/hosts/nuke/api/lib.py b/openpype/hosts/nuke/api/lib.py index ab4c992719..87bf137d93 100644 --- a/openpype/hosts/nuke/api/lib.py +++ b/openpype/hosts/nuke/api/lib.py @@ -1031,7 +1031,7 @@ class WorkfileSettings(object): log.error(msg) nuke.message(msg) - bbox = self._asset_entity.get('data', {}).get('crop') + bbox = self._asset_entity.get('data', {}).get('reformat') if bbox: try: @@ -1046,7 +1046,7 @@ class WorkfileSettings(object): ) except Exception as e: bbox = None - msg = ("{}:{} \nFormat:Crop need to be set with dots, " + msg = ("{}:{} \nFormat:Reformat need to be set with dots, " "example: 0.0.1920.1080, " "/nSetting to default").format(__name__, e) log.error(msg) diff --git a/openpype/hosts/nuke/plugins/create/create_write_render.py b/openpype/hosts/nuke/plugins/create/create_write_render.py index a1381122ee..3a68ce4035 100644 --- a/openpype/hosts/nuke/plugins/create/create_write_render.py +++ b/openpype/hosts/nuke/plugins/create/create_write_render.py @@ -99,7 +99,7 @@ class CreateWriteRender(plugin.PypeCreator): "fpath_template": ("{work}/renders/nuke/{subset}" "/{subset}.{frame}.{ext}")}) - # add crop node to cut off all outside of format bounding box + # add reformat node to cut off all outside of format bounding box # get width and height try: width, height = (selected_node.width(), selected_node.height()) @@ -109,8 +109,8 @@ class CreateWriteRender(plugin.PypeCreator): _prenodes = [ { - "name": "Crop01", - "class": "Crop", + "name": "Reformat01", + "class": "Reformat", "knobs": [ ("box", [ 0.0, diff --git a/openpype/hosts/nuke/plugins/publish/validate_output_resolution.py b/openpype/hosts/nuke/plugins/publish/validate_output_resolution.py index 2563ee929f..27094b8d74 100644 --- a/openpype/hosts/nuke/plugins/publish/validate_output_resolution.py +++ b/openpype/hosts/nuke/plugins/publish/validate_output_resolution.py @@ -56,8 +56,8 @@ class ValidateOutputResolution(pyblish.api.InstancePlugin): def process(self, instance): - # Skip bounding box check if a crop node exists. - if instance[0].dependencies()[0].Class() == "Crop": + # Skip bounding box check if a reformat node exists. + if instance[0].dependencies()[0].Class() == "Reformat": return msg = "Bounding box is outside the format." From cb4dc83fd84aebe87a3dd863556d0a790d7d8bdf Mon Sep 17 00:00:00 2001 From: karimmozilla Date: Wed, 6 Oct 2021 13:49:59 +0200 Subject: [PATCH 2/5] reformat knobs --- .../hosts/nuke/plugins/create/create_write_render.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/openpype/hosts/nuke/plugins/create/create_write_render.py b/openpype/hosts/nuke/plugins/create/create_write_render.py index 3a68ce4035..acc1ee53ff 100644 --- a/openpype/hosts/nuke/plugins/create/create_write_render.py +++ b/openpype/hosts/nuke/plugins/create/create_write_render.py @@ -112,12 +112,10 @@ class CreateWriteRender(plugin.PypeCreator): "name": "Reformat01", "class": "Reformat", "knobs": [ - ("box", [ - 0.0, - 0.0, - width, - height - ]) + ("type", 1), + ("box_fixed", 1), + ("box_width", width), + ("box_height", height) ], "dependent": None } From 296b7305072032dd20e76a41d63b67dbf52494bb Mon Sep 17 00:00:00 2001 From: karimmozlia Date: Fri, 15 Oct 2021 15:26:17 +0200 Subject: [PATCH 3/5] Root.format instead of data.width --- openpype/hosts/nuke/api/lib.py | 21 ------------------- .../plugins/create/create_write_render.py | 6 ++---- 2 files changed, 2 insertions(+), 25 deletions(-) diff --git a/openpype/hosts/nuke/api/lib.py b/openpype/hosts/nuke/api/lib.py index 87bf137d93..eb4eab2b22 100644 --- a/openpype/hosts/nuke/api/lib.py +++ b/openpype/hosts/nuke/api/lib.py @@ -1031,27 +1031,6 @@ class WorkfileSettings(object): log.error(msg) nuke.message(msg) - bbox = self._asset_entity.get('data', {}).get('reformat') - - if bbox: - try: - x, y, r, t = bbox.split(".") - data.update( - { - "x": int(x), - "y": int(y), - "r": int(r), - "t": int(t), - } - ) - except Exception as e: - bbox = None - msg = ("{}:{} \nFormat:Reformat need to be set with dots, " - "example: 0.0.1920.1080, " - "/nSetting to default").format(__name__, e) - log.error(msg) - nuke.message(msg) - existing_format = None for format in nuke.formats(): if data["name"] == format.name(): diff --git a/openpype/hosts/nuke/plugins/create/create_write_render.py b/openpype/hosts/nuke/plugins/create/create_write_render.py index acc1ee53ff..5f13fddf4e 100644 --- a/openpype/hosts/nuke/plugins/create/create_write_render.py +++ b/openpype/hosts/nuke/plugins/create/create_write_render.py @@ -112,10 +112,8 @@ class CreateWriteRender(plugin.PypeCreator): "name": "Reformat01", "class": "Reformat", "knobs": [ - ("type", 1), - ("box_fixed", 1), - ("box_width", width), - ("box_height", height) + ("resize", 0), + ("black_outside", 1), ], "dependent": None } From 835a89e82a99cb6c8a313c93ec3c403e0081bd3c Mon Sep 17 00:00:00 2001 From: karimmozlia Date: Fri, 15 Oct 2021 16:03:14 +0200 Subject: [PATCH 4/5] del bbox --- openpype/hosts/nuke/api/lib.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/openpype/hosts/nuke/api/lib.py b/openpype/hosts/nuke/api/lib.py index eb4eab2b22..6e46747d85 100644 --- a/openpype/hosts/nuke/api/lib.py +++ b/openpype/hosts/nuke/api/lib.py @@ -1042,12 +1042,6 @@ class WorkfileSettings(object): existing_format.setWidth(data["width"]) existing_format.setHeight(data["height"]) existing_format.setPixelAspect(data["pixel_aspect"]) - - if bbox: - existing_format.setX(data["x"]) - existing_format.setY(data["y"]) - existing_format.setR(data["r"]) - existing_format.setT(data["t"]) else: format_string = self.make_format_string(**data) log.info("Creating new format: {}".format(format_string)) From 9ed805f1a652db2feee2554ba4d31e2f63c36695 Mon Sep 17 00:00:00 2001 From: karimmozlia Date: Tue, 19 Oct 2021 12:24:50 +0200 Subject: [PATCH 5/5] update --- openpype/hosts/nuke/api/lib.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/openpype/hosts/nuke/api/lib.py b/openpype/hosts/nuke/api/lib.py index eb4eab2b22..6e46747d85 100644 --- a/openpype/hosts/nuke/api/lib.py +++ b/openpype/hosts/nuke/api/lib.py @@ -1042,12 +1042,6 @@ class WorkfileSettings(object): existing_format.setWidth(data["width"]) existing_format.setHeight(data["height"]) existing_format.setPixelAspect(data["pixel_aspect"]) - - if bbox: - existing_format.setX(data["x"]) - existing_format.setY(data["y"]) - existing_format.setR(data["r"]) - existing_format.setT(data["t"]) else: format_string = self.make_format_string(**data) log.info("Creating new format: {}".format(format_string))