From c4854be5c090cf63f2044fc81b8a7e33ee8c642d Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 10 Aug 2022 18:48:54 +0200
Subject: [PATCH 001/147] OP-3682 - extracted sha256 method to lib

---
 openpype/client/addon_distribution.py | 149 ++++++++++++++++++++++++++
 openpype/lib/path_tools.py            |  20 ++++
 openpype/tools/repack_version.py      |  24 +----
 3 files changed, 172 insertions(+), 21 deletions(-)
 create mode 100644 openpype/client/addon_distribution.py

diff --git a/openpype/client/addon_distribution.py b/openpype/client/addon_distribution.py
new file mode 100644
index 0000000000..3246c5bb72
--- /dev/null
+++ b/openpype/client/addon_distribution.py
@@ -0,0 +1,149 @@
+import os
+from enum import Enum
+from zipfile import ZipFile
+from abc import abstractmethod
+
+import attr
+
+from openpype.lib.path_tools import sha256sum
+from openpype.lib import PypeLogger
+
+log = PypeLogger().get_logger(__name__)
+
+
+class UrlType(Enum):
+    HTTP = {}
+    GIT = {}
+    OS = {}
+
+
+@attr.s
+class AddonInfo(object):
+    """Object matching json payload from Server"""
+    name = attr.ib(default=None)
+    version = attr.ib(default=None)
+    addon_url = attr.ib(default=None)
+    type = attr.ib(default=None)
+    hash = attr.ib(default=None)
+
+
+class AddonDownloader:
+
+    def __init__(self):
+        self._downloaders = {}
+
+    def register_format(self, downloader_type, downloader):
+        self._downloaders[downloader_type] = downloader
+
+    def get_downloader(self, downloader_type):
+        downloader = self._downloaders.get(downloader_type)
+        if not downloader:
+            raise ValueError(f"{downloader_type} not implemented")
+        return downloader()
+
+    @classmethod
+    @abstractmethod
+    def download(cls, addon_url, destination):
+        """Returns url to downloaded addon zip file.
+
+        Args:
+            addon_url (str): http or OS or any supported protocol url to addon
+                zip file
+            destination (str): local folder to unzip
+        Retursn:
+            (str) local path to addon zip file
+        """
+        pass
+
+    @classmethod
+    def check_hash(cls, addon_path, addon_hash):
+        """Compares 'hash' of downloaded 'addon_url' file.
+
+        Args:
+            addon_path (str): local path to addon zip file
+            addon_hash (str): sha256 hash of zip file
+        Raises:
+            ValueError if hashes doesn't match
+        """
+        if addon_hash != sha256sum(addon_path):
+            raise ValueError(
+                "{} doesn't match expected hash".format(addon_path))
+
+    @classmethod
+    def unzip(cls, addon_path, destination):
+        """Unzips local 'addon_path' to 'destination'.
+
+        Args:
+            addon_path (str): local path to addon zip file
+            destination (str): local folder to unzip
+        """
+        addon_file_name = os.path.basename(addon_path)
+        addon_base_file_name, _ = os.path.splitext(addon_file_name)
+        with ZipFile(addon_path, "r") as zip_ref:
+            log.debug(f"Unzipping {addon_path} to {destination}.")
+            zip_ref.extractall(
+                os.path.join(destination, addon_base_file_name))
+
+    @classmethod
+    def remove(cls, addon_url):
+        pass
+
+
+class OSAddonDownloader(AddonDownloader):
+
+    @classmethod
+    def download(cls, addon_url, destination):
+        # OS doesnt need to download, unzip directly
+        if not os.path.exists(addon_url):
+            raise ValueError("{} is not accessible".format(addon_url))
+        return addon_url
+
+
+def get_addons_info():
+    """Returns list of addon information from Server"""
+    # TODO temp
+    addon_info = AddonInfo(
+        **{"name": "openpype_slack",
+           "version": "1.0.0",
+           "addon_url": "c:/projects/openpype_slack_1.0.0.zip",
+           "type": UrlType.OS,
+           "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"})  # noqa
+
+    return [addon_info]
+
+
+def update_addon_state(addon_infos, destination_folder, factory):
+    """Loops through all 'addon_infos', compares local version, unzips.
+
+    Loops through server provided list of dictionaries with information about
+    available addons. Looks if each addon is already present and deployed.
+    If isn't, addon zip gets downloaded and unzipped into 'destination_folder'.
+    Args:
+        addon_infos (list of AddonInfo)
+        destination_folder (str): local path
+        factory (AddonDownloader): factory to get appropriate downloader per
+            addon type
+    """
+    for addon in addon_infos:
+        full_name = "{}_{}".format(addon.name, addon.version)
+        addon_url = os.path.join(destination_folder, full_name)
+
+        if os.path.isdir(addon_url):
+            log.debug(f"Addon version folder {addon_url} already exists.")
+            continue
+
+        downloader = factory.get_downloader(addon.type)
+        downloader.download(addon.addon_url, destination_folder)
+
+
+def cli(args):
+    addon_folder = "c:/Users/petrk/AppData/Local/pypeclub/openpype/addons"
+
+    downloader_factory = AddonDownloader()
+    downloader_factory.register_format(UrlType.OS, OSAddonDownloader)
+
+    print(update_addon_state(get_addons_info(), addon_folder,
+                             downloader_factory))
+    print(sha256sum("c:/projects/openpype_slack_1.0.0.zip"))
+
+
diff --git a/openpype/lib/path_tools.py b/openpype/lib/path_tools.py
index 4f28be3302..2083dc48d1 100644
--- a/openpype/lib/path_tools.py
+++ b/openpype/lib/path_tools.py
@@ -5,6 +5,7 @@ import json
 import logging
 import six
 import platform
+import hashlib
 
 from openpype.client import get_project
 from openpype.settings import get_project_settings
@@ -478,3 +479,22 @@ class HostDirmap:
 
             log.debug("local sync mapping:: {}".format(mapping))
         return mapping
+
+
+def sha256sum(filename):
+    """Calculate sha256 for content of the file.
+
+    Args:
+         filename (str): Path to file.
+
+    Returns:
+        str: hex encoded sha256
+
+    """
+    h = hashlib.sha256()
+    b = bytearray(128 * 1024)
+    mv = memoryview(b)
+    with open(filename, 'rb', buffering=0) as f:
+        for n in iter(lambda: f.readinto(mv), 0):
+            h.update(mv[:n])
+    return h.hexdigest()
\ No newline at end of file
diff --git a/openpype/tools/repack_version.py b/openpype/tools/repack_version.py
index 0172264c79..414152970a 100644
--- a/openpype/tools/repack_version.py
+++ b/openpype/tools/repack_version.py
@@ -7,10 +7,11 @@ from pathlib import Path
 import platform
 from zipfile import ZipFile
 from typing import List
-import hashlib
 import sys
 from igniter.bootstrap_repos import OpenPypeVersion
 
+from openpype.lib.path_tools import sha256sum
+
 
 class VersionRepacker:
 
@@ -45,25 +46,6 @@ class VersionRepacker:
 
         print("{}{}".format(header, msg))
 
-    @staticmethod
-    def sha256sum(filename):
-        """Calculate sha256 for content of the file.
-
-        Args:
-             filename (str): Path to file.
-
-        Returns:
-            str: hex encoded sha256
-
-        """
-        h = hashlib.sha256()
-        b = bytearray(128 * 1024)
-        mv = memoryview(b)
-        with open(filename, 'rb', buffering=0) as f:
-            for n in iter(lambda: f.readinto(mv), 0):
-                h.update(mv[:n])
-        return h.hexdigest()
-
     @staticmethod
     def _filter_dir(path: Path, path_filter: List) -> List[Path]:
         """Recursively crawl over path and filter."""
@@ -104,7 +86,7 @@ class VersionRepacker:
             nits="%", color="green")
         for file in file_list:
             checksums.append((
-                VersionRepacker.sha256sum(file.as_posix()),
+                sha256sum(file.as_posix()),
                 file.resolve().relative_to(self.version_path),
                 file
             ))

From 66b280796e30ad89bfc5ef2e43f3f1b677d64a4f Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 10 Aug 2022 18:49:24 +0200
Subject: [PATCH 002/147] OP-3682 - implemented local disk downloader

---
 openpype/client/addon_distribution.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/openpype/client/addon_distribution.py b/openpype/client/addon_distribution.py
index 3246c5bb72..8fe9567688 100644
--- a/openpype/client/addon_distribution.py
+++ b/openpype/client/addon_distribution.py
@@ -144,6 +144,5 @@ def cli(args):
 
     print(update_addon_state(get_addons_info(), addon_folder,
                              downloader_factory))
-    print(sha256sum("c:/projects/openpype_slack_1.0.0.zip"))
 
 

From 159052f8f9555ec1706d2c565b74133c785096ec Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 11:24:41 +0200
Subject: [PATCH 003/147] OP-3682 - Hound

---
 openpype/lib/path_tools.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/lib/path_tools.py b/openpype/lib/path_tools.py
index 2083dc48d1..0ae5e44d79 100644
--- a/openpype/lib/path_tools.py
+++ b/openpype/lib/path_tools.py
@@ -497,4 +497,4 @@ def sha256sum(filename):
     with open(filename, 'rb', buffering=0) as f:
         for n in iter(lambda: f.readinto(mv), 0):
             h.update(mv[:n])
-    return h.hexdigest()
\ No newline at end of file
+    return h.hexdigest()

From 27125a1088786f004404302485b750fa1594462d Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 12:02:55 +0200
Subject: [PATCH 004/147] OP-3682 - extract file_handler from tests

Addon distribution could use already implemented methods for dowloading from HTTP (GDrive urls).
---
 {tests => openpype}/lib/file_handler.py | 0
 tests/lib/testing_classes.py            | 2 +-
 2 files changed, 1 insertion(+), 1 deletion(-)
 rename {tests => openpype}/lib/file_handler.py (100%)

diff --git a/tests/lib/file_handler.py b/openpype/lib/file_handler.py
similarity index 100%
rename from tests/lib/file_handler.py
rename to openpype/lib/file_handler.py
diff --git a/tests/lib/testing_classes.py b/tests/lib/testing_classes.py
index 2b4d7deb48..75f859de48 100644
--- a/tests/lib/testing_classes.py
+++ b/tests/lib/testing_classes.py
@@ -10,7 +10,7 @@ import glob
 import platform
 
 from tests.lib.db_handler import DBHandler
-from tests.lib.file_handler import RemoteFileHandler
+from openpype.lib.file_handler import RemoteFileHandler
 
 from openpype.lib.remote_publish import find_variant_key
 

From 66899d9dd9b50c6bd9285d191fd1da116ab03f4f Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 13:04:13 +0200
Subject: [PATCH 005/147] OP-3682 - implemented download from HTTP

Handles shared links from GDrive.
---
 openpype/client/addon_distribution.py | 59 ++++++++++++++++++---------
 1 file changed, 40 insertions(+), 19 deletions(-)

diff --git a/openpype/client/addon_distribution.py b/openpype/client/addon_distribution.py
index 8fe9567688..de84c7301a 100644
--- a/openpype/client/addon_distribution.py
+++ b/openpype/client/addon_distribution.py
@@ -7,14 +7,15 @@ import attr
 
 from openpype.lib.path_tools import sha256sum
 from openpype.lib import PypeLogger
+from openpype.lib.file_handler import RemoteFileHandler
 
 log = PypeLogger().get_logger(__name__)
 
 
 class UrlType(Enum):
-    HTTP = {}
-    GIT = {}
-    OS = {}
+    HTTP = "http"
+    GIT = "git"
+    OS = "os"
 
 
 @attr.s
@@ -70,19 +71,15 @@ class AddonDownloader:
                 "{} doesn't match expected hash".format(addon_path))
 
     @classmethod
-    def unzip(cls, addon_path, destination):
-        """Unzips local 'addon_path' to 'destination'.
+    def unzip(cls, addon_zip_path, destination):
+        """Unzips local 'addon_zip_path' to 'destination'.
 
         Args:
-            addon_path (str): local path to addon zip file
+            addon_zip_path (str): local path to addon zip file
             destination (str): local folder to unzip
         """
-        addon_file_name = os.path.basename(addon_path)
-        addon_base_file_name, _ = os.path.splitext(addon_file_name)
-        with ZipFile(addon_path, "r") as zip_ref:
-            log.debug(f"Unzipping {addon_path} to {destination}.")
-            zip_ref.extractall(
-                os.path.join(destination, addon_base_file_name))
+        RemoteFileHandler.unzip(addon_zip_path, destination)
+        os.remove(addon_zip_path)
 
     @classmethod
     def remove(cls, addon_url):
@@ -99,6 +96,23 @@ class OSAddonDownloader(AddonDownloader):
         return addon_url
 
 
+class HTTPAddonDownloader(AddonDownloader):
+    CHUNK_SIZE = 100000
+
+    @classmethod
+    def download(cls, addon_url, destination):
+        log.debug(f"Downloading {addon_url} to {destination}")
+        file_name = os.path.basename(destination)
+        _, ext = os.path.splitext(file_name)
+        if (ext.replace(".", '') not
+                in set(RemoteFileHandler.IMPLEMENTED_ZIP_FORMATS)):
+            file_name += ".zip"
+        RemoteFileHandler.download_url(addon_url,
+                                       destination,
+                                       filename=file_name)
+
+        return os.path.join(destination, file_name)
+
 def get_addons_info():
     """Returns list of addon information from Server"""
     # TODO temp
@@ -109,7 +123,14 @@ def get_addons_info():
            "type": UrlType.OS,
            "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"})  # noqa
 
-    return [addon_info]
+    http_addon = AddonInfo(
+        **{"name": "openpype_slack",
+           "version": "1.0.0",
+           "addon_url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing",  # noqa
+           "type": UrlType.HTTP,
+           "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"})  # noqa
+
+    return [http_addon]
 
 
 def update_addon_state(addon_infos, destination_folder, factory):
@@ -126,14 +147,15 @@ def update_addon_state(addon_infos, destination_folder, factory):
     """
     for addon in addon_infos:
         full_name = "{}_{}".format(addon.name, addon.version)
-        addon_url = os.path.join(destination_folder, full_name)
+        addon_dest = os.path.join(destination_folder, full_name)
 
-        if os.path.isdir(addon_url):
-            log.debug(f"Addon version folder {addon_url} already exists.")
+        if os.path.isdir(addon_dest):
+            log.debug(f"Addon version folder {addon_dest} already exists.")
             continue
 
         downloader = factory.get_downloader(addon.type)
-        downloader.download(addon.addon_url, destination_folder)
+        zip_file_path = downloader.download(addon.addon_url, addon_dest)
+        downloader.unzip(zip_file_path, addon_dest)
 
 
 def cli(args):
@@ -141,8 +163,7 @@ def cli(args):
 
     downloader_factory = AddonDownloader()
     downloader_factory.register_format(UrlType.OS, OSAddonDownloader)
+    downloader_factory.register_format(UrlType.HTTP, HTTPAddonDownloader)
 
     print(update_addon_state(get_addons_info(), addon_folder,
                              downloader_factory))
-
-

From bc33432a57bf16245f5bbc9ca22f1f26fbea9dd1 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 16:05:56 +0200
Subject: [PATCH 006/147] OP-3682 - updated hash logic

Currently only checking hash of zip file.
---
 openpype/client/addon_distribution.py | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/openpype/client/addon_distribution.py b/openpype/client/addon_distribution.py
index de84c7301a..95c8e7d23f 100644
--- a/openpype/client/addon_distribution.py
+++ b/openpype/client/addon_distribution.py
@@ -1,6 +1,5 @@
 import os
 from enum import Enum
-from zipfile import ZipFile
 from abc import abstractmethod
 
 import attr
@@ -66,9 +65,10 @@ class AddonDownloader:
         Raises:
             ValueError if hashes doesn't match
         """
+        if not os.path.exists(addon_path):
+            raise ValueError(f"{addon_path} doesn't exist.")
         if addon_hash != sha256sum(addon_path):
-            raise ValueError(
-                "{} doesn't match expected hash".format(addon_path))
+            raise ValueError(f"{addon_path} doesn't match expected hash.")
 
     @classmethod
     def unzip(cls, addon_zip_path, destination):
@@ -153,9 +153,14 @@ def update_addon_state(addon_infos, destination_folder, factory):
             log.debug(f"Addon version folder {addon_dest} already exists.")
             continue
 
-        downloader = factory.get_downloader(addon.type)
-        zip_file_path = downloader.download(addon.addon_url, addon_dest)
-        downloader.unzip(zip_file_path, addon_dest)
+        try:
+            downloader = factory.get_downloader(addon.type)
+            zip_file_path = downloader.download(addon.addon_url, addon_dest)
+            downloader.check_hash(zip_file_path, addon.hash)
+            downloader.unzip(zip_file_path, addon_dest)
+        except Exception:
+            log.warning(f"Error happened during updating {addon.name}",
+                        stack_info=True)
 
 
 def cli(args):

From ceeb652699a4dd5a2ceb2ccba15ae84f57684e07 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 16:36:55 +0200
Subject: [PATCH 007/147] OP-3682 - changed logging method

PypeLogger is obsolete
---
 openpype/client/addon_distribution.py | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/openpype/client/addon_distribution.py b/openpype/client/addon_distribution.py
index 95c8e7d23f..46098cfa11 100644
--- a/openpype/client/addon_distribution.py
+++ b/openpype/client/addon_distribution.py
@@ -1,14 +1,11 @@
 import os
 from enum import Enum
 from abc import abstractmethod
-
 import attr
 
 from openpype.lib.path_tools import sha256sum
-from openpype.lib import PypeLogger
 from openpype.lib.file_handler import RemoteFileHandler
-
-log = PypeLogger().get_logger(__name__)
+from openpype.lib import Logger
 
 
 class UrlType(Enum):
@@ -28,6 +25,7 @@ class AddonInfo(object):
 
 
 class AddonDownloader:
+    log = Logger.get_logger(__name__)
 
     def __init__(self):
         self._downloaders = {}
@@ -101,7 +99,7 @@ class HTTPAddonDownloader(AddonDownloader):
 
     @classmethod
     def download(cls, addon_url, destination):
-        log.debug(f"Downloading {addon_url} to {destination}")
+        cls.log.debug(f"Downloading {addon_url} to {destination}")
         file_name = os.path.basename(destination)
         _, ext = os.path.splitext(file_name)
         if (ext.replace(".", '') not
@@ -113,6 +111,7 @@ class HTTPAddonDownloader(AddonDownloader):
 
         return os.path.join(destination, file_name)
 
+
 def get_addons_info():
     """Returns list of addon information from Server"""
     # TODO temp
@@ -145,6 +144,10 @@ def update_addon_state(addon_infos, destination_folder, factory):
         factory (AddonDownloader): factory to get appropriate downloader per
             addon type
     """
+    from openpype.lib import Logger
+
+    log = Logger.get_logger(__name__)
+
     for addon in addon_infos:
         full_name = "{}_{}".format(addon.name, addon.version)
         addon_dest = os.path.join(destination_folder, full_name)

From 542eedb4b299aeab0a6e74a361e72e3961c17bfb Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 17:19:58 +0200
Subject: [PATCH 008/147] OP-3682 - moved file to distribution folder

Needs to be separate from Openpype. Igniter and Openpype (and tests) could import from this if necessary.
---
 {openpype/client => distribution}/addon_distribution.py | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename {openpype/client => distribution}/addon_distribution.py (100%)

diff --git a/openpype/client/addon_distribution.py b/distribution/addon_distribution.py
similarity index 100%
rename from openpype/client/addon_distribution.py
rename to distribution/addon_distribution.py

From cfbc9b00777073b945b1ec25e18c32b89127ed7c Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 17:24:38 +0200
Subject: [PATCH 009/147] OP-3682 - replaced Logger to logging

Shouldn't import anything from Openpype
---
 distribution/addon_distribution.py | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 46098cfa11..b76cd8e3f8 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -2,10 +2,10 @@ import os
 from enum import Enum
 from abc import abstractmethod
 import attr
+import logging
 
 from openpype.lib.path_tools import sha256sum
 from openpype.lib.file_handler import RemoteFileHandler
-from openpype.lib import Logger
 
 
 class UrlType(Enum):
@@ -25,7 +25,7 @@ class AddonInfo(object):
 
 
 class AddonDownloader:
-    log = Logger.get_logger(__name__)
+    log = logging.getLogger(__name__)
 
     def __init__(self):
         self._downloaders = {}
@@ -132,7 +132,8 @@ def get_addons_info():
     return [http_addon]
 
 
-def update_addon_state(addon_infos, destination_folder, factory):
+def update_addon_state(addon_infos, destination_folder, factory,
+                       log=None):
     """Loops through all 'addon_infos', compares local version, unzips.
 
     Loops through server provided list of dictionaries with information about
@@ -143,10 +144,10 @@ def update_addon_state(addon_infos, destination_folder, factory):
         destination_folder (str): local path
         factory (AddonDownloader): factory to get appropriate downloader per
             addon type
+        log (logging.Logger)
     """
-    from openpype.lib import Logger
-
-    log = Logger.get_logger(__name__)
+    if not log:
+        log = logging.getLogger(__name__)
 
     for addon in addon_infos:
         full_name = "{}_{}".format(addon.name, addon.version)

From 98444762cd97da52e62370677762a82b25b850c8 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 17:27:14 +0200
Subject: [PATCH 010/147] OP-3682 - moved file_handler

---
 distribution/addon_distribution.py             | 5 ++---
 {openpype/lib => distribution}/file_handler.py | 2 +-
 tests/lib/testing_classes.py                   | 2 +-
 3 files changed, 4 insertions(+), 5 deletions(-)
 rename {openpype/lib => distribution}/file_handler.py (99%)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index b76cd8e3f8..e29e9bbf9b 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -4,8 +4,7 @@ from abc import abstractmethod
 import attr
 import logging
 
-from openpype.lib.path_tools import sha256sum
-from openpype.lib.file_handler import RemoteFileHandler
+from distribution.file_handler import RemoteFileHandler
 
 
 class UrlType(Enum):
@@ -65,7 +64,7 @@ class AddonDownloader:
         """
         if not os.path.exists(addon_path):
             raise ValueError(f"{addon_path} doesn't exist.")
-        if addon_hash != sha256sum(addon_path):
+        if addon_hash != RemoteFileHandler.calculate_md5(addon_path):
             raise ValueError(f"{addon_path} doesn't match expected hash.")
 
     @classmethod
diff --git a/openpype/lib/file_handler.py b/distribution/file_handler.py
similarity index 99%
rename from openpype/lib/file_handler.py
rename to distribution/file_handler.py
index ee3abc6ecb..8c8b4230ce 100644
--- a/openpype/lib/file_handler.py
+++ b/distribution/file_handler.py
@@ -21,7 +21,7 @@ class RemoteFileHandler:
                                'tar.gz', 'tar.xz', 'tar.bz2']
 
     @staticmethod
-    def calculate_md5(fpath, chunk_size):
+    def calculate_md5(fpath, chunk_size=10000):
         md5 = hashlib.md5()
         with open(fpath, 'rb') as f:
             for chunk in iter(lambda: f.read(chunk_size), b''):
diff --git a/tests/lib/testing_classes.py b/tests/lib/testing_classes.py
index 75f859de48..e819ae80de 100644
--- a/tests/lib/testing_classes.py
+++ b/tests/lib/testing_classes.py
@@ -10,7 +10,7 @@ import glob
 import platform
 
 from tests.lib.db_handler import DBHandler
-from openpype.lib.file_handler import RemoteFileHandler
+from distribution.file_handler import RemoteFileHandler
 
 from openpype.lib.remote_publish import find_variant_key
 

From b0c8a47f0f27a734f8ba9f201ae08dabe5d1271d Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 17:32:22 +0200
Subject: [PATCH 011/147] Revert "OP-3682 - extracted sha256 method to lib"

This reverts commit c4854be5
---
 openpype/lib/path_tools.py       | 19 -------------------
 openpype/tools/repack_version.py | 24 +++++++++++++++++++++---
 2 files changed, 21 insertions(+), 22 deletions(-)

diff --git a/openpype/lib/path_tools.py b/openpype/lib/path_tools.py
index 0ae5e44d79..11648f9969 100644
--- a/openpype/lib/path_tools.py
+++ b/openpype/lib/path_tools.py
@@ -5,7 +5,6 @@ import json
 import logging
 import six
 import platform
-import hashlib
 
 from openpype.client import get_project
 from openpype.settings import get_project_settings
@@ -480,21 +479,3 @@ class HostDirmap:
             log.debug("local sync mapping:: {}".format(mapping))
         return mapping
 
-
-def sha256sum(filename):
-    """Calculate sha256 for content of the file.
-
-    Args:
-         filename (str): Path to file.
-
-    Returns:
-        str: hex encoded sha256
-
-    """
-    h = hashlib.sha256()
-    b = bytearray(128 * 1024)
-    mv = memoryview(b)
-    with open(filename, 'rb', buffering=0) as f:
-        for n in iter(lambda: f.readinto(mv), 0):
-            h.update(mv[:n])
-    return h.hexdigest()
diff --git a/openpype/tools/repack_version.py b/openpype/tools/repack_version.py
index 414152970a..0172264c79 100644
--- a/openpype/tools/repack_version.py
+++ b/openpype/tools/repack_version.py
@@ -7,11 +7,10 @@ from pathlib import Path
 import platform
 from zipfile import ZipFile
 from typing import List
+import hashlib
 import sys
 from igniter.bootstrap_repos import OpenPypeVersion
 
-from openpype.lib.path_tools import sha256sum
-
 
 class VersionRepacker:
 
@@ -46,6 +45,25 @@ class VersionRepacker:
 
         print("{}{}".format(header, msg))
 
+    @staticmethod
+    def sha256sum(filename):
+        """Calculate sha256 for content of the file.
+
+        Args:
+             filename (str): Path to file.
+
+        Returns:
+            str: hex encoded sha256
+
+        """
+        h = hashlib.sha256()
+        b = bytearray(128 * 1024)
+        mv = memoryview(b)
+        with open(filename, 'rb', buffering=0) as f:
+            for n in iter(lambda: f.readinto(mv), 0):
+                h.update(mv[:n])
+        return h.hexdigest()
+
     @staticmethod
     def _filter_dir(path: Path, path_filter: List) -> List[Path]:
         """Recursively crawl over path and filter."""
@@ -86,7 +104,7 @@ class VersionRepacker:
             nits="%", color="green")
         for file in file_list:
             checksums.append((
-                sha256sum(file.as_posix()),
+                VersionRepacker.sha256sum(file.as_posix()),
                 file.resolve().relative_to(self.version_path),
                 file
             ))

From 0fb8988522a328afa33cc08960a8a2a678e2b26c Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 11 Aug 2022 17:35:12 +0200
Subject: [PATCH 012/147] OP-3682 - Hound

---
 openpype/lib/path_tools.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/openpype/lib/path_tools.py b/openpype/lib/path_tools.py
index 11648f9969..4f28be3302 100644
--- a/openpype/lib/path_tools.py
+++ b/openpype/lib/path_tools.py
@@ -478,4 +478,3 @@ class HostDirmap:
 
             log.debug("local sync mapping:: {}".format(mapping))
         return mapping
-

From 5f0a8d700e5fc72570b70e56240b488819da3d43 Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Fri, 12 Aug 2022 11:22:10 +0200
Subject: [PATCH 013/147] Maya Redshift: Skip aov file format check for
 Cryptomatte

---
 .../plugins/publish/validate_rendersettings.py    | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
index 1dab3274a0..feb6a16dac 100644
--- a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
+++ b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
@@ -180,14 +180,17 @@ class ValidateRenderSettings(pyblish.api.InstancePlugin):
                         redshift_AOV_prefix
                     ))
                     invalid = True
-                # get aov format
-                aov_ext = cmds.getAttr(
-                    "{}.fileFormat".format(aov), asString=True)
 
-                default_ext = cmds.getAttr(
-                    "redshiftOptions.imageFormat", asString=True)
+                # check aov file format
+                aov_ext = cmds.getAttr("{}.fileFormat".format(aov))
+                default_ext = cmds.getAttr("redshiftOptions.imageFormat")
+                aov_type = cmds.getAttr("{}.aovType".format(aov))
+                if aov_type == "Cryptomatte":
+                    # redshift Cryptomatte AOV always uses "Cryptomatte (EXR)"
+                    # so we ignore validating file format for it.
+                    pass
 
-                if default_ext != aov_ext:
+                elif default_ext != aov_ext:
                     cls.log.error(("AOV file format is not the same "
                                    "as the one set globally "
                                    "{} != {}").format(default_ext,

From 3252c732e1c41460016bc8a17ab01ea5ade34f60 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Fri, 12 Aug 2022 18:28:14 +0200
Subject: [PATCH 014/147] OP-3682 - added more fields to metadata

Additional fields could be useful in the future for some addon Store or pulling information into customer's internal CRM.
---
 distribution/addon_distribution.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index e29e9bbf9b..465950f6e8 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -3,6 +3,7 @@ from enum import Enum
 from abc import abstractmethod
 import attr
 import logging
+import requests
 
 from distribution.file_handler import RemoteFileHandler
 
@@ -21,6 +22,9 @@ class AddonInfo(object):
     addon_url = attr.ib(default=None)
     type = attr.ib(default=None)
     hash = attr.ib(default=None)
+    description = attr.ib(default=None)
+    license = attr.ib(default=None)
+    authors = attr.ib(default=None)
 
 
 class AddonDownloader:

From 6187cf18f50c43ca60f234bce439a4dc466263cf Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Fri, 12 Aug 2022 19:08:30 +0200
Subject: [PATCH 015/147] OP-3682 - implemented basic GET

Used publish Postman mock server for testing
---
 distribution/addon_distribution.py | 59 ++++++++++++++++++++----------
 1 file changed, 40 insertions(+), 19 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 465950f6e8..86b6de3a74 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -34,7 +34,7 @@ class AddonDownloader:
         self._downloaders = {}
 
     def register_format(self, downloader_type, downloader):
-        self._downloaders[downloader_type] = downloader
+        self._downloaders[downloader_type.value] = downloader
 
     def get_downloader(self, downloader_type):
         downloader = self._downloaders.get(downloader_type)
@@ -115,24 +115,31 @@ class HTTPAddonDownloader(AddonDownloader):
         return os.path.join(destination, file_name)
 
 
-def get_addons_info():
+def get_addons_info(server_endpoint):
     """Returns list of addon information from Server"""
     # TODO temp
-    addon_info = AddonInfo(
-        **{"name": "openpype_slack",
-           "version": "1.0.0",
-           "addon_url": "c:/projects/openpype_slack_1.0.0.zip",
-           "type": UrlType.OS,
-           "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"})  # noqa
+    # addon_info = AddonInfo(
+    #     **{"name": "openpype_slack",
+    #        "version": "1.0.0",
+    #        "addon_url": "c:/projects/openpype_slack_1.0.0.zip",
+    #        "type": UrlType.OS,
+    #        "hash": "4f6b8568eb9dd6f510fd7c4dcb676788"})  # noqa
+    #
+    # http_addon = AddonInfo(
+    #     **{"name": "openpype_slack",
+    #        "version": "1.0.0",
+    #        "addon_url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing",  # noqa
+    #        "type": UrlType.HTTP,
+    #        "hash": "4f6b8568eb9dd6f510fd7c4dcb676788"})  # noqa
 
-    http_addon = AddonInfo(
-        **{"name": "openpype_slack",
-           "version": "1.0.0",
-           "addon_url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing",  # noqa
-           "type": UrlType.HTTP,
-           "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"})  # noqa
+    response = requests.get(server_endpoint)
+    if not response.ok:
+        raise Exception(response.text)
 
-    return [http_addon]
+    addons_info = []
+    for addon in response.json():
+        addons_info.append(AddonInfo(**addon))
+    return addons_info
 
 
 def update_addon_state(addon_infos, destination_folder, factory,
@@ -167,15 +174,29 @@ def update_addon_state(addon_infos, destination_folder, factory,
             downloader.unzip(zip_file_path, addon_dest)
         except Exception:
             log.warning(f"Error happened during updating {addon.name}",
-                        stack_info=True)
+                        exc_info=True)
+
+
+def check_addons(server_endpoint, addon_folder, downloaders):
+    """Main entry point to compare existing addons with those on server."""
+    addons_info = get_addons_info(server_endpoint)
+    update_addon_state(addons_info,
+                       addon_folder,
+                       downloaders)
 
 
 def cli(args):
-    addon_folder = "c:/Users/petrk/AppData/Local/pypeclub/openpype/addons"
+    addon_folder = "c:/projects/testing_addons/pypeclub/openpype/addons"
 
     downloader_factory = AddonDownloader()
     downloader_factory.register_format(UrlType.OS, OSAddonDownloader)
     downloader_factory.register_format(UrlType.HTTP, HTTPAddonDownloader)
 
-    print(update_addon_state(get_addons_info(), addon_folder,
-                             downloader_factory))
+    test_endpoint = "https://34e99f0f-f987-4715-95e6-d2d88caa7586.mock.pstmn.io/get_addons_info"  # noqa
+    if os.environ.get("OPENPYPE_SERVER"):  # TODO or from keychain
+        server_endpoint = os.environ.get("OPENPYPE_SERVER") + "get_addons_info"
+    else:
+        server_endpoint = test_endpoint
+
+    check_addons(server_endpoint, addon_folder, downloader_factory)
+

From 385b6b97f02c2a384e3432fd8f204ee4f6810e18 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Fri, 12 Aug 2022 19:09:06 +0200
Subject: [PATCH 016/147] OP-3682 - Hound

---
 distribution/addon_distribution.py | 1 -
 1 file changed, 1 deletion(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 86b6de3a74..a0c48923df 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -199,4 +199,3 @@ def cli(args):
         server_endpoint = test_endpoint
 
     check_addons(server_endpoint, addon_folder, downloader_factory)
-

From 538513304e9b3ebcd433765881a620a0e00bc48c Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Tue, 16 Aug 2022 13:20:25 +0200
Subject: [PATCH 017/147] OP-3682 - refactored OS to FILESYSTEM

---
 distribution/addon_distribution.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index a0c48923df..3cc2374b93 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -11,7 +11,7 @@ from distribution.file_handler import RemoteFileHandler
 class UrlType(Enum):
     HTTP = "http"
     GIT = "git"
-    OS = "os"
+    FILESYSTEM = "filesystem"
 
 
 @attr.s
@@ -122,7 +122,7 @@ def get_addons_info(server_endpoint):
     #     **{"name": "openpype_slack",
     #        "version": "1.0.0",
     #        "addon_url": "c:/projects/openpype_slack_1.0.0.zip",
-    #        "type": UrlType.OS,
+    #        "type": UrlType.FILESYSTEM,
     #        "hash": "4f6b8568eb9dd6f510fd7c4dcb676788"})  # noqa
     #
     # http_addon = AddonInfo(
@@ -189,7 +189,7 @@ def cli(args):
     addon_folder = "c:/projects/testing_addons/pypeclub/openpype/addons"
 
     downloader_factory = AddonDownloader()
-    downloader_factory.register_format(UrlType.OS, OSAddonDownloader)
+    downloader_factory.register_format(UrlType.FILESYSTEM, OSAddonDownloader)
     downloader_factory.register_format(UrlType.HTTP, HTTPAddonDownloader)
 
     test_endpoint = "https://34e99f0f-f987-4715-95e6-d2d88caa7586.mock.pstmn.io/get_addons_info"  # noqa

From 1615f74af3e8daddb8c625329f67f0756deb9bc9 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 24 Aug 2022 15:40:02 +0200
Subject: [PATCH 018/147] OP-3214 - updated format of addon info response

When downloading it should go through each source until it succeeds
---
 distribution/addon_distribution.py | 37 +++++++++++++++++++++---------
 1 file changed, 26 insertions(+), 11 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 3cc2374b93..2efbb34274 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -4,6 +4,7 @@ from abc import abstractmethod
 import attr
 import logging
 import requests
+import platform
 
 from distribution.file_handler import RemoteFileHandler
 
@@ -14,13 +15,26 @@ class UrlType(Enum):
     FILESYSTEM = "filesystem"
 
 
+@attr.s
+class MultiPlatformPath(object):
+    windows = attr.ib(default=None)
+    linux = attr.ib(default=None)
+    darwin = attr.ib(default=None)
+
+
+@attr.s
+class AddonSource(object):
+    type = attr.ib()
+    url = attr.ib(default=None)
+    path = attr.ib(default=attr.Factory(MultiPlatformPath))
+
+
 @attr.s
 class AddonInfo(object):
     """Object matching json payload from Server"""
-    name = attr.ib(default=None)
-    version = attr.ib(default=None)
-    addon_url = attr.ib(default=None)
-    type = attr.ib(default=None)
+    name = attr.ib()
+    version = attr.ib()
+    sources = attr.ib(default=attr.Factory(list), type=AddonSource)
     hash = attr.ib(default=None)
     description = attr.ib(default=None)
     license = attr.ib(default=None)
@@ -44,12 +58,11 @@ class AddonDownloader:
 
     @classmethod
     @abstractmethod
-    def download(cls, addon_url, destination):
+    def download(cls, source, destination):
         """Returns url to downloaded addon zip file.
 
         Args:
-            addon_url (str): http or OS or any supported protocol url to addon
-                zip file
+            source (dict): {type:"http", "url":"https://} ...}
             destination (str): local folder to unzip
         Retursn:
             (str) local path to addon zip file
@@ -90,8 +103,9 @@ class AddonDownloader:
 class OSAddonDownloader(AddonDownloader):
 
     @classmethod
-    def download(cls, addon_url, destination):
+    def download(cls, source, destination):
         # OS doesnt need to download, unzip directly
+        addon_url = source["path"].get(platform.system().lower())
         if not os.path.exists(addon_url):
             raise ValueError("{} is not accessible".format(addon_url))
         return addon_url
@@ -101,14 +115,15 @@ class HTTPAddonDownloader(AddonDownloader):
     CHUNK_SIZE = 100000
 
     @classmethod
-    def download(cls, addon_url, destination):
-        cls.log.debug(f"Downloading {addon_url} to {destination}")
+    def download(cls, source, destination):
+        source_url = source["url"]
+        cls.log.debug(f"Downloading {source_url} to {destination}")
         file_name = os.path.basename(destination)
         _, ext = os.path.splitext(file_name)
         if (ext.replace(".", '') not
                 in set(RemoteFileHandler.IMPLEMENTED_ZIP_FORMATS)):
             file_name += ".zip"
-        RemoteFileHandler.download_url(addon_url,
+        RemoteFileHandler.download_url(source_url,
                                        destination,
                                        filename=file_name)
 

From 34c15c24292a3ae434b509987acb9b28f8176106 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 24 Aug 2022 15:41:03 +0200
Subject: [PATCH 019/147] OP-3214 - fixed update_addon_state

Should be able to update whatever can.
---
 distribution/addon_distribution.py | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 2efbb34274..f5af0f77ed 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -170,26 +170,36 @@ def update_addon_state(addon_infos, destination_folder, factory,
         factory (AddonDownloader): factory to get appropriate downloader per
             addon type
         log (logging.Logger)
+    Returns:
+        (dict): {"addon_full_name":"exists"|"updated"|"failed"
     """
     if not log:
         log = logging.getLogger(__name__)
 
+    download_states = {}
     for addon in addon_infos:
         full_name = "{}_{}".format(addon.name, addon.version)
         addon_dest = os.path.join(destination_folder, full_name)
 
         if os.path.isdir(addon_dest):
             log.debug(f"Addon version folder {addon_dest} already exists.")
+            download_states[full_name] = "exists"
             continue
 
-        try:
-            downloader = factory.get_downloader(addon.type)
-            zip_file_path = downloader.download(addon.addon_url, addon_dest)
-            downloader.check_hash(zip_file_path, addon.hash)
-            downloader.unzip(zip_file_path, addon_dest)
-        except Exception:
-            log.warning(f"Error happened during updating {addon.name}",
-                        exc_info=True)
+        for source in addon.sources:
+            download_states[full_name] = "failed"
+            try:
+                downloader = factory.get_downloader(source["type"])
+                zip_file_path = downloader.download(source, addon_dest)
+                downloader.check_hash(zip_file_path, addon.hash)
+                downloader.unzip(zip_file_path, addon_dest)
+                download_states[full_name] = "updated"
+                break
+            except Exception:
+                log.warning(f"Error happened during updating {addon.name}",
+                            exc_info=True)
+
+    return download_states
 
 
 def check_addons(server_endpoint, addon_folder, downloaders):

From 437ead97762c861172f19901d0d83d8ea11b7b2b Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 24 Aug 2022 15:54:06 +0200
Subject: [PATCH 020/147] OP-3214 - introduced update state enum

---
 distribution/addon_distribution.py | 33 ++++++++++++++++++++++--------
 1 file changed, 25 insertions(+), 8 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index f5af0f77ed..4ca3f5687a 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -15,6 +15,11 @@ class UrlType(Enum):
     FILESYSTEM = "filesystem"
 
 
+class UpdateState(Enum):
+    EXISTS = "exists"
+    UPDATED = "updated"
+    FAILED = "failed"
+
 @attr.s
 class MultiPlatformPath(object):
     windows = attr.ib(default=None)
@@ -171,7 +176,8 @@ def update_addon_state(addon_infos, destination_folder, factory,
             addon type
         log (logging.Logger)
     Returns:
-        (dict): {"addon_full_name":"exists"|"updated"|"failed"
+        (dict): {"addon_full_name": UpdateState.value
+            (eg. "exists"|"updated"|"failed")
     """
     if not log:
         log = logging.getLogger(__name__)
@@ -183,17 +189,17 @@ def update_addon_state(addon_infos, destination_folder, factory,
 
         if os.path.isdir(addon_dest):
             log.debug(f"Addon version folder {addon_dest} already exists.")
-            download_states[full_name] = "exists"
+            download_states[full_name] = UpdateState.EXISTS.value
             continue
 
         for source in addon.sources:
-            download_states[full_name] = "failed"
+            download_states[full_name] = UpdateState.FAILED.value
             try:
                 downloader = factory.get_downloader(source["type"])
                 zip_file_path = downloader.download(source, addon_dest)
                 downloader.check_hash(zip_file_path, addon.hash)
                 downloader.unzip(zip_file_path, addon_dest)
-                download_states[full_name] = "updated"
+                download_states[full_name] = UpdateState.UPDATED.value
                 break
             except Exception:
                 log.warning(f"Error happened during updating {addon.name}",
@@ -203,11 +209,22 @@ def update_addon_state(addon_infos, destination_folder, factory,
 
 
 def check_addons(server_endpoint, addon_folder, downloaders):
-    """Main entry point to compare existing addons with those on server."""
+    """Main entry point to compare existing addons with those on server.
+
+    Args:
+        server_endpoint (str): url to v4 server endpoint
+        addon_folder (str): local dir path for addons
+        downloaders (AddonDownloader): factory of downloaders
+
+    Raises:
+        (RuntimeError) if any addon failed update
+    """
     addons_info = get_addons_info(server_endpoint)
-    update_addon_state(addons_info,
-                       addon_folder,
-                       downloaders)
+    result = update_addon_state(addons_info,
+                                addon_folder,
+                                downloaders)
+    if UpdateState.FAILED.value in result.values():
+        raise RuntimeError(f"Unable to update some addons {result}")
 
 
 def cli(args):

From 0d495a36834d0e5aec062841c3f3820f68900c0a Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 24 Aug 2022 16:01:37 +0200
Subject: [PATCH 021/147] OP-3214 - added unit tests

---
 distribution/__init__.py                      |   0
 .../tests/test_addon_distributtion.py         | 121 ++++++++++++++++++
 2 files changed, 121 insertions(+)
 create mode 100644 distribution/__init__.py
 create mode 100644 distribution/tests/test_addon_distributtion.py

diff --git a/distribution/__init__.py b/distribution/__init__.py
new file mode 100644
index 0000000000..e69de29bb2
diff --git a/distribution/tests/test_addon_distributtion.py b/distribution/tests/test_addon_distributtion.py
new file mode 100644
index 0000000000..2e81bc4ef9
--- /dev/null
+++ b/distribution/tests/test_addon_distributtion.py
@@ -0,0 +1,121 @@
+import pytest
+import attr
+import tempfile
+
+from distribution.addon_distribution import (
+    AddonDownloader,
+    UrlType,
+    OSAddonDownloader,
+    HTTPAddonDownloader,
+    AddonInfo,
+    update_addon_state,
+    UpdateState
+)
+
+
+@pytest.fixture
+def addon_downloader():
+    addon_downloader = AddonDownloader()
+    addon_downloader.register_format(UrlType.FILESYSTEM, OSAddonDownloader)
+    addon_downloader.register_format(UrlType.HTTP, HTTPAddonDownloader)
+
+    yield addon_downloader
+
+
+@pytest.fixture
+def http_downloader(addon_downloader):
+    yield addon_downloader.get_downloader(UrlType.HTTP.value)
+
+
+@pytest.fixture
+def temp_folder():
+    yield tempfile.mkdtemp()
+
+
+@pytest.fixture
+def sample_addon_info():
+    addon_info = {
+        "name": "openpype_slack",
+        "version": "1.0.0",
+        "sources": [
+            {
+                "type": "http",
+                "url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing"
+            },
+            {
+                "type": "filesystem",
+                "path": {
+                    "windows": ["P:/sources/some_file.zip", "W:/sources/some_file.zip"],
+                    "linux": ["/mnt/srv/sources/some_file.zip"],
+                    "darwin": ["/Volumes/srv/sources/some_file.zip"]
+                }
+            }
+        ],
+        "hash": "4f6b8568eb9dd6f510fd7c4dcb676788"
+    }
+    yield addon_info
+
+
+def test_register(printer):
+    addon_downloader = AddonDownloader()
+
+    assert len(addon_downloader._downloaders) == 0, "Contains registered"
+
+    addon_downloader.register_format(UrlType.FILESYSTEM, OSAddonDownloader)
+    assert len(addon_downloader._downloaders) == 1, "Should contain one"
+
+
+def test_get_downloader(printer, addon_downloader):
+    assert addon_downloader.get_downloader(UrlType.FILESYSTEM.value), "Should find"  # noqa
+
+    with pytest.raises(ValueError):
+        addon_downloader.get_downloader("unknown"), "Shouldn't find"
+
+
+def test_addon_info(printer, sample_addon_info):
+    valid_minimum = {"name": "openpype_slack", "version": "1.0.0"}
+
+    assert AddonInfo(**valid_minimum), "Missing required fields"
+    assert AddonInfo(name=valid_minimum["name"],
+                     version=valid_minimum["version"]), \
+        "Missing required fields"
+
+    with pytest.raises(TypeError):
+        # TODO should be probably implemented
+        assert AddonInfo(valid_minimum), "Wrong argument format"
+
+    addon = AddonInfo(**sample_addon_info)
+    assert addon, "Should be created"
+    assert addon.name == "openpype_slack", "Incorrect name"
+    assert addon.version == "1.0.0", "Incorrect version"
+
+    with pytest.raises(TypeError):
+        assert addon["name"], "Dict approach not implemented"
+
+    addon_as_dict = attr.asdict(addon)
+    assert addon_as_dict["name"], "Dict approach should work"
+
+    with pytest.raises(AttributeError):
+        # TODO should be probably implemented as . not dict
+        first_source = addon.sources[0]
+        assert first_source.type == "http", "Not implemented"
+
+
+def test_update_addon_state(printer, sample_addon_info,
+                            temp_folder, addon_downloader):
+    addon_info = AddonInfo(**sample_addon_info)
+    orig_hash = addon_info.hash
+
+    addon_info.hash = "brokenhash"
+    result = update_addon_state([addon_info], temp_folder, addon_downloader)
+    assert (result["openpype_slack_1.0.0"] == UpdateState.FAILED.value,
+            "Hashes not matching")
+
+    addon_info.hash = orig_hash
+    result = update_addon_state([addon_info], temp_folder, addon_downloader)
+    assert (result["openpype_slack_1.0.0"] == UpdateState.UPDATED.value,
+            "Failed updating")
+
+    result = update_addon_state([addon_info], temp_folder, addon_downloader)
+    assert (result["openpype_slack_1.0.0"] == UpdateState.EXISTS.value,
+            "Tried to update")

From be5dbd6512362c58abb5ec9415414903e8badb20 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 24 Aug 2022 16:03:57 +0200
Subject: [PATCH 022/147] OP-3214 - Hound

---
 distribution/addon_distribution.py             |  1 +
 distribution/tests/test_addon_distributtion.py | 16 ++++++++--------
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 4ca3f5687a..95d0b5e397 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -20,6 +20,7 @@ class UpdateState(Enum):
     UPDATED = "updated"
     FAILED = "failed"
 
+
 @attr.s
 class MultiPlatformPath(object):
     windows = attr.ib(default=None)
diff --git a/distribution/tests/test_addon_distributtion.py b/distribution/tests/test_addon_distributtion.py
index 2e81bc4ef9..e67ca3c479 100644
--- a/distribution/tests/test_addon_distributtion.py
+++ b/distribution/tests/test_addon_distributtion.py
@@ -40,12 +40,12 @@ def sample_addon_info():
         "sources": [
             {
                 "type": "http",
-                "url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing"
+                "url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing"  # noqa
             },
             {
                 "type": "filesystem",
                 "path": {
-                    "windows": ["P:/sources/some_file.zip", "W:/sources/some_file.zip"],
+                    "windows": ["P:/sources/some_file.zip", "W:/sources/some_file.zip"],  # noqa
                     "linux": ["/mnt/srv/sources/some_file.zip"],
                     "darwin": ["/Volumes/srv/sources/some_file.zip"]
                 }
@@ -108,14 +108,14 @@ def test_update_addon_state(printer, sample_addon_info,
 
     addon_info.hash = "brokenhash"
     result = update_addon_state([addon_info], temp_folder, addon_downloader)
-    assert (result["openpype_slack_1.0.0"] == UpdateState.FAILED.value,
-            "Hashes not matching")
+    assert result["openpype_slack_1.0.0"] == UpdateState.FAILED.value, \
+        "Hashes not matching"
 
     addon_info.hash = orig_hash
     result = update_addon_state([addon_info], temp_folder, addon_downloader)
-    assert (result["openpype_slack_1.0.0"] == UpdateState.UPDATED.value,
-            "Failed updating")
+    assert result["openpype_slack_1.0.0"] == UpdateState.UPDATED.value, \
+        "Failed updating"
 
     result = update_addon_state([addon_info], temp_folder, addon_downloader)
-    assert (result["openpype_slack_1.0.0"] == UpdateState.EXISTS.value,
-            "Tried to update")
+    assert result["openpype_slack_1.0.0"] == UpdateState.EXISTS.value, \
+        "Tried to update"

From 390dbb6320f97ba1b05e1de895905b57c62ce1e3 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 25 Aug 2022 14:51:21 +0200
Subject: [PATCH 023/147] OP-3682 - added readme to highlight it is for v4

---
 distribution/README.md | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)
 create mode 100644 distribution/README.md

diff --git a/distribution/README.md b/distribution/README.md
new file mode 100644
index 0000000000..212eb267b8
--- /dev/null
+++ b/distribution/README.md
@@ -0,0 +1,18 @@
+Addon distribution tool
+------------------------
+
+Code in this folder is backend portion of Addon distribution logic for v4 server.
+
+Each host, module will be separate Addon in the future. Each v4 server could run different set of Addons.
+
+Client (running on artist machine) will in the first step ask v4 for list of enabled addons. 
+(It expects list of json documents matching to `addon_distribution.py:AddonInfo` object.)
+Next it will compare presence of enabled addon version in local folder. In the case of missing version of
+an addon, client will use information in the addon to download (from http/shared local disk/git) zip file
+and unzip it.
+
+Required part of addon distribution will be sharing of dependencies (python libraries, utilities) which is not part of this folder.
+
+Location of this folder might change in the future as it will be required for a clint to add this folder to sys.path reliably.
+
+This code needs to be independent on Openpype code as much as possible!
\ No newline at end of file

From 47908465197226814aee76e51e74de7fedc8b01a Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 1 Sep 2022 12:03:27 +0200
Subject: [PATCH 024/147] Use new import source of Extractor

---
 openpype/hosts/harmony/plugins/publish/extract_palette.py  | 4 ++--
 openpype/hosts/harmony/plugins/publish/extract_template.py | 7 +++----
 openpype/hosts/harmony/plugins/publish/extract_workfile.py | 4 ++--
 3 files changed, 7 insertions(+), 8 deletions(-)

diff --git a/openpype/hosts/harmony/plugins/publish/extract_palette.py b/openpype/hosts/harmony/plugins/publish/extract_palette.py
index fae778f6b0..69c6e098ff 100644
--- a/openpype/hosts/harmony/plugins/publish/extract_palette.py
+++ b/openpype/hosts/harmony/plugins/publish/extract_palette.py
@@ -6,10 +6,10 @@ import csv
 from PIL import Image, ImageDraw, ImageFont
 
 import openpype.hosts.harmony.api as harmony
-import openpype.api
+from openpype.pipeline import publish
 
 
-class ExtractPalette(openpype.api.Extractor):
+class ExtractPalette(publish.Extractor):
     """Extract palette."""
 
     label = "Extract Palette"
diff --git a/openpype/hosts/harmony/plugins/publish/extract_template.py b/openpype/hosts/harmony/plugins/publish/extract_template.py
index d25b07bba3..458bf25a3c 100644
--- a/openpype/hosts/harmony/plugins/publish/extract_template.py
+++ b/openpype/hosts/harmony/plugins/publish/extract_template.py
@@ -3,12 +3,11 @@
 import os
 import shutil
 
-import openpype.api
+from openpype.pipeline import publish
 import openpype.hosts.harmony.api as harmony
-import openpype.hosts.harmony
 
 
-class ExtractTemplate(openpype.api.Extractor):
+class ExtractTemplate(publish.Extractor):
     """Extract the connected nodes to the composite instance."""
 
     label = "Extract Template"
@@ -50,7 +49,7 @@ class ExtractTemplate(openpype.api.Extractor):
             dependencies.remove(instance.data["setMembers"][0])
 
         # Export template.
-        openpype.hosts.harmony.api.export_template(
+        harmony.export_template(
             unique_backdrops, dependencies, filepath
         )
 
diff --git a/openpype/hosts/harmony/plugins/publish/extract_workfile.py b/openpype/hosts/harmony/plugins/publish/extract_workfile.py
index 7f25ec8150..9bb3090558 100644
--- a/openpype/hosts/harmony/plugins/publish/extract_workfile.py
+++ b/openpype/hosts/harmony/plugins/publish/extract_workfile.py
@@ -4,10 +4,10 @@ import os
 import shutil
 from zipfile import ZipFile
 
-import openpype.api
+from openpype.pipeline import publish
 
 
-class ExtractWorkfile(openpype.api.Extractor):
+class ExtractWorkfile(publish.Extractor):
     """Extract and zip complete workfile folder into zip."""
 
     label = "Extract Workfile"

From 2fbfe59d966a4a22dc3534be3f5bb97da08a65c6 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 1 Sep 2022 12:09:18 +0200
Subject: [PATCH 025/147] Use new import source of Extractor

---
 openpype/hosts/houdini/plugins/publish/extract_alembic.py    | 5 +++--
 openpype/hosts/houdini/plugins/publish/extract_ass.py        | 5 +++--
 openpype/hosts/houdini/plugins/publish/extract_composite.py  | 4 ++--
 openpype/hosts/houdini/plugins/publish/extract_hda.py        | 5 +++--
 .../hosts/houdini/plugins/publish/extract_redshift_proxy.py  | 5 +++--
 openpype/hosts/houdini/plugins/publish/extract_usd.py        | 5 +++--
 .../hosts/houdini/plugins/publish/extract_usd_layered.py     | 4 ++--
 openpype/hosts/houdini/plugins/publish/extract_vdb_cache.py  | 5 +++--
 8 files changed, 22 insertions(+), 16 deletions(-)

diff --git a/openpype/hosts/houdini/plugins/publish/extract_alembic.py b/openpype/hosts/houdini/plugins/publish/extract_alembic.py
index 83b790407f..758d4c560b 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_alembic.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_alembic.py
@@ -1,11 +1,12 @@
 import os
 
 import pyblish.api
-import openpype.api
+
+from openpype.pipeline import publish
 from openpype.hosts.houdini.api.lib import render_rop
 
 
-class ExtractAlembic(openpype.api.Extractor):
+class ExtractAlembic(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder
     label = "Extract Alembic"
diff --git a/openpype/hosts/houdini/plugins/publish/extract_ass.py b/openpype/hosts/houdini/plugins/publish/extract_ass.py
index e56e40df85..a302b451cb 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_ass.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_ass.py
@@ -1,11 +1,12 @@
 import os
 
 import pyblish.api
-import openpype.api
+
+from openpype.pipeline import publish
 from openpype.hosts.houdini.api.lib import render_rop
 
 
-class ExtractAss(openpype.api.Extractor):
+class ExtractAss(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder + 0.1
     label = "Extract Ass"
diff --git a/openpype/hosts/houdini/plugins/publish/extract_composite.py b/openpype/hosts/houdini/plugins/publish/extract_composite.py
index f300b6d28d..23e875f107 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_composite.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_composite.py
@@ -1,12 +1,12 @@
 import os
 
 import pyblish.api
-import openpype.api
 
+from openpype.pipeline import publish
 from openpype.hosts.houdini.api.lib import render_rop
 
 
-class ExtractComposite(openpype.api.Extractor):
+class ExtractComposite(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder
     label = "Extract Composite (Image Sequence)"
diff --git a/openpype/hosts/houdini/plugins/publish/extract_hda.py b/openpype/hosts/houdini/plugins/publish/extract_hda.py
index 301dd4e297..7dd03a92b7 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_hda.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_hda.py
@@ -4,10 +4,11 @@ import os
 from pprint import pformat
 
 import pyblish.api
-import openpype.api
+
+from openpype.pipeline import publish
 
 
-class ExtractHDA(openpype.api.Extractor):
+class ExtractHDA(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder
     label = "Extract HDA"
diff --git a/openpype/hosts/houdini/plugins/publish/extract_redshift_proxy.py b/openpype/hosts/houdini/plugins/publish/extract_redshift_proxy.py
index c754d60c59..ca9be64a47 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_redshift_proxy.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_redshift_proxy.py
@@ -1,11 +1,12 @@
 import os
 
 import pyblish.api
-import openpype.api
+
+from openpype.pipeline import publish
 from openpype.hosts.houdini.api.lib import render_rop
 
 
-class ExtractRedshiftProxy(openpype.api.Extractor):
+class ExtractRedshiftProxy(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder + 0.1
     label = "Extract Redshift Proxy"
diff --git a/openpype/hosts/houdini/plugins/publish/extract_usd.py b/openpype/hosts/houdini/plugins/publish/extract_usd.py
index 0fc26900fb..78c32affb4 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_usd.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_usd.py
@@ -1,11 +1,12 @@
 import os
 
 import pyblish.api
-import openpype.api
+
+from openpype.pipeline import publish
 from openpype.hosts.houdini.api.lib import render_rop
 
 
-class ExtractUSD(openpype.api.Extractor):
+class ExtractUSD(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder
     label = "Extract USD"
diff --git a/openpype/hosts/houdini/plugins/publish/extract_usd_layered.py b/openpype/hosts/houdini/plugins/publish/extract_usd_layered.py
index 80919c023b..f686f712bb 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_usd_layered.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_usd_layered.py
@@ -5,7 +5,6 @@ import sys
 from collections import deque
 
 import pyblish.api
-import openpype.api
 
 from openpype.client import (
     get_asset_by_name,
@@ -16,6 +15,7 @@ from openpype.client import (
 from openpype.pipeline import (
     get_representation_path,
     legacy_io,
+    publish,
 )
 import openpype.hosts.houdini.api.usd as hou_usdlib
 from openpype.hosts.houdini.api.lib import render_rop
@@ -160,7 +160,7 @@ def parm_values(overrides):
                 parm.set(value)
 
 
-class ExtractUSDLayered(openpype.api.Extractor):
+class ExtractUSDLayered(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder
     label = "Extract Layered USD"
diff --git a/openpype/hosts/houdini/plugins/publish/extract_vdb_cache.py b/openpype/hosts/houdini/plugins/publish/extract_vdb_cache.py
index 113e1b0bcb..26ec423048 100644
--- a/openpype/hosts/houdini/plugins/publish/extract_vdb_cache.py
+++ b/openpype/hosts/houdini/plugins/publish/extract_vdb_cache.py
@@ -1,11 +1,12 @@
 import os
 
 import pyblish.api
-import openpype.api
+
+from openpype.pipeline import publish
 from openpype.hosts.houdini.api.lib import render_rop
 
 
-class ExtractVDBCache(openpype.api.Extractor):
+class ExtractVDBCache(publish.Extractor):
 
     order = pyblish.api.ExtractorOrder + 0.1
     label = "Extract VDB Cache"

From 170c35c4d11936e40e40b3a36967c558cee3caa9 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Wed, 7 Sep 2022 14:37:00 +0200
Subject: [PATCH 026/147] initial commit - not changing current implementation
 yet

---
 .../pipeline/workfile/new_template_loader.py  | 678 ++++++++++++++++++
 1 file changed, 678 insertions(+)
 create mode 100644 openpype/pipeline/workfile/new_template_loader.py

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
new file mode 100644
index 0000000000..82cb2d9974
--- /dev/null
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -0,0 +1,678 @@
+import os
+import collections
+from abc import ABCMeta, abstractmethod
+
+import six
+
+from openpype.client import get_asset_by_name
+from openpype.settings import get_project_settings
+from openpype.host import HostBase
+from openpype.lib import Logger, StringTemplate, filter_profiles
+from openpype.pipeline import legacy_io, Anatomy
+from openpype.pipeline.load import get_loaders_by_name
+from openpype.pipeline.create import get_legacy_creator_by_name
+
+from .build_template_exceptions import (
+    TemplateProfileNotFound,
+    TemplateLoadingFailed,
+    TemplateNotFound,
+)
+
+
+@six.add_metaclass(ABCMeta)
+class AbstractTemplateLoader:
+    """Abstraction of Template Loader.
+
+    Args:
+        host (Union[HostBase, ModuleType]): Implementation of host.
+    """
+
+    _log = None
+
+    def __init__(self, host):
+        # Store host
+        self._host = host
+        if isinstance(host, HostBase):
+            host_name = host.name
+        else:
+            host_name = os.environ.get("AVALON_APP")
+        self._host_name = host_name
+
+        # Shared data across placeholder plugins
+        self._shared_data = {}
+
+        # Where created objects of placeholder plugins will be stored
+        self._placeholder_plugins = None
+
+        project_name = legacy_io.active_project()
+        asset_name = legacy_io.Session["AVALON_ASSET"]
+
+        self.current_asset = asset_name
+        self.project_name = project_name
+        self.task_name = legacy_io.Session["AVALON_TASK"]
+        self.current_asset_doc = get_asset_by_name(project_name, asset_name)
+        self.task_type = (
+            self.current_asset_doc
+            .get("data", {})
+            .get("tasks", {})
+            .get(self.task_name, {})
+            .get("type")
+        )
+
+    @abstractmethod
+    def get_placeholder_plugin_classes(self):
+        """Get placeholder plugin classes that can be used to build template.
+
+        Returns:
+            List[PlaceholderPlugin]: Plugin classes available for host.
+        """
+
+        return []
+
+    @property
+    def host(self):
+        """Access to host implementation.
+
+        Returns:
+            Union[HostBase, ModuleType]: Implementation of host.
+        """
+
+        return self._host
+
+    @property
+    def host_name(self):
+        """Name of 'host' implementation.
+
+        Returns:
+            str: Host's name.
+        """
+
+        return self._host_name
+
+    @property
+    def log(self):
+        """Dynamically created logger for the plugin."""
+
+        if self._log is None:
+            self._log = Logger.get_logger(repr(self))
+        return self._log
+
+    def refresh(self):
+        """Reset cached data."""
+
+        self._placeholder_plugins = None
+        self._loaders_by_name = None
+        self._creators_by_name = None
+        self.clear_shared_data()
+
+    def clear_shared_data(self):
+        """Clear shared data.
+
+        Method only clear shared data to default state.
+        """
+
+        self._shared_data = {}
+
+    def get_loaders_by_name(self):
+        if self._loaders_by_name is None:
+            self._loaders_by_name = get_loaders_by_name()
+        return self._loaders_by_name
+
+    def get_creators_by_name(self):
+        if self._creators_by_name is None:
+            self._creators_by_name = get_legacy_creator_by_name()
+        return self._creators_by_name
+
+    def get_shared_data(self, key):
+        """Receive shared data across plugins and placeholders.
+
+        This can be used to scroll scene only once to look for placeholder
+        items if the storing is unified but each placeholder plugin would have
+        to call it again.
+
+        Shared data are cleaned up on specific callbacks.
+
+        Args:
+            key (str): Key under which are shared data stored.
+
+        Returns:
+            Union[None, Any]: None if key was not set.
+        """
+
+        return self._shared_data.get(key)
+
+    def set_shared_data(self, key, value):
+        """Store share data across plugins and placeholders.
+
+        Store data that can be afterwards accessed from any future call. It
+        is good practice to check if the same value is not already stored under
+        different key or if the key is not already used for something else.
+
+        Key should be self explanatory to content.
+        - wrong: 'asset'
+        - good: 'asset_name'
+
+        Shared data are cleaned up on specific callbacks.
+
+        Args:
+            key (str): Key under which is key stored.
+            value (Any): Value that should be stored under the key.
+        """
+
+        self._shared_data[key] = value
+
+    @property
+    def placeholder_plugins(self):
+        """Access to initialized placeholder plugins.
+
+        Returns:
+            List[PlaceholderPlugin]: Initialized plugins available for host.
+        """
+
+        if self._placeholder_plugins is None:
+            placeholder_plugins = {}
+            for cls in self.get_placeholder_plugin_classes():
+                try:
+                    plugin = cls(self)
+                    placeholder_plugins[plugin.identifier] = plugin
+
+                except Exception:
+                    self.log.warning(
+                        "Failed to initialize placeholder plugin {}".format(
+                            cls.__name__
+                        )
+                    )
+
+            self._placeholder_plugins = placeholder_plugins
+        return self._placeholder_plugins
+
+    def get_placeholders(self):
+        """Collect placeholder items from scene.
+
+        Each placeholder plugin can collect it's placeholders and return them.
+        This method does not use cached values but always go through the scene.
+
+        Returns:
+            List[PlaceholderItem]: Sorted placeholder items.
+        """
+
+        placeholders = []
+        for placeholder_plugin in self.placeholder_plugins:
+            result = placeholder_plugin.collect_placeholders()
+            if result:
+                placeholders.extend(result)
+
+        return list(sorted(
+            placeholders,
+            key=lambda i: i.order
+        ))
+
+    @abstractmethod
+    def import_template(self, template_path):
+        """
+        Import template in current host.
+
+        Should load the content of template into scene so
+        'process_scene_placeholders' can be started.
+
+        Args:
+            template_path (str): Fullpath for current task and
+                host's template file.
+        """
+
+        pass
+
+    # def template_already_imported(self, err_msg):
+    #     pass
+    #
+    # def template_loading_failed(self, err_msg):
+    #     pass
+
+    def _prepare_placeholders(self, placeholders):
+        """Run preparation part for placeholders on plugins.
+
+        Args:
+            placeholders (List[PlaceholderItem]): Placeholder items that will
+                be processed.
+        """
+
+        # Prepare placeholder items by plugin
+        plugins_by_identifier = {}
+        placeholders_by_plugin_id = collections.defaultdict(list)
+        for placeholder in placeholders:
+            plugin = placeholder.plugin
+            identifier = plugin.identifier
+            plugins_by_identifier[identifier] = plugin
+            placeholders_by_plugin_id[identifier].append(placeholder)
+
+        # Plugin should prepare data for passed placeholders
+        for identifier, placeholders in placeholders_by_plugin_id.items():
+            plugin = plugins_by_identifier[identifier]
+            plugin.prepare_placeholders(placeholders)
+
+    def process_scene_placeholders(self, level_limit=None):
+        """Find placeholders in scene using plugins and process them.
+
+        This should happen after 'import_template'.
+
+        Collect available placeholders from scene. All of them are processed
+        after that shared data are cleared. Placeholder items are collected
+        again and if there are any new the loop happens again. This is possible
+        to change with defying 'level_limit'.
+
+        Placeholders are marked as processed so they're not re-processed. To
+        identify which placeholders were already processed is used
+        placeholder's 'scene_identifier'.
+
+        Args:
+            level_limit (int): Level of loops that can happen. By default
+                if is possible to have infinite nested placeholder processing.
+        """
+
+        if not self.placeholder_plugins:
+            self.log.warning("There are no placeholder plugins available.")
+            return
+
+        placeholders = self.get_placeholders()
+        if not placeholders:
+            self.log.warning("No placeholders were found.")
+            return
+
+        placeholder_by_scene_id = {
+            placeholder.identifier: placeholder
+            for placeholder in placeholders
+        }
+        all_processed = len(placeholders) == 0
+        iter_counter = 0
+        while not all_processed:
+            filtered_placeholders = []
+            for placeholder in placeholders:
+                if placeholder.finished:
+                    continue
+
+                if placeholder.in_progress:
+                    self.log.warning((
+                        "Placeholder that should be processed"
+                        " is already in progress."
+                    ))
+                    continue
+                filtered_placeholders.append(placeholder)
+
+            self._prepare_placeholders(filtered_placeholders)
+
+            for placeholder in filtered_placeholders:
+                placeholder.set_in_progress()
+                placeholder_plugin = placeholder.plugin
+                try:
+                    placeholder_plugin.process_placeholder(placeholder)
+
+                except Exception as exc:
+                    placeholder.set_error(exc)
+
+                else:
+                    placeholder.set_finished()
+
+            # Clear shared data before getting new placeholders
+            self.clear_shared_data()
+
+            if level_limit:
+                iter_counter += 1
+                if iter_counter >= level_limit:
+                    break
+
+            all_processed = True
+            collected_placeholders = self.get_placeholders()
+            for placeholder in collected_placeholders:
+                if placeholder.identifier in placeholder_by_scene_id:
+                    continue
+
+                all_processed = False
+                identifier = placeholder.identifier
+                placeholder_by_scene_id[identifier] = placeholder
+                placeholders.append(placeholder)
+
+    def _get_build_profiles(self):
+        project_settings = get_project_settings(self.project_name)
+        return (
+            project_settings
+            [self.host_name]
+            ["templated_workfile_build"]
+            ["profiles"]
+        )
+
+    def get_template_path(self):
+        project_name = self.project_name
+        host_name = self.host_name
+        task_name = self.task_name
+        task_type = self.task_type
+
+        build_profiles = self._get_build_profiles()
+        profile = filter_profiles(
+            build_profiles,
+            {
+                "task_types": task_type,
+                "task_names": task_name
+            }
+        )
+
+        if not profile:
+            raise TemplateProfileNotFound((
+                "No matching profile found for task '{}' of type '{}' "
+                "with host '{}'"
+            ).format(task_name, task_type, host_name))
+
+        path = profile["path"]
+        if not path:
+            raise TemplateLoadingFailed((
+                "Template path is not set.\n"
+                "Path need to be set in {}\\Template Workfile Build "
+                "Settings\\Profiles"
+            ).format(host_name.title()))
+
+        # Try fill path with environments and anatomy roots
+        anatomy = Anatomy(project_name)
+        fill_data = {
+            key: value
+            for key, value in os.environ.items()
+        }
+        fill_data["root"] = anatomy.roots
+        result = StringTemplate.format_template(path, fill_data)
+        if result.solved:
+            path = result.normalized()
+
+        if path and os.path.exists(path):
+            self.log.info("Found template at: '{}'".format(path))
+            return path
+
+        solved_path = None
+        while True:
+            try:
+                solved_path = anatomy.path_remapper(path)
+            except KeyError as missing_key:
+                raise KeyError(
+                    "Could not solve key '{}' in template path '{}'".format(
+                        missing_key, path))
+
+            if solved_path is None:
+                solved_path = path
+            if solved_path == path:
+                break
+            path = solved_path
+
+        solved_path = os.path.normpath(solved_path)
+        if not os.path.exists(solved_path):
+            raise TemplateNotFound(
+                "Template found in openPype settings for task '{}' with host "
+                "'{}' does not exists. (Not found : {})".format(
+                    task_name, host_name, solved_path))
+
+        self.log.info("Found template at: '{}'".format(solved_path))
+
+        return solved_path
+
+
+@six.add_metaclass(ABCMeta)
+class PlaceholderPlugin(object):
+    label = None
+    placeholder_options = []
+    _log = None
+
+    def __init__(self, builder):
+        self._builder = builder
+
+    @property
+    def builder(self):
+        """Access to builder which initialized the plugin.
+
+        Returns:
+            AbstractTemplateLoader: Loader of template build.
+        """
+
+        return self._builder
+
+    @property
+    def log(self):
+        """Dynamically created logger for the plugin."""
+
+        if self._log is None:
+            self._log = Logger.get_logger(repr(self))
+        return self._log
+
+    @property
+    def identifier(self):
+        """Identifier which will be stored to placeholder.
+
+        Default implementation uses class name.
+
+        Returns:
+            str: Unique identifier of placeholder plugin.
+        """
+
+        return self.__class__.__name__
+
+    @abstractmethod
+    def collect_placeholders(self):
+        """Collect placeholders from scene.
+
+        Returns:
+            List[PlaceholderItem]: Placeholder objects.
+        """
+
+        pass
+
+    def get_placeholder_options(self):
+        """Placeholder options for data showed.
+
+        Returns:
+            List[AbtractAttrDef]: Attribute definitions of placeholder options.
+        """
+
+        return self.placeholder_options
+
+    def prepare_placeholders(self, placeholders):
+        """Preparation part of placeholders.
+
+        Args:
+            placeholders (List[PlaceholderItem]): List of placeholders that
+                will be processed.
+        """
+
+        pass
+
+    @abstractmethod
+    def process_placeholder(self, placeholder):
+        """Process single placeholder item.
+
+        Processing of placeholders is defined by their order thus can't be
+        processed in batch.
+
+        Args:
+            placeholder (PlaceholderItem): Placeholder that should be
+                processed.
+        """
+
+        pass
+
+    def cleanup_placeholders(self, placeholders):
+        """Cleanup of placeholders after processing.
+
+        Not:
+            Passed placeholders can be failed.
+
+        Args:
+            placeholders (List[PlaceholderItem]): List of placeholders that
+                were be processed.
+        """
+
+        pass
+
+    def get_plugin_shared_data(self, key):
+        """Receive shared data across plugin and placeholders.
+
+        Using shared data from builder but stored under plugin identifier.
+
+        Shared data are cleaned up on specific callbacks.
+
+        Args:
+            key (str): Key under which are shared data stored.
+
+        Returns:
+            Union[None, Any]: None if key was not set.
+        """
+
+        plugin_data = self.builder.get_shared_data(self.identifier)
+        if plugin_data is None:
+            return None
+        return plugin_data.get(key)
+
+    def set_plugin_shared_data(self, key, value):
+        """Store share data across plugin and placeholders.
+
+        Using shared data from builder but stored under plugin identifier.
+
+        Key should be self explanatory to content.
+        - wrong: 'asset'
+        - good: 'asset_name'
+
+        Shared data are cleaned up on specific callbacks.
+
+        Args:
+            key (str): Key under which is key stored.
+            value (Any): Value that should be stored under the key.
+        """
+
+        plugin_data = self.builder.get_shared_data(self.identifier)
+        if plugin_data is None:
+            plugin_data = {}
+        plugin_data[key] = value
+        self.builder.set_shared_data(self.identifier, plugin_data)
+
+
+class PlaceholderItem(object):
+    """Item representing single item in scene that is a placeholder to process.
+
+    Scene identifier is used to avoid processing of the palceholder item
+    multiple times.
+
+    Args:
+        scene_identifier (str): Unique scene identifier. If placeholder is
+            created from the same "node" it must have same identifier.
+        data (Dict[str, Any]): Data related to placeholder. They're defined
+            by plugin.
+        plugin (PlaceholderPlugin): Plugin which created the placeholder item.
+    """
+
+    default_order = 100
+
+    def __init__(self, scene_identifier, data, plugin):
+        self._log = None
+        self._scene_identifier = scene_identifier
+        self._data = data
+        self._plugin = plugin
+
+        # Keep track about state of Placeholder process
+        self._state = 0
+
+        # Exception which happened during processing
+        self._error = None
+
+    @property
+    def plugin(self):
+        """Access to plugin which created placeholder.
+
+        Returns:
+            PlaceholderPlugin: Plugin object.
+        """
+
+        return self._plugin
+
+    @property
+    def builder(self):
+        """Access to builder.
+
+        Returns:
+            AbstractTemplateLoader: Builder which is the top part of
+                placeholder.
+        """
+
+        return self.plugin.builder
+
+    @property
+    def data(self):
+        """Placeholder data which can modify how placeholder is processed.
+
+        Possible general keys
+        - order: Can define the order in which is palceholder processed.
+                    Lower == earlier.
+
+        Other keys are defined by placeholder and should validate them on item
+        creation.
+
+        Returns:
+            Dict[str, Any]: Placeholder item data.
+        """
+
+        return self._data
+
+    @property
+    def log(self):
+        if self._log is None:
+            self._log = Logger.get_logger(repr(self))
+        return self._log
+
+    def __repr__(self):
+        return "< {} {} >".format(self.__class__.__name__, self.name)
+
+    @property
+    def order(self):
+        order = self._data.get("order")
+        if order is None:
+            return self.default_order
+        return order
+
+    @property
+    def scene_identifier(self):
+        return self._scene_identifier
+
+    @property
+    def finished(self):
+        """Item was already processed."""
+
+        return self._state == 2
+
+    @property
+    def in_progress(self):
+        """Processing is in progress."""
+
+        return self._state == 1
+
+    @property
+    def failed(self):
+        """Processing of placeholder failed."""
+
+        return self._error is not None
+
+    @property
+    def error(self):
+        """Exception with which the placeholder process failed.
+
+        Gives ability to access the exception.
+        """
+
+        return self._error
+
+    def set_in_progress(self):
+        """Change to in progress state."""
+
+        self._state = 1
+
+    def set_finished(self):
+        """Change to finished state."""
+
+        self._state = 2
+
+    def set_error(self, error):
+        """Set placeholder item as failed and mark it as finished."""
+
+        self._error = error
+        self.set_finished()

From ae88578dbda9eca89cc792cec498d19c7ef3d6af Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 7 Sep 2022 14:38:45 +0200
Subject: [PATCH 027/147] OP-3682 - changed md5 to sha256

Updated tests.
Removed test cli method
---
 distribution/addon_distribution.py            | 28 ++++------
 distribution/file_handler.py                  | 54 ++++++++++++++-----
 .../tests/test_addon_distributtion.py         |  8 +--
 3 files changed, 57 insertions(+), 33 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 95d0b5e397..0e3c672915 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -5,6 +5,7 @@ import attr
 import logging
 import requests
 import platform
+import shutil
 
 from distribution.file_handler import RemoteFileHandler
 
@@ -87,7 +88,9 @@ class AddonDownloader:
         """
         if not os.path.exists(addon_path):
             raise ValueError(f"{addon_path} doesn't exist.")
-        if addon_hash != RemoteFileHandler.calculate_md5(addon_path):
+        if not RemoteFileHandler.check_integrity(addon_path,
+                                                 addon_hash,
+                                                 hash_type="sha256"):
             raise ValueError(f"{addon_path} doesn't match expected hash.")
 
     @classmethod
@@ -144,14 +147,14 @@ def get_addons_info(server_endpoint):
     #        "version": "1.0.0",
     #        "addon_url": "c:/projects/openpype_slack_1.0.0.zip",
     #        "type": UrlType.FILESYSTEM,
-    #        "hash": "4f6b8568eb9dd6f510fd7c4dcb676788"})  # noqa
+    #        "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"})  # noqa
     #
     # http_addon = AddonInfo(
     #     **{"name": "openpype_slack",
     #        "version": "1.0.0",
     #        "addon_url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing",  # noqa
     #        "type": UrlType.HTTP,
-    #        "hash": "4f6b8568eb9dd6f510fd7c4dcb676788"})  # noqa
+    #        "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"})  # noqa
 
     response = requests.get(server_endpoint)
     if not response.ok:
@@ -205,6 +208,9 @@ def update_addon_state(addon_infos, destination_folder, factory,
             except Exception:
                 log.warning(f"Error happened during updating {addon.name}",
                             exc_info=True)
+                if os.path.isdir(addon_dest):
+                    log.debug(f"Cleaning {addon_dest}")
+                    shutil.rmtree(addon_dest)
 
     return download_states
 
@@ -228,17 +234,5 @@ def check_addons(server_endpoint, addon_folder, downloaders):
         raise RuntimeError(f"Unable to update some addons {result}")
 
 
-def cli(args):
-    addon_folder = "c:/projects/testing_addons/pypeclub/openpype/addons"
-
-    downloader_factory = AddonDownloader()
-    downloader_factory.register_format(UrlType.FILESYSTEM, OSAddonDownloader)
-    downloader_factory.register_format(UrlType.HTTP, HTTPAddonDownloader)
-
-    test_endpoint = "https://34e99f0f-f987-4715-95e6-d2d88caa7586.mock.pstmn.io/get_addons_info"  # noqa
-    if os.environ.get("OPENPYPE_SERVER"):  # TODO or from keychain
-        server_endpoint = os.environ.get("OPENPYPE_SERVER") + "get_addons_info"
-    else:
-        server_endpoint = test_endpoint
-
-    check_addons(server_endpoint, addon_folder, downloader_factory)
+def cli(*args):
+    raise NotImplemented
\ No newline at end of file
diff --git a/distribution/file_handler.py b/distribution/file_handler.py
index 8c8b4230ce..f585c77632 100644
--- a/distribution/file_handler.py
+++ b/distribution/file_handler.py
@@ -33,17 +33,45 @@ class RemoteFileHandler:
         return md5 == RemoteFileHandler.calculate_md5(fpath, **kwargs)
 
     @staticmethod
-    def check_integrity(fpath, md5=None):
+    def calculate_sha256(fpath):
+        """Calculate sha256 for content of the file.
+
+        Args:
+             fpath (str): Path to file.
+
+        Returns:
+            str: hex encoded sha256
+
+        """
+        h = hashlib.sha256()
+        b = bytearray(128 * 1024)
+        mv = memoryview(b)
+        with open(fpath, 'rb', buffering=0) as f:
+            for n in iter(lambda: f.readinto(mv), 0):
+                h.update(mv[:n])
+        return h.hexdigest()
+
+    @staticmethod
+    def check_sha256(fpath, sha256, **kwargs):
+        return sha256 == RemoteFileHandler.calculate_sha256(fpath, **kwargs)
+
+    @staticmethod
+    def check_integrity(fpath, hash_value=None, hash_type=None):
         if not os.path.isfile(fpath):
             return False
-        if md5 is None:
+        if hash_value is None:
             return True
-        return RemoteFileHandler.check_md5(fpath, md5)
+        if not hash_type:
+            raise ValueError("Provide hash type, md5 or sha256")
+        if hash_type == 'md5':
+            return RemoteFileHandler.check_md5(fpath, hash_value)
+        if hash_type == "sha256":
+            return RemoteFileHandler.check_sha256(fpath, hash_value)
 
     @staticmethod
     def download_url(
         url, root, filename=None,
-        md5=None, max_redirect_hops=3
+        sha256=None, max_redirect_hops=3
     ):
         """Download a file from a url and place it in root.
         Args:
@@ -51,7 +79,7 @@ class RemoteFileHandler:
             root (str): Directory to place downloaded file in
             filename (str, optional): Name to save the file under.
                 If None, use the basename of the URL
-            md5 (str, optional): MD5 checksum of the download.
+            sha256 (str, optional): sha256 checksum of the download.
                 If None, do not check
             max_redirect_hops (int, optional): Maximum number of redirect
                 hops allowed
@@ -64,7 +92,8 @@ class RemoteFileHandler:
         os.makedirs(root, exist_ok=True)
 
         # check if file is already present locally
-        if RemoteFileHandler.check_integrity(fpath, md5):
+        if RemoteFileHandler.check_integrity(fpath,
+                                             sha256, hash_type="sha256"):
             print('Using downloaded and verified file: ' + fpath)
             return
 
@@ -76,7 +105,7 @@ class RemoteFileHandler:
         file_id = RemoteFileHandler._get_google_drive_file_id(url)
         if file_id is not None:
             return RemoteFileHandler.download_file_from_google_drive(
-                file_id, root, filename, md5)
+                file_id, root, filename, sha256)
 
         # download the file
         try:
@@ -92,20 +121,21 @@ class RemoteFileHandler:
                 raise e
 
         # check integrity of downloaded file
-        if not RemoteFileHandler.check_integrity(fpath, md5):
+        if not RemoteFileHandler.check_integrity(fpath,
+                                                 sha256, hash_type="sha256"):
             raise RuntimeError("File not found or corrupted.")
 
     @staticmethod
     def download_file_from_google_drive(file_id, root,
                                         filename=None,
-                                        md5=None):
+                                        sha256=None):
         """Download a Google Drive file from  and place it in root.
         Args:
             file_id (str): id of file to be downloaded
             root (str): Directory to place downloaded file in
             filename (str, optional): Name to save the file under.
                 If None, use the id of the file.
-            md5 (str, optional): MD5 checksum of the download.
+            sha256 (str, optional): sha256 checksum of the download.
                 If None, do not check
         """
         # Based on https://stackoverflow.com/questions/38511444/python-download-files-from-google-drive-using-url # noqa
@@ -119,8 +149,8 @@ class RemoteFileHandler:
 
         os.makedirs(root, exist_ok=True)
 
-        if os.path.isfile(fpath) and RemoteFileHandler.check_integrity(fpath,
-                                                                       md5):
+        if os.path.isfile(fpath) and RemoteFileHandler.check_integrity(
+                fpath, sha256, hash_type="sha256"):
             print('Using downloaded and verified file: ' + fpath)
         else:
             session = requests.Session()
diff --git a/distribution/tests/test_addon_distributtion.py b/distribution/tests/test_addon_distributtion.py
index e67ca3c479..717ef1330e 100644
--- a/distribution/tests/test_addon_distributtion.py
+++ b/distribution/tests/test_addon_distributtion.py
@@ -51,7 +51,7 @@ def sample_addon_info():
                 }
             }
         ],
-        "hash": "4f6b8568eb9dd6f510fd7c4dcb676788"
+        "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"
     }
     yield addon_info
 
@@ -109,13 +109,13 @@ def test_update_addon_state(printer, sample_addon_info,
     addon_info.hash = "brokenhash"
     result = update_addon_state([addon_info], temp_folder, addon_downloader)
     assert result["openpype_slack_1.0.0"] == UpdateState.FAILED.value, \
-        "Hashes not matching"
+        "Update should failed because of wrong hash"
 
     addon_info.hash = orig_hash
     result = update_addon_state([addon_info], temp_folder, addon_downloader)
     assert result["openpype_slack_1.0.0"] == UpdateState.UPDATED.value, \
-        "Failed updating"
+        "Addon should have been updated"
 
     result = update_addon_state([addon_info], temp_folder, addon_downloader)
     assert result["openpype_slack_1.0.0"] == UpdateState.EXISTS.value, \
-        "Tried to update"
+        "Addon should already exist"

From b2999a7bbd402154570140fd1db72f6a62158d60 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 7 Sep 2022 14:46:12 +0200
Subject: [PATCH 028/147] OP-3682 - Hound

---
 distribution/addon_distribution.py             | 2 +-
 distribution/tests/test_addon_distributtion.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/distribution/addon_distribution.py b/distribution/addon_distribution.py
index 0e3c672915..389b92b10b 100644
--- a/distribution/addon_distribution.py
+++ b/distribution/addon_distribution.py
@@ -235,4 +235,4 @@ def check_addons(server_endpoint, addon_folder, downloaders):
 
 
 def cli(*args):
-    raise NotImplemented
\ No newline at end of file
+    raise NotImplemented
diff --git a/distribution/tests/test_addon_distributtion.py b/distribution/tests/test_addon_distributtion.py
index 717ef1330e..c6ecaca3c8 100644
--- a/distribution/tests/test_addon_distributtion.py
+++ b/distribution/tests/test_addon_distributtion.py
@@ -51,7 +51,7 @@ def sample_addon_info():
                 }
             }
         ],
-        "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"
+        "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"  # noqa
     }
     yield addon_info
 

From 0d6c40bb32fff14cb08cc33505acf298555b95e7 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Wed, 7 Sep 2022 19:13:00 +0200
Subject: [PATCH 029/147] added few missing abstract methods and attributes

---
 .../pipeline/workfile/new_template_loader.py  | 68 ++++++++++++++++++-
 1 file changed, 66 insertions(+), 2 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 82cb2d9974..4b77168aa1 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -1,5 +1,6 @@
 import os
 import collections
+import copy
 from abc import ABCMeta, abstractmethod
 
 import six
@@ -43,6 +44,8 @@ class AbstractTemplateLoader:
 
         # Where created objects of placeholder plugins will be stored
         self._placeholder_plugins = None
+        self._loaders_by_name = None
+        self._creators_by_name = None
 
         project_name = legacy_io.active_project()
         asset_name = legacy_io.Session["AVALON_ASSET"]
@@ -180,12 +183,29 @@ class AbstractTemplateLoader:
                     self.log.warning(
                         "Failed to initialize placeholder plugin {}".format(
                             cls.__name__
-                        )
+                        ),
+                        exc_info=True
                     )
 
             self._placeholder_plugins = placeholder_plugins
         return self._placeholder_plugins
 
+    def create_placeholder(self, plugin_identifier, placeholder_data):
+        """Create new placeholder using plugin identifier and data.
+
+        Args:
+            plugin_identifier (str): Identifier of plugin. That's how builder
+                know which plugin should be used.
+            placeholder_data (Dict[str, Any]): Placeholder item data. They
+                should match options required by the plugin.
+
+        Returns:
+            PlaceholderItem: Created placeholder item.
+        """
+
+        plugin = self.placeholder_plugins[plugin_identifier]
+        return plugin.create_placeholder(placeholder_data)
+
     def get_placeholders(self):
         """Collect placeholder items from scene.
 
@@ -197,7 +217,7 @@ class AbstractTemplateLoader:
         """
 
         placeholders = []
-        for placeholder_plugin in self.placeholder_plugins:
+        for placeholder_plugin in self.placeholder_plugins.values():
             result = placeholder_plugin.collect_placeholders()
             if result:
                 placeholders.extend(result)
@@ -450,6 +470,42 @@ class PlaceholderPlugin(object):
 
         return self.__class__.__name__
 
+    @abstractmethod
+    def create_placeholder(self, placeholder_data):
+        """Create new placeholder in scene and get it's item.
+
+        It matters on the plugin implementation if placeholder will use
+        selection in scene or create new node.
+
+        Args:
+            placeholder_data (Dict[str, Any]): Data that were created
+                based on attribute definitions from 'get_placeholder_options'.
+
+        Returns:
+            PlaceholderItem: Created placeholder item.
+        """
+
+        pass
+
+    @abstractmethod
+    def update_placeholder(self, placeholder_item, placeholder_data):
+        """Update placeholder item with new data.
+
+        New data should be propagated to object of placeholder item itself
+        and also into the scene.
+
+        Reason:
+            Some placeholder plugins may require some special way how the
+            updates should be propagated to object.
+
+        Args:
+            placeholder_item (PlaceholderItem): Object of placeholder that
+                should be updated.
+            placeholder_data (Dict[str, Any]): Data related to placeholder.
+                Should match plugin options.
+        """
+        pass
+
     @abstractmethod
     def collect_placeholders(self):
         """Collect placeholders from scene.
@@ -614,6 +670,14 @@ class PlaceholderItem(object):
 
         return self._data
 
+    def to_dict(self):
+        """Create copy of item's data.
+
+        Returns:
+            Dict[str, Any]: Placeholder data.
+        """
+        return copy.deepcopy(self.data)
+
     @property
     def log(self):
         if self._log is None:

From 50a9a7973b32a3fb38b1f42861288ffb44ed823f Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 8 Sep 2022 18:31:15 +0200
Subject: [PATCH 030/147] small modifications of placeholder identifiers and
 errors

---
 .../pipeline/workfile/new_template_loader.py  | 45 ++++++++-----------
 1 file changed, 19 insertions(+), 26 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 4b77168aa1..b1231c2308 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -299,7 +299,7 @@ class AbstractTemplateLoader:
             return
 
         placeholder_by_scene_id = {
-            placeholder.identifier: placeholder
+            placeholder.scene_identifier: placeholder
             for placeholder in placeholders
         }
         all_processed = len(placeholders) == 0
@@ -343,11 +343,11 @@ class AbstractTemplateLoader:
             all_processed = True
             collected_placeholders = self.get_placeholders()
             for placeholder in collected_placeholders:
-                if placeholder.identifier in placeholder_by_scene_id:
+                identifier = placeholder.scene_identifier
+                if identifier in placeholder_by_scene_id:
                     continue
 
                 all_processed = False
-                identifier = placeholder.identifier
                 placeholder_by_scene_id[identifier] = placeholder
                 placeholders.append(placeholder)
 
@@ -434,7 +434,6 @@ class AbstractTemplateLoader:
 @six.add_metaclass(ABCMeta)
 class PlaceholderPlugin(object):
     label = None
-    placeholder_options = []
     _log = None
 
     def __init__(self, builder):
@@ -516,14 +515,14 @@ class PlaceholderPlugin(object):
 
         pass
 
-    def get_placeholder_options(self):
+    def get_placeholder_options(self, options=None):
         """Placeholder options for data showed.
 
         Returns:
             List[AbtractAttrDef]: Attribute definitions of placeholder options.
         """
 
-        return self.placeholder_options
+        return []
 
     def prepare_placeholders(self, placeholders):
         """Preparation part of placeholders.
@@ -629,8 +628,9 @@ class PlaceholderItem(object):
         # Keep track about state of Placeholder process
         self._state = 0
 
-        # Exception which happened during processing
-        self._error = None
+        # Error messages to be shown in UI
+        # - all other messages should be logged
+        self._errors = []  # -> List[str]
 
     @property
     def plugin(self):
@@ -676,6 +676,7 @@ class PlaceholderItem(object):
         Returns:
             Dict[str, Any]: Placeholder data.
         """
+
         return copy.deepcopy(self.data)
 
     @property
@@ -710,21 +711,6 @@ class PlaceholderItem(object):
 
         return self._state == 1
 
-    @property
-    def failed(self):
-        """Processing of placeholder failed."""
-
-        return self._error is not None
-
-    @property
-    def error(self):
-        """Exception with which the placeholder process failed.
-
-        Gives ability to access the exception.
-        """
-
-        return self._error
-
     def set_in_progress(self):
         """Change to in progress state."""
 
@@ -735,8 +721,15 @@ class PlaceholderItem(object):
 
         self._state = 2
 
-    def set_error(self, error):
+    def add_error(self, error):
         """Set placeholder item as failed and mark it as finished."""
 
-        self._error = error
-        self.set_finished()
+        self._errors.append(error)
+
+    def get_errors(self):
+        """Exception with which the placeholder process failed.
+
+        Gives ability to access the exception.
+        """
+
+        return self._errors

From 2eef3a8f826b614b1f496d6aa05b02da6a328a02 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 8 Sep 2022 18:31:39 +0200
Subject: [PATCH 031/147] initial commit of maya implementation of new template
 builder

---
 .../hosts/maya/api/new_template_builder.py    | 505 ++++++++++++++++++
 1 file changed, 505 insertions(+)
 create mode 100644 openpype/hosts/maya/api/new_template_builder.py

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
new file mode 100644
index 0000000000..023f240061
--- /dev/null
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -0,0 +1,505 @@
+import re
+from maya import cmds
+
+from openpype.client import get_representations
+from openpype.lib import attribute_definitions
+from openpype.pipeline import legacy_io
+from openpype.pipeline.workfile.build_template_exceptions import (
+    TemplateAlreadyImported
+)
+from openpype.pipeline.workfile.new_template_loader import (
+    AbstractTemplateLoader,
+    PlaceholderPlugin,
+    PlaceholderItem,
+)
+
+from .lib import read, imprint
+
+PLACEHOLDER_SET = "PLACEHOLDERS_SET"
+
+
+class MayaTemplateLoader(AbstractTemplateLoader):
+    """Concrete implementation of AbstractTemplateLoader for maya"""
+
+    def import_template(self, path):
+        """Import template into current scene.
+        Block if a template is already loaded.
+
+        Args:
+            path (str): A path to current template (usually given by
+            get_template_path implementation)
+
+        Returns:
+            bool: Wether the template was succesfully imported or not
+        """
+
+        if cmds.objExists(PLACEHOLDER_SET):
+            raise TemplateAlreadyImported((
+                "Build template already loaded\n"
+                "Clean scene if needed (File > New Scene)"
+            ))
+
+        cmds.sets(name=PLACEHOLDER_SET, empty=True)
+        cmds.file(path, i=True, returnNewNodes=True)
+
+        cmds.setAttr(PLACEHOLDER_SET + '.hiddenInOutliner', True)
+
+        # This should be handled by creators
+        # for set_name in cmds.listSets(allSets=True):
+        #     if (
+        #         cmds.objExists(set_name)
+        #         and cmds.attributeQuery('id', node=set_name, exists=True)
+        #         and cmds.getAttr(set_name + '.id') == 'pyblish.avalon.instance'
+        #     ):
+        #         if cmds.attributeQuery('asset', node=set_name, exists=True):
+        #             cmds.setAttr(
+        #                 set_name + '.asset',
+        #                 legacy_io.Session['AVALON_ASSET'], type='string'
+        #             )
+
+        return True
+
+    def get_placeholder_plugin_classes(self):
+        return [
+            MayaLoadPlaceholderPlugin
+        ]
+
+    # def template_already_imported(self, err_msg):
+    #     clearButton = "Clear scene and build"
+    #     updateButton = "Update template"
+    #     abortButton = "Abort"
+    #
+    #     title = "Scene already builded"
+    #     message = (
+    #         "It's seems a template was already build for this scene.\n"
+    #         "Error message reveived :\n\n\"{}\"".format(err_msg))
+    #     buttons = [clearButton, updateButton, abortButton]
+    #     defaultButton = clearButton
+    #     cancelButton = abortButton
+    #     dismissString = abortButton
+    #     answer = cmds.confirmDialog(
+    #         t=title,
+    #         m=message,
+    #         b=buttons,
+    #         db=defaultButton,
+    #         cb=cancelButton,
+    #         ds=dismissString)
+    #
+    #     if answer == clearButton:
+    #         cmds.file(newFile=True, force=True)
+    #         self.import_template(self.template_path)
+    #         self.populate_template()
+    #     elif answer == updateButton:
+    #         self.update_missing_containers()
+    #     elif answer == abortButton:
+    #         return
+
+    # def get_loaded_containers_by_id(self):
+    #     try:
+    #         containers = cmds.sets("AVALON_CONTAINERS", q=True)
+    #     except ValueError:
+    #         return None
+    #
+    #     return [
+    #         cmds.getAttr(container + '.representation')
+    #         for container in containers]
+
+
+class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
+    identifier = "maya.load"
+    label = "Maya load"
+
+    def _collect_scene_placeholders(self):
+        # Cache placeholder data to shared data
+        placeholder_nodes = self.builder.get_shared_data("placeholder_nodes")
+        if placeholder_nodes is None:
+            attributes = cmds.ls("*.plugin_identifier", long=True)
+            placeholder_nodes = [
+                self._parse_placeholder_node_data(attribute.rpartition(".")[0])
+                for attribute in attributes
+            ]
+            self.builder.set_shared_data(
+                "placeholder_nodes", placeholder_nodes
+            )
+        return placeholder_nodes
+
+    def _parse_placeholder_node_data(self, node_name):
+        placeholder_data = read(node_name)
+        parent_name = (
+            cmds.getAttr(node_name + ".parent", asString=True)
+            or node_name.rpartition("|")[0]
+            or ""
+        )
+        if parent_name:
+            siblings = cmds.listRelatives(parent_name, children=True)
+        else:
+            siblings = cmds.ls(assemblies=True)
+        node_shortname = node_name.rpartition("|")[2]
+        current_index = cmds.getAttr(node_name + ".index", asString=True)
+        if current_index < 0:
+            current_index = siblings.index(node_shortname)
+
+        placeholder_data.update({
+            "parent": parent_name,
+            "index": current_index
+        })
+        return placeholder_data
+
+    def _create_placeholder_name(self, placeholder_data):
+        # TODO implement placeholder name logic
+        return "Placeholder"
+
+    def create_placeholder(self, placeholder_data):
+        selection = cmds.ls(selection=True)
+        if not selection:
+            raise ValueError("Nothing is selected")
+        if len(selection) > 1:
+            raise ValueError("More then one item are selected")
+
+        placeholder_data["plugin_identifier"] = self.identifier
+
+        placeholder_name = self._create_placeholder_name(placeholder_data)
+
+        placeholder = cmds.spaceLocator(name=placeholder_name)[0]
+
+        # TODO: this can crash if selection can't be used
+        cmds.parent(placeholder, selection[0])
+
+        # get the long name of the placeholder (with the groups)
+        placeholder_full_name = (
+            cmds.ls(selection[0], long=True)[0]
+            + "|"
+            + placeholder.replace("|", "")
+        )
+
+        imprint(placeholder_full_name, placeholder_data)
+
+        # Add helper attributes to keep placeholder info
+        cmds.addAttr(
+            placeholder_full_name,
+            longName="parent",
+            hidden=True,
+            dataType="string"
+        )
+        cmds.addAttr(
+            placeholder_full_name,
+            longName="index",
+            hidden=True,
+            attributeType="short",
+            defaultValue=-1
+        )
+
+        cmds.setAttr(placeholder_full_name + ".parent", "", type="string")
+
+    def update_placeholder(self, placeholder_item, placeholder_data):
+        node_name = placeholder_item.scene_identifier
+        new_values = {}
+        for key, value in placeholder_data.items():
+            placeholder_value = placeholder_item.data.get(key)
+            if value != placeholder_value:
+                new_values[key] = value
+                placeholder_item.data[key] = value
+
+        imprint(node_name, new_values)
+
+    def collect_placeholders(self):
+        filtered_placeholders = []
+        for placeholder_data in self._collect_scene_placeholders():
+            if placeholder_data.get("plugin_identifier") != self.identifier:
+                continue
+
+            filtered_placeholders.append(placeholder_data)
+
+        output = []
+        for placeholder_data in filtered_placeholders:
+            # TODO do data validations and maybe updgrades if are invalid
+            output.append(LoadPlaceholder(placeholder_data))
+        return output
+
+    def process_placeholder(self, placeholder):
+        current_asset_doc = self.current_asset_doc
+        linked_assets = self.linked_assets
+        loader_name = placeholder.data["loader"]
+        loader_args = placeholder.data["loader_args"]
+
+        # TODO check loader existence
+        placeholder_representations = placeholder.get_representations(
+            current_asset_doc,
+            linked_assets
+        )
+
+        if not placeholder_representations:
+            self.log.info((
+                "There's no representation for this placeholder: {}"
+            ).format(placeholder.scene_identifier))
+            return
+
+        loaders_by_name = self.builder.get_loaders_by_name()
+        for representation in placeholder_representations:
+            repre_context = representation["context"]
+            self.log.info(
+                "Loading {} from {} with loader {}\n"
+                "Loader arguments used : {}".format(
+                    repre_context["subset"],
+                    repre_context["asset"],
+                    loader_name,
+                    loader_args
+                )
+            )
+            try:
+                container = self.load(
+                    placeholder, loaders_by_name, representation)
+            except Exception:
+                placeholder.load_failed(representation)
+
+            else:
+                placeholder.load_succeed(container)
+            # TODO find out if 'postload make sense?'
+            # finally:
+            #     self.postload(placeholder)
+
+    def get_placeholder_options(self, options=None):
+        loaders_by_name = self.builder.get_loaders_by_name()
+        loader_names = list(sorted(loaders_by_name.keys()))
+        options = options or {}
+        return [
+            attribute_definitions.UISeparatorDef(),
+            attribute_definitions.UILabelDef("Main attributes"),
+
+            attribute_definitions.EnumDef(
+                "builder_type",
+                label="Asset Builder Type",
+                default=options.get("builder_type"),
+                items=[
+                    ("context_asset", "Current asset"),
+                    ("linked_asset", "Linked assets"),
+                    ("all_assets", "All assets")
+                ],
+                tooltip=(
+                    "Asset Builder Type\n"
+                    "\nBuilder type describe what template loader will look"
+                    " for."
+                    "\ncontext_asset : Template loader will look for subsets"
+                    " of current context asset (Asset bob will find asset)"
+                    "\nlinked_asset : Template loader will look for assets"
+                    " linked to current context asset."
+                    "\nLinked asset are looked in database under"
+                    " field \"inputLinks\""
+                )
+            ),
+            attribute_definitions.TextDef(
+                "family",
+                label="Family",
+                default=options.get("family"),
+                placeholder="model, look, ..."
+            ),
+            attribute_definitions.TextDef(
+                "representation",
+                label="Representation name",
+                default=options.get("representation"),
+                placeholder="ma, abc, ..."
+            ),
+            attribute_definitions.EnumDef(
+                "loader",
+                label="Loader",
+                default=options.get("loader"),
+                items=[
+                    (loader_name, loader_name)
+                    for loader_name in loader_names
+                ],
+                tooltip="""Loader
+Defines what OpenPype loader will be used to load assets.
+Useable loader depends on current host's loader list.
+Field is case sensitive.
+"""
+            ),
+            attribute_definitions.TextDef(
+                "loader_args",
+                label="Loader Arguments",
+                default=options.get("loader_args"),
+                placeholder='{"camera":"persp", "lights":True}',
+                tooltip="""Loader
+Defines a dictionnary of arguments used to load assets.
+Useable arguments depend on current placeholder Loader.
+Field should be a valid python dict. Anything else will be ignored.
+"""
+            ),
+            attribute_definitions.NumberDef(
+                "order",
+                label="Order",
+                default=options.get("order") or 0,
+                decimals=0,
+                minimum=0,
+                maximum=999,
+                tooltip="""Order
+Order defines asset loading priority (0 to 999)
+Priority rule is : "lowest is first to load"."""
+            ),
+            attribute_definitions.UISeparatorDef(),
+            attribute_definitions.UILabelDef("Optional attributes"),
+            attribute_definitions.UISeparatorDef(),
+            attribute_definitions.TextDef(
+                "asset",
+                label="Asset filter",
+                default=options.get("asset"),
+                placeholder="regex filtering by asset name",
+                tooltip=(
+                    "Filtering assets by matching field regex to asset's name"
+                )
+            ),
+            attribute_definitions.TextDef(
+                "subset",
+                label="Subset filter",
+                default=options.get("subset"),
+                placeholder="regex filtering by subset name",
+                tooltip=(
+                    "Filtering assets by matching field regex to subset's name"
+                )
+            ),
+            attribute_definitions.TextDef(
+                "hierarchy",
+                label="Hierarchy filter",
+                default=options.get("hierarchy"),
+                placeholder="regex filtering by asset's hierarchy",
+                tooltip=(
+                    "Filtering assets by matching field asset's hierarchy"
+                )
+            )
+        ]
+
+
+class LoadPlaceholder(PlaceholderItem):
+    """Concrete implementation of AbstractPlaceholder for maya
+    """
+
+    def __init__(self, *args, **kwargs):
+        super(LoadPlaceholder, self).__init__(*args, **kwargs)
+        self._failed_representations = []
+
+    def parent_in_hierarchy(self, container):
+        """Parent loaded container to placeholder's parent.
+
+        ie : Set loaded content as placeholder's sibling
+
+        Args:
+            container (str): Placeholder loaded containers
+        """
+
+        if not container:
+            return
+
+        roots = cmds.sets(container, q=True)
+        nodes_to_parent = []
+        for root in roots:
+            if root.endswith("_RN"):
+                refRoot = cmds.referenceQuery(root, n=True)[0]
+                refRoot = cmds.listRelatives(refRoot, parent=True) or [refRoot]
+                nodes_to_parent.extend(refRoot)
+            elif root not in cmds.listSets(allSets=True):
+                nodes_to_parent.append(root)
+
+            elif not cmds.sets(root, q=True):
+                return
+
+        if self.data['parent']:
+            cmds.parent(nodes_to_parent, self.data['parent'])
+        # Move loaded nodes to correct index in outliner hierarchy
+        placeholder_form = cmds.xform(
+            self._scene_identifier,
+            q=True,
+            matrix=True,
+            worldSpace=True
+        )
+        for node in set(nodes_to_parent):
+            cmds.reorder(node, front=True)
+            cmds.reorder(node, relative=self.data['index'])
+            cmds.xform(node, matrix=placeholder_form, ws=True)
+
+        holding_sets = cmds.listSets(object=self._scene_identifier)
+        if not holding_sets:
+            return
+        for holding_set in holding_sets:
+            cmds.sets(roots, forceElement=holding_set)
+
+    def clean(self):
+        """Hide placeholder, parent them to root
+        add them to placeholder set and register placeholder's parent
+        to keep placeholder info available for future use
+        """
+
+        node = self._scene_identifier
+        if self.data['parent']:
+            cmds.setAttr(node + '.parent', self.data['parent'], type='string')
+        if cmds.getAttr(node + '.index') < 0:
+            cmds.setAttr(node + '.index', self.data['index'])
+
+        holding_sets = cmds.listSets(object=node)
+        if holding_sets:
+            for set in holding_sets:
+                cmds.sets(node, remove=set)
+
+        if cmds.listRelatives(node, p=True):
+            node = cmds.parent(node, world=True)[0]
+        cmds.sets(node, addElement=PLACEHOLDER_SET)
+        cmds.hide(node)
+        cmds.setAttr(node + '.hiddenInOutliner', True)
+
+    def get_representations(self, current_asset_doc, linked_asset_docs):
+        project_name = legacy_io.active_project()
+
+        builder_type = self.data["builder_type"]
+        if builder_type == "context_asset":
+            context_filters = {
+                "asset": [current_asset_doc["name"]],
+                "subset": [re.compile(self.data["subset"])],
+                "hierarchy": [re.compile(self.data["hierarchy"])],
+                "representations": [self.data["representation"]],
+                "family": [self.data["family"]]
+            }
+
+        elif builder_type != "linked_asset":
+            context_filters = {
+                "asset": [re.compile(self.data["asset"])],
+                "subset": [re.compile(self.data["subset"])],
+                "hierarchy": [re.compile(self.data["hierarchy"])],
+                "representation": [self.data["representation"]],
+                "family": [self.data["family"]]
+            }
+
+        else:
+            asset_regex = re.compile(self.data["asset"])
+            linked_asset_names = []
+            for asset_doc in linked_asset_docs:
+                asset_name = asset_doc["name"]
+                if asset_regex.match(asset_name):
+                    linked_asset_names.append(asset_name)
+
+            context_filters = {
+                "asset": linked_asset_names,
+                "subset": [re.compile(self.data["subset"])],
+                "hierarchy": [re.compile(self.data["hierarchy"])],
+                "representation": [self.data["representation"]],
+                "family": [self.data["family"]],
+            }
+
+        return list(get_representations(
+            project_name,
+            context_filters=context_filters
+        ))
+
+    def get_errors(self):
+        if not self._failed_representations:
+            return []
+        message = (
+            "Failed to load {} representations using Loader {}"
+        ).format(
+            len(self._failed_representations),
+            self.data["loader"]
+        )
+        return [message]
+
+    def load_failed(self, representation):
+        self._failed_representations.append(representation)
+
+    def load_succeed(self, container):
+        self.parent_in_hierarchy(container)

From 5fe6d2606ddc69e265f89584326ee19939c4b2c8 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 8 Sep 2022 18:32:20 +0200
Subject: [PATCH 032/147] added simple toolt to be able show attribute
 definitionis for workfile template builder

---
 .../tools/workfile_template_build/__init__.py |   5 +
 .../tools/workfile_template_build/window.py   | 232 ++++++++++++++++++
 2 files changed, 237 insertions(+)
 create mode 100644 openpype/tools/workfile_template_build/__init__.py
 create mode 100644 openpype/tools/workfile_template_build/window.py

diff --git a/openpype/tools/workfile_template_build/__init__.py b/openpype/tools/workfile_template_build/__init__.py
new file mode 100644
index 0000000000..70b8867759
--- /dev/null
+++ b/openpype/tools/workfile_template_build/__init__.py
@@ -0,0 +1,5 @@
+from .window import WorkfileBuildDialog
+
+__all__ = (
+    "WorkfileBuildDialog",
+)
diff --git a/openpype/tools/workfile_template_build/window.py b/openpype/tools/workfile_template_build/window.py
new file mode 100644
index 0000000000..a5cec465ec
--- /dev/null
+++ b/openpype/tools/workfile_template_build/window.py
@@ -0,0 +1,232 @@
+from Qt import QtWidgets
+
+from openpype import style
+from openpype.lib import Logger
+from openpype.pipeline import legacy_io
+from openpype.widgets.attribute_defs import AttributeDefinitionsWidget
+
+
+class WorkfileBuildDialog(QtWidgets.QDialog):
+    def __init__(self, host, builder, parent=None):
+        super(WorkfileBuildDialog, self).__init__(parent)
+        self.setWindowTitle("Workfile Placeholder Manager")
+
+        self._log = None
+
+        self._first_show = True
+        self._first_refreshed = False
+
+        self._builder = builder
+        self._host = host
+        # Mode can be 0 (create) or 1 (update)
+        # TODO write it a little bit better
+        self._mode = 0
+        self._update_item = None
+        self._last_selected_plugin = None
+
+        host_name = getattr(self._host, "name", None)
+        if not host_name:
+            host_name = legacy_io.Session.get("AVALON_APP") or "NA"
+        self._host_name = host_name
+
+        plugins_combo = QtWidgets.QComboBox(self)
+
+        content_widget = QtWidgets.QWidget(self)
+        content_layout = QtWidgets.QVBoxLayout(content_widget)
+        content_layout.setContentsMargins(0, 0, 0, 0)
+
+        btns_widget = QtWidgets.QWidget(self)
+        create_btn = QtWidgets.QPushButton("Create", btns_widget)
+        save_btn = QtWidgets.QPushButton("Save", btns_widget)
+        close_btn = QtWidgets.QPushButton("Close", btns_widget)
+
+        create_btn.setVisible(False)
+        save_btn.setVisible(False)
+
+        btns_layout = QtWidgets.QHBoxLayout(btns_widget)
+        btns_layout.addStretch(1)
+        btns_layout.addWidget(create_btn, 0)
+        btns_layout.addWidget(save_btn, 0)
+        btns_layout.addWidget(close_btn, 0)
+
+        main_layout = QtWidgets.QVBoxLayout(self)
+        main_layout.addWidget(plugins_combo, 0)
+        main_layout.addWidget(content_widget, 1)
+        main_layout.addWidget(btns_widget, 0)
+
+        create_btn.clicked.connect(self._on_create_click)
+        save_btn.clicked.connect(self._on_save_click)
+        close_btn.clicked.connect(self._on_close_click)
+        plugins_combo.currentIndexChanged.connect(self._on_plugin_change)
+
+        self._attr_defs_widget = None
+        self._plugins_combo = plugins_combo
+
+        self._content_widget = content_widget
+        self._content_layout = content_layout
+
+        self._create_btn = create_btn
+        self._save_btn = save_btn
+        self._close_btn = close_btn
+
+    @property
+    def log(self):
+        if self._log is None:
+            self._log = Logger.get_logger(self.__class__.__name__)
+        return self._log
+
+    def _clear_content_widget(self):
+        while self._content_layout.count() > 0:
+            item = self._content_layout.takeAt(0)
+            widget = item.widget
+            if widget:
+                widget.setVisible(False)
+                widget.deleteLater()
+
+    def _add_message_to_content(self, message):
+        msg_label = QtWidgets.QLabel(message, self._content_widget)
+        self._content_layout.addWidget(msg_label, 0)
+        self._content_layout.addStretch(1)
+
+    def refresh(self):
+        self._first_refreshed = True
+        self._clear_content_widget()
+
+        if not self._builder:
+            self._add_message_to_content((
+                "Host \"{}\" does not have implemented logic"
+                " for template workfile build."
+            ).format(self._host_name))
+            self._update_ui_visibility()
+            return
+
+        if self._mode == 1:
+            self._update_ui_visibility()
+            return
+
+        placeholder_plugins = builder.placeholder_plugins
+        if not placeholder_plugins:
+            self._add_message_to_content((
+                "Host \"{}\" does not have implemented plugins"
+                " for template workfile build."
+            ).format(self._host_name))
+            self._update_ui_visibility()
+            return
+
+        last_selected_plugin = self._last_selected_plugin
+        self._last_selected_plugin = None
+        self._plugins_combo.clear()
+        for identifier, plugin in placeholder_plugins.items():
+            label = plugin.label or plugin.identifier
+            self._plugins_combo.addItem(label, plugin.identifier)
+
+        index = self._plugins_combo.findData(last_selected_plugin)
+        if index < 0:
+            index = 0
+        self._plugins_combo.setCurrentIndex(index)
+        self._on_plugin_change()
+
+        self._update_ui_visibility()
+
+    def set_create_mode(self):
+        if self._mode == 0:
+            return
+
+        self._mode = 0
+        self._update_item = None
+        self.refresh()
+
+    def set_update_mode(self, update_item):
+        if self._mode == 1:
+            return
+
+        self._mode = 1
+        self._update_item = update_item
+        if not update_item:
+            self._add_message_to_content((
+                "Nothing to update."
+                " (You maybe don't have selected placeholder.)"
+            ))
+        else:
+            self._create_option_widgets(
+                update_item.plugin, update_item.to_dict()
+            )
+        self._update_ui_visibility()
+
+    def _create_option_widgets(self, plugin, options=None):
+        self._clear_content_widget()
+        attr_defs = plugin.get_placeholder_options(options)
+        widget = AttributeDefinitionsWidget(attr_defs, self._content_widget)
+        self._content_layout.addWidget(widget, 0)
+        self._content_layout.addStretch(1)
+        self._attr_defs_widget = widget
+
+    def _update_ui_visibility(self):
+        create_mode = self._mode == 0
+        self._plugins_combo.setVisible(create_mode)
+
+        if not self._builder:
+            self._save_btn.setVisible(False)
+            self._create_btn.setVisible(False)
+            return
+
+        save_enabled = not create_mode
+        if save_enabled:
+            save_enabled = self._update_item is not None
+        self._save_btn.setVisible(save_enabled)
+        self._create_btn.setVisible(create_mode)
+
+    def _on_plugin_change(self):
+        index = self._plugins_combo.currentIndex()
+        plugin_identifier = self._plugins_combo.itemData(index)
+        if plugin_identifier == self._last_selected_plugin:
+            return
+
+        self._last_selected_plugin = plugin_identifier
+        plugin = self._builder.placeholder_plugins.get(plugin_identifier)
+        self._create_option_widgets(plugin)
+
+    def _on_save_click(self):
+        options = self._attr_defs_widget.current_value()
+        plugin = self._builder.placeholder_plugins.get(
+            self._last_selected_plugin
+        )
+        # TODO much better error handling
+        try:
+            plugin.update_placeholder(self._update_item, options)
+            self.accept()
+        except Exception as exc:
+            self.log.warning("Something went wrong", exc_info=True)
+            dialog = QtWidgets.QMessageBox(self)
+            dialog.setWindowTitle("Something went wrong")
+            dialog.setText("Something went wrong")
+            dialog.exec_()
+
+    def _on_create_click(self):
+        options = self._attr_defs_widget.current_value()
+        plugin = self._builder.placeholder_plugins.get(
+            self._last_selected_plugin
+        )
+        # TODO much better error handling
+        try:
+            plugin.create_placeholder(options)
+            self.accept()
+        except Exception as exc:
+            self.log.warning("Something went wrong", exc_info=True)
+            dialog = QtWidgets.QMessageBox(self)
+            dialog.setWindowTitle("Something went wrong")
+            dialog.setText("Something went wrong")
+            dialog.exec_()
+
+    def _on_close_click(self):
+        self.reject()
+
+    def showEvent(self, event):
+        super(WorkfileBuildDialog, self).showEvent(event)
+        if not self._first_refreshed:
+            self.refresh()
+
+        if self._first_show:
+            self._first_show = False
+            self.setStyleSheet(style.load_stylesheet())
+            self.resize(390, 450)

From 379a5f5d787f3d4fff3f16e3d6d4b1f6adea390e Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Thu, 8 Sep 2022 22:52:08 +0200
Subject: [PATCH 033/147] Log file format in more human-readable manner instead
 of an integer

---
 .../maya/plugins/publish/validate_rendersettings.py   | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
index feb6a16dac..679535aa8c 100644
--- a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
+++ b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
@@ -10,6 +10,12 @@ import openpype.api
 from openpype.hosts.maya.api import lib
 
 
+def get_redshift_image_format_labels():
+    """Return nice labels for Redshift image formats."""
+    var = "$g_redshiftImageFormatLabels"
+    return mel.eval("{0}={0}".format(var))
+
+
 class ValidateRenderSettings(pyblish.api.InstancePlugin):
     """Validates the global render settings
 
@@ -191,10 +197,11 @@ class ValidateRenderSettings(pyblish.api.InstancePlugin):
                     pass
 
                 elif default_ext != aov_ext:
+                    labels = get_redshift_image_format_labels()
                     cls.log.error(("AOV file format is not the same "
                                    "as the one set globally "
-                                   "{} != {}").format(default_ext,
-                                                      aov_ext))
+                                   "{} != {}").format(labels[default_ext],
+                                                      labels[aov_ext]))
                     invalid = True
 
         if renderer == "renderman":

From d37f65e81ff2d88dcdd4bca07048fcea0d85849d Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Thu, 8 Sep 2022 22:55:36 +0200
Subject: [PATCH 034/147] Fix `prefix` is None issue

---
 openpype/hosts/maya/plugins/publish/validate_rendersettings.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
index 679535aa8c..eea60ef4f3 100644
--- a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
+++ b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
@@ -108,8 +108,9 @@ class ValidateRenderSettings(pyblish.api.InstancePlugin):
 
         # Get the node attributes for current renderer
         attrs = lib.RENDER_ATTRS.get(renderer, lib.RENDER_ATTRS['default'])
+        # Prefix attribute can return None when a value was never set
         prefix = lib.get_attr_in_layer(cls.ImagePrefixes[renderer],
-                                       layer=layer)
+                                       layer=layer) or ""
         padding = lib.get_attr_in_layer("{node}.{padding}".format(**attrs),
                                         layer=layer)
 

From 4d84a06bd323425c7c033400853a058c983b4e32 Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Thu, 8 Sep 2022 22:57:46 +0200
Subject: [PATCH 035/147] Repair defaultRenderGlobals.animation (must be
 enabled)

---
 openpype/hosts/maya/plugins/publish/validate_rendersettings.py | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
index eea60ef4f3..dcf77ad1f7 100644
--- a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
+++ b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
@@ -302,6 +302,9 @@ class ValidateRenderSettings(pyblish.api.InstancePlugin):
             default = lib.RENDER_ATTRS['default']
             render_attrs = lib.RENDER_ATTRS.get(renderer, default)
 
+            # Repair animation must be enabled
+            cmds.setAttr("defaultRenderGlobals.animation", True)
+
             # Repair prefix
             if renderer != "renderman":
                 node = render_attrs["node"]

From fea33ee4966a0e7f00792bdf98b73515976a334d Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Thu, 8 Sep 2022 23:04:41 +0200
Subject: [PATCH 036/147] Clarify log message which of the values is AOV format
 and which is global

---
 .../hosts/maya/plugins/publish/validate_rendersettings.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
index dcf77ad1f7..ed4a076302 100644
--- a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
+++ b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
@@ -199,10 +199,10 @@ class ValidateRenderSettings(pyblish.api.InstancePlugin):
 
                 elif default_ext != aov_ext:
                     labels = get_redshift_image_format_labels()
-                    cls.log.error(("AOV file format is not the same "
-                                   "as the one set globally "
-                                   "{} != {}").format(labels[default_ext],
-                                                      labels[aov_ext]))
+                    cls.log.error(
+                        "AOV file format {} does not match global file format "
+                        "{}".format(labels[default_ext], labels[aov_ext])
+                    )
                     invalid = True
 
         if renderer == "renderman":

From 1f8887eabb2a68c08af178d35f408e6a3eb5acfc Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Thu, 8 Sep 2022 23:05:03 +0200
Subject: [PATCH 037/147] Cosmetics

---
 openpype/hosts/maya/plugins/publish/validate_rendersettings.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
index ed4a076302..7f0985f69b 100644
--- a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
+++ b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
@@ -337,8 +337,7 @@ class ValidateRenderSettings(pyblish.api.InstancePlugin):
                 cmds.optionMenuGrp("vrayRenderElementSeparator",
                                    v=instance.data.get("aovSeparator", "_"))
                 cmds.setAttr(
-                    "{}.fileNameRenderElementSeparator".format(
-                        node),
+                    "{}.fileNameRenderElementSeparator".format(node),
                     instance.data.get("aovSeparator", "_"),
                     type="string"
                 )

From 7ca64b67c39eff858028f2aa52fca2d3b6de8f90 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:22:00 +0200
Subject: [PATCH 038/147] modified attr defs creation

---
 .../hosts/maya/api/new_template_builder.py    | 33 +++++++++++--------
 1 file changed, 20 insertions(+), 13 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index 023f240061..06d1cf0fd7 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -265,6 +265,7 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
         return [
             attribute_definitions.UISeparatorDef(),
             attribute_definitions.UILabelDef("Main attributes"),
+            attribute_definitions.UISeparatorDef(),
 
             attribute_definitions.EnumDef(
                 "builder_type",
@@ -307,22 +308,26 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
                     (loader_name, loader_name)
                     for loader_name in loader_names
                 ],
-                tooltip="""Loader
-Defines what OpenPype loader will be used to load assets.
-Useable loader depends on current host's loader list.
-Field is case sensitive.
-"""
+                tooltip=(
+                    "Loader"
+                    "\nDefines what OpenPype loader will be used to"
+                    " load assets."
+                    "\nUseable loader depends on current host's loader list."
+                    "\nField is case sensitive."
+                )
             ),
             attribute_definitions.TextDef(
                 "loader_args",
                 label="Loader Arguments",
                 default=options.get("loader_args"),
                 placeholder='{"camera":"persp", "lights":True}',
-                tooltip="""Loader
-Defines a dictionnary of arguments used to load assets.
-Useable arguments depend on current placeholder Loader.
-Field should be a valid python dict. Anything else will be ignored.
-"""
+                tooltip=(
+                    "Loader"
+                    "\nDefines a dictionnary of arguments used to load assets."
+                    "\nUseable arguments depend on current placeholder Loader."
+                    "\nField should be a valid python dict."
+                    " Anything else will be ignored."
+                )
             ),
             attribute_definitions.NumberDef(
                 "order",
@@ -331,9 +336,11 @@ Field should be a valid python dict. Anything else will be ignored.
                 decimals=0,
                 minimum=0,
                 maximum=999,
-                tooltip="""Order
-Order defines asset loading priority (0 to 999)
-Priority rule is : "lowest is first to load"."""
+                tooltip=(
+                    "Order"
+                    "\nOrder defines asset loading priority (0 to 999)"
+                    "\nPriority rule is : \"lowest is first to load\"."
+                )
             ),
             attribute_definitions.UISeparatorDef(),
             attribute_definitions.UILabelDef("Optional attributes"),

From f3ce64c1893bc2ea1b81fa254b6a8bc8734b587d Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:22:19 +0200
Subject: [PATCH 039/147] copied placeholder name creation

---
 .../hosts/maya/api/new_template_builder.py    | 25 +++++++++++++++++--
 1 file changed, 23 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index 06d1cf0fd7..36a74e9b9a 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -1,4 +1,6 @@
 import re
+import json
+
 from maya import cmds
 
 from openpype.client import get_representations
@@ -146,8 +148,27 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
         return placeholder_data
 
     def _create_placeholder_name(self, placeholder_data):
-        # TODO implement placeholder name logic
-        return "Placeholder"
+        placeholder_name_parts = placeholder_data["builder_type"].split("_")
+
+        pos = 1
+        # add famlily in any
+        placeholder_family = placeholder_data["family"]
+        if placeholder_family:
+            placeholder_name_parts.insert(pos, placeholder_family)
+            pos += 1
+
+        # add loader arguments if any
+        loader_args = placeholder_data["loader_args"]
+        if loader_args:
+            loader_args = json.loads(loader_args.replace('\'', '\"'))
+            values = [v for v in loader_args.values()]
+            for value in values:
+                placeholder_name_parts.insert(pos, value)
+                pos += 1
+
+        placeholder_name = "_".join(placeholder_name_parts)
+
+        return placeholder_name.capitalize()
 
     def create_placeholder(self, placeholder_data):
         selection = cmds.ls(selection=True)

From 88f16988a4786c5b8144ca1d0988c27b973637e3 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:22:57 +0200
Subject: [PATCH 040/147] fix build dialog and renamed it to placeholder dialog

---
 .../tools/workfile_template_build/__init__.py |  4 +-
 .../tools/workfile_template_build/window.py   | 40 ++++++++++++-------
 2 files changed, 27 insertions(+), 17 deletions(-)

diff --git a/openpype/tools/workfile_template_build/__init__.py b/openpype/tools/workfile_template_build/__init__.py
index 70b8867759..82a22aea50 100644
--- a/openpype/tools/workfile_template_build/__init__.py
+++ b/openpype/tools/workfile_template_build/__init__.py
@@ -1,5 +1,5 @@
-from .window import WorkfileBuildDialog
+from .window import WorkfileBuildPlaceholderDialog
 
 __all__ = (
-    "WorkfileBuildDialog",
+    "WorkfileBuildPlaceholderDialog",
 )
diff --git a/openpype/tools/workfile_template_build/window.py b/openpype/tools/workfile_template_build/window.py
index a5cec465ec..2e531026cf 100644
--- a/openpype/tools/workfile_template_build/window.py
+++ b/openpype/tools/workfile_template_build/window.py
@@ -6,9 +6,9 @@ from openpype.pipeline import legacy_io
 from openpype.widgets.attribute_defs import AttributeDefinitionsWidget
 
 
-class WorkfileBuildDialog(QtWidgets.QDialog):
+class WorkfileBuildPlaceholderDialog(QtWidgets.QDialog):
     def __init__(self, host, builder, parent=None):
-        super(WorkfileBuildDialog, self).__init__(parent)
+        super(WorkfileBuildPlaceholderDialog, self).__init__(parent)
         self.setWindowTitle("Workfile Placeholder Manager")
 
         self._log = None
@@ -78,7 +78,7 @@ class WorkfileBuildDialog(QtWidgets.QDialog):
     def _clear_content_widget(self):
         while self._content_layout.count() > 0:
             item = self._content_layout.takeAt(0)
-            widget = item.widget
+            widget = item.widget()
             if widget:
                 widget.setVisible(False)
                 widget.deleteLater()
@@ -90,6 +90,7 @@ class WorkfileBuildDialog(QtWidgets.QDialog):
 
     def refresh(self):
         self._first_refreshed = True
+
         self._clear_content_widget()
 
         if not self._builder:
@@ -100,11 +101,19 @@ class WorkfileBuildDialog(QtWidgets.QDialog):
             self._update_ui_visibility()
             return
 
+        placeholder_plugins = self._builder.placeholder_plugins
+
         if self._mode == 1:
+            self._last_selected_plugin
+            plugin = self._builder.placeholder_plugins.get(
+                self._last_selected_plugin
+            )
+            self._create_option_widgets(
+                plugin, self._update_item.to_dict()
+            )
             self._update_ui_visibility()
             return
 
-        placeholder_plugins = builder.placeholder_plugins
         if not placeholder_plugins:
             self._add_message_to_content((
                 "Host \"{}\" does not have implemented plugins"
@@ -142,15 +151,16 @@ class WorkfileBuildDialog(QtWidgets.QDialog):
 
         self._mode = 1
         self._update_item = update_item
-        if not update_item:
-            self._add_message_to_content((
-                "Nothing to update."
-                " (You maybe don't have selected placeholder.)"
-            ))
-        else:
-            self._create_option_widgets(
-                update_item.plugin, update_item.to_dict()
-            )
+        if update_item:
+            self._last_selected_plugin = update_item.plugin.identifier
+            self.refresh()
+            return
+
+        self._clear_content_widget()
+        self._add_message_to_content((
+            "Nothing to update."
+            " (You maybe don't have selected placeholder.)"
+        ))
         self._update_ui_visibility()
 
     def _create_option_widgets(self, plugin, options=None):
@@ -160,6 +170,7 @@ class WorkfileBuildDialog(QtWidgets.QDialog):
         self._content_layout.addWidget(widget, 0)
         self._content_layout.addStretch(1)
         self._attr_defs_widget = widget
+        self._last_selected_plugin = plugin.identifier
 
     def _update_ui_visibility(self):
         create_mode = self._mode == 0
@@ -182,7 +193,6 @@ class WorkfileBuildDialog(QtWidgets.QDialog):
         if plugin_identifier == self._last_selected_plugin:
             return
 
-        self._last_selected_plugin = plugin_identifier
         plugin = self._builder.placeholder_plugins.get(plugin_identifier)
         self._create_option_widgets(plugin)
 
@@ -222,7 +232,7 @@ class WorkfileBuildDialog(QtWidgets.QDialog):
         self.reject()
 
     def showEvent(self, event):
-        super(WorkfileBuildDialog, self).showEvent(event)
+        super(WorkfileBuildPlaceholderDialog, self).showEvent(event)
         if not self._first_refreshed:
             self.refresh()
 

From 8f2bf758f3963badfa6a211211eda4ea5efe9326 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:23:31 +0200
Subject: [PATCH 041/147] fixed get of value from attribute defs widget

---
 openpype/widgets/attribute_defs/widgets.py | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/openpype/widgets/attribute_defs/widgets.py b/openpype/widgets/attribute_defs/widgets.py
index 60ae952553..dc697b08a6 100644
--- a/openpype/widgets/attribute_defs/widgets.py
+++ b/openpype/widgets/attribute_defs/widgets.py
@@ -108,10 +108,12 @@ class AttributeDefinitionsWidget(QtWidgets.QWidget):
 
         row = 0
         for attr_def in attr_defs:
-            if attr_def.key in self._current_keys:
-                raise KeyError("Duplicated key \"{}\"".format(attr_def.key))
+            if not isinstance(attr_def, UIDef):
+                if attr_def.key in self._current_keys:
+                    raise KeyError(
+                        "Duplicated key \"{}\"".format(attr_def.key))
 
-            self._current_keys.add(attr_def.key)
+                self._current_keys.add(attr_def.key)
             widget = create_widget_for_attr_def(attr_def, self)
 
             expand_cols = 2

From 187eaaec2d9f17d01cff4cc43bd3b01c58d679e4 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:24:37 +0200
Subject: [PATCH 042/147] renamed 'process_scene_placeholders' to
 'populate_scene_placeholders'

---
 .../pipeline/workfile/new_template_loader.py  | 19 +++++++++++--------
 1 file changed, 11 insertions(+), 8 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index b1231c2308..a59394b09c 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -233,7 +233,7 @@ class AbstractTemplateLoader:
         Import template in current host.
 
         Should load the content of template into scene so
-        'process_scene_placeholders' can be started.
+        'populate_scene_placeholders' can be started.
 
         Args:
             template_path (str): Fullpath for current task and
@@ -270,7 +270,7 @@ class AbstractTemplateLoader:
             plugin = plugins_by_identifier[identifier]
             plugin.prepare_placeholders(placeholders)
 
-    def process_scene_placeholders(self, level_limit=None):
+    def populate_scene_placeholders(self, level_limit=None):
         """Find placeholders in scene using plugins and process them.
 
         This should happen after 'import_template'.
@@ -285,8 +285,7 @@ class AbstractTemplateLoader:
         placeholder's 'scene_identifier'.
 
         Args:
-            level_limit (int): Level of loops that can happen. By default
-                if is possible to have infinite nested placeholder processing.
+            level_limit (int): Level of loops that can happen. Default is 1000.
         """
 
         if not self.placeholder_plugins:
@@ -298,6 +297,11 @@ class AbstractTemplateLoader:
             self.log.warning("No placeholders were found.")
             return
 
+        # Avoid infinite loop
+        # - 1000 iterations of placeholders processing must be enough
+        if not level_limit:
+            level_limit = 1000
+
         placeholder_by_scene_id = {
             placeholder.scene_identifier: placeholder
             for placeholder in placeholders
@@ -335,10 +339,9 @@ class AbstractTemplateLoader:
             # Clear shared data before getting new placeholders
             self.clear_shared_data()
 
-            if level_limit:
-                iter_counter += 1
-                if iter_counter >= level_limit:
-                    break
+            iter_counter += 1
+            if iter_counter >= level_limit:
+                break
 
             all_processed = True
             collected_placeholders = self.get_placeholders()

From 1ee1c2858856eae18b38244ea179580bb5ba2fb9 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:24:54 +0200
Subject: [PATCH 043/147] added method to build template

---
 openpype/pipeline/workfile/new_template_loader.py | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index a59394b09c..3fee84a4e8 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -227,6 +227,12 @@ class AbstractTemplateLoader:
             key=lambda i: i.order
         ))
 
+    def build_template(self, template_path=None, level_limit=None):
+        if template_path is None:
+            template_path = self.get_template_path()
+        self.import_template(template_path)
+        self.populate_scene_placeholders(level_limit)
+
     @abstractmethod
     def import_template(self, template_path):
         """

From 326d21d86a2d99f36bc8f420b20b271bd0a894b1 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:25:11 +0200
Subject: [PATCH 044/147] use 'get_placeholder_plugin_classes' from host

---
 openpype/pipeline/workfile/new_template_loader.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 3fee84a4e8..dbf58fe15d 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -174,7 +174,7 @@ class AbstractTemplateLoader:
 
         if self._placeholder_plugins is None:
             placeholder_plugins = {}
-            for cls in self.get_placeholder_plugin_classes():
+            for cls in self.host.get_placeholder_plugin_classes():
                 try:
                     plugin = cls(self)
                     placeholder_plugins[plugin.identifier] = plugin

From ffab250bf822a6440670ece4d815199f4826a52a Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:26:45 +0200
Subject: [PATCH 045/147] changed how 'get_placeholder_plugin_classes' is
 implemented

---
 .../pipeline/workfile/new_template_loader.py  | 48 ++++++++++++-------
 1 file changed, 31 insertions(+), 17 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index dbf58fe15d..64e3021f00 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -8,7 +8,12 @@ import six
 from openpype.client import get_asset_by_name
 from openpype.settings import get_project_settings
 from openpype.host import HostBase
-from openpype.lib import Logger, StringTemplate, filter_profiles
+from openpype.lib import (
+    Logger,
+    StringTemplate,
+    filter_profiles,
+)
+from openpype.lib.attribute_definitions import get_attributes_keys
 from openpype.pipeline import legacy_io, Anatomy
 from openpype.pipeline.load import get_loaders_by_name
 from openpype.pipeline.create import get_legacy_creator_by_name
@@ -31,12 +36,26 @@ class AbstractTemplateLoader:
     _log = None
 
     def __init__(self, host):
-        # Store host
-        self._host = host
+        # Prepare context information
+        project_name = legacy_io.active_project()
+        asset_name = legacy_io.Session["AVALON_ASSET"]
+        task_name = legacy_io.Session["AVALON_TASK"]
+        current_asset_doc = get_asset_by_name(project_name, asset_name)
+        task_type = (
+            current_asset_doc
+            .get("data", {})
+            .get("tasks", {})
+            .get(task_name, {})
+            .get("type")
+        )
+
+        # Get host name
         if isinstance(host, HostBase):
             host_name = host.name
         else:
             host_name = os.environ.get("AVALON_APP")
+
+        self._host = host
         self._host_name = host_name
 
         # Shared data across placeholder plugins
@@ -47,29 +66,24 @@ class AbstractTemplateLoader:
         self._loaders_by_name = None
         self._creators_by_name = None
 
-        project_name = legacy_io.active_project()
-        asset_name = legacy_io.Session["AVALON_ASSET"]
-
         self.current_asset = asset_name
         self.project_name = project_name
-        self.task_name = legacy_io.Session["AVALON_TASK"]
-        self.current_asset_doc = get_asset_by_name(project_name, asset_name)
-        self.task_type = (
-            self.current_asset_doc
-            .get("data", {})
-            .get("tasks", {})
-            .get(self.task_name, {})
-            .get("type")
-        )
+        self.task_name = task_name
+        self.current_asset_doc = current_asset_doc
+        self.task_type = task_type
 
-    @abstractmethod
     def get_placeholder_plugin_classes(self):
         """Get placeholder plugin classes that can be used to build template.
 
+        Default implementation looks for 'get_placeholder_plugin_classes' on
+        host.
+
         Returns:
             List[PlaceholderPlugin]: Plugin classes available for host.
         """
 
+        if hasattr(self._host, "get_placeholder_plugin_classes"):
+            return self._host.get_placeholder_plugin_classes()
         return []
 
     @property
@@ -174,7 +188,7 @@ class AbstractTemplateLoader:
 
         if self._placeholder_plugins is None:
             placeholder_plugins = {}
-            for cls in self.host.get_placeholder_plugin_classes():
+            for cls in self.get_placeholder_plugin_classes():
                 try:
                     plugin = cls(self)
                     placeholder_plugins[plugin.identifier] = plugin

From d5346a14d90f7746d7ee589e17d6315c0f7baaea Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 12:28:32 +0200
Subject: [PATCH 046/147] implemented helper functions to receive placeholder
 option keys

---
 openpype/lib/attribute_definitions.py         | 21 +++++++++++++++++++
 .../pipeline/workfile/new_template_loader.py  | 11 ++++++++++
 2 files changed, 32 insertions(+)

diff --git a/openpype/lib/attribute_definitions.py b/openpype/lib/attribute_definitions.py
index 17658eef93..cbd53d1f07 100644
--- a/openpype/lib/attribute_definitions.py
+++ b/openpype/lib/attribute_definitions.py
@@ -9,6 +9,27 @@ import six
 import clique
 
 
+def get_attributes_keys(attribute_definitions):
+    """Collect keys from list of attribute definitions.
+
+    Args:
+        attribute_definitions (List[AbtractAttrDef]): Objects of attribute
+            definitions.
+
+    Returns:
+        Set[str]: Keys that will be created using passed attribute definitions.
+    """
+
+    keys = set()
+    if not attribute_definitions:
+        return keys
+
+    for attribute_def in attribute_definitions:
+        if not isinstance(attribute_def, UIDef):
+            keys.add(attribute_def.key)
+    return keys
+
+
 class AbstractAttrDefMeta(ABCMeta):
     """Meta class to validate existence of 'key' attribute.
 
diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 64e3021f00..21bfa3650d 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -547,6 +547,17 @@ class PlaceholderPlugin(object):
 
         return []
 
+    def get_placeholder_keys(self):
+        """Get placeholder keys that are stored in scene.
+
+        Returns:
+            Set[str]: Key of placeholder keys that are stored in scene.
+        """
+
+        option_keys = get_attributes_keys(self.get_placeholder_options())
+        option_keys.add("plugin_identifier")
+        return option_keys
+
     def prepare_placeholders(self, placeholders):
         """Preparation part of placeholders.
 

From 6401c4064150f316ae96cd39585edf6b77a4cdac Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 13:14:05 +0200
Subject: [PATCH 047/147] changed how placeholders are cached

---
 .../hosts/maya/api/new_template_builder.py    | 39 +++++++++++--------
 1 file changed, 22 insertions(+), 17 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index 36a74e9b9a..b25d75452c 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -44,7 +44,7 @@ class MayaTemplateLoader(AbstractTemplateLoader):
         cmds.sets(name=PLACEHOLDER_SET, empty=True)
         cmds.file(path, i=True, returnNewNodes=True)
 
-        cmds.setAttr(PLACEHOLDER_SET + '.hiddenInOutliner', True)
+        cmds.setAttr(PLACEHOLDER_SET + ".hiddenInOutliner", True)
 
         # This should be handled by creators
         # for set_name in cmds.listSets(allSets=True):
@@ -116,10 +116,13 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
         placeholder_nodes = self.builder.get_shared_data("placeholder_nodes")
         if placeholder_nodes is None:
             attributes = cmds.ls("*.plugin_identifier", long=True)
-            placeholder_nodes = [
-                self._parse_placeholder_node_data(attribute.rpartition(".")[0])
-                for attribute in attributes
-            ]
+            placeholder_nodes = {}
+            for attribute in attributes:
+                node_name = attribute.rpartition(".")[0]
+                placeholder_nodes[node_name] = (
+                    self._parse_placeholder_node_data(node_name)
+                )
+
             self.builder.set_shared_data(
                 "placeholder_nodes", placeholder_nodes
             )
@@ -182,7 +185,6 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
         placeholder_name = self._create_placeholder_name(placeholder_data)
 
         placeholder = cmds.spaceLocator(name=placeholder_name)[0]
-
         # TODO: this can crash if selection can't be used
         cmds.parent(placeholder, selection[0])
 
@@ -221,20 +223,23 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
                 new_values[key] = value
                 placeholder_item.data[key] = value
 
+        for key in new_values.keys():
+            cmds.deleteAttr(node_name + "." + key)
+
         imprint(node_name, new_values)
 
     def collect_placeholders(self):
-        filtered_placeholders = []
-        for placeholder_data in self._collect_scene_placeholders():
+        output = []
+        scene_placeholders = self._collect_scene_placeholders()
+        for node_name, placeholder_data in scene_placeholders.items():
             if placeholder_data.get("plugin_identifier") != self.identifier:
                 continue
 
-            filtered_placeholders.append(placeholder_data)
-
-        output = []
-        for placeholder_data in filtered_placeholders:
             # TODO do data validations and maybe updgrades if are invalid
-            output.append(LoadPlaceholder(placeholder_data))
+            output.append(
+                LoadPlaceholder(node_name, placeholder_data, self)
+            )
+
         return output
 
     def process_placeholder(self, placeholder):
@@ -429,8 +434,8 @@ class LoadPlaceholder(PlaceholderItem):
             elif not cmds.sets(root, q=True):
                 return
 
-        if self.data['parent']:
-            cmds.parent(nodes_to_parent, self.data['parent'])
+        if self.data["parent"]:
+            cmds.parent(nodes_to_parent, self.data["parent"])
         # Move loaded nodes to correct index in outliner hierarchy
         placeholder_form = cmds.xform(
             self._scene_identifier,
@@ -440,7 +445,7 @@ class LoadPlaceholder(PlaceholderItem):
         )
         for node in set(nodes_to_parent):
             cmds.reorder(node, front=True)
-            cmds.reorder(node, relative=self.data['index'])
+            cmds.reorder(node, relative=self.data["index"])
             cmds.xform(node, matrix=placeholder_form, ws=True)
 
         holding_sets = cmds.listSets(object=self._scene_identifier)
@@ -470,7 +475,7 @@ class LoadPlaceholder(PlaceholderItem):
             node = cmds.parent(node, world=True)[0]
         cmds.sets(node, addElement=PLACEHOLDER_SET)
         cmds.hide(node)
-        cmds.setAttr(node + '.hiddenInOutliner', True)
+        cmds.setAttr(node + ".hiddenInOutliner", True)
 
     def get_representations(self, current_asset_doc, linked_asset_docs):
         project_name = legacy_io.active_project()

From 5ccda391e4e4c980915c8f6954b5b43aaf454d86 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 13:23:10 +0200
Subject: [PATCH 048/147] changed loaders

---
 openpype/hosts/maya/api/new_template_builder.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index b25d75452c..bc1a0250a8 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -286,7 +286,12 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
 
     def get_placeholder_options(self, options=None):
         loaders_by_name = self.builder.get_loaders_by_name()
-        loader_names = list(sorted(loaders_by_name.keys()))
+        loader_items = [
+            (loader_name, loader.label or loader_name)
+            for loader_name, loader in loaders_by_name.items()
+        ]
+
+        loader_items = list(sorted(loader_items, key=lambda i: i[0]))
         options = options or {}
         return [
             attribute_definitions.UISeparatorDef(),
@@ -330,10 +335,7 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
                 "loader",
                 label="Loader",
                 default=options.get("loader"),
-                items=[
-                    (loader_name, loader_name)
-                    for loader_name in loader_names
-                ],
+                items=loader_items,
                 tooltip=(
                     "Loader"
                     "\nDefines what OpenPype loader will be used to"

From e5654595a83d88a5ac4dcea8bd7c9b7fe360f3bd Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 13:31:55 +0200
Subject: [PATCH 049/147] implemented 'get_workfile_build_placeholder_plugins'
 for maya

---
 openpype/hosts/maya/api/pipeline.py               | 6 ++++++
 openpype/pipeline/workfile/new_template_loader.py | 8 ++++----
 2 files changed, 10 insertions(+), 4 deletions(-)

diff --git a/openpype/hosts/maya/api/pipeline.py b/openpype/hosts/maya/api/pipeline.py
index c963b5d996..2492e75b36 100644
--- a/openpype/hosts/maya/api/pipeline.py
+++ b/openpype/hosts/maya/api/pipeline.py
@@ -35,6 +35,7 @@ from openpype.hosts.maya import MAYA_ROOT_DIR
 from openpype.hosts.maya.lib import copy_workspace_mel
 
 from . import menu, lib
+from .new_template_builder import MayaLoadPlaceholderPlugin
 from .workio import (
     open_file,
     save_file,
@@ -123,6 +124,11 @@ class MayaHost(HostBase, IWorkfileHost, ILoadHost):
     def get_containers(self):
         return ls()
 
+    def get_workfile_build_placeholder_plugins(self):
+        return [
+            MayaLoadPlaceholderPlugin
+        ]
+
     @contextlib.contextmanager
     def maintained_selection(self):
         with lib.maintained_selection():
diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 21bfa3650d..8b64306c18 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -75,15 +75,15 @@ class AbstractTemplateLoader:
     def get_placeholder_plugin_classes(self):
         """Get placeholder plugin classes that can be used to build template.
 
-        Default implementation looks for 'get_placeholder_plugin_classes' on
-        host.
+        Default implementation looks for method
+            'get_workfile_build_placeholder_plugins' on host.
 
         Returns:
             List[PlaceholderPlugin]: Plugin classes available for host.
         """
 
-        if hasattr(self._host, "get_placeholder_plugin_classes"):
-            return self._host.get_placeholder_plugin_classes()
+        if hasattr(self._host, "get_workfile_build_placeholder_plugins"):
+            return self._host.get_workfile_build_placeholder_plugins()
         return []
 
     @property

From d3eca627de790a3e73c58cf96ff03f14bf2f7d96 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 16:52:39 +0200
Subject: [PATCH 050/147] added some more options for shared data

---
 .../pipeline/workfile/new_template_loader.py  | 122 ++++++++++++++++--
 1 file changed, 110 insertions(+), 12 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 8b64306c18..baca11d730 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -60,6 +60,7 @@ class AbstractTemplateLoader:
 
         # Shared data across placeholder plugins
         self._shared_data = {}
+        self._shared_populate_data = {}
 
         # Where created objects of placeholder plugins will be stored
         self._placeholder_plugins = None
@@ -121,14 +122,7 @@ class AbstractTemplateLoader:
         self._loaders_by_name = None
         self._creators_by_name = None
         self.clear_shared_data()
-
-    def clear_shared_data(self):
-        """Clear shared data.
-
-        Method only clear shared data to default state.
-        """
-
-        self._shared_data = {}
+        self.clear_shared_populate_data()
 
     def get_loaders_by_name(self):
         if self._loaders_by_name is None:
@@ -147,8 +141,6 @@ class AbstractTemplateLoader:
         items if the storing is unified but each placeholder plugin would have
         to call it again.
 
-        Shared data are cleaned up on specific callbacks.
-
         Args:
             key (str): Key under which are shared data stored.
 
@@ -169,8 +161,6 @@ class AbstractTemplateLoader:
         - wrong: 'asset'
         - good: 'asset_name'
 
-        Shared data are cleaned up on specific callbacks.
-
         Args:
             key (str): Key under which is key stored.
             value (Any): Value that should be stored under the key.
@@ -178,6 +168,72 @@ class AbstractTemplateLoader:
 
         self._shared_data[key] = value
 
+    def clear_shared_data(self):
+        """Clear shared data.
+
+        Method only clear shared data to default state.
+        """
+
+        self._shared_data = {}
+
+    def clear_shared_populate_data(self):
+        """Receive shared data across plugins and placeholders.
+
+        These data are cleared after each loop of populating of template.
+
+        This can be used to scroll scene only once to look for placeholder
+        items if the storing is unified but each placeholder plugin would have
+        to call it again.
+
+        Args:
+            key (str): Key under which are shared data stored.
+
+        Returns:
+            Union[None, Any]: None if key was not set.
+        """
+
+        self._shared_populate_data = {}
+
+    def get_shared_populate_data(self, key):
+        """Store share populate data across plugins and placeholders.
+
+        These data are cleared after each loop of populating of template.
+
+        Store data that can be afterwards accessed from any future call. It
+        is good practice to check if the same value is not already stored under
+        different key or if the key is not already used for something else.
+
+        Key should be self explanatory to content.
+        - wrong: 'asset'
+        - good: 'asset_name'
+
+        Args:
+            key (str): Key under which is key stored.
+            value (Any): Value that should be stored under the key.
+        """
+
+        return self._shared_populate_data.get(key)
+
+    def set_shared_populate_data(self, key, value):
+        """Store share populate data across plugins and placeholders.
+
+        These data are cleared after each loop of populating of template.
+
+        Store data that can be afterwards accessed from any future call. It
+        is good practice to check if the same value is not already stored under
+        different key or if the key is not already used for something else.
+
+        Key should be self explanatory to content.
+        - wrong: 'asset'
+        - good: 'asset_name'
+
+        Args:
+            key (str): Key under which is key stored.
+            value (Any): Value that should be stored under the key.
+        """
+
+        self._shared_populate_data[key] = value
+
     @property
     def placeholder_plugins(self):
         """Access to initialized placeholder plugins.
@@ -636,6 +692,48 @@ class PlaceholderPlugin(object):
         plugin_data[key] = value
         self.builder.set_shared_data(self.identifier, plugin_data)
 
+    def get_plugin_shared_populate_data(self, key):
+        """Receive shared data across plugin and placeholders.
+
+        Using shared populate data from builder but stored under plugin
+        identifier.
+
+        Shared populate data are cleaned up during populate while loop.
+
+        Args:
+            key (str): Key under which are shared data stored.
+
+        Returns:
+            Union[None, Any]: None if key was not set.
+        """
+
+        plugin_data = self.builder.get_shared_populate_data(self.identifier)
+        if plugin_data is None:
+            return None
+        return plugin_data.get(key)
+
+    def set_plugin_shared_populate_data(self, key, value):
+        """Store share data across plugin and placeholders.
+
+        Using shared data from builder but stored under plugin identifier.
+
+        Key should be self explanatory to content.
+        - wrong: 'asset'
+        - good: 'asset_name'
+
+        Shared populate data are cleaned up during populate while loop.
+
+        Args:
+            key (str): Key under which is key stored.
+            value (Any): Value that should be stored under the key.
+        """
+
+        plugin_data = self.builder.get_shared_populate_data(self.identifier)
+        if plugin_data is None:
+            plugin_data = {}
+        plugin_data[key] = value
+        self.builder.set_shared_populate_data(self.identifier, plugin_data)
+
 
 class PlaceholderItem(object):
     """Item representing single item in scene that is a placeholder to process.

From e45fd5f99507d4cf6c8e4b7220651741b3bf564e Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 16:53:06 +0200
Subject: [PATCH 051/147] changed 'process_placeholder' to
 'populate_placeholder'

---
 openpype/pipeline/workfile/new_template_loader.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index baca11d730..953b7771b2 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -404,7 +404,7 @@ class AbstractTemplateLoader:
                 placeholder.set_in_progress()
                 placeholder_plugin = placeholder.plugin
                 try:
-                    placeholder_plugin.process_placeholder(placeholder)
+                    placeholder_plugin.populate_placeholder(placeholder)
 
                 except Exception as exc:
                     placeholder.set_error(exc)
@@ -625,7 +625,7 @@ class PlaceholderPlugin(object):
         pass
 
     @abstractmethod
-    def process_placeholder(self, placeholder):
+    def populate_placeholder(self, placeholder):
         """Process single placeholder item.
 
         Processing of placeholders is defined by their order thus can't be

From 77d8d1b1ce05872a613e3e54ff1d2e182d4e5eb4 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 16:53:21 +0200
Subject: [PATCH 052/147] implemented basics of update template placeholder

---
 .../pipeline/workfile/new_template_loader.py  | 57 ++++++++++++-------
 1 file changed, 38 insertions(+), 19 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 953b7771b2..b97e48dcba 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -303,6 +303,37 @@ class AbstractTemplateLoader:
         self.import_template(template_path)
         self.populate_scene_placeholders(level_limit)
 
+    def update_template(self):
+        """Go through existing placeholders in scene and update them.
+
+        This could not make sense for all plugin types so this is optional
+        logic for plugins.
+
+        Note:
+            Logic is not importing the template again but using placeholders
+                that were already available. We should maybe change the method
+                name.
+
+        Question:
+            Should this also handle subloops as it is possible that another
+                template is loaded during processing?
+        """
+
+        if not self.placeholder_plugins:
+            self.log.info("There are no placeholder plugins available.")
+            return
+
+        placeholders = self.get_placeholders()
+        if not placeholders:
+            self.log.info("No placeholders were found.")
+            return
+
+        for placeholder in placeholders:
+            plugin = placeholder.plugin
+            plugin.update_template_placeholder(placeholder)
+
+        self.clear_shared_populate_data()
+
     @abstractmethod
     def import_template(self, template_path):
         """
@@ -318,12 +349,6 @@ class AbstractTemplateLoader:
 
         pass
 
-    # def template_already_imported(self, err_msg):
-    #     pass
-    #
-    # def template_loading_failed(self, err_msg):
-    #     pass
-
     def _prepare_placeholders(self, placeholders):
         """Run preparation part for placeholders on plugins.
 
@@ -413,7 +438,7 @@ class AbstractTemplateLoader:
                     placeholder.set_finished()
 
             # Clear shared data before getting new placeholders
-            self.clear_shared_data()
+            self.clear_shared_populate_data()
 
             iter_counter += 1
             if iter_counter >= level_limit:
@@ -430,6 +455,8 @@ class AbstractTemplateLoader:
                 placeholder_by_scene_id[identifier] = placeholder
                 placeholders.append(placeholder)
 
+        self.refresh()
+
     def _get_build_profiles(self):
         project_settings = get_project_settings(self.project_name)
         return (
@@ -582,6 +609,7 @@ class PlaceholderPlugin(object):
             placeholder_data (Dict[str, Any]): Data related to placeholder.
                 Should match plugin options.
         """
+
         pass
 
     @abstractmethod
@@ -638,15 +666,10 @@ class PlaceholderPlugin(object):
 
         pass
 
-    def cleanup_placeholders(self, placeholders):
-        """Cleanup of placeholders after processing.
+    def update_template_placeholder(self, placeholder):
+        """Update scene with current context for passed placeholder.
 
-        Not:
-            Passed placeholders can be failed.
-
-        Args:
-            placeholders (List[PlaceholderItem]): List of placeholders that
-                were be processed.
+        Can be used to re-run placeholder logic (if it make sense).
         """
 
         pass
@@ -656,8 +679,6 @@ class PlaceholderPlugin(object):
 
         Using shared data from builder but stored under plugin identifier.
 
-        Shared data are cleaned up on specific callbacks.
-
         Args:
             key (str): Key under which are shared data stored.
 
@@ -679,8 +700,6 @@ class PlaceholderPlugin(object):
         - wrong: 'asset'
         - good: 'asset_name'
 
-        Shared data are cleaned up on specific callbacks.
-
         Args:
             key (str): Key under which is key stored.
             value (Any): Value that should be stored under the key.

From 9821a05cdcf201b14319ba4a054adc735ea8d69a Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 16:54:58 +0200
Subject: [PATCH 053/147] implemented update logic for maya load plugin

---
 .../hosts/maya/api/new_template_builder.py    | 39 +++++++++++++++++--
 1 file changed, 35 insertions(+), 4 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index bc1a0250a8..9017e447c5 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -173,6 +173,25 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
 
         return placeholder_name.capitalize()
 
+    def _get_loaded_repre_ids(self):
+        loaded_representation_ids = self.builder.get_shared_populate_data(
+            "loaded_representation_ids"
+        )
+        if loaded_representation_ids is None:
+            try:
+                containers = cmds.sets("AVALON_CONTAINERS", q=True)
+            except ValueError:
+                containers = []
+
+            loaded_representation_ids = {
+                cmds.getAttr(container + ".representation")
+                for container in containers
+            }
+            self.builder.set_shared_populate_data(
+                "loaded_representation_ids"
+            )
+        return loaded_representation_ids
+
     def create_placeholder(self, placeholder_data):
         selection = cmds.ls(selection=True)
         if not selection:
@@ -242,7 +261,17 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
 
         return output
 
-    def process_placeholder(self, placeholder):
+    def populate_placeholder(self, placeholder):
+        self._populate_placeholder(placeholder)
+
+    def update_template_placeholder(self, placeholder):
+        repre_ids = self._get_loaded_repre_ids()
+        self._populate_placeholder(placeholder, repre_ids)
+
+    def _populate_placeholder(self, placeholder, ignore_repre_ids=None):
+        if ignore_repre_ids is None:
+            ignore_repre_ids = set()
+
         current_asset_doc = self.current_asset_doc
         linked_assets = self.linked_assets
         loader_name = placeholder.data["loader"]
@@ -262,6 +291,10 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
 
         loaders_by_name = self.builder.get_loaders_by_name()
         for representation in placeholder_representations:
+            repre_id = str(representation["_id"])
+            if repre_id in ignore_repre_ids:
+                continue
+
             repre_context = representation["context"]
             self.log.info(
                 "Loading {} from {} with loader {}\n"
@@ -280,9 +313,7 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
 
             else:
                 placeholder.load_succeed(container)
-            # TODO find out if 'postload make sense?'
-            # finally:
-            #     self.postload(placeholder)
+            placeholder.clean()
 
     def get_placeholder_options(self, options=None):
         loaders_by_name = self.builder.get_loaders_by_name()

From f133f401c059a4b03033e995ea67460de6fac732 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 16:55:09 +0200
Subject: [PATCH 054/147] small tweaks in code

---
 openpype/hosts/maya/api/new_template_builder.py | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index 9017e447c5..b28cc80cd1 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -61,11 +61,6 @@ class MayaTemplateLoader(AbstractTemplateLoader):
 
         return True
 
-    def get_placeholder_plugin_classes(self):
-        return [
-            MayaLoadPlaceholderPlugin
-        ]
-
     # def template_already_imported(self, err_msg):
     #     clearButton = "Clear scene and build"
     #     updateButton = "Update template"
@@ -113,7 +108,9 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
 
     def _collect_scene_placeholders(self):
         # Cache placeholder data to shared data
-        placeholder_nodes = self.builder.get_shared_data("placeholder_nodes")
+        placeholder_nodes = self.builder.get_shared_populate_data(
+            "placeholder_nodes"
+        )
         if placeholder_nodes is None:
             attributes = cmds.ls("*.plugin_identifier", long=True)
             placeholder_nodes = {}
@@ -123,7 +120,7 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
                     self._parse_placeholder_node_data(node_name)
                 )
 
-            self.builder.set_shared_data(
+            self.builder.set_shared_populate_data(
                 "placeholder_nodes", placeholder_nodes
             )
         return placeholder_nodes

From 8d60739fe43b96ea227e2af6b3d7889504448ae6 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 16:55:24 +0200
Subject: [PATCH 055/147] implemented functions for building actions

---
 .../hosts/maya/api/new_template_builder.py    | 47 ++++++++++++++++++-
 1 file changed, 46 insertions(+), 1 deletion(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index b28cc80cd1..43e92c59e2 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -5,7 +5,7 @@ from maya import cmds
 
 from openpype.client import get_representations
 from openpype.lib import attribute_definitions
-from openpype.pipeline import legacy_io
+from openpype.pipeline import legacy_io, registered_host
 from openpype.pipeline.workfile.build_template_exceptions import (
     TemplateAlreadyImported
 )
@@ -14,6 +14,9 @@ from openpype.pipeline.workfile.new_template_loader import (
     PlaceholderPlugin,
     PlaceholderItem,
 )
+from openpype.tools.workfile_template_build import (
+    WorkfileBuildPlaceholderDialog,
+)
 
 from .lib import read, imprint
 
@@ -566,3 +569,45 @@ class LoadPlaceholder(PlaceholderItem):
 
     def load_succeed(self, container):
         self.parent_in_hierarchy(container)
+
+
+def build_workfile_template():
+    builder = MayaTemplateLoader(registered_host())
+    builder.build_template()
+
+
+def update_workfile_template():
+    builder = MayaTemplateLoader(registered_host())
+    builder.update_build_template()
+
+
+def create_placeholder():
+    host = registered_host()
+    builder = MayaTemplateLoader(host)
+    window = WorkfileBuildPlaceholderDialog(host, builder)
+    window.exec_()
+
+
+def update_placeholder():
+    host = registered_host()
+    builder = MayaTemplateLoader(host)
+    placeholder_items_by_id = {
+        placeholder_item.scene_identifier: placeholder_item
+        for placeholder_item in builder.get_placeholders()
+    }
+    placeholder_items = []
+    for node_name in cmds.ls(selection=True, long=True):
+        if node_name in placeholder_items_by_id:
+            placeholder_items.append(placeholder_items_by_id[node_name])
+
+    # TODO show UI at least
+    if len(placeholder_items) == 0:
+        raise ValueError("No node selected")
+
+    if len(placeholder_items) > 1:
+        raise ValueError("Too many selected nodes")
+
+    placeholder_item = placeholder_items[0]
+    window = WorkfileBuildPlaceholderDialog(host, builder)
+    window.set_update_mode(placeholder_item)
+    window.exec_()

From 0102614531c70902c37b5bde494daf65718c805b Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 16:55:34 +0200
Subject: [PATCH 056/147] use functions in menu

---
 openpype/hosts/maya/api/menu.py | 11 ++++++-----
 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/openpype/hosts/maya/api/menu.py b/openpype/hosts/maya/api/menu.py
index 666f555660..0b3ea81403 100644
--- a/openpype/hosts/maya/api/menu.py
+++ b/openpype/hosts/maya/api/menu.py
@@ -9,16 +9,17 @@ import maya.cmds as cmds
 from openpype.settings import get_project_settings
 from openpype.pipeline import legacy_io
 from openpype.pipeline.workfile import BuildWorkfile
-from openpype.pipeline.workfile.build_template import (
-    build_workfile_template,
-    update_workfile_template
-)
 from openpype.tools.utils import host_tools
 from openpype.hosts.maya.api import lib, lib_rendersettings
 from .lib import get_main_window, IS_HEADLESS
 from .commands import reset_frame_range
-from .lib_template_builder import create_placeholder, update_placeholder
 
+from .new_template_builder import (
+    create_placeholder,
+    update_placeholder,
+    build_workfile_template,
+    update_workfile_template,
+)
 
 log = logging.getLogger(__name__)
 

From b25270ccddbb7b47cbc6bca978a8c539096e7798 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 17:58:07 +0200
Subject: [PATCH 057/147] use direct function calls

---
 openpype/hosts/maya/api/menu.py                 | 4 ++--
 openpype/hosts/maya/api/new_template_builder.py | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/openpype/hosts/maya/api/menu.py b/openpype/hosts/maya/api/menu.py
index 0b3ea81403..cc9a17fd72 100644
--- a/openpype/hosts/maya/api/menu.py
+++ b/openpype/hosts/maya/api/menu.py
@@ -162,12 +162,12 @@ def install():
         cmds.menuItem(
             "Create Placeholder",
             parent=builder_menu,
-            command=lambda *args: create_placeholder()
+            command=create_placeholder
         )
         cmds.menuItem(
             "Update Placeholder",
             parent=builder_menu,
-            command=lambda *args: update_placeholder()
+            command=update_placeholder
         )
         cmds.menuItem(
             "Build Workfile from template",
diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index 43e92c59e2..72d613afa3 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -571,24 +571,24 @@ class LoadPlaceholder(PlaceholderItem):
         self.parent_in_hierarchy(container)
 
 
-def build_workfile_template():
+def build_workfile_template(*args):
     builder = MayaTemplateLoader(registered_host())
     builder.build_template()
 
 
-def update_workfile_template():
+def update_workfile_template(*args):
     builder = MayaTemplateLoader(registered_host())
     builder.update_build_template()
 
 
-def create_placeholder():
+def create_placeholder(*args):
     host = registered_host()
     builder = MayaTemplateLoader(host)
     window = WorkfileBuildPlaceholderDialog(host, builder)
     window.exec_()
 
 
-def update_placeholder():
+def update_placeholder(*args):
     host = registered_host()
     builder = MayaTemplateLoader(host)
     placeholder_items_by_id = {

From b2a59336eca51bbc163e66a830238e57c3671d3b Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 17:58:20 +0200
Subject: [PATCH 058/147] use attributes from builder

---
 openpype/hosts/maya/api/new_template_builder.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index 72d613afa3..80f62b8759 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -272,8 +272,8 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
         if ignore_repre_ids is None:
             ignore_repre_ids = set()
 
-        current_asset_doc = self.current_asset_doc
-        linked_assets = self.linked_assets
+        current_asset_doc = self.builder.current_asset_doc
+        linked_assets = self.builder.linked_asset_docs
         loader_name = placeholder.data["loader"]
         loader_args = placeholder.data["loader_args"]
 

From bd5d7ca4a6d53bdc23d573a9b190c70a077b0437 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 17:58:51 +0200
Subject: [PATCH 059/147] added more specific attributes

---
 .../pipeline/workfile/new_template_loader.py  | 82 ++++++++++++++++---
 1 file changed, 70 insertions(+), 12 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index b97e48dcba..b23f03b0df 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -5,7 +5,10 @@ from abc import ABCMeta, abstractmethod
 
 import six
 
-from openpype.client import get_asset_by_name
+from openpype.client import (
+    get_asset_by_name,
+    get_linked_assets,
+)
 from openpype.settings import get_project_settings
 from openpype.host import HostBase
 from openpype.lib import (
@@ -67,11 +70,50 @@ class AbstractTemplateLoader:
         self._loaders_by_name = None
         self._creators_by_name = None
 
-        self.current_asset = asset_name
-        self.project_name = project_name
-        self.task_name = task_name
-        self.current_asset_doc = current_asset_doc
-        self.task_type = task_type
+        self._current_asset_doc = None
+        self._linked_asset_docs = None
+        self._task_type = None
+
+    @property
+    def project_name(self):
+        return legacy_io.active_project()
+
+    @property
+    def current_asset_name(self):
+        return legacy_io.Session["AVALON_ASSET"]
+
+    @property
+    def current_task_name(self):
+        return legacy_io.Session["AVALON_TASK"]
+
+    @property
+    def current_asset_doc(self):
+        if self._current_asset_doc is None:
+            self._current_asset_doc = get_asset_by_name(
+                self.project_name, self.current_asset_name
+            )
+        return self._current_asset_doc
+
+    @property
+    def linked_asset_docs(self):
+        if self._linked_asset_docs is None:
+            self._linked_asset_docs = get_linked_assets(
+                self.current_asset_doc
+            )
+        return self._linked_asset_docs
+
+    @property
+    def current_task_type(self):
+        asset_doc = self.current_asset_doc
+        if not asset_doc:
+            return None
+        return (
+            asset_doc
+            .get("data", {})
+            .get("tasks", {})
+            .get(self.current_task_name, {})
+            .get("type")
+        )
 
     def get_placeholder_plugin_classes(self):
         """Get placeholder plugin classes that can be used to build template.
@@ -121,6 +163,11 @@ class AbstractTemplateLoader:
         self._placeholder_plugins = None
         self._loaders_by_name = None
         self._creators_by_name = None
+
+        self._current_asset_doc = None
+        self._linked_asset_docs = None
+        self._task_type = None
+
         self.clear_shared_data()
         self.clear_shared_populate_data()
 
@@ -432,10 +479,18 @@ class AbstractTemplateLoader:
                     placeholder_plugin.populate_placeholder(placeholder)
 
                 except Exception as exc:
-                    placeholder.set_error(exc)
+                    self.log.warning(
+                        (
+                            "Failed to process placeholder {} with plugin {}"
+                        ).format(
+                            placeholder.scene_identifier,
+                            placeholder_plugin.__class__.__name__
+                        ),
+                        exc_info=True
+                    )
+                    placeholder.set_failed(exc)
 
-                else:
-                    placeholder.set_finished()
+                placeholder.set_finished()
 
             # Clear shared data before getting new placeholders
             self.clear_shared_populate_data()
@@ -467,10 +522,10 @@ class AbstractTemplateLoader:
         )
 
     def get_template_path(self):
-        project_name = self.project_name
         host_name = self.host_name
-        task_name = self.task_name
-        task_type = self.task_type
+        project_name = self.project_name
+        task_name = self.current_task_name
+        task_type = self.current_task_type
 
         build_profiles = self._get_build_profiles()
         profile = filter_profiles(
@@ -872,6 +927,9 @@ class PlaceholderItem(object):
 
         self._state = 2
 
+    def set_failed(self, exception):
+        self.add_error(str(exception))
+
     def add_error(self, error):
         """Set placeholder item as failed and mark it as finished."""
 

From 419812241c91f8d9b1dad18a36937cad0fe152fe Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 18:00:57 +0200
Subject: [PATCH 060/147] removed unused code

---
 .../hosts/maya/api/new_template_builder.py    | 53 -------------------
 1 file changed, 53 deletions(-)

diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/new_template_builder.py
index 80f62b8759..05f6a8551a 100644
--- a/openpype/hosts/maya/api/new_template_builder.py
+++ b/openpype/hosts/maya/api/new_template_builder.py
@@ -49,61 +49,8 @@ class MayaTemplateLoader(AbstractTemplateLoader):
 
         cmds.setAttr(PLACEHOLDER_SET + ".hiddenInOutliner", True)
 
-        # This should be handled by creators
-        # for set_name in cmds.listSets(allSets=True):
-        #     if (
-        #         cmds.objExists(set_name)
-        #         and cmds.attributeQuery('id', node=set_name, exists=True)
-        #         and cmds.getAttr(set_name + '.id') == 'pyblish.avalon.instance'
-        #     ):
-        #         if cmds.attributeQuery('asset', node=set_name, exists=True):
-        #             cmds.setAttr(
-        #                 set_name + '.asset',
-        #                 legacy_io.Session['AVALON_ASSET'], type='string'
-        #             )
-
         return True
 
-    # def template_already_imported(self, err_msg):
-    #     clearButton = "Clear scene and build"
-    #     updateButton = "Update template"
-    #     abortButton = "Abort"
-    #
-    #     title = "Scene already builded"
-    #     message = (
-    #         "It's seems a template was already build for this scene.\n"
-    #         "Error message reveived :\n\n\"{}\"".format(err_msg))
-    #     buttons = [clearButton, updateButton, abortButton]
-    #     defaultButton = clearButton
-    #     cancelButton = abortButton
-    #     dismissString = abortButton
-    #     answer = cmds.confirmDialog(
-    #         t=title,
-    #         m=message,
-    #         b=buttons,
-    #         db=defaultButton,
-    #         cb=cancelButton,
-    #         ds=dismissString)
-    #
-    #     if answer == clearButton:
-    #         cmds.file(newFile=True, force=True)
-    #         self.import_template(self.template_path)
-    #         self.populate_template()
-    #     elif answer == updateButton:
-    #         self.update_missing_containers()
-    #     elif answer == abortButton:
-    #         return
-
-    # def get_loaded_containers_by_id(self):
-    #     try:
-    #         containers = cmds.sets("AVALON_CONTAINERS", q=True)
-    #     except ValueError:
-    #         return None
-    #
-    #     return [
-    #         cmds.getAttr(container + '.representation')
-    #         for container in containers]
-
 
 class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
     identifier = "maya.load"

From 486d6636a994da49c35113337b4fa62c3e1d2071 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 18:05:17 +0200
Subject: [PATCH 061/147] renamed file 'new_template_builder' to
 'workfile_template_builder'

---
 openpype/hosts/maya/api/menu.py                                 | 2 +-
 openpype/hosts/maya/api/pipeline.py                             | 2 +-
 .../{new_template_builder.py => workfile_template_builder.py}   | 0
 3 files changed, 2 insertions(+), 2 deletions(-)
 rename openpype/hosts/maya/api/{new_template_builder.py => workfile_template_builder.py} (100%)

diff --git a/openpype/hosts/maya/api/menu.py b/openpype/hosts/maya/api/menu.py
index cc9a17fd72..e20f29049b 100644
--- a/openpype/hosts/maya/api/menu.py
+++ b/openpype/hosts/maya/api/menu.py
@@ -14,7 +14,7 @@ from openpype.hosts.maya.api import lib, lib_rendersettings
 from .lib import get_main_window, IS_HEADLESS
 from .commands import reset_frame_range
 
-from .new_template_builder import (
+from .workfile_template_builder import (
     create_placeholder,
     update_placeholder,
     build_workfile_template,
diff --git a/openpype/hosts/maya/api/pipeline.py b/openpype/hosts/maya/api/pipeline.py
index 2492e75b36..c47e34aebc 100644
--- a/openpype/hosts/maya/api/pipeline.py
+++ b/openpype/hosts/maya/api/pipeline.py
@@ -35,7 +35,7 @@ from openpype.hosts.maya import MAYA_ROOT_DIR
 from openpype.hosts.maya.lib import copy_workspace_mel
 
 from . import menu, lib
-from .new_template_builder import MayaLoadPlaceholderPlugin
+from .workfile_template_builder import MayaLoadPlaceholderPlugin
 from .workio import (
     open_file,
     save_file,
diff --git a/openpype/hosts/maya/api/new_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
similarity index 100%
rename from openpype/hosts/maya/api/new_template_builder.py
rename to openpype/hosts/maya/api/workfile_template_builder.py

From a3b6d9645e7a0b93d359b4304e8a96381cd373ca Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 18:05:27 +0200
Subject: [PATCH 062/147] removed legacy workfile template builder

---
 .../hosts/maya/api/lib_template_builder.py    | 253 ------------------
 openpype/hosts/maya/api/template_loader.py    | 252 -----------------
 2 files changed, 505 deletions(-)
 delete mode 100644 openpype/hosts/maya/api/lib_template_builder.py
 delete mode 100644 openpype/hosts/maya/api/template_loader.py

diff --git a/openpype/hosts/maya/api/lib_template_builder.py b/openpype/hosts/maya/api/lib_template_builder.py
deleted file mode 100644
index 34a8450a26..0000000000
--- a/openpype/hosts/maya/api/lib_template_builder.py
+++ /dev/null
@@ -1,253 +0,0 @@
-import json
-from collections import OrderedDict
-import maya.cmds as cmds
-
-import qargparse
-from openpype.tools.utils.widgets import OptionDialog
-from .lib import get_main_window, imprint
-
-# To change as enum
-build_types = ["context_asset", "linked_asset", "all_assets"]
-
-
-def get_placeholder_attributes(node):
-    return {
-        attr: cmds.getAttr("{}.{}".format(node, attr))
-        for attr in cmds.listAttr(node, userDefined=True)}
-
-
-def delete_placeholder_attributes(node):
-    '''
-    function to delete all extra placeholder attributes
-    '''
-    extra_attributes = get_placeholder_attributes(node)
-    for attribute in extra_attributes:
-        cmds.deleteAttr(node + '.' + attribute)
-
-
-def create_placeholder():
-    args = placeholder_window()
-
-    if not args:
-        return  # operation canceled, no locator created
-
-    # custom arg parse to force empty data query
-    # and still imprint them on placeholder
-    # and getting items when arg is of type Enumerator
-    options = create_options(args)
-
-    # create placeholder name dynamically from args and options
-    placeholder_name = create_placeholder_name(args, options)
-
-    selection = cmds.ls(selection=True)
-    if not selection:
-        raise ValueError("Nothing is selected")
-
-    placeholder = cmds.spaceLocator(name=placeholder_name)[0]
-
-    # get the long name of the placeholder (with the groups)
-    placeholder_full_name = cmds.ls(selection[0], long=True)[
-        0] + '|' + placeholder.replace('|', '')
-
-    if selection:
-        cmds.parent(placeholder, selection[0])
-
-    imprint(placeholder_full_name, options)
-
-    # Some tweaks because imprint force enums to to default value so we get
-    # back arg read and force them to attributes
-    imprint_enum(placeholder_full_name, args)
-
-    # Add helper attributes to keep placeholder info
-    cmds.addAttr(
-        placeholder_full_name,
-        longName="parent",
-        hidden=True,
-        dataType="string"
-    )
-    cmds.addAttr(
-        placeholder_full_name,
-        longName="index",
-        hidden=True,
-        attributeType="short",
-        defaultValue=-1
-    )
-
-    cmds.setAttr(placeholder_full_name + '.parent', "", type="string")
-
-
-def create_placeholder_name(args, options):
-    placeholder_builder_type = [
-        arg.read() for arg in args if 'builder_type' in str(arg)
-    ][0]
-    placeholder_family = options['family']
-    placeholder_name = placeholder_builder_type.split('_')
-
-    # add famlily in any
-    if placeholder_family:
-        placeholder_name.insert(1, placeholder_family)
-
-    # add loader arguments if any
-    if options['loader_args']:
-        pos = 2
-        loader_args = options['loader_args'].replace('\'', '\"')
-        loader_args = json.loads(loader_args)
-        values = [v for v in loader_args.values()]
-        for i in range(len(values)):
-            placeholder_name.insert(i + pos, values[i])
-
-    placeholder_name = '_'.join(placeholder_name)
-
-    return placeholder_name.capitalize()
-
-
-def update_placeholder():
-    placeholder = cmds.ls(selection=True)
-    if len(placeholder) == 0:
-        raise ValueError("No node selected")
-    if len(placeholder) > 1:
-        raise ValueError("Too many selected nodes")
-    placeholder = placeholder[0]
-
-    args = placeholder_window(get_placeholder_attributes(placeholder))
-
-    if not args:
-        return  # operation canceled
-
-    # delete placeholder attributes
-    delete_placeholder_attributes(placeholder)
-
-    options = create_options(args)
-
-    imprint(placeholder, options)
-    imprint_enum(placeholder, args)
-
-    cmds.addAttr(
-        placeholder,
-        longName="parent",
-        hidden=True,
-        dataType="string"
-    )
-    cmds.addAttr(
-        placeholder,
-        longName="index",
-        hidden=True,
-        attributeType="short",
-        defaultValue=-1
-    )
-
-    cmds.setAttr(placeholder + '.parent', '', type="string")
-
-
-def create_options(args):
-    options = OrderedDict()
-    for arg in args:
-        if not type(arg) == qargparse.Separator:
-            options[str(arg)] = arg._data.get("items") or arg.read()
-    return options
-
-
-def imprint_enum(placeholder, args):
-    """
-    Imprint method doesn't act properly with enums.
-    Replacing the functionnality with this for now
-    """
-    enum_values = {str(arg): arg.read()
-                   for arg in args if arg._data.get("items")}
-    string_to_value_enum_table = {
-        build: i for i, build
-        in enumerate(build_types)}
-    for key, value in enum_values.items():
-        cmds.setAttr(
-            placeholder + "." + key,
-            string_to_value_enum_table[value])
-
-
-def placeholder_window(options=None):
-    options = options or dict()
-    dialog = OptionDialog(parent=get_main_window())
-    dialog.setWindowTitle("Create Placeholder")
-
-    args = [
-        qargparse.Separator("Main attributes"),
-        qargparse.Enum(
-            "builder_type",
-            label="Asset Builder Type",
-            default=options.get("builder_type", 0),
-            items=build_types,
-            help="""Asset Builder Type
-Builder type describe what template loader will look for.
-context_asset : Template loader will look for subsets of
-current context asset (Asset bob will find asset)
-linked_asset : Template loader will look for assets linked
-to current context asset.
-Linked asset are looked in avalon database under field "inputLinks"
-"""
-        ),
-        qargparse.String(
-            "family",
-            default=options.get("family", ""),
-            label="OpenPype Family",
-            placeholder="ex: model, look ..."),
-        qargparse.String(
-            "representation",
-            default=options.get("representation", ""),
-            label="OpenPype Representation",
-            placeholder="ex: ma, abc ..."),
-        qargparse.String(
-            "loader",
-            default=options.get("loader", ""),
-            label="Loader",
-            placeholder="ex: ReferenceLoader, LightLoader ...",
-            help="""Loader
-Defines what openpype loader will be used to load assets.
-Useable loader depends on current host's loader list.
-Field is case sensitive.
-"""),
-        qargparse.String(
-            "loader_args",
-            default=options.get("loader_args", ""),
-            label="Loader Arguments",
-            placeholder='ex: {"camera":"persp", "lights":True}',
-            help="""Loader
-Defines a dictionnary of arguments used to load assets.
-Useable arguments depend on current placeholder Loader.
-Field should be a valid python dict. Anything else will be ignored.
-"""),
-        qargparse.Integer(
-            "order",
-            default=options.get("order", 0),
-            min=0,
-            max=999,
-            label="Order",
-            placeholder="ex: 0, 100 ... (smallest order loaded first)",
-            help="""Order
-Order defines asset loading priority (0 to 999)
-Priority rule is : "lowest is first to load"."""),
-        qargparse.Separator(
-            "Optional attributes"),
-        qargparse.String(
-            "asset",
-            default=options.get("asset", ""),
-            label="Asset filter",
-            placeholder="regex filtering by asset name",
-            help="Filtering assets by matching field regex to asset's name"),
-        qargparse.String(
-            "subset",
-            default=options.get("subset", ""),
-            label="Subset filter",
-            placeholder="regex filtering by subset name",
-            help="Filtering assets by matching field regex to subset's name"),
-        qargparse.String(
-            "hierarchy",
-            default=options.get("hierarchy", ""),
-            label="Hierarchy filter",
-            placeholder="regex filtering by asset's hierarchy",
-            help="Filtering assets by matching field asset's hierarchy")
-    ]
-    dialog.create(args)
-
-    if not dialog.exec_():
-        return None
-
-    return args
diff --git a/openpype/hosts/maya/api/template_loader.py b/openpype/hosts/maya/api/template_loader.py
deleted file mode 100644
index ecffafc93d..0000000000
--- a/openpype/hosts/maya/api/template_loader.py
+++ /dev/null
@@ -1,252 +0,0 @@
-import re
-from maya import cmds
-
-from openpype.client import get_representations
-from openpype.pipeline import legacy_io
-from openpype.pipeline.workfile.abstract_template_loader import (
-    AbstractPlaceholder,
-    AbstractTemplateLoader
-)
-from openpype.pipeline.workfile.build_template_exceptions import (
-    TemplateAlreadyImported
-)
-
-PLACEHOLDER_SET = 'PLACEHOLDERS_SET'
-
-
-class MayaTemplateLoader(AbstractTemplateLoader):
-    """Concrete implementation of AbstractTemplateLoader for maya
-    """
-
-    def import_template(self, path):
-        """Import template into current scene.
-        Block if a template is already loaded.
-        Args:
-            path (str): A path to current template (usually given by
-            get_template_path implementation)
-        Returns:
-            bool: Wether the template was succesfully imported or not
-        """
-        if cmds.objExists(PLACEHOLDER_SET):
-            raise TemplateAlreadyImported(
-                "Build template already loaded\n"
-                "Clean scene if needed (File > New Scene)")
-
-        cmds.sets(name=PLACEHOLDER_SET, empty=True)
-        self.new_nodes = cmds.file(path, i=True, returnNewNodes=True)
-        cmds.setAttr(PLACEHOLDER_SET + '.hiddenInOutliner', True)
-
-        for set in cmds.listSets(allSets=True):
-            if (cmds.objExists(set) and
-               cmds.attributeQuery('id', node=set, exists=True) and
-               cmds.getAttr(set + '.id') == 'pyblish.avalon.instance'):
-                if cmds.attributeQuery('asset', node=set, exists=True):
-                    cmds.setAttr(
-                        set + '.asset',
-                        legacy_io.Session['AVALON_ASSET'], type='string'
-                    )
-
-        return True
-
-    def template_already_imported(self, err_msg):
-        clearButton = "Clear scene and build"
-        updateButton = "Update template"
-        abortButton = "Abort"
-
-        title = "Scene already builded"
-        message = (
-            "It's seems a template was already build for this scene.\n"
-            "Error message reveived :\n\n\"{}\"".format(err_msg))
-        buttons = [clearButton, updateButton, abortButton]
-        defaultButton = clearButton
-        cancelButton = abortButton
-        dismissString = abortButton
-        answer = cmds.confirmDialog(
-            t=title,
-            m=message,
-            b=buttons,
-            db=defaultButton,
-            cb=cancelButton,
-            ds=dismissString)
-
-        if answer == clearButton:
-            cmds.file(newFile=True, force=True)
-            self.import_template(self.template_path)
-            self.populate_template()
-        elif answer == updateButton:
-            self.update_missing_containers()
-        elif answer == abortButton:
-            return
-
-    @staticmethod
-    def get_template_nodes():
-        attributes = cmds.ls('*.builder_type', long=True)
-        return [attribute.rpartition('.')[0] for attribute in attributes]
-
-    def get_loaded_containers_by_id(self):
-        try:
-            containers = cmds.sets("AVALON_CONTAINERS", q=True)
-        except ValueError:
-            return None
-
-        return [
-            cmds.getAttr(container + '.representation')
-            for container in containers]
-
-
-class MayaPlaceholder(AbstractPlaceholder):
-    """Concrete implementation of AbstractPlaceholder for maya
-    """
-
-    optional_keys = {'asset', 'subset', 'hierarchy'}
-
-    def get_data(self, node):
-        user_data = dict()
-        for attr in self.required_keys.union(self.optional_keys):
-            attribute_name = '{}.{}'.format(node, attr)
-            if not cmds.attributeQuery(attr, node=node, exists=True):
-                print("{} not found".format(attribute_name))
-                continue
-            user_data[attr] = cmds.getAttr(
-                attribute_name,
-                asString=True)
-        user_data['parent'] = (
-            cmds.getAttr(node + '.parent', asString=True)
-            or node.rpartition('|')[0]
-            or ""
-        )
-        user_data['node'] = node
-        if user_data['parent']:
-            siblings = cmds.listRelatives(user_data['parent'], children=True)
-        else:
-            siblings = cmds.ls(assemblies=True)
-        node_shortname = user_data['node'].rpartition('|')[2]
-        current_index = cmds.getAttr(node + '.index', asString=True)
-        user_data['index'] = (
-            current_index if current_index >= 0
-            else siblings.index(node_shortname))
-
-        self.data = user_data
-
-    def parent_in_hierarchy(self, containers):
-        """Parent loaded container to placeholder's parent
-        ie : Set loaded content as placeholder's sibling
-        Args:
-            containers (String): Placeholder loaded containers
-        """
-        if not containers:
-            return
-
-        roots = cmds.sets(containers, q=True)
-        nodes_to_parent = []
-        for root in roots:
-            if root.endswith("_RN"):
-                refRoot = cmds.referenceQuery(root, n=True)[0]
-                refRoot = cmds.listRelatives(refRoot, parent=True) or [refRoot]
-                nodes_to_parent.extend(refRoot)
-            elif root in cmds.listSets(allSets=True):
-                if not cmds.sets(root, q=True):
-                    return
-                else:
-                    continue
-            else:
-                nodes_to_parent.append(root)
-
-        if self.data['parent']:
-            cmds.parent(nodes_to_parent, self.data['parent'])
-        # Move loaded nodes to correct index in outliner hierarchy
-        placeholder_node = self.data['node']
-        placeholder_form = cmds.xform(
-            placeholder_node,
-            q=True,
-            matrix=True,
-            worldSpace=True
-        )
-        for node in set(nodes_to_parent):
-            cmds.reorder(node, front=True)
-            cmds.reorder(node, relative=self.data['index'])
-            cmds.xform(node, matrix=placeholder_form, ws=True)
-
-        holding_sets = cmds.listSets(object=placeholder_node)
-        if not holding_sets:
-            return
-        for holding_set in holding_sets:
-            cmds.sets(roots, forceElement=holding_set)
-
-    def clean(self):
-        """Hide placeholder, parent them to root
-        add them to placeholder set and register placeholder's parent
-        to keep placeholder info available for future use
-        """
-        node = self.data['node']
-        if self.data['parent']:
-            cmds.setAttr(node + '.parent', self.data['parent'], type='string')
-        if cmds.getAttr(node + '.index') < 0:
-            cmds.setAttr(node + '.index', self.data['index'])
-
-        holding_sets = cmds.listSets(object=node)
-        if holding_sets:
-            for set in holding_sets:
-                cmds.sets(node, remove=set)
-
-        if cmds.listRelatives(node, p=True):
-            node = cmds.parent(node, world=True)[0]
-        cmds.sets(node, addElement=PLACEHOLDER_SET)
-        cmds.hide(node)
-        cmds.setAttr(node + '.hiddenInOutliner', True)
-
-    def get_representations(self, current_asset_doc, linked_asset_docs):
-        project_name = legacy_io.active_project()
-
-        builder_type = self.data["builder_type"]
-        if builder_type == "context_asset":
-            context_filters = {
-                "asset": [current_asset_doc["name"]],
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representations": [self.data["representation"]],
-                "family": [self.data["family"]]
-            }
-
-        elif builder_type != "linked_asset":
-            context_filters = {
-                "asset": [re.compile(self.data["asset"])],
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representation": [self.data["representation"]],
-                "family": [self.data["family"]]
-            }
-
-        else:
-            asset_regex = re.compile(self.data["asset"])
-            linked_asset_names = []
-            for asset_doc in linked_asset_docs:
-                asset_name = asset_doc["name"]
-                if asset_regex.match(asset_name):
-                    linked_asset_names.append(asset_name)
-
-            context_filters = {
-                "asset": linked_asset_names,
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representation": [self.data["representation"]],
-                "family": [self.data["family"]],
-            }
-
-        return list(get_representations(
-            project_name,
-            context_filters=context_filters
-        ))
-
-    def err_message(self):
-        return (
-            "Error while trying to load a representation.\n"
-            "Either the subset wasn't published or the template is malformed."
-            "\n\n"
-            "Builder was looking for :\n{attributes}".format(
-                attributes="\n".join([
-                    "{}: {}".format(key.title(), value)
-                    for key, value in self.data.items()]
-                )
-            )
-        )

From 778f2c09ad13675981076c6eef601447da41d591 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 18:09:18 +0200
Subject: [PATCH 063/147] renamed 'update_template' to 'rebuild_template'

---
 openpype/hosts/maya/api/workfile_template_builder.py | 4 ++--
 openpype/pipeline/workfile/new_template_loader.py    | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index 05f6a8551a..98da18bba1 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -135,7 +135,7 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
                 for container in containers
             }
             self.builder.set_shared_populate_data(
-                "loaded_representation_ids"
+                "loaded_representation_ids", loaded_representation_ids
             )
         return loaded_representation_ids
 
@@ -525,7 +525,7 @@ def build_workfile_template(*args):
 
 def update_workfile_template(*args):
     builder = MayaTemplateLoader(registered_host())
-    builder.update_build_template()
+    builder.rebuild_template()
 
 
 def create_placeholder(*args):
diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index b23f03b0df..47d84d4ff7 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -350,7 +350,7 @@ class AbstractTemplateLoader:
         self.import_template(template_path)
         self.populate_scene_placeholders(level_limit)
 
-    def update_template(self):
+    def rebuild_template(self):
         """Go through existing placeholders in scene and update them.
 
         This could not make sense for all plugin types so this is optional

From abbe7b7a3609dcd5c33bcbd8eff1e19853d0b495 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 19:15:49 +0200
Subject: [PATCH 064/147] implemented function 'get_contexts_for_repre_docs' to
 get representation contexts from already queried representations

---
 openpype/pipeline/load/utils.py | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/openpype/pipeline/load/utils.py b/openpype/pipeline/load/utils.py
index 83b904e4a7..22e823bd3b 100644
--- a/openpype/pipeline/load/utils.py
+++ b/openpype/pipeline/load/utils.py
@@ -87,13 +87,20 @@ def get_repres_contexts(representation_ids, dbcon=None):
     if not dbcon:
         dbcon = legacy_io
 
-    contexts = {}
     if not representation_ids:
-        return contexts
+        return {}
 
     project_name = dbcon.active_project()
     repre_docs = get_representations(project_name, representation_ids)
 
+    return get_contexts_for_repre_docs(project_name, repre_docs)
+
+
+def get_contexts_for_repre_docs(project_name, repre_docs):
+    contexts = {}
+    if not repre_docs:
+        return contexts
+
     repre_docs_by_id = {}
     version_ids = set()
     for repre_doc in repre_docs:

From 81b9b16a5c2eb3c0e1845262a1e2747f8bc9e6d5 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 19:16:14 +0200
Subject: [PATCH 065/147] extracted loading specific logic into load mixin

---
 .../maya/api/workfile_template_builder.py     | 228 +-------------
 .../pipeline/workfile/new_template_loader.py  | 283 +++++++++++++++++-
 2 files changed, 292 insertions(+), 219 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index 98da18bba1..14f1f284fd 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -1,11 +1,8 @@
-import re
 import json
 
 from maya import cmds
 
-from openpype.client import get_representations
-from openpype.lib import attribute_definitions
-from openpype.pipeline import legacy_io, registered_host
+from openpype.pipeline import registered_host
 from openpype.pipeline.workfile.build_template_exceptions import (
     TemplateAlreadyImported
 )
@@ -13,6 +10,7 @@ from openpype.pipeline.workfile.new_template_loader import (
     AbstractTemplateLoader,
     PlaceholderPlugin,
     PlaceholderItem,
+    PlaceholderLoadMixin,
 )
 from openpype.tools.workfile_template_build import (
     WorkfileBuildPlaceholderDialog,
@@ -52,7 +50,7 @@ class MayaTemplateLoader(AbstractTemplateLoader):
         return True
 
 
-class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
+class MayaPlaceholderLoadPlugin(PlaceholderPlugin, PlaceholderLoadMixin):
     identifier = "maya.load"
     label = "Maya load"
 
@@ -203,190 +201,27 @@ class MayaLoadPlaceholderPlugin(PlaceholderPlugin):
 
             # TODO do data validations and maybe updgrades if are invalid
             output.append(
-                LoadPlaceholder(node_name, placeholder_data, self)
+                LoadPlaceholderItem(node_name, placeholder_data, self)
             )
 
         return output
 
     def populate_placeholder(self, placeholder):
-        self._populate_placeholder(placeholder)
+        self.populate_load_placeholder(placeholder)
 
     def update_template_placeholder(self, placeholder):
         repre_ids = self._get_loaded_repre_ids()
-        self._populate_placeholder(placeholder, repre_ids)
-
-    def _populate_placeholder(self, placeholder, ignore_repre_ids=None):
-        if ignore_repre_ids is None:
-            ignore_repre_ids = set()
-
-        current_asset_doc = self.builder.current_asset_doc
-        linked_assets = self.builder.linked_asset_docs
-        loader_name = placeholder.data["loader"]
-        loader_args = placeholder.data["loader_args"]
-
-        # TODO check loader existence
-        placeholder_representations = placeholder.get_representations(
-            current_asset_doc,
-            linked_assets
-        )
-
-        if not placeholder_representations:
-            self.log.info((
-                "There's no representation for this placeholder: {}"
-            ).format(placeholder.scene_identifier))
-            return
-
-        loaders_by_name = self.builder.get_loaders_by_name()
-        for representation in placeholder_representations:
-            repre_id = str(representation["_id"])
-            if repre_id in ignore_repre_ids:
-                continue
-
-            repre_context = representation["context"]
-            self.log.info(
-                "Loading {} from {} with loader {}\n"
-                "Loader arguments used : {}".format(
-                    repre_context["subset"],
-                    repre_context["asset"],
-                    loader_name,
-                    loader_args
-                )
-            )
-            try:
-                container = self.load(
-                    placeholder, loaders_by_name, representation)
-            except Exception:
-                placeholder.load_failed(representation)
-
-            else:
-                placeholder.load_succeed(container)
-            placeholder.clean()
+        self.populate_load_placeholder(placeholder, repre_ids)
 
     def get_placeholder_options(self, options=None):
-        loaders_by_name = self.builder.get_loaders_by_name()
-        loader_items = [
-            (loader_name, loader.label or loader_name)
-            for loader_name, loader in loaders_by_name.items()
-        ]
-
-        loader_items = list(sorted(loader_items, key=lambda i: i[0]))
-        options = options or {}
-        return [
-            attribute_definitions.UISeparatorDef(),
-            attribute_definitions.UILabelDef("Main attributes"),
-            attribute_definitions.UISeparatorDef(),
-
-            attribute_definitions.EnumDef(
-                "builder_type",
-                label="Asset Builder Type",
-                default=options.get("builder_type"),
-                items=[
-                    ("context_asset", "Current asset"),
-                    ("linked_asset", "Linked assets"),
-                    ("all_assets", "All assets")
-                ],
-                tooltip=(
-                    "Asset Builder Type\n"
-                    "\nBuilder type describe what template loader will look"
-                    " for."
-                    "\ncontext_asset : Template loader will look for subsets"
-                    " of current context asset (Asset bob will find asset)"
-                    "\nlinked_asset : Template loader will look for assets"
-                    " linked to current context asset."
-                    "\nLinked asset are looked in database under"
-                    " field \"inputLinks\""
-                )
-            ),
-            attribute_definitions.TextDef(
-                "family",
-                label="Family",
-                default=options.get("family"),
-                placeholder="model, look, ..."
-            ),
-            attribute_definitions.TextDef(
-                "representation",
-                label="Representation name",
-                default=options.get("representation"),
-                placeholder="ma, abc, ..."
-            ),
-            attribute_definitions.EnumDef(
-                "loader",
-                label="Loader",
-                default=options.get("loader"),
-                items=loader_items,
-                tooltip=(
-                    "Loader"
-                    "\nDefines what OpenPype loader will be used to"
-                    " load assets."
-                    "\nUseable loader depends on current host's loader list."
-                    "\nField is case sensitive."
-                )
-            ),
-            attribute_definitions.TextDef(
-                "loader_args",
-                label="Loader Arguments",
-                default=options.get("loader_args"),
-                placeholder='{"camera":"persp", "lights":True}',
-                tooltip=(
-                    "Loader"
-                    "\nDefines a dictionnary of arguments used to load assets."
-                    "\nUseable arguments depend on current placeholder Loader."
-                    "\nField should be a valid python dict."
-                    " Anything else will be ignored."
-                )
-            ),
-            attribute_definitions.NumberDef(
-                "order",
-                label="Order",
-                default=options.get("order") or 0,
-                decimals=0,
-                minimum=0,
-                maximum=999,
-                tooltip=(
-                    "Order"
-                    "\nOrder defines asset loading priority (0 to 999)"
-                    "\nPriority rule is : \"lowest is first to load\"."
-                )
-            ),
-            attribute_definitions.UISeparatorDef(),
-            attribute_definitions.UILabelDef("Optional attributes"),
-            attribute_definitions.UISeparatorDef(),
-            attribute_definitions.TextDef(
-                "asset",
-                label="Asset filter",
-                default=options.get("asset"),
-                placeholder="regex filtering by asset name",
-                tooltip=(
-                    "Filtering assets by matching field regex to asset's name"
-                )
-            ),
-            attribute_definitions.TextDef(
-                "subset",
-                label="Subset filter",
-                default=options.get("subset"),
-                placeholder="regex filtering by subset name",
-                tooltip=(
-                    "Filtering assets by matching field regex to subset's name"
-                )
-            ),
-            attribute_definitions.TextDef(
-                "hierarchy",
-                label="Hierarchy filter",
-                default=options.get("hierarchy"),
-                placeholder="regex filtering by asset's hierarchy",
-                tooltip=(
-                    "Filtering assets by matching field asset's hierarchy"
-                )
-            )
-        ]
+        return self.get_load_plugin_options(self, options)
 
 
-class LoadPlaceholder(PlaceholderItem):
-    """Concrete implementation of AbstractPlaceholder for maya
-    """
+class LoadPlaceholderItem(PlaceholderItem):
+    """Concrete implementation of PlaceholderItem for Maya load plugin."""
 
     def __init__(self, *args, **kwargs):
-        super(LoadPlaceholder, self).__init__(*args, **kwargs)
+        super(LoadPlaceholderItem, self).__init__(*args, **kwargs)
         self._failed_representations = []
 
     def parent_in_hierarchy(self, container):
@@ -457,49 +292,6 @@ class LoadPlaceholder(PlaceholderItem):
         cmds.hide(node)
         cmds.setAttr(node + ".hiddenInOutliner", True)
 
-    def get_representations(self, current_asset_doc, linked_asset_docs):
-        project_name = legacy_io.active_project()
-
-        builder_type = self.data["builder_type"]
-        if builder_type == "context_asset":
-            context_filters = {
-                "asset": [current_asset_doc["name"]],
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representations": [self.data["representation"]],
-                "family": [self.data["family"]]
-            }
-
-        elif builder_type != "linked_asset":
-            context_filters = {
-                "asset": [re.compile(self.data["asset"])],
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representation": [self.data["representation"]],
-                "family": [self.data["family"]]
-            }
-
-        else:
-            asset_regex = re.compile(self.data["asset"])
-            linked_asset_names = []
-            for asset_doc in linked_asset_docs:
-                asset_name = asset_doc["name"]
-                if asset_regex.match(asset_name):
-                    linked_asset_names.append(asset_name)
-
-            context_filters = {
-                "asset": linked_asset_names,
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representation": [self.data["representation"]],
-                "family": [self.data["family"]],
-            }
-
-        return list(get_representations(
-            project_name,
-            context_filters=context_filters
-        ))
-
     def get_errors(self):
         if not self._failed_representations:
             return []
diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 47d84d4ff7..921cc39ba9 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -1,4 +1,5 @@
 import os
+import re
 import collections
 import copy
 from abc import ABCMeta, abstractmethod
@@ -8,6 +9,7 @@ import six
 from openpype.client import (
     get_asset_by_name,
     get_linked_assets,
+    get_representations,
 )
 from openpype.settings import get_project_settings
 from openpype.host import HostBase
@@ -15,10 +17,15 @@ from openpype.lib import (
     Logger,
     StringTemplate,
     filter_profiles,
+    attribute_definitions,
 )
 from openpype.lib.attribute_definitions import get_attributes_keys
 from openpype.pipeline import legacy_io, Anatomy
-from openpype.pipeline.load import get_loaders_by_name
+from openpype.pipeline.load import (
+    get_loaders_by_name,
+    get_contexts_for_repre_docs,
+    load_with_repre_context,
+)
 from openpype.pipeline.create import get_legacy_creator_by_name
 
 from .build_template_exceptions import (
@@ -942,3 +949,277 @@ class PlaceholderItem(object):
         """
 
         return self._errors
+
+
+class PlaceholderLoadMixin(object):
+    """Mixin prepared for loading placeholder plugins.
+
+    Implementation prepares options for placeholders with
+    'get_load_plugin_options'.
+
+    For placeholder population is implemented 'populate_load_placeholder'.
+
+    Requires that PlaceholderItem has implemented methods:
+    - 'load_failed' - called when loading of one representation failed
+    - 'load_succeed' - called when loading of one representation succeeded
+    - 'clean' - called when placeholder processing finished
+    """
+
+    def get_load_plugin_options(self, options=None):
+        """Unified attribute definitions for load placeholder.
+
+        Common function for placeholder plugins used for loading of
+        repsentations.
+
+        Args:
+            plugin (PlaceholderPlugin): Plugin used for loading of
+                representations.
+            options (Dict[str, Any]): Already available options which are used
+                as defaults for attributes.
+
+        Returns:
+            List[AbtractAttrDef]: Attribute definitions common for load
+                plugins.
+        """
+
+        loaders_by_name = self.builder.get_loaders_by_name()
+        loader_items = [
+            (loader_name, loader.label or loader_name)
+            for loader_name, loader in loaders_by_name.items()
+        ]
+
+        loader_items = list(sorted(loader_items, key=lambda i: i[1]))
+        options = options or {}
+        return [
+            attribute_definitions.UISeparatorDef(),
+            attribute_definitions.UILabelDef("Main attributes"),
+            attribute_definitions.UISeparatorDef(),
+
+            attribute_definitions.EnumDef(
+                "builder_type",
+                label="Asset Builder Type",
+                default=options.get("builder_type"),
+                items=[
+                    ("context_asset", "Current asset"),
+                    ("linked_asset", "Linked assets"),
+                    ("all_assets", "All assets")
+                ],
+                tooltip=(
+                    "Asset Builder Type\n"
+                    "\nBuilder type describe what template loader will look"
+                    " for."
+                    "\ncontext_asset : Template loader will look for subsets"
+                    " of current context asset (Asset bob will find asset)"
+                    "\nlinked_asset : Template loader will look for assets"
+                    " linked to current context asset."
+                    "\nLinked asset are looked in database under"
+                    " field \"inputLinks\""
+                )
+            ),
+            attribute_definitions.TextDef(
+                "family",
+                label="Family",
+                default=options.get("family"),
+                placeholder="model, look, ..."
+            ),
+            attribute_definitions.TextDef(
+                "representation",
+                label="Representation name",
+                default=options.get("representation"),
+                placeholder="ma, abc, ..."
+            ),
+            attribute_definitions.EnumDef(
+                "loader",
+                label="Loader",
+                default=options.get("loader"),
+                items=loader_items,
+                tooltip=(
+                    "Loader"
+                    "\nDefines what OpenPype loader will be used to"
+                    " load assets."
+                    "\nUseable loader depends on current host's loader list."
+                    "\nField is case sensitive."
+                )
+            ),
+            attribute_definitions.TextDef(
+                "loader_args",
+                label="Loader Arguments",
+                default=options.get("loader_args"),
+                placeholder='{"camera":"persp", "lights":True}',
+                tooltip=(
+                    "Loader"
+                    "\nDefines a dictionnary of arguments used to load assets."
+                    "\nUseable arguments depend on current placeholder Loader."
+                    "\nField should be a valid python dict."
+                    " Anything else will be ignored."
+                )
+            ),
+            attribute_definitions.NumberDef(
+                "order",
+                label="Order",
+                default=options.get("order") or 0,
+                decimals=0,
+                minimum=0,
+                maximum=999,
+                tooltip=(
+                    "Order"
+                    "\nOrder defines asset loading priority (0 to 999)"
+                    "\nPriority rule is : \"lowest is first to load\"."
+                )
+            ),
+            attribute_definitions.UISeparatorDef(),
+            attribute_definitions.UILabelDef("Optional attributes"),
+            attribute_definitions.UISeparatorDef(),
+            attribute_definitions.TextDef(
+                "asset",
+                label="Asset filter",
+                default=options.get("asset"),
+                placeholder="regex filtering by asset name",
+                tooltip=(
+                    "Filtering assets by matching field regex to asset's name"
+                )
+            ),
+            attribute_definitions.TextDef(
+                "subset",
+                label="Subset filter",
+                default=options.get("subset"),
+                placeholder="regex filtering by subset name",
+                tooltip=(
+                    "Filtering assets by matching field regex to subset's name"
+                )
+            ),
+            attribute_definitions.TextDef(
+                "hierarchy",
+                label="Hierarchy filter",
+                default=options.get("hierarchy"),
+                placeholder="regex filtering by asset's hierarchy",
+                tooltip=(
+                    "Filtering assets by matching field asset's hierarchy"
+                )
+            )
+        ]
+
+    def parse_loader_args(self, loader_args):
+        """Helper function to parse string of loader arugments.
+
+        Empty dictionary is returned if conversion fails.
+
+        Args:
+            loader_args (str): Loader args filled by user.
+
+        Returns:
+            Dict[str, Any]: Parsed arguments used as dictionary.
+        """
+
+        if not loader_args:
+            return {}
+
+        try:
+            parsed_args = eval(loader_args)
+            if isinstance(parsed_args, dict):
+                return parsed_args
+
+        except Exception as err:
+            print(
+                "Error while parsing loader arguments '{}'.\n{}: {}\n\n"
+                "Continuing with default arguments. . .".format(
+                    loader_args, err.__class__.__name__, err))
+
+        return {}
+
+    def get_representations(self, placeholder):
+        project_name = self.builder.project_name
+        current_asset_doc = self.builder.current_asset_doc
+        linked_asset_docs = self.builder.linked_asset_docs
+
+        builder_type = placeholder.data["builder_type"]
+        if builder_type == "context_asset":
+            context_filters = {
+                "asset": [current_asset_doc["name"]],
+                "subset": [re.compile(placeholder.data["subset"])],
+                "hierarchy": [re.compile(placeholder.data["hierarchy"])],
+                "representations": [placeholder.data["representation"]],
+                "family": [placeholder.data["family"]]
+            }
+
+        elif builder_type != "linked_asset":
+            context_filters = {
+                "asset": [re.compile(placeholder.data["asset"])],
+                "subset": [re.compile(placeholder.data["subset"])],
+                "hierarchy": [re.compile(placeholder.data["hierarchy"])],
+                "representation": [placeholder.data["representation"]],
+                "family": [placeholder.data["family"]]
+            }
+
+        else:
+            asset_regex = re.compile(placeholder.data["asset"])
+            linked_asset_names = []
+            for asset_doc in linked_asset_docs:
+                asset_name = asset_doc["name"]
+                if asset_regex.match(asset_name):
+                    linked_asset_names.append(asset_name)
+
+            context_filters = {
+                "asset": linked_asset_names,
+                "subset": [re.compile(placeholder.data["subset"])],
+                "hierarchy": [re.compile(placeholder.data["hierarchy"])],
+                "representation": [placeholder.data["representation"]],
+                "family": [placeholder.data["family"]],
+            }
+
+        return list(get_representations(
+            project_name,
+            context_filters=context_filters
+        ))
+
+    def populate_load_placeholder(self, placeholder, ignore_repre_ids=None):
+        if ignore_repre_ids is None:
+            ignore_repre_ids = set()
+
+        # TODO check loader existence
+        loader_name = placeholder.data["loader"]
+        loader_args = placeholder.data["loader_args"]
+
+        placeholder_representations = self.get_representations(placeholder)
+
+        filtered_representations = []
+        for representation in placeholder_representations:
+            repre_id = str(representation["_id"])
+            if repre_id not in ignore_repre_ids:
+                filtered_representations.append(representation)
+
+        if not filtered_representations:
+            self.log.info((
+                "There's no representation for this placeholder: {}"
+            ).format(placeholder.scene_identifier))
+            return
+
+        repre_load_contexts = get_contexts_for_repre_docs(
+            self.project_name, filtered_representations
+        )
+        loaders_by_name = self.builder.get_loaders_by_name()
+        for repre_load_context in repre_load_contexts:
+            representation = repre_load_context["representation"]
+            repre_context = representation["context"]
+            self.log.info(
+                "Loading {} from {} with loader {}\n"
+                "Loader arguments used : {}".format(
+                    repre_context["subset"],
+                    repre_context["asset"],
+                    loader_name,
+                    loader_args
+                )
+            )
+            try:
+                container = load_with_repre_context(
+                    loaders_by_name[loader_name],
+                    repre_load_context,
+                    options=self.parse_loader_args(loader_args)
+                )
+
+            except Exception:
+                placeholder.load_failed(representation)
+
+            else:
+                placeholder.load_succeed(container)
+            placeholder.clean()

From a2a900d18aedf1ad9e4fd87868487f24359df094 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 9 Sep 2022 19:16:28 +0200
Subject: [PATCH 066/147] fix class name change

---
 openpype/hosts/maya/api/pipeline.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/maya/api/pipeline.py b/openpype/hosts/maya/api/pipeline.py
index c47e34aebc..70e6b02e4c 100644
--- a/openpype/hosts/maya/api/pipeline.py
+++ b/openpype/hosts/maya/api/pipeline.py
@@ -35,7 +35,7 @@ from openpype.hosts.maya import MAYA_ROOT_DIR
 from openpype.hosts.maya.lib import copy_workspace_mel
 
 from . import menu, lib
-from .workfile_template_builder import MayaLoadPlaceholderPlugin
+from .workfile_template_builder import MayaPlaceholderLoadPlugin
 from .workio import (
     open_file,
     save_file,
@@ -126,7 +126,7 @@ class MayaHost(HostBase, IWorkfileHost, ILoadHost):
 
     def get_workfile_build_placeholder_plugins(self):
         return [
-            MayaLoadPlaceholderPlugin
+            MayaPlaceholderLoadPlugin
         ]
 
     @contextlib.contextmanager

From 5fa019527b2868c010334a6c36852e32ebaa476e Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Mon, 12 Sep 2022 10:26:23 +0200
Subject: [PATCH 067/147] OP-3682 - changed folder structure

---
 {distribution => common/openpype_common/distribution}/README.md | 0
 .../openpype_common/distribution}/__init__.py                   | 0
 .../openpype_common/distribution}/addon_distribution.py         | 2 +-
 .../openpype_common/distribution}/file_handler.py               | 0
 .../distribution}/tests/test_addon_distributtion.py             | 2 +-
 5 files changed, 2 insertions(+), 2 deletions(-)
 rename {distribution => common/openpype_common/distribution}/README.md (100%)
 rename {distribution => common/openpype_common/distribution}/__init__.py (100%)
 rename {distribution => common/openpype_common/distribution}/addon_distribution.py (98%)
 rename {distribution => common/openpype_common/distribution}/file_handler.py (100%)
 rename {distribution => common/openpype_common/distribution}/tests/test_addon_distributtion.py (98%)

diff --git a/distribution/README.md b/common/openpype_common/distribution/README.md
similarity index 100%
rename from distribution/README.md
rename to common/openpype_common/distribution/README.md
diff --git a/distribution/__init__.py b/common/openpype_common/distribution/__init__.py
similarity index 100%
rename from distribution/__init__.py
rename to common/openpype_common/distribution/__init__.py
diff --git a/distribution/addon_distribution.py b/common/openpype_common/distribution/addon_distribution.py
similarity index 98%
rename from distribution/addon_distribution.py
rename to common/openpype_common/distribution/addon_distribution.py
index 389b92b10b..e39ce66a0a 100644
--- a/distribution/addon_distribution.py
+++ b/common/openpype_common/distribution/addon_distribution.py
@@ -7,7 +7,7 @@ import requests
 import platform
 import shutil
 
-from distribution.file_handler import RemoteFileHandler
+from common.openpype_common.distribution.file_handler import RemoteFileHandler
 
 
 class UrlType(Enum):
diff --git a/distribution/file_handler.py b/common/openpype_common/distribution/file_handler.py
similarity index 100%
rename from distribution/file_handler.py
rename to common/openpype_common/distribution/file_handler.py
diff --git a/distribution/tests/test_addon_distributtion.py b/common/openpype_common/distribution/tests/test_addon_distributtion.py
similarity index 98%
rename from distribution/tests/test_addon_distributtion.py
rename to common/openpype_common/distribution/tests/test_addon_distributtion.py
index c6ecaca3c8..7dd27fd44f 100644
--- a/distribution/tests/test_addon_distributtion.py
+++ b/common/openpype_common/distribution/tests/test_addon_distributtion.py
@@ -2,7 +2,7 @@ import pytest
 import attr
 import tempfile
 
-from distribution.addon_distribution import (
+from common.openpype_common.distribution.addon_distribution import (
     AddonDownloader,
     UrlType,
     OSAddonDownloader,

From 37286eef2ce894d357cfaa530434f011f5ff4a59 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 11:42:38 +0200
Subject: [PATCH 068/147] propagated 'get_contexts_for_repre_docs' to load init

---
 openpype/pipeline/load/__init__.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/openpype/pipeline/load/__init__.py b/openpype/pipeline/load/__init__.py
index bf38a0b3c8..e96f64f2a4 100644
--- a/openpype/pipeline/load/__init__.py
+++ b/openpype/pipeline/load/__init__.py
@@ -5,6 +5,7 @@ from .utils import (
     InvalidRepresentationContext,
 
     get_repres_contexts,
+    get_contexts_for_repre_docs,
     get_subset_contexts,
     get_representation_context,
 
@@ -54,6 +55,7 @@ __all__ = (
     "InvalidRepresentationContext",
 
     "get_repres_contexts",
+    "get_contexts_for_repre_docs",
     "get_subset_contexts",
     "get_representation_context",
 

From cacfa0999553e35af0cafb9272c83414bcfc50c5 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 11:43:16 +0200
Subject: [PATCH 069/147] reduce representations to last version

---
 .../pipeline/workfile/new_template_loader.py  | 45 +++++++++++++------
 1 file changed, 31 insertions(+), 14 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 921cc39ba9..2cae32a04a 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -46,19 +46,6 @@ class AbstractTemplateLoader:
     _log = None
 
     def __init__(self, host):
-        # Prepare context information
-        project_name = legacy_io.active_project()
-        asset_name = legacy_io.Session["AVALON_ASSET"]
-        task_name = legacy_io.Session["AVALON_TASK"]
-        current_asset_doc = get_asset_by_name(project_name, asset_name)
-        task_type = (
-            current_asset_doc
-            .get("data", {})
-            .get("tasks", {})
-            .get(task_name, {})
-            .get("type")
-        )
-
         # Get host name
         if isinstance(host, HostBase):
             host_name = host.name
@@ -1172,6 +1159,34 @@ class PlaceholderLoadMixin(object):
             context_filters=context_filters
         ))
 
+    def _reduce_last_version_repre_docs(self, representations):
+        """Reduce representations to last verison."""
+
+        mapping = {}
+        for repre_doc in representations:
+            repre_context = repre_doc["context"]
+
+            asset_name = repre_context["asset"]
+            subset_name = repre_context["subset"]
+            version = repre_context.get("version", -1)
+
+            if asset_name not in mapping:
+                mapping[asset_name] = {}
+
+            subset_mapping = mapping[asset_name]
+            if subset_name not in subset_mapping:
+                subset_mapping[subset_name] = collections.defaultdict(list)
+
+            version_mapping = subset_mapping[subset_name]
+            version_mapping[version].append(repre_doc)
+
+        output = []
+        for subset_mapping in mapping.values():
+            for version_mapping in subset_mapping.values():
+                last_version = tuple(sorted(version_mapping.keys()))[-1]
+                output.extend(version_mapping[last_version])
+        return output
+
     def populate_load_placeholder(self, placeholder, ignore_repre_ids=None):
         if ignore_repre_ids is None:
             ignore_repre_ids = set()
@@ -1183,7 +1198,9 @@ class PlaceholderLoadMixin(object):
         placeholder_representations = self.get_representations(placeholder)
 
         filtered_representations = []
-        for representation in placeholder_representations:
+        for representation in self._reduce_last_version_repre_docs(
+            placeholder_representations
+        ):
             repre_id = str(representation["_id"])
             if repre_id not in ignore_repre_ids:
                 filtered_representations.append(representation)

From af895da690654573f64c542ce09ad6690fc7e817 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 11:43:51 +0200
Subject: [PATCH 070/147] few minor fixes

---
 .../pipeline/workfile/new_template_loader.py  | 27 ++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 2cae32a04a..65c50b9d80 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -604,6 +604,10 @@ class PlaceholderPlugin(object):
 
         return self._builder
 
+    @property
+    def project_name(self):
+        return self._builder.project_name
+
     @property
     def log(self):
         """Dynamically created logger for the plugin."""
@@ -956,7 +960,7 @@ class PlaceholderLoadMixin(object):
         """Unified attribute definitions for load placeholder.
 
         Common function for placeholder plugins used for loading of
-        repsentations.
+        repsentations. Use it in 'get_placeholder_options'.
 
         Args:
             plugin (PlaceholderPlugin): Plugin used for loading of
@@ -1125,7 +1129,7 @@ class PlaceholderLoadMixin(object):
                 "asset": [current_asset_doc["name"]],
                 "subset": [re.compile(placeholder.data["subset"])],
                 "hierarchy": [re.compile(placeholder.data["hierarchy"])],
-                "representations": [placeholder.data["representation"]],
+                "representation": [placeholder.data["representation"]],
                 "family": [placeholder.data["family"]]
             }
 
@@ -1188,6 +1192,23 @@ class PlaceholderLoadMixin(object):
         return output
 
     def populate_load_placeholder(self, placeholder, ignore_repre_ids=None):
+        """Load placeholder is goind to load matching representations.
+
+        Note:
+            Ignore repre ids is to avoid loading the same representation again
+            on load. But the representation can be loaded with different loader
+            and there could be published new version of matching subset for the
+            representation. We should maybe expect containers.
+
+            Also import loaders don't have containers at all...
+
+        Args:
+            placeholder (PlaceholderItem): Placeholder item with information
+                about requested representations.
+            ignore_repre_ids (Iterable[Union[str, ObjectId]]): Representation
+                ids that should be skipped.
+        """
+
         if ignore_repre_ids is None:
             ignore_repre_ids = set()
 
@@ -1215,7 +1236,7 @@ class PlaceholderLoadMixin(object):
             self.project_name, filtered_representations
         )
         loaders_by_name = self.builder.get_loaders_by_name()
-        for repre_load_context in repre_load_contexts:
+        for repre_load_context in repre_load_contexts.values():
             representation = repre_load_context["representation"]
             repre_context = representation["context"]
             self.log.info(

From 09c73beec90df7b493e83e481fc97313a4d7a850 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 11:44:04 +0200
Subject: [PATCH 071/147] added option to have callback before load

---
 openpype/pipeline/workfile/new_template_loader.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 65c50b9d80..07ff69d1f5 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -1163,6 +1163,11 @@ class PlaceholderLoadMixin(object):
             context_filters=context_filters
         ))
 
+    def _before_repre_load(self, placeholder, representation):
+        """Can be overriden. Is called before representation is loaded."""
+
+        pass
+
     def _reduce_last_version_repre_docs(self, representations):
         """Reduce representations to last verison."""
 
@@ -1239,6 +1244,9 @@ class PlaceholderLoadMixin(object):
         for repre_load_context in repre_load_contexts.values():
             representation = repre_load_context["representation"]
             repre_context = representation["context"]
+            self._before_repre_load(
+                placeholder, representation
+            )
             self.log.info(
                 "Loading {} from {} with loader {}\n"
                 "Loader arguments used : {}".format(

From c702d117172c3b7561eedd5cdb70ada3b5a399cc Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 11:44:37 +0200
Subject: [PATCH 072/147] moved cleanup logic to plugin responsibility instead
 of placeholder's

---
 .../maya/api/workfile_template_builder.py     | 48 ++++++++++---------
 .../pipeline/workfile/new_template_loader.py  |  5 +-
 2 files changed, 29 insertions(+), 24 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index 14f1f284fd..42736badf2 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -216,6 +216,31 @@ class MayaPlaceholderLoadPlugin(PlaceholderPlugin, PlaceholderLoadMixin):
     def get_placeholder_options(self, options=None):
         return self.get_load_plugin_options(self, options)
 
+    def cleanup_placeholder(self, placeholder):
+        """Hide placeholder, parent them to root
+        add them to placeholder set and register placeholder's parent
+        to keep placeholder info available for future use
+        """
+
+        node = placeholder._scene_identifier
+        node_parent = placeholder.data["parent"]
+        if node_parent:
+            cmds.setAttr(node + ".parent", node_parent, type="string")
+
+        if cmds.getAttr(node + ".index") < 0:
+            cmds.setAttr(node + ".index", placeholder.data["index"])
+
+        holding_sets = cmds.listSets(object=node)
+        if holding_sets:
+            for set in holding_sets:
+                cmds.sets(node, remove=set)
+
+        if cmds.listRelatives(node, p=True):
+            node = cmds.parent(node, world=True)[0]
+        cmds.sets(node, addElement=PLACEHOLDER_SET)
+        cmds.hide(node)
+        cmds.setAttr(node + ".hiddenInOutliner", True)
+
 
 class LoadPlaceholderItem(PlaceholderItem):
     """Concrete implementation of PlaceholderItem for Maya load plugin."""
@@ -269,29 +294,6 @@ class LoadPlaceholderItem(PlaceholderItem):
         for holding_set in holding_sets:
             cmds.sets(roots, forceElement=holding_set)
 
-    def clean(self):
-        """Hide placeholder, parent them to root
-        add them to placeholder set and register placeholder's parent
-        to keep placeholder info available for future use
-        """
-
-        node = self._scene_identifier
-        if self.data['parent']:
-            cmds.setAttr(node + '.parent', self.data['parent'], type='string')
-        if cmds.getAttr(node + '.index') < 0:
-            cmds.setAttr(node + '.index', self.data['index'])
-
-        holding_sets = cmds.listSets(object=node)
-        if holding_sets:
-            for set in holding_sets:
-                cmds.sets(node, remove=set)
-
-        if cmds.listRelatives(node, p=True):
-            node = cmds.parent(node, world=True)[0]
-        cmds.sets(node, addElement=PLACEHOLDER_SET)
-        cmds.hide(node)
-        cmds.setAttr(node + ".hiddenInOutliner", True)
-
     def get_errors(self):
         if not self._failed_representations:
             return []
diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/new_template_loader.py
index 07ff69d1f5..3f81ce0114 100644
--- a/openpype/pipeline/workfile/new_template_loader.py
+++ b/openpype/pipeline/workfile/new_template_loader.py
@@ -1268,4 +1268,7 @@ class PlaceholderLoadMixin(object):
 
             else:
                 placeholder.load_succeed(container)
-            placeholder.clean()
+            self.cleanup_placeholder(placeholder)
+
+    def cleanup_placeholder(self, placeholder):
+        pass

From f36b0aa2c6026d093ffc7421a52eb9c59264c740 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 11:48:41 +0200
Subject: [PATCH 073/147] initial commit of nuke workfile builder

---
 openpype/hosts/nuke/api/__init__.py           |   4 +
 openpype/hosts/nuke/api/pipeline.py           |   6 +
 .../nuke/api/workfile_template_builder.py     | 607 ++++++++++++++++++
 3 files changed, 617 insertions(+)
 create mode 100644 openpype/hosts/nuke/api/workfile_template_builder.py

diff --git a/openpype/hosts/nuke/api/__init__.py b/openpype/hosts/nuke/api/__init__.py
index 962f31c177..c65058874b 100644
--- a/openpype/hosts/nuke/api/__init__.py
+++ b/openpype/hosts/nuke/api/__init__.py
@@ -21,6 +21,8 @@ from .pipeline import (
     containerise,
     parse_container,
     update_container,
+
+    get_workfile_build_placeholder_plugins,
 )
 from .lib import (
     maintained_selection,
@@ -55,6 +57,8 @@ __all__ = (
     "parse_container",
     "update_container",
 
+    "get_workfile_build_placeholder_plugins",
+
     "maintained_selection",
     "reset_selection",
     "get_view_process_node",
diff --git a/openpype/hosts/nuke/api/pipeline.py b/openpype/hosts/nuke/api/pipeline.py
index bac42128cc..d4edd24cf6 100644
--- a/openpype/hosts/nuke/api/pipeline.py
+++ b/openpype/hosts/nuke/api/pipeline.py
@@ -141,6 +141,12 @@ def _show_workfiles():
     host_tools.show_workfiles(parent=None, on_top=False)
 
 
+def get_workfile_build_placeholder_plugins():
+    return [
+        NukePlaceholderLoadPlugin
+    ]
+
+
 def _install_menu():
     # uninstall original avalon menu
     main_window = get_main_window()
diff --git a/openpype/hosts/nuke/api/workfile_template_builder.py b/openpype/hosts/nuke/api/workfile_template_builder.py
new file mode 100644
index 0000000000..71ea5c95a5
--- /dev/null
+++ b/openpype/hosts/nuke/api/workfile_template_builder.py
@@ -0,0 +1,607 @@
+import json
+import collections
+
+import nuke
+
+from openpype.pipeline import registered_host
+from openpype.pipeline.workfile.build_template_exceptions import (
+    TemplateAlreadyImported
+)
+from openpype.pipeline.workfile.new_template_loader import (
+    AbstractTemplateLoader,
+    PlaceholderPlugin,
+    PlaceholderItem,
+    PlaceholderLoadMixin,
+)
+from openpype.tools.workfile_template_build import (
+    WorkfileBuildPlaceholderDialog,
+)
+
+from .lib import (
+    find_free_space_to_paste_nodes,
+    get_extreme_positions,
+    get_group_io_nodes,
+    imprint,
+    refresh_node,
+    refresh_nodes,
+    reset_selection,
+    get_names_from_nodes,
+    get_nodes_by_names,
+    select_nodes,
+    duplicate_node,
+    node_tempfile,
+)
+
+PLACEHOLDER_SET = "PLACEHOLDERS_SET"
+
+
+class NukeTemplateLoader(AbstractTemplateLoader):
+    """Concrete implementation of AbstractTemplateLoader for maya"""
+
+    def import_template(self, path):
+        """Import template into current scene.
+        Block if a template is already loaded.
+
+        Args:
+            path (str): A path to current template (usually given by
+            get_template_path implementation)
+
+        Returns:
+            bool: Wether the template was succesfully imported or not
+        """
+
+        # TODO check if the template is already imported
+
+        nuke.nodePaste(path)
+        reset_selection()
+
+        return True
+
+
+class NukePlaceholderPlugin(PlaceholderPlugin):
+    noce_color = 4278190335
+
+    def _collect_scene_placeholders(self):
+        # Cache placeholder data to shared data
+        placeholder_nodes = self.builder.get_shared_populate_data(
+            "placeholder_nodes"
+        )
+        if placeholder_nodes is None:
+            placeholder_nodes = {}
+            all_groups = collections.deque()
+            all_groups.append(nuke.thisGroup())
+            while all_groups:
+                group = all_groups.popleft()
+                for node in group.nodes():
+                    if isinstance(node, nuke.Group):
+                        all_groups.append(node)
+
+                    node_knobs = node.knobs()
+                    if (
+                        "builder_type" not in node_knobs
+                        or "is_placeholder" not in node_knobs
+                        or not node.knob("is_placeholder").value()
+                    ):
+                        continue
+
+                    if "empty" in node_knobs and node.knob("empty").value():
+                        continue
+
+                    placeholder_nodes[node.fullName()] = node
+
+            self.builder.set_shared_populate_data(
+                "placeholder_nodes", placeholder_nodes
+            )
+        return placeholder_nodes
+
+    def create_placeholder(self, placeholder_data):
+        placeholder_data["plugin_identifier"] = self.identifier
+
+        placeholder = nuke.nodes.NoOp()
+        placeholder.setName("PLACEHOLDER")
+        placeholder.knob("tile_color").setValue(self.node_color)
+
+        imprint(placeholder, placeholder_data)
+        imprint(placeholder, {"is_placeholder": True})
+        placeholder.knob("is_placeholder").setVisible(False)
+
+    def update_placeholder(self, placeholder_item, placeholder_data):
+        node = nuke.toNode(placeholder_item.scene_identifier)
+        imprint(node, placeholder_data)
+
+    def _parse_placeholder_node_data(self, node):
+        placeholder_data = {}
+        for key in self.get_placeholder_keys():
+            knob = node.knob(key)
+            value = None
+            if knob is not None:
+                value = knob.getValue()
+            placeholder_data[key] = value
+        return placeholder_data
+
+
+class NukePlaceholderLoadPlugin(NukePlaceholderPlugin, PlaceholderLoadMixin):
+    identifier = "nuke.load"
+    label = "Nuke load"
+
+    def _parse_placeholder_node_data(self, node):
+        placeholder_data = super(
+            NukePlaceholderLoadPlugin, self
+        )._parse_placeholder_node_data(node)
+
+        node_knobs = node.knobs()
+        nb_children = 0
+        if "nb_children" in node_knobs:
+            nb_children = int(node_knobs["nb_children"].getValue())
+        placeholder_data["nb_children"] = nb_children
+
+        siblings = []
+        if "siblings" in node_knobs:
+            siblings = node_knobs["siblings"].values()
+        placeholder_data["siblings"] = siblings
+
+        node_full_name = node.fullName()
+        placeholder_data["group_name"] = node_full_name.rpartition(".")[0]
+        placeholder_data["last_loaded"] = []
+        placeholder_data["delete"] = False
+        return placeholder_data
+
+    def _get_loaded_repre_ids(self):
+        loaded_representation_ids = self.builder.get_shared_populate_data(
+            "loaded_representation_ids"
+        )
+        if loaded_representation_ids is None:
+            loaded_representation_ids = set()
+            for node in nuke.allNodes():
+                if "repre_id" in node.knobs():
+                    loaded_representation_ids.add(
+                        node.knob("repre_id").getValue()
+                    )
+
+            self.builder.set_shared_populate_data(
+                "loaded_representation_ids", loaded_representation_ids
+            )
+        return loaded_representation_ids
+
+    def _before_repre_load(self, placeholder, representation):
+        placeholder.data["nodes_init"] = nuke.allNodes()
+        placeholder.data["last_repre_id"] = str(representation["_id"])
+
+    def collect_placeholders(self):
+        output = []
+        scene_placeholders = self._collect_scene_placeholders()
+        for node_name, node in scene_placeholders.items():
+            plugin_identifier_knob = node.knob("plugin_identifier")
+            if (
+                plugin_identifier_knob is None
+                or plugin_identifier_knob.getValue() != self.identifier
+            ):
+                continue
+
+            placeholder_data = self._parse_placeholder_node_data(node)
+            # TODO do data validations and maybe updgrades if are invalid
+            output.append(
+                NukeLoadPlaceholderItem(node_name, placeholder_data, self)
+            )
+
+        return output
+
+    def populate_placeholder(self, placeholder):
+        self.populate_load_placeholder(placeholder)
+
+    def update_template_placeholder(self, placeholder):
+        repre_ids = self._get_loaded_repre_ids()
+        self.populate_load_placeholder(placeholder, repre_ids)
+
+    def get_placeholder_options(self, options=None):
+        return self.get_load_plugin_options(options)
+
+    def cleanup_placeholder(self, placeholder):
+        # deselect all selected nodes
+        placeholder_node = nuke.toNode(placeholder.scene_identifier)
+
+        # getting the latest nodes added
+        # TODO get from shared populate data!
+        nodes_init = placeholder.data["nodes_init"]
+        nodes_loaded = list(set(nuke.allNodes()) - set(nodes_init))
+        self.log.debug("Loaded nodes: {}".format(nodes_loaded))
+        if not nodes_loaded:
+            return
+
+        placeholder.data["delete"] = True
+
+        nodes_loaded = self._move_to_placeholder_group(
+            placeholder, nodes_loaded
+        )
+        placeholder.data["last_loaded"] = nodes_loaded
+        refresh_nodes(nodes_loaded)
+
+        # positioning of the loaded nodes
+        min_x, min_y, _, _ = get_extreme_positions(nodes_loaded)
+        for node in nodes_loaded:
+            xpos = (node.xpos() - min_x) + placeholder_node.xpos()
+            ypos = (node.ypos() - min_y) + placeholder_node.ypos()
+            node.setXYpos(xpos, ypos)
+        refresh_nodes(nodes_loaded)
+
+        # fix the problem of z_order for backdrops
+        self._fix_z_order(placeholder)
+        self._imprint_siblings(placeholder)
+
+        if placeholder.data["nb_children"] == 0:
+            # save initial nodes postions and dimensions, update them
+            # and set inputs and outputs of loaded nodes
+
+            self._imprint_inits()
+            self._update_nodes(placeholder, nuke.allNodes(), nodes_loaded)
+            self._set_loaded_connections(placeholder)
+
+        elif placeholder.data["siblings"]:
+            # create copies of placeholder siblings for the new loaded nodes,
+            # set their inputs and outpus and update all nodes positions and
+            # dimensions and siblings names
+
+            siblings = get_nodes_by_names(placeholder.data["siblings"])
+            refresh_nodes(siblings)
+            copies = self._create_sib_copies(placeholder)
+            new_nodes = list(copies.values())  # copies nodes
+            self._update_nodes(new_nodes, nodes_loaded)
+            placeholder_node.removeKnob(placeholder_node.knob("siblings"))
+            new_nodes_name = get_names_from_nodes(new_nodes)
+            imprint(placeholder_node, {"siblings": new_nodes_name})
+            self._set_copies_connections(placeholder, copies)
+
+            self._update_nodes(
+                nuke.allNodes(),
+                new_nodes + nodes_loaded,
+                20
+            )
+
+            new_siblings = get_names_from_nodes(new_nodes)
+            placeholder.data["siblings"] = new_siblings
+
+        else:
+            # if the placeholder doesn't have siblings, the loaded
+            # nodes will be placed in a free space
+
+            xpointer, ypointer = find_free_space_to_paste_nodes(
+                nodes_loaded, direction="bottom", offset=200
+            )
+            node = nuke.createNode("NoOp")
+            reset_selection()
+            nuke.delete(node)
+            for node in nodes_loaded:
+                xpos = (node.xpos() - min_x) + xpointer
+                ypos = (node.ypos() - min_y) + ypointer
+                node.setXYpos(xpos, ypos)
+
+        placeholder.data["nb_children"] += 1
+        reset_selection()
+        # go back to root group
+        nuke.root().begin()
+
+    def _move_to_placeholder_group(self, placeholder, nodes_loaded):
+        """
+        opening the placeholder's group and copying loaded nodes in it.
+
+        Returns :
+            nodes_loaded (list): the new list of pasted nodes
+        """
+
+        groups_name = placeholder.data["group_name"]
+        reset_selection()
+        select_nodes(nodes_loaded)
+        if groups_name:
+            with node_tempfile() as filepath:
+                nuke.nodeCopy(filepath)
+                for node in nuke.selectedNodes():
+                    nuke.delete(node)
+                group = nuke.toNode(groups_name)
+                group.begin()
+                nuke.nodePaste(filepath)
+                nodes_loaded = nuke.selectedNodes()
+        return nodes_loaded
+
+    def _fix_z_order(self, placeholder):
+        """Fix the problem of z_order when a backdrop is loaded."""
+
+        nodes_loaded = placeholder.data["last_loaded"]
+        loaded_backdrops = []
+        bd_orders = set()
+        for node in nodes_loaded:
+            if isinstance(node, nuke.BackdropNode):
+                loaded_backdrops.append(node)
+                bd_orders.add(node.knob("z_order").getValue())
+
+        if not bd_orders:
+            return
+
+        sib_orders = set()
+        for node_name in placeholder.data["siblings"]:
+            node = nuke.toNode(node_name)
+            if isinstance(node, nuke.BackdropNode):
+                sib_orders.add(node.knob("z_order").getValue())
+
+        if not sib_orders:
+            return
+
+        min_order = min(bd_orders)
+        max_order = max(sib_orders)
+        for backdrop_node in loaded_backdrops:
+            z_order = backdrop_node.knob("z_order").getValue()
+            backdrop_node.knob("z_order").setValue(
+                z_order + max_order - min_order + 1)
+
+    def _imprint_siblings(self, placeholder):
+        """
+        - add siblings names to placeholder attributes (nodes loaded with it)
+        - add Id to the attributes of all the other nodes
+        """
+
+        loaded_nodes = placeholder.data["last_loaded"]
+        loaded_nodes_set = set(loaded_nodes)
+        data = {"repre_id": str(placeholder.data["last_repre_id"])}
+
+        for node in loaded_nodes:
+            node_knobs = node.knobs()
+            if "builder_type" not in node_knobs:
+                # save the id of representation for all imported nodes
+                imprint(node, data)
+                node.knob("repre_id").setVisible(False)
+                refresh_node(node)
+                continue
+
+            if (
+                "is_placeholder" not in node_knobs
+                or (
+                    "is_placeholder" in node_knobs
+                    and node.knob("is_placeholder").value()
+                )
+            ):
+                siblings = list(loaded_nodes_set - {node})
+                siblings_name = get_names_from_nodes(siblings)
+                siblings = {"siblings": siblings_name}
+                imprint(node, siblings)
+
+    def _imprint_inits(self):
+        """Add initial positions and dimensions to the attributes"""
+
+        for node in nuke.allNodes():
+            refresh_node(node)
+            imprint(node, {"x_init": node.xpos(), "y_init": node.ypos()})
+            node.knob("x_init").setVisible(False)
+            node.knob("y_init").setVisible(False)
+            width = node.screenWidth()
+            height = node.screenHeight()
+            if "bdwidth" in node.knobs():
+                imprint(node, {"w_init": width, "h_init": height})
+                node.knob("w_init").setVisible(False)
+                node.knob("h_init").setVisible(False)
+            refresh_node(node)
+
+    def _update_nodes(
+        self, placeholder, nodes, considered_nodes, offset_y=None
+    ):
+        """Adjust backdrop nodes dimensions and positions.
+
+        Considering some nodes sizes.
+
+        Args:
+            nodes (list): list of nodes to update
+            considered_nodes (list): list of nodes to consider while updating
+                positions and dimensions
+            offset (int): distance between copies
+        """
+
+        placeholder_node = nuke.toNode(placeholder.scene_identifier)
+
+        min_x, min_y, max_x, max_y = get_extreme_positions(considered_nodes)
+
+        diff_x = diff_y = 0
+        contained_nodes = []  # for backdrops
+
+        if offset_y is None:
+            width_ph = placeholder_node.screenWidth()
+            height_ph = placeholder_node.screenHeight()
+            diff_y = max_y - min_y - height_ph
+            diff_x = max_x - min_x - width_ph
+            contained_nodes = [placeholder_node]
+            min_x = placeholder_node.xpos()
+            min_y = placeholder_node.ypos()
+        else:
+            siblings = get_nodes_by_names(placeholder.data["siblings"])
+            minX, _, maxX, _ = get_extreme_positions(siblings)
+            diff_y = max_y - min_y + 20
+            diff_x = abs(max_x - min_x - maxX + minX)
+            contained_nodes = considered_nodes
+
+        if diff_y <= 0 and diff_x <= 0:
+            return
+
+        for node in nodes:
+            refresh_node(node)
+
+            if (
+                node == placeholder_node
+                or node in considered_nodes
+            ):
+                continue
+
+            if (
+                not isinstance(node, nuke.BackdropNode)
+                or (
+                    isinstance(node, nuke.BackdropNode)
+                    and not set(contained_nodes) <= set(node.getNodes())
+                )
+            ):
+                if offset_y is None and node.xpos() >= min_x:
+                    node.setXpos(node.xpos() + diff_x)
+
+                if node.ypos() >= min_y:
+                    node.setYpos(node.ypos() + diff_y)
+
+            else:
+                width = node.screenWidth()
+                height = node.screenHeight()
+                node.knob("bdwidth").setValue(width + diff_x)
+                node.knob("bdheight").setValue(height + diff_y)
+
+            refresh_node(node)
+
+    def _set_loaded_connections(self, placeholder):
+        """
+        set inputs and outputs of loaded nodes"""
+
+        placeholder_node = nuke.toNode(placeholder.scene_identifier)
+        input_node, output_node = get_group_io_nodes(
+            placeholder.data["last_loaded"]
+        )
+        for node in placeholder_node.dependent():
+            for idx in range(node.inputs()):
+                if node.input(idx) == placeholder_node:
+                    node.setInput(idx, output_node)
+
+        for node in placeholder_node.dependencies():
+            for idx in range(placeholder_node.inputs()):
+                if placeholder_node.input(idx) == node:
+                    input_node.setInput(0, node)
+
+    def _create_sib_copies(self, placeholder):
+        """ creating copies of the palce_holder siblings (the ones who were
+        loaded with it) for the new nodes added
+
+        Returns :
+            copies (dict) : with copied nodes names and their copies
+        """
+
+        copies = {}
+        siblings = get_nodes_by_names(placeholder.data["siblings"])
+        for node in siblings:
+            new_node = duplicate_node(node)
+
+            x_init = int(new_node.knob("x_init").getValue())
+            y_init = int(new_node.knob("y_init").getValue())
+            new_node.setXYpos(x_init, y_init)
+            if isinstance(new_node, nuke.BackdropNode):
+                w_init = new_node.knob("w_init").getValue()
+                h_init = new_node.knob("h_init").getValue()
+                new_node.knob("bdwidth").setValue(w_init)
+                new_node.knob("bdheight").setValue(h_init)
+                refresh_node(node)
+
+            if "repre_id" in node.knobs().keys():
+                node.removeKnob(node.knob("repre_id"))
+            copies[node.name()] = new_node
+        return copies
+
+    def _set_copies_connections(self, placeholder, copies):
+        """Set inputs and outputs of the copies.
+
+        Args:
+            copies (dict): Copied nodes by their names.
+        """
+
+        last_input, last_output = get_group_io_nodes(
+            placeholder.data["last_loaded"]
+        )
+        siblings = get_nodes_by_names(placeholder.data["siblings"])
+        siblings_input, siblings_output = get_group_io_nodes(siblings)
+        copy_input = copies[siblings_input.name()]
+        copy_output = copies[siblings_output.name()]
+
+        for node_init in siblings:
+            if node_init == siblings_output:
+                continue
+
+            node_copy = copies[node_init.name()]
+            for node in node_init.dependent():
+                for idx in range(node.inputs()):
+                    if node.input(idx) != node_init:
+                        continue
+
+                    if node in siblings:
+                        copies[node.name()].setInput(idx, node_copy)
+                    else:
+                        last_input.setInput(0, node_copy)
+
+            for node in node_init.dependencies():
+                for idx in range(node_init.inputs()):
+                    if node_init.input(idx) != node:
+                        continue
+
+                    if node_init == siblings_input:
+                        copy_input.setInput(idx, node)
+                    elif node in siblings:
+                        node_copy.setInput(idx, copies[node.name()])
+                    else:
+                        node_copy.setInput(idx, last_output)
+
+        siblings_input.setInput(0, copy_output)
+
+
+class NukeLoadPlaceholderItem(PlaceholderItem):
+    """Concrete implementation of PlaceholderItem for Maya load plugin."""
+
+    def __init__(self, *args, **kwargs):
+        super(NukeLoadPlaceholderItem, self).__init__(*args, **kwargs)
+        self._failed_representations = []
+
+    def get_errors(self):
+        if not self._failed_representations:
+            return []
+        message = (
+            "Failed to load {} representations using Loader {}"
+        ).format(
+            len(self._failed_representations),
+            self.data["loader"]
+        )
+        return [message]
+
+    def load_failed(self, representation):
+        self._failed_representations.append(representation)
+
+    def load_succeed(self, container):
+        pass
+
+
+def build_workfile_template(*args):
+    builder = NukeTemplateLoader(registered_host())
+    builder.build_template()
+
+
+def update_workfile_template(*args):
+    builder = NukeTemplateLoader(registered_host())
+    builder.rebuild_template()
+
+
+def create_placeholder(*args):
+    host = registered_host()
+    builder = NukeTemplateLoader(host)
+    window = WorkfileBuildPlaceholderDialog(host, builder)
+    window.exec_()
+
+
+def update_placeholder(*args):
+    host = registered_host()
+    builder = NukeTemplateLoader(host)
+    placeholder_items_by_id = {
+        placeholder_item.scene_identifier: placeholder_item
+        for placeholder_item in builder.get_placeholders()
+    }
+    placeholder_items = []
+    for node in nuke.selectedNodes():
+        node_name = node.fullName()
+        if node_name in placeholder_items_by_id:
+            placeholder_items.append(placeholder_items_by_id[node_name])
+
+    # TODO show UI at least
+    if len(placeholder_items) == 0:
+        raise ValueError("No node selected")
+
+    if len(placeholder_items) > 1:
+        raise ValueError("Too many selected nodes")
+
+    placeholder_item = placeholder_items[0]
+    window = WorkfileBuildPlaceholderDialog(host, builder)
+    window.set_update_mode(placeholder_item)
+    window.exec_()

From 34dc71936b626ed6b15de64003d086de3d3625a3 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 11:51:22 +0200
Subject: [PATCH 074/147] use new workfile building system in nuke

---
 openpype/hosts/nuke/api/pipeline.py | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/openpype/hosts/nuke/api/pipeline.py b/openpype/hosts/nuke/api/pipeline.py
index d4edd24cf6..c6ccfaeb3a 100644
--- a/openpype/hosts/nuke/api/pipeline.py
+++ b/openpype/hosts/nuke/api/pipeline.py
@@ -22,10 +22,6 @@ from openpype.pipeline import (
     AVALON_CONTAINER_ID,
 )
 from openpype.pipeline.workfile import BuildWorkfile
-from openpype.pipeline.workfile.build_template import (
-    build_workfile_template,
-    update_workfile_template
-)
 from openpype.tools.utils import host_tools
 
 from .command import viewer_update_and_undo_stop
@@ -40,8 +36,12 @@ from .lib import (
     set_avalon_knob_data,
     read_avalon_data,
 )
-from .lib_template_builder import (
-    create_placeholder, update_placeholder
+from .workfile_template_builder import (
+    NukePlaceholderLoadPlugin,
+    build_workfile_template,
+    update_workfile_template,
+    create_placeholder,
+    update_placeholder,
 )
 
 log = Logger.get_logger(__name__)

From 703169e1706e50ec02d6a05959bf2e8504ebac5c Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 12:00:34 +0200
Subject: [PATCH 075/147] removed unused imports

---
 openpype/hosts/nuke/api/workfile_template_builder.py | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/openpype/hosts/nuke/api/workfile_template_builder.py b/openpype/hosts/nuke/api/workfile_template_builder.py
index 71ea5c95a5..d018b9b598 100644
--- a/openpype/hosts/nuke/api/workfile_template_builder.py
+++ b/openpype/hosts/nuke/api/workfile_template_builder.py
@@ -1,12 +1,8 @@
-import json
 import collections
 
 import nuke
 
 from openpype.pipeline import registered_host
-from openpype.pipeline.workfile.build_template_exceptions import (
-    TemplateAlreadyImported
-)
 from openpype.pipeline.workfile.new_template_loader import (
     AbstractTemplateLoader,
     PlaceholderPlugin,

From 085ec8989092af6b0a478ab2d414975285476e19 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 12:17:14 +0200
Subject: [PATCH 076/147] renamed 'new_template_loader' to
 'workfile_template_builder'

---
 .../{new_template_loader.py => workfile_template_builder.py}      | 0
 1 file changed, 0 insertions(+), 0 deletions(-)
 rename openpype/pipeline/workfile/{new_template_loader.py => workfile_template_builder.py} (100%)

diff --git a/openpype/pipeline/workfile/new_template_loader.py b/openpype/pipeline/workfile/workfile_template_builder.py
similarity index 100%
rename from openpype/pipeline/workfile/new_template_loader.py
rename to openpype/pipeline/workfile/workfile_template_builder.py

From 518c3f75cabdce037c42f5132b50e623bc9c88de Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 12:18:09 +0200
Subject: [PATCH 077/147] changed AbstractTemplateLoader to
 AbstractTemplateBuilder

---
 .../hosts/maya/api/workfile_template_builder.py  | 16 ++++++++--------
 .../hosts/nuke/api/workfile_template_builder.py  | 16 ++++++++--------
 .../workfile/workfile_template_builder.py        | 10 ++++++++--
 3 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index 42736badf2..b947a51aaa 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -6,8 +6,8 @@ from openpype.pipeline import registered_host
 from openpype.pipeline.workfile.build_template_exceptions import (
     TemplateAlreadyImported
 )
-from openpype.pipeline.workfile.new_template_loader import (
-    AbstractTemplateLoader,
+from openpype.pipeline.workfile.workfile_template_builder import (
+    AbstractTemplateBuilder,
     PlaceholderPlugin,
     PlaceholderItem,
     PlaceholderLoadMixin,
@@ -21,8 +21,8 @@ from .lib import read, imprint
 PLACEHOLDER_SET = "PLACEHOLDERS_SET"
 
 
-class MayaTemplateLoader(AbstractTemplateLoader):
-    """Concrete implementation of AbstractTemplateLoader for maya"""
+class MayaTemplateBuilder(AbstractTemplateBuilder):
+    """Concrete implementation of AbstractTemplateBuilder for maya"""
 
     def import_template(self, path):
         """Import template into current scene.
@@ -313,25 +313,25 @@ class LoadPlaceholderItem(PlaceholderItem):
 
 
 def build_workfile_template(*args):
-    builder = MayaTemplateLoader(registered_host())
+    builder = MayaTemplateBuilder(registered_host())
     builder.build_template()
 
 
 def update_workfile_template(*args):
-    builder = MayaTemplateLoader(registered_host())
+    builder = MayaTemplateBuilder(registered_host())
     builder.rebuild_template()
 
 
 def create_placeholder(*args):
     host = registered_host()
-    builder = MayaTemplateLoader(host)
+    builder = MayaTemplateBuilder(host)
     window = WorkfileBuildPlaceholderDialog(host, builder)
     window.exec_()
 
 
 def update_placeholder(*args):
     host = registered_host()
-    builder = MayaTemplateLoader(host)
+    builder = MayaTemplateBuilder(host)
     placeholder_items_by_id = {
         placeholder_item.scene_identifier: placeholder_item
         for placeholder_item in builder.get_placeholders()
diff --git a/openpype/hosts/nuke/api/workfile_template_builder.py b/openpype/hosts/nuke/api/workfile_template_builder.py
index d018b9b598..f4dfac1e32 100644
--- a/openpype/hosts/nuke/api/workfile_template_builder.py
+++ b/openpype/hosts/nuke/api/workfile_template_builder.py
@@ -3,8 +3,8 @@ import collections
 import nuke
 
 from openpype.pipeline import registered_host
-from openpype.pipeline.workfile.new_template_loader import (
-    AbstractTemplateLoader,
+from openpype.pipeline.workfile.workfile_template_builder import (
+    AbstractTemplateBuilder,
     PlaceholderPlugin,
     PlaceholderItem,
     PlaceholderLoadMixin,
@@ -31,8 +31,8 @@ from .lib import (
 PLACEHOLDER_SET = "PLACEHOLDERS_SET"
 
 
-class NukeTemplateLoader(AbstractTemplateLoader):
-    """Concrete implementation of AbstractTemplateLoader for maya"""
+class NukeTemplateBuilder(AbstractTemplateBuilder):
+    """Concrete implementation of AbstractTemplateBuilder for maya"""
 
     def import_template(self, path):
         """Import template into current scene.
@@ -561,25 +561,25 @@ class NukeLoadPlaceholderItem(PlaceholderItem):
 
 
 def build_workfile_template(*args):
-    builder = NukeTemplateLoader(registered_host())
+    builder = NukeTemplateBuilder(registered_host())
     builder.build_template()
 
 
 def update_workfile_template(*args):
-    builder = NukeTemplateLoader(registered_host())
+    builder = NukeTemplateBuilder(registered_host())
     builder.rebuild_template()
 
 
 def create_placeholder(*args):
     host = registered_host()
-    builder = NukeTemplateLoader(host)
+    builder = NukeTemplateBuilder(host)
     window = WorkfileBuildPlaceholderDialog(host, builder)
     window.exec_()
 
 
 def update_placeholder(*args):
     host = registered_host()
-    builder = NukeTemplateLoader(host)
+    builder = NukeTemplateBuilder(host)
     placeholder_items_by_id = {
         placeholder_item.scene_identifier: placeholder_item
         for placeholder_item in builder.get_placeholders()
diff --git a/openpype/pipeline/workfile/workfile_template_builder.py b/openpype/pipeline/workfile/workfile_template_builder.py
index 3f81ce0114..4c6f3939e5 100644
--- a/openpype/pipeline/workfile/workfile_template_builder.py
+++ b/openpype/pipeline/workfile/workfile_template_builder.py
@@ -36,8 +36,14 @@ from .build_template_exceptions import (
 
 
 @six.add_metaclass(ABCMeta)
-class AbstractTemplateLoader:
-    """Abstraction of Template Loader.
+class AbstractTemplateBuilder(object):
+    """Abstraction of Template Builder.
+
+    Builder cares about context, shared data, cache, discovery of plugins
+    and trigger logic. Provides public api for host workfile build systen.
+
+    Rest of logic is based on plugins that care about collection and creation
+    of placeholder items.
 
     Args:
         host (Union[HostBase, ModuleType]): Implementation of host.

From 30780efd487ee22a4214bdaf6f09ebb48e66e004 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 12:18:38 +0200
Subject: [PATCH 078/147] renamed method 'update_template_placeholder' to
 'repopulate_placeholder'

---
 openpype/hosts/maya/api/workfile_template_builder.py    | 2 +-
 openpype/hosts/nuke/api/workfile_template_builder.py    | 2 +-
 openpype/pipeline/workfile/workfile_template_builder.py | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index b947a51aaa..5fd2113bdb 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -209,7 +209,7 @@ class MayaPlaceholderLoadPlugin(PlaceholderPlugin, PlaceholderLoadMixin):
     def populate_placeholder(self, placeholder):
         self.populate_load_placeholder(placeholder)
 
-    def update_template_placeholder(self, placeholder):
+    def repopulate_placeholder(self, placeholder):
         repre_ids = self._get_loaded_repre_ids()
         self.populate_load_placeholder(placeholder, repre_ids)
 
diff --git a/openpype/hosts/nuke/api/workfile_template_builder.py b/openpype/hosts/nuke/api/workfile_template_builder.py
index f4dfac1e32..ba0d975496 100644
--- a/openpype/hosts/nuke/api/workfile_template_builder.py
+++ b/openpype/hosts/nuke/api/workfile_template_builder.py
@@ -185,7 +185,7 @@ class NukePlaceholderLoadPlugin(NukePlaceholderPlugin, PlaceholderLoadMixin):
     def populate_placeholder(self, placeholder):
         self.populate_load_placeholder(placeholder)
 
-    def update_template_placeholder(self, placeholder):
+    def repopulate_placeholder(self, placeholder):
         repre_ids = self._get_loaded_repre_ids()
         self.populate_load_placeholder(placeholder, repre_ids)
 
diff --git a/openpype/pipeline/workfile/workfile_template_builder.py b/openpype/pipeline/workfile/workfile_template_builder.py
index 4c6f3939e5..494eebda8a 100644
--- a/openpype/pipeline/workfile/workfile_template_builder.py
+++ b/openpype/pipeline/workfile/workfile_template_builder.py
@@ -377,7 +377,7 @@ class AbstractTemplateBuilder(object):
 
         for placeholder in placeholders:
             plugin = placeholder.plugin
-            plugin.update_template_placeholder(placeholder)
+            plugin.repopulate_placeholder(placeholder)
 
         self.clear_shared_populate_data()
 
@@ -725,7 +725,7 @@ class PlaceholderPlugin(object):
 
         pass
 
-    def update_template_placeholder(self, placeholder):
+    def repopulate_placeholder(self, placeholder):
         """Update scene with current context for passed placeholder.
 
         Can be used to re-run placeholder logic (if it make sense).

From 6c2c161ed4cb570085b8ff6aada053bc4e1daf11 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 15:30:31 +0200
Subject: [PATCH 079/147] moved exceptions to workfile_template_builder

---
 .../maya/api/workfile_template_builder.py     |  4 +--
 .../workfile/workfile_template_builder.py     | 26 +++++++++++++++----
 2 files changed, 22 insertions(+), 8 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index 5fd2113bdb..71e3e0ce4e 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -3,10 +3,8 @@ import json
 from maya import cmds
 
 from openpype.pipeline import registered_host
-from openpype.pipeline.workfile.build_template_exceptions import (
-    TemplateAlreadyImported
-)
 from openpype.pipeline.workfile.workfile_template_builder import (
+    TemplateAlreadyImported,
     AbstractTemplateBuilder,
     PlaceholderPlugin,
     PlaceholderItem,
diff --git a/openpype/pipeline/workfile/workfile_template_builder.py b/openpype/pipeline/workfile/workfile_template_builder.py
index 494eebda8a..a381b96c8f 100644
--- a/openpype/pipeline/workfile/workfile_template_builder.py
+++ b/openpype/pipeline/workfile/workfile_template_builder.py
@@ -28,11 +28,27 @@ from openpype.pipeline.load import (
 )
 from openpype.pipeline.create import get_legacy_creator_by_name
 
-from .build_template_exceptions import (
-    TemplateProfileNotFound,
-    TemplateLoadingFailed,
-    TemplateNotFound,
-)
+
+class TemplateNotFound(Exception):
+    """Exception raised when template does not exist."""
+    pass
+
+
+class TemplateProfileNotFound(Exception):
+    """Exception raised when current profile
+    doesn't match any template profile"""
+    pass
+
+
+class TemplateAlreadyImported(Exception):
+    """Error raised when Template was already imported by host for
+    this session"""
+    pass
+
+
+class TemplateLoadFailed(Exception):
+    """Error raised whend Template loader was unable to load the template"""
+    pass
 
 
 @six.add_metaclass(ABCMeta)

From b2b1613016f54d8293296c2f6cca5a87a9b62565 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 16:19:52 +0200
Subject: [PATCH 080/147] fix raised exception

---
 openpype/pipeline/workfile/workfile_template_builder.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/pipeline/workfile/workfile_template_builder.py b/openpype/pipeline/workfile/workfile_template_builder.py
index a381b96c8f..2358a047f1 100644
--- a/openpype/pipeline/workfile/workfile_template_builder.py
+++ b/openpype/pipeline/workfile/workfile_template_builder.py
@@ -560,7 +560,7 @@ class AbstractTemplateBuilder(object):
 
         path = profile["path"]
         if not path:
-            raise TemplateLoadingFailed((
+            raise TemplateLoadFailed((
                 "Template path is not set.\n"
                 "Path need to be set in {}\\Template Workfile Build "
                 "Settings\\Profiles"

From fe2a769a7e3b5b8e6fc0744054c711a0e019ec72 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 16:20:27 +0200
Subject: [PATCH 081/147] added quick access to settings

---
 .../workfile/workfile_template_builder.py     | 26 ++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/openpype/pipeline/workfile/workfile_template_builder.py b/openpype/pipeline/workfile/workfile_template_builder.py
index 2358a047f1..28c06aeeac 100644
--- a/openpype/pipeline/workfile/workfile_template_builder.py
+++ b/openpype/pipeline/workfile/workfile_template_builder.py
@@ -11,7 +11,10 @@ from openpype.client import (
     get_linked_assets,
     get_representations,
 )
-from openpype.settings import get_project_settings
+from openpype.settings import (
+    get_project_settings,
+    get_system_settings,
+)
 from openpype.host import HostBase
 from openpype.lib import (
     Logger,
@@ -86,6 +89,9 @@ class AbstractTemplateBuilder(object):
         self._loaders_by_name = None
         self._creators_by_name = None
 
+        self._system_settings = None
+        self._project_settings = None
+
         self._current_asset_doc = None
         self._linked_asset_docs = None
         self._task_type = None
@@ -102,6 +108,18 @@ class AbstractTemplateBuilder(object):
     def current_task_name(self):
         return legacy_io.Session["AVALON_TASK"]
 
+    @property
+    def system_settings(self):
+        if self._system_settings is None:
+            self._system_settings = get_system_settings()
+        return self._system_settings
+
+    @property
+    def project_settings(self):
+        if self._project_settings is None:
+            self._project_settings = get_project_settings(self.project_name)
+        return self._project_settings
+
     @property
     def current_asset_doc(self):
         if self._current_asset_doc is None:
@@ -184,6 +202,9 @@ class AbstractTemplateBuilder(object):
         self._linked_asset_docs = None
         self._task_type = None
 
+        self._system_settings = None
+        self._project_settings = None
+
         self.clear_shared_data()
         self.clear_shared_populate_data()
 
@@ -529,9 +550,8 @@ class AbstractTemplateBuilder(object):
         self.refresh()
 
     def _get_build_profiles(self):
-        project_settings = get_project_settings(self.project_name)
         return (
-            project_settings
+            self.project_settings
             [self.host_name]
             ["templated_workfile_build"]
             ["profiles"]

From a0ffa97e1d125642f575a26f888e6b8469ea8230 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 16:20:44 +0200
Subject: [PATCH 082/147] added some docstrings

---
 openpype/pipeline/workfile/build_workfile.py  |  11 ++
 .../workfile/workfile_template_builder.py     | 117 ++++++++++++++++--
 2 files changed, 121 insertions(+), 7 deletions(-)

diff --git a/openpype/pipeline/workfile/build_workfile.py b/openpype/pipeline/workfile/build_workfile.py
index 0b8a444436..87b9df158f 100644
--- a/openpype/pipeline/workfile/build_workfile.py
+++ b/openpype/pipeline/workfile/build_workfile.py
@@ -1,3 +1,14 @@
+"""Workfile build based on settings.
+
+Workfile builder will do stuff based on project settings. Advantage is that
+it need only access to settings. Disadvantage is that it is hard to focus
+build per context and being explicit about loaded content.
+
+For more explicit workfile build is recommended 'AbstractTemplateBuilder'
+from '~/openpype/pipeline/workfile/workfile_template_builder'. Which gives
+more abilities to define how build happens but require more code to achive it.
+"""
+
 import os
 import re
 import collections
diff --git a/openpype/pipeline/workfile/workfile_template_builder.py b/openpype/pipeline/workfile/workfile_template_builder.py
index 28c06aeeac..f81849fbe4 100644
--- a/openpype/pipeline/workfile/workfile_template_builder.py
+++ b/openpype/pipeline/workfile/workfile_template_builder.py
@@ -1,3 +1,16 @@
+"""Workfile build mechanism using workfile templates.
+
+Build templates are manually prepared using plugin definitions which create
+placeholders inside the template which are populated on import.
+
+This approach is very explicit to achive very specific build logic that can be
+targeted by task types and names.
+
+Placeholders are created using placeholder plugins which should care about
+logic and data of placeholder items. 'PlaceholderItem' is used to keep track
+about it's progress.
+"""
+
 import os
 import re
 import collections
@@ -64,6 +77,13 @@ class AbstractTemplateBuilder(object):
     Rest of logic is based on plugins that care about collection and creation
     of placeholder items.
 
+    Population of placeholders happens in loops. Each loop will collect all
+    available placeholders, skip already populated, and populate the rest.
+
+    Builder item has 2 types of shared data. Refresh lifetime which are cleared
+    on refresh and populate lifetime which are cleared after loop of
+    placeholder population.
+
     Args:
         host (Union[HostBase, ModuleType]): Implementation of host.
     """
@@ -382,6 +402,20 @@ class AbstractTemplateBuilder(object):
         ))
 
     def build_template(self, template_path=None, level_limit=None):
+        """Main callback for building workfile from template path.
+
+        Todo:
+            Handle report of populated placeholders from
+                'populate_scene_placeholders' to be shown to a user.
+
+        Args:
+            template_path (str): Path to a template file with placeholders.
+                Template from settings 'get_template_path' used when not
+                passed.
+            level_limit (int): Limit of populate loops. Related to
+                'populate_scene_placeholders' method.
+        """
+
         if template_path is None:
             template_path = self.get_template_path()
         self.import_template(template_path)
@@ -492,6 +526,8 @@ class AbstractTemplateBuilder(object):
             for placeholder in placeholders
         }
         all_processed = len(placeholders) == 0
+        # Counter is checked at the ned of a loop so the loop happens at least
+        #   once.
         iter_counter = 0
         while not all_processed:
             filtered_placeholders = []
@@ -550,6 +586,12 @@ class AbstractTemplateBuilder(object):
         self.refresh()
 
     def _get_build_profiles(self):
+        """Get build profiles for workfile build template path.
+
+        Returns:
+            List[Dict[str, Any]]: Profiles for template path resolving.
+        """
+
         return (
             self.project_settings
             [self.host_name]
@@ -558,6 +600,22 @@ class AbstractTemplateBuilder(object):
         )
 
     def get_template_path(self):
+        """Unified way how template path is received usign settings.
+
+        Method is dependent on '_get_build_profiles' which should return filter
+        profiles to resolve path to a template. Default implementation looks
+        into host settings:
+        - 'project_settings/{host name}/templated_workfile_build/profiles'
+
+        Returns:
+            str: Path to a template file with placeholders.
+
+        Raises:
+            TemplateProfileNotFound: When profiles are not filled.
+            TemplateLoadFailed: Profile was found but path is not set.
+            TemplateNotFound: Path was set but file does not exists.
+        """
+
         host_name = self.host_name
         project_name = self.project_name
         task_name = self.current_task_name
@@ -630,6 +688,14 @@ class AbstractTemplateBuilder(object):
 
 @six.add_metaclass(ABCMeta)
 class PlaceholderPlugin(object):
+    """Plugin which care about handling of placeholder items logic.
+
+    Plugin create and update placeholders in scene and populate them on
+    template import. Populating means that based on placeholder data happens
+    a logic in the scene. Most common logic is to load representation using
+    loaders or to create instances in scene.
+    """
+
     label = None
     _log = None
 
@@ -641,7 +707,7 @@ class PlaceholderPlugin(object):
         """Access to builder which initialized the plugin.
 
         Returns:
-            AbstractTemplateLoader: Loader of template build.
+            AbstractTemplateBuilder: Loader of template build.
         """
 
         return self._builder
@@ -852,8 +918,12 @@ class PlaceholderPlugin(object):
 class PlaceholderItem(object):
     """Item representing single item in scene that is a placeholder to process.
 
+    Items are always created and updated by their plugins. Each plugin can use
+    modified class of 'PlacehoderItem' but only to add more options instead of
+    new other.
+
     Scene identifier is used to avoid processing of the palceholder item
-    multiple times.
+    multiple times so must be unique across whole workfile builder.
 
     Args:
         scene_identifier (str): Unique scene identifier. If placeholder is
@@ -893,7 +963,7 @@ class PlaceholderItem(object):
         """Access to builder.
 
         Returns:
-            AbstractTemplateLoader: Builder which is the top part of
+            AbstractTemplateBuilder: Builder which is the top part of
                 placeholder.
         """
 
@@ -936,6 +1006,8 @@ class PlaceholderItem(object):
 
     @property
     def order(self):
+        """Order of item processing."""
+
         order = self._data.get("order")
         if order is None:
             return self.default_order
@@ -1160,7 +1232,25 @@ class PlaceholderLoadMixin(object):
 
         return {}
 
-    def get_representations(self, placeholder):
+    def _get_representations(self, placeholder):
+        """Prepared query of representations based on load options.
+
+        This function is directly connected to options defined in
+        'get_load_plugin_options'.
+
+        Note:
+            This returns all representation documents from all versions of
+                matching subset. To filter for last version use
+                '_reduce_last_version_repre_docs'.
+
+        Args:
+            placeholder (PlaceholderItem): Item which should be populated.
+
+        Returns:
+            List[Dict[str, Any]]: Representation documents matching filters
+                from placeholder data.
+        """
+
         project_name = self.builder.project_name
         current_asset_doc = self.builder.current_asset_doc
         linked_asset_docs = self.builder.linked_asset_docs
@@ -1263,7 +1353,7 @@ class PlaceholderLoadMixin(object):
         loader_name = placeholder.data["loader"]
         loader_args = placeholder.data["loader_args"]
 
-        placeholder_representations = self.get_representations(placeholder)
+        placeholder_representations = self._get_representations(placeholder)
 
         filtered_representations = []
         for representation in self._reduce_last_version_repre_docs(
@@ -1306,11 +1396,24 @@ class PlaceholderLoadMixin(object):
                 )
 
             except Exception:
+                failed = True
                 placeholder.load_failed(representation)
 
             else:
+                failed = False
                 placeholder.load_succeed(container)
-            self.cleanup_placeholder(placeholder)
+            self.cleanup_placeholder(placeholder, failed)
+
+    def cleanup_placeholder(self, placeholder, failed):
+        """Cleanup placeholder after load of single representation.
+
+        Can be called multiple times during placeholder item populating and is
+        called even if loading failed.
+
+        Args:
+            placeholder (PlaceholderItem): Item which was just used to load
+                representation.
+            failed (bool): Loading of representation failed.
+        """
 
-    def cleanup_placeholder(self, placeholder):
         pass

From 60c1d1eb6c1ea42bd974cfd528dc9ce3cfda0b3f Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 16:21:46 +0200
Subject: [PATCH 083/147] removed nuke previous template builder

---
 .../hosts/nuke/api/lib_template_builder.py    | 220 ------
 openpype/hosts/nuke/api/template_loader.py    | 639 ------------------
 2 files changed, 859 deletions(-)
 delete mode 100644 openpype/hosts/nuke/api/lib_template_builder.py
 delete mode 100644 openpype/hosts/nuke/api/template_loader.py

diff --git a/openpype/hosts/nuke/api/lib_template_builder.py b/openpype/hosts/nuke/api/lib_template_builder.py
deleted file mode 100644
index 61baa23928..0000000000
--- a/openpype/hosts/nuke/api/lib_template_builder.py
+++ /dev/null
@@ -1,220 +0,0 @@
-from collections import OrderedDict
-
-import qargparse
-
-import nuke
-
-from openpype.tools.utils.widgets import OptionDialog
-
-from .lib import imprint, get_main_window
-
-
-# To change as enum
-build_types = ["context_asset", "linked_asset", "all_assets"]
-
-
-def get_placeholder_attributes(node, enumerate=False):
-    list_atts = {
-        "builder_type",
-        "family",
-        "representation",
-        "loader",
-        "loader_args",
-        "order",
-        "asset",
-        "subset",
-        "hierarchy",
-        "siblings",
-        "last_loaded"
-    }
-    attributes = {}
-    for attr in node.knobs().keys():
-        if attr in list_atts:
-            if enumerate:
-                try:
-                    attributes[attr] = node.knob(attr).values()
-                except AttributeError:
-                    attributes[attr] = node.knob(attr).getValue()
-            else:
-                attributes[attr] = node.knob(attr).getValue()
-
-    return attributes
-
-
-def delete_placeholder_attributes(node):
-    """Delete all extra placeholder attributes."""
-
-    extra_attributes = get_placeholder_attributes(node)
-    for attribute in extra_attributes.keys():
-        try:
-            node.removeKnob(node.knob(attribute))
-        except ValueError:
-            continue
-
-
-def hide_placeholder_attributes(node):
-    """Hide all extra placeholder attributes."""
-
-    extra_attributes = get_placeholder_attributes(node)
-    for attribute in extra_attributes.keys():
-        try:
-            node.knob(attribute).setVisible(False)
-        except ValueError:
-            continue
-
-
-def create_placeholder():
-    args = placeholder_window()
-    if not args:
-        # operation canceled, no locator created
-        return
-
-    placeholder = nuke.nodes.NoOp()
-    placeholder.setName("PLACEHOLDER")
-    placeholder.knob("tile_color").setValue(4278190335)
-
-    # custom arg parse to force empty data query
-    # and still imprint them on placeholder
-    # and getting items when arg is of type Enumerator
-    options = OrderedDict()
-    for arg in args:
-        if not type(arg) == qargparse.Separator:
-            options[str(arg)] = arg._data.get("items") or arg.read()
-    imprint(placeholder, options)
-    imprint(placeholder, {"is_placeholder": True})
-    placeholder.knob("is_placeholder").setVisible(False)
-
-
-def update_placeholder():
-    placeholder = nuke.selectedNodes()
-    if not placeholder:
-        raise ValueError("No node selected")
-    if len(placeholder) > 1:
-        raise ValueError("Too many selected nodes")
-    placeholder = placeholder[0]
-
-    args = placeholder_window(get_placeholder_attributes(placeholder))
-    if not args:
-        return  # operation canceled
-    # delete placeholder attributes
-    delete_placeholder_attributes(placeholder)
-
-    options = OrderedDict()
-    for arg in args:
-        if not type(arg) == qargparse.Separator:
-            options[str(arg)] = arg._data.get("items") or arg.read()
-    imprint(placeholder, options)
-
-
-def imprint_enum(placeholder, args):
-    """
-    Imprint method doesn't act properly with enums.
-    Replacing the functionnality with this for now
-    """
-
-    enum_values = {
-        str(arg): arg.read()
-        for arg in args
-        if arg._data.get("items")
-    }
-    string_to_value_enum_table = {
-        build: idx
-        for idx, build in enumerate(build_types)
-    }
-    attrs = {}
-    for key, value in enum_values.items():
-        attrs[key] = string_to_value_enum_table[value]
-
-
-def placeholder_window(options=None):
-    options = options or dict()
-    dialog = OptionDialog(parent=get_main_window())
-    dialog.setWindowTitle("Create Placeholder")
-
-    args = [
-        qargparse.Separator("Main attributes"),
-        qargparse.Enum(
-            "builder_type",
-            label="Asset Builder Type",
-            default=options.get("builder_type", 0),
-            items=build_types,
-            help="""Asset Builder Type
-Builder type describe what template loader will look for.
-
-context_asset : Template loader will look for subsets of
-current context asset (Asset bob will find asset)
-
-linked_asset : Template loader will look for assets linked
-to current context asset.
-Linked asset are looked in OpenPype database under field "inputLinks"
-"""
-        ),
-        qargparse.String(
-            "family",
-            default=options.get("family", ""),
-            label="OpenPype Family",
-            placeholder="ex: image, plate ..."),
-        qargparse.String(
-            "representation",
-            default=options.get("representation", ""),
-            label="OpenPype Representation",
-            placeholder="ex: mov, png ..."),
-        qargparse.String(
-            "loader",
-            default=options.get("loader", ""),
-            label="Loader",
-            placeholder="ex: LoadClip, LoadImage ...",
-            help="""Loader
-
-Defines what openpype loader will be used to load assets.
-Useable loader depends on current host's loader list.
-Field is case sensitive.
-"""),
-        qargparse.String(
-            "loader_args",
-            default=options.get("loader_args", ""),
-            label="Loader Arguments",
-            placeholder='ex: {"camera":"persp", "lights":True}',
-            help="""Loader
-
-Defines a dictionnary of arguments used to load assets.
-Useable arguments depend on current placeholder Loader.
-Field should be a valid python dict. Anything else will be ignored.
-"""),
-        qargparse.Integer(
-            "order",
-            default=options.get("order", 0),
-            min=0,
-            max=999,
-            label="Order",
-            placeholder="ex: 0, 100 ... (smallest order loaded first)",
-            help="""Order
-
-Order defines asset loading priority (0 to 999)
-Priority rule is : "lowest is first to load"."""),
-        qargparse.Separator(
-            "Optional attributes "),
-        qargparse.String(
-            "asset",
-            default=options.get("asset", ""),
-            label="Asset filter",
-            placeholder="regex filtering by asset name",
-            help="Filtering assets by matching field regex to asset's name"),
-        qargparse.String(
-            "subset",
-            default=options.get("subset", ""),
-            label="Subset filter",
-            placeholder="regex filtering by subset name",
-            help="Filtering assets by matching field regex to subset's name"),
-        qargparse.String(
-            "hierarchy",
-            default=options.get("hierarchy", ""),
-            label="Hierarchy filter",
-            placeholder="regex filtering by asset's hierarchy",
-            help="Filtering assets by matching field asset's hierarchy")
-    ]
-    dialog.create(args)
-    if not dialog.exec_():
-        return None
-
-    return args
diff --git a/openpype/hosts/nuke/api/template_loader.py b/openpype/hosts/nuke/api/template_loader.py
deleted file mode 100644
index 5ff4b8fc41..0000000000
--- a/openpype/hosts/nuke/api/template_loader.py
+++ /dev/null
@@ -1,639 +0,0 @@
-import re
-import collections
-
-import nuke
-
-from openpype.client import get_representations
-from openpype.pipeline import legacy_io
-from openpype.pipeline.workfile.abstract_template_loader import (
-    AbstractPlaceholder,
-    AbstractTemplateLoader,
-)
-
-from .lib import (
-    find_free_space_to_paste_nodes,
-    get_extreme_positions,
-    get_group_io_nodes,
-    imprint,
-    refresh_node,
-    refresh_nodes,
-    reset_selection,
-    get_names_from_nodes,
-    get_nodes_by_names,
-    select_nodes,
-    duplicate_node,
-    node_tempfile,
-)
-
-from .lib_template_builder import (
-    delete_placeholder_attributes,
-    get_placeholder_attributes,
-    hide_placeholder_attributes
-)
-
-PLACEHOLDER_SET = "PLACEHOLDERS_SET"
-
-
-class NukeTemplateLoader(AbstractTemplateLoader):
-    """Concrete implementation of AbstractTemplateLoader for Nuke
-
-    """
-
-    def import_template(self, path):
-        """Import template into current scene.
-        Block if a template is already loaded.
-
-        Args:
-            path (str): A path to current template (usually given by
-            get_template_path implementation)
-
-        Returns:
-            bool: Wether the template was succesfully imported or not
-        """
-
-        # TODO check if the template is already imported
-
-        nuke.nodePaste(path)
-        reset_selection()
-
-        return True
-
-    def preload(self, placeholder, loaders_by_name, last_representation):
-        placeholder.data["nodes_init"] = nuke.allNodes()
-        placeholder.data["last_repre_id"] = str(last_representation["_id"])
-
-    def populate_template(self, ignored_ids=None):
-        processed_key = "_node_processed"
-
-        processed_nodes = []
-        nodes = self.get_template_nodes()
-        while nodes:
-            # Mark nodes as processed so they're not re-executed
-            # - that can happen if processing of placeholder node fails
-            for node in nodes:
-                imprint(node, {processed_key: True})
-                processed_nodes.append(node)
-
-            super(NukeTemplateLoader, self).populate_template(ignored_ids)
-
-            # Recollect nodes to repopulate
-            nodes = []
-            for node in self.get_template_nodes():
-                # Skip already processed nodes
-                if (
-                    processed_key in node.knobs()
-                    and node.knob(processed_key).value()
-                ):
-                    continue
-                nodes.append(node)
-
-        for node in processed_nodes:
-            knob = node.knob(processed_key)
-            if knob is not None:
-                node.removeKnob(knob)
-
-    @staticmethod
-    def get_template_nodes():
-        placeholders = []
-        all_groups = collections.deque()
-        all_groups.append(nuke.thisGroup())
-        while all_groups:
-            group = all_groups.popleft()
-            for node in group.nodes():
-                if isinstance(node, nuke.Group):
-                    all_groups.append(node)
-
-                node_knobs = node.knobs()
-                if (
-                    "builder_type" not in node_knobs
-                    or "is_placeholder" not in node_knobs
-                    or not node.knob("is_placeholder").value()
-                ):
-                    continue
-
-                if "empty" in node_knobs and node.knob("empty").value():
-                    continue
-
-                placeholders.append(node)
-
-        return placeholders
-
-    def update_missing_containers(self):
-        nodes_by_id = collections.defaultdict(list)
-
-        for node in nuke.allNodes():
-            node_knobs = node.knobs().keys()
-            if "repre_id" in node_knobs:
-                repre_id = node.knob("repre_id").getValue()
-                nodes_by_id[repre_id].append(node.name())
-
-            if "empty" in node_knobs:
-                node.removeKnob(node.knob("empty"))
-                imprint(node, {"empty": False})
-
-        for node_names in nodes_by_id.values():
-            node = None
-            for node_name in node_names:
-                node_by_name = nuke.toNode(node_name)
-                if "builder_type" in node_by_name.knobs().keys():
-                    node = node_by_name
-                    break
-
-            if node is None:
-                continue
-
-            placeholder = nuke.nodes.NoOp()
-            placeholder.setName("PLACEHOLDER")
-            placeholder.knob("tile_color").setValue(4278190335)
-            attributes = get_placeholder_attributes(node, enumerate=True)
-            imprint(placeholder, attributes)
-            pos_x = int(node.knob("x").getValue())
-            pos_y = int(node.knob("y").getValue())
-            placeholder.setXYpos(pos_x, pos_y)
-            imprint(placeholder, {"nb_children": 1})
-            refresh_node(placeholder)
-
-        self.populate_template(self.get_loaded_containers_by_id())
-
-    def get_loaded_containers_by_id(self):
-        repre_ids = set()
-        for node in nuke.allNodes():
-            if "repre_id" in node.knobs():
-                repre_ids.add(node.knob("repre_id").getValue())
-
-        # Removes duplicates in the list
-        return list(repre_ids)
-
-    def delete_placeholder(self, placeholder):
-        placeholder_node = placeholder.data["node"]
-        last_loaded = placeholder.data["last_loaded"]
-        if not placeholder.data["delete"]:
-            if "empty" in placeholder_node.knobs().keys():
-                placeholder_node.removeKnob(placeholder_node.knob("empty"))
-            imprint(placeholder_node, {"empty": True})
-            return
-
-        if not last_loaded:
-            nuke.delete(placeholder_node)
-            return
-
-        if "last_loaded" in placeholder_node.knobs().keys():
-            for node_name in placeholder_node.knob("last_loaded").values():
-                node = nuke.toNode(node_name)
-                try:
-                    delete_placeholder_attributes(node)
-                except Exception:
-                    pass
-
-        last_loaded_names = [
-            loaded_node.name()
-            for loaded_node in last_loaded
-        ]
-        imprint(placeholder_node, {"last_loaded": last_loaded_names})
-
-        for node in last_loaded:
-            refresh_node(node)
-            refresh_node(placeholder_node)
-            if "builder_type" not in node.knobs().keys():
-                attributes = get_placeholder_attributes(placeholder_node, True)
-                imprint(node, attributes)
-                imprint(node, {"is_placeholder": False})
-                hide_placeholder_attributes(node)
-                node.knob("is_placeholder").setVisible(False)
-                imprint(
-                    node,
-                    {
-                        "x": placeholder_node.xpos(),
-                        "y": placeholder_node.ypos()
-                    }
-                )
-                node.knob("x").setVisible(False)
-                node.knob("y").setVisible(False)
-        nuke.delete(placeholder_node)
-
-
-class NukePlaceholder(AbstractPlaceholder):
-    """Concrete implementation of AbstractPlaceholder for Nuke"""
-
-    optional_keys = {"asset", "subset", "hierarchy"}
-
-    def get_data(self, node):
-        user_data = dict()
-        node_knobs = node.knobs()
-        for attr in self.required_keys.union(self.optional_keys):
-            if attr in node_knobs:
-                user_data[attr] = node_knobs[attr].getValue()
-        user_data["node"] = node
-
-        nb_children = 0
-        if "nb_children" in node_knobs:
-            nb_children = int(node_knobs["nb_children"].getValue())
-        user_data["nb_children"] = nb_children
-
-        siblings = []
-        if "siblings" in node_knobs:
-            siblings = node_knobs["siblings"].values()
-        user_data["siblings"] = siblings
-
-        node_full_name = node.fullName()
-        user_data["group_name"] = node_full_name.rpartition(".")[0]
-        user_data["last_loaded"] = []
-        user_data["delete"] = False
-        self.data = user_data
-
-    def parent_in_hierarchy(self, containers):
-        return
-
-    def create_sib_copies(self):
-        """ creating copies of the palce_holder siblings (the ones who were
-        loaded with it) for the new nodes added
-
-        Returns :
-            copies (dict) : with copied nodes names and their copies
-        """
-
-        copies = {}
-        siblings = get_nodes_by_names(self.data["siblings"])
-        for node in siblings:
-            new_node = duplicate_node(node)
-
-            x_init = int(new_node.knob("x_init").getValue())
-            y_init = int(new_node.knob("y_init").getValue())
-            new_node.setXYpos(x_init, y_init)
-            if isinstance(new_node, nuke.BackdropNode):
-                w_init = new_node.knob("w_init").getValue()
-                h_init = new_node.knob("h_init").getValue()
-                new_node.knob("bdwidth").setValue(w_init)
-                new_node.knob("bdheight").setValue(h_init)
-                refresh_node(node)
-
-            if "repre_id" in node.knobs().keys():
-                node.removeKnob(node.knob("repre_id"))
-            copies[node.name()] = new_node
-        return copies
-
-    def fix_z_order(self):
-        """Fix the problem of z_order when a backdrop is loaded."""
-
-        nodes_loaded = self.data["last_loaded"]
-        loaded_backdrops = []
-        bd_orders = set()
-        for node in nodes_loaded:
-            if isinstance(node, nuke.BackdropNode):
-                loaded_backdrops.append(node)
-                bd_orders.add(node.knob("z_order").getValue())
-
-        if not bd_orders:
-            return
-
-        sib_orders = set()
-        for node_name in self.data["siblings"]:
-            node = nuke.toNode(node_name)
-            if isinstance(node, nuke.BackdropNode):
-                sib_orders.add(node.knob("z_order").getValue())
-
-        if not sib_orders:
-            return
-
-        min_order = min(bd_orders)
-        max_order = max(sib_orders)
-        for backdrop_node in loaded_backdrops:
-            z_order = backdrop_node.knob("z_order").getValue()
-            backdrop_node.knob("z_order").setValue(
-                z_order + max_order - min_order + 1)
-
-    def update_nodes(self, nodes, considered_nodes, offset_y=None):
-        """Adjust backdrop nodes dimensions and positions.
-
-        Considering some nodes sizes.
-
-        Args:
-            nodes (list): list of nodes to update
-            considered_nodes (list): list of nodes to consider while updating
-                positions and dimensions
-            offset (int): distance between copies
-        """
-
-        placeholder_node = self.data["node"]
-
-        min_x, min_y, max_x, max_y = get_extreme_positions(considered_nodes)
-
-        diff_x = diff_y = 0
-        contained_nodes = []  # for backdrops
-
-        if offset_y is None:
-            width_ph = placeholder_node.screenWidth()
-            height_ph = placeholder_node.screenHeight()
-            diff_y = max_y - min_y - height_ph
-            diff_x = max_x - min_x - width_ph
-            contained_nodes = [placeholder_node]
-            min_x = placeholder_node.xpos()
-            min_y = placeholder_node.ypos()
-        else:
-            siblings = get_nodes_by_names(self.data["siblings"])
-            minX, _, maxX, _ = get_extreme_positions(siblings)
-            diff_y = max_y - min_y + 20
-            diff_x = abs(max_x - min_x - maxX + minX)
-            contained_nodes = considered_nodes
-
-        if diff_y <= 0 and diff_x <= 0:
-            return
-
-        for node in nodes:
-            refresh_node(node)
-
-            if (
-                node == placeholder_node
-                or node in considered_nodes
-            ):
-                continue
-
-            if (
-                not isinstance(node, nuke.BackdropNode)
-                or (
-                    isinstance(node, nuke.BackdropNode)
-                    and not set(contained_nodes) <= set(node.getNodes())
-                )
-            ):
-                if offset_y is None and node.xpos() >= min_x:
-                    node.setXpos(node.xpos() + diff_x)
-
-                if node.ypos() >= min_y:
-                    node.setYpos(node.ypos() + diff_y)
-
-            else:
-                width = node.screenWidth()
-                height = node.screenHeight()
-                node.knob("bdwidth").setValue(width + diff_x)
-                node.knob("bdheight").setValue(height + diff_y)
-
-            refresh_node(node)
-
-    def imprint_inits(self):
-        """Add initial positions and dimensions to the attributes"""
-
-        for node in nuke.allNodes():
-            refresh_node(node)
-            imprint(node, {"x_init": node.xpos(), "y_init": node.ypos()})
-            node.knob("x_init").setVisible(False)
-            node.knob("y_init").setVisible(False)
-            width = node.screenWidth()
-            height = node.screenHeight()
-            if "bdwidth" in node.knobs():
-                imprint(node, {"w_init": width, "h_init": height})
-                node.knob("w_init").setVisible(False)
-                node.knob("h_init").setVisible(False)
-            refresh_node(node)
-
-    def imprint_siblings(self):
-        """
-        - add siblings names to placeholder attributes (nodes loaded with it)
-        - add Id to the attributes of all the other nodes
-        """
-
-        loaded_nodes = self.data["last_loaded"]
-        loaded_nodes_set = set(loaded_nodes)
-        data = {"repre_id": str(self.data["last_repre_id"])}
-
-        for node in loaded_nodes:
-            node_knobs = node.knobs()
-            if "builder_type" not in node_knobs:
-                # save the id of representation for all imported nodes
-                imprint(node, data)
-                node.knob("repre_id").setVisible(False)
-                refresh_node(node)
-                continue
-
-            if (
-                "is_placeholder" not in node_knobs
-                or (
-                    "is_placeholder" in node_knobs
-                    and node.knob("is_placeholder").value()
-                )
-            ):
-                siblings = list(loaded_nodes_set - {node})
-                siblings_name = get_names_from_nodes(siblings)
-                siblings = {"siblings": siblings_name}
-                imprint(node, siblings)
-
-    def set_loaded_connections(self):
-        """
-        set inputs and outputs of loaded nodes"""
-
-        placeholder_node = self.data["node"]
-        input_node, output_node = get_group_io_nodes(self.data["last_loaded"])
-        for node in placeholder_node.dependent():
-            for idx in range(node.inputs()):
-                if node.input(idx) == placeholder_node:
-                    node.setInput(idx, output_node)
-
-        for node in placeholder_node.dependencies():
-            for idx in range(placeholder_node.inputs()):
-                if placeholder_node.input(idx) == node:
-                    input_node.setInput(0, node)
-
-    def set_copies_connections(self, copies):
-        """Set inputs and outputs of the copies.
-
-        Args:
-            copies (dict): Copied nodes by their names.
-        """
-
-        last_input, last_output = get_group_io_nodes(self.data["last_loaded"])
-        siblings = get_nodes_by_names(self.data["siblings"])
-        siblings_input, siblings_output = get_group_io_nodes(siblings)
-        copy_input = copies[siblings_input.name()]
-        copy_output = copies[siblings_output.name()]
-
-        for node_init in siblings:
-            if node_init == siblings_output:
-                continue
-
-            node_copy = copies[node_init.name()]
-            for node in node_init.dependent():
-                for idx in range(node.inputs()):
-                    if node.input(idx) != node_init:
-                        continue
-
-                    if node in siblings:
-                        copies[node.name()].setInput(idx, node_copy)
-                    else:
-                        last_input.setInput(0, node_copy)
-
-            for node in node_init.dependencies():
-                for idx in range(node_init.inputs()):
-                    if node_init.input(idx) != node:
-                        continue
-
-                    if node_init == siblings_input:
-                        copy_input.setInput(idx, node)
-                    elif node in siblings:
-                        node_copy.setInput(idx, copies[node.name()])
-                    else:
-                        node_copy.setInput(idx, last_output)
-
-        siblings_input.setInput(0, copy_output)
-
-    def move_to_placeholder_group(self, nodes_loaded):
-        """
-        opening the placeholder's group and copying loaded nodes in it.
-
-        Returns :
-            nodes_loaded (list): the new list of pasted nodes
-        """
-
-        groups_name = self.data["group_name"]
-        reset_selection()
-        select_nodes(nodes_loaded)
-        if groups_name:
-            with node_tempfile() as filepath:
-                nuke.nodeCopy(filepath)
-                for node in nuke.selectedNodes():
-                    nuke.delete(node)
-                group = nuke.toNode(groups_name)
-                group.begin()
-                nuke.nodePaste(filepath)
-                nodes_loaded = nuke.selectedNodes()
-        return nodes_loaded
-
-    def clean(self):
-        # deselect all selected nodes
-        placeholder_node = self.data["node"]
-
-        # getting the latest nodes added
-        nodes_init = self.data["nodes_init"]
-        nodes_loaded = list(set(nuke.allNodes()) - set(nodes_init))
-        self.log.debug("Loaded nodes: {}".format(nodes_loaded))
-        if not nodes_loaded:
-            return
-
-        self.data["delete"] = True
-
-        nodes_loaded = self.move_to_placeholder_group(nodes_loaded)
-        self.data["last_loaded"] = nodes_loaded
-        refresh_nodes(nodes_loaded)
-
-        # positioning of the loaded nodes
-        min_x, min_y, _, _ = get_extreme_positions(nodes_loaded)
-        for node in nodes_loaded:
-            xpos = (node.xpos() - min_x) + placeholder_node.xpos()
-            ypos = (node.ypos() - min_y) + placeholder_node.ypos()
-            node.setXYpos(xpos, ypos)
-        refresh_nodes(nodes_loaded)
-
-        self.fix_z_order()  # fix the problem of z_order for backdrops
-        self.imprint_siblings()
-
-        if self.data["nb_children"] == 0:
-            # save initial nodes postions and dimensions, update them
-            # and set inputs and outputs of loaded nodes
-
-            self.imprint_inits()
-            self.update_nodes(nuke.allNodes(), nodes_loaded)
-            self.set_loaded_connections()
-
-        elif self.data["siblings"]:
-            # create copies of placeholder siblings for the new loaded nodes,
-            # set their inputs and outpus and update all nodes positions and
-            # dimensions and siblings names
-
-            siblings = get_nodes_by_names(self.data["siblings"])
-            refresh_nodes(siblings)
-            copies = self.create_sib_copies()
-            new_nodes = list(copies.values())  # copies nodes
-            self.update_nodes(new_nodes, nodes_loaded)
-            placeholder_node.removeKnob(placeholder_node.knob("siblings"))
-            new_nodes_name = get_names_from_nodes(new_nodes)
-            imprint(placeholder_node, {"siblings": new_nodes_name})
-            self.set_copies_connections(copies)
-
-            self.update_nodes(
-                nuke.allNodes(),
-                new_nodes + nodes_loaded,
-                20
-            )
-
-            new_siblings = get_names_from_nodes(new_nodes)
-            self.data["siblings"] = new_siblings
-
-        else:
-            # if the placeholder doesn't have siblings, the loaded
-            # nodes will be placed in a free space
-
-            xpointer, ypointer = find_free_space_to_paste_nodes(
-                nodes_loaded, direction="bottom", offset=200
-            )
-            node = nuke.createNode("NoOp")
-            reset_selection()
-            nuke.delete(node)
-            for node in nodes_loaded:
-                xpos = (node.xpos() - min_x) + xpointer
-                ypos = (node.ypos() - min_y) + ypointer
-                node.setXYpos(xpos, ypos)
-
-        self.data["nb_children"] += 1
-        reset_selection()
-        # go back to root group
-        nuke.root().begin()
-
-    def get_representations(self, current_asset_doc, linked_asset_docs):
-        project_name = legacy_io.active_project()
-
-        builder_type = self.data["builder_type"]
-        if builder_type == "context_asset":
-            context_filters = {
-                "asset": [re.compile(self.data["asset"])],
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representations": [self.data["representation"]],
-                "family": [self.data["family"]]
-            }
-
-        elif builder_type != "linked_asset":
-            context_filters = {
-                "asset": [
-                    current_asset_doc["name"],
-                    re.compile(self.data["asset"])
-                ],
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representation": [self.data["representation"]],
-                "family": [self.data["family"]]
-            }
-
-        else:
-            asset_regex = re.compile(self.data["asset"])
-            linked_asset_names = []
-            for asset_doc in linked_asset_docs:
-                asset_name = asset_doc["name"]
-                if asset_regex.match(asset_name):
-                    linked_asset_names.append(asset_name)
-
-            if not linked_asset_names:
-                return []
-
-            context_filters = {
-                "asset": linked_asset_names,
-                "subset": [re.compile(self.data["subset"])],
-                "hierarchy": [re.compile(self.data["hierarchy"])],
-                "representation": [self.data["representation"]],
-                "family": [self.data["family"]],
-            }
-
-        return list(get_representations(
-            project_name,
-            context_filters=context_filters
-        ))
-
-    def err_message(self):
-        return (
-            "Error while trying to load a representation.\n"
-            "Either the subset wasn't published or the template is malformed."
-            "\n\n"
-            "Builder was looking for:\n{attributes}".format(
-                attributes="\n".join([
-                    "{}: {}".format(key.title(), value)
-                    for key, value in self.data.items()]
-                )
-            )
-        )

From 8259a4129bc1439443ee7fa5d778e76f32ccd9df Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 16:22:16 +0200
Subject: [PATCH 084/147] removed functionality of previous template build
 logic

---
 .../workfile/abstract_template_loader.py      | 528 ------------------
 openpype/pipeline/workfile/build_template.py  |  72 ---
 .../workfile/build_template_exceptions.py     |  35 --
 3 files changed, 635 deletions(-)
 delete mode 100644 openpype/pipeline/workfile/abstract_template_loader.py
 delete mode 100644 openpype/pipeline/workfile/build_template.py
 delete mode 100644 openpype/pipeline/workfile/build_template_exceptions.py

diff --git a/openpype/pipeline/workfile/abstract_template_loader.py b/openpype/pipeline/workfile/abstract_template_loader.py
deleted file mode 100644
index e2fbea98ca..0000000000
--- a/openpype/pipeline/workfile/abstract_template_loader.py
+++ /dev/null
@@ -1,528 +0,0 @@
-import os
-from abc import ABCMeta, abstractmethod
-
-import six
-import logging
-from functools import reduce
-
-from openpype.client import (
-    get_asset_by_name,
-    get_linked_assets,
-)
-from openpype.settings import get_project_settings
-from openpype.lib import (
-    StringTemplate,
-    Logger,
-    filter_profiles,
-)
-from openpype.pipeline import legacy_io, Anatomy
-from openpype.pipeline.load import (
-    get_loaders_by_name,
-    get_representation_context,
-    load_with_repre_context,
-)
-
-from .build_template_exceptions import (
-    TemplateAlreadyImported,
-    TemplateLoadingFailed,
-    TemplateProfileNotFound,
-    TemplateNotFound
-)
-
-log = logging.getLogger(__name__)
-
-
-def update_representations(entities, entity):
-    if entity['context']['subset'] not in entities:
-        entities[entity['context']['subset']] = entity
-    else:
-        current = entities[entity['context']['subset']]
-        incomming = entity
-        entities[entity['context']['subset']] = max(
-            current, incomming,
-            key=lambda entity: entity["context"].get("version", -1))
-
-    return entities
-
-
-def parse_loader_args(loader_args):
-    if not loader_args:
-        return dict()
-    try:
-        parsed_args = eval(loader_args)
-        if not isinstance(parsed_args, dict):
-            return dict()
-        else:
-            return parsed_args
-    except Exception as err:
-        print(
-            "Error while parsing loader arguments '{}'.\n{}: {}\n\n"
-            "Continuing with default arguments. . .".format(
-                loader_args,
-                err.__class__.__name__,
-                err))
-        return dict()
-
-
-@six.add_metaclass(ABCMeta)
-class AbstractTemplateLoader:
-    """
-    Abstraction of Template Loader.
-    Properties:
-        template_path : property to get current template path
-    Methods:
-        import_template : Abstract Method. Used to load template,
-            depending on current host
-        get_template_nodes : Abstract Method. Used to query nodes acting
-            as placeholders. Depending on current host
-    """
-
-    _log = None
-
-    def __init__(self, placeholder_class):
-        # TODO template loader should expect host as and argument
-        #   - host have all responsibility for most of code (also provide
-        #       placeholder class)
-        #   - also have responsibility for current context
-        #       - this won't work in DCCs where multiple workfiles with
-        #           different contexts can be opened at single time
-        #  - template loader should have ability to change context
-        project_name = legacy_io.active_project()
-        asset_name = legacy_io.Session["AVALON_ASSET"]
-
-        self.loaders_by_name = get_loaders_by_name()
-        self.current_asset = asset_name
-        self.project_name = project_name
-        self.host_name = legacy_io.Session["AVALON_APP"]
-        self.task_name = legacy_io.Session["AVALON_TASK"]
-        self.placeholder_class = placeholder_class
-        self.current_asset_doc = get_asset_by_name(project_name, asset_name)
-        self.task_type = (
-            self.current_asset_doc
-            .get("data", {})
-            .get("tasks", {})
-            .get(self.task_name, {})
-            .get("type")
-        )
-
-        self.log.info(
-            "BUILDING ASSET FROM TEMPLATE :\n"
-            "Starting templated build for {asset} in {project}\n\n"
-            "Asset : {asset}\n"
-            "Task : {task_name} ({task_type})\n"
-            "Host : {host}\n"
-            "Project : {project}\n".format(
-                asset=self.current_asset,
-                host=self.host_name,
-                project=self.project_name,
-                task_name=self.task_name,
-                task_type=self.task_type
-            ))
-        # Skip if there is no loader
-        if not self.loaders_by_name:
-            self.log.warning(
-                "There is no registered loaders. No assets will be loaded")
-            return
-
-    @property
-    def log(self):
-        if self._log is None:
-            self._log = Logger.get_logger(self.__class__.__name__)
-        return self._log
-
-    def template_already_imported(self, err_msg):
-        """In case template was already loaded.
-        Raise the error as a default action.
-        Override this method in your template loader implementation
-        to manage this case."""
-        self.log.error("{}: {}".format(
-            err_msg.__class__.__name__,
-            err_msg))
-        raise TemplateAlreadyImported(err_msg)
-
-    def template_loading_failed(self, err_msg):
-        """In case template loading failed
-        Raise the error as a default action.
-        Override this method in your template loader implementation
-        to manage this case.
-        """
-        self.log.error("{}: {}".format(
-            err_msg.__class__.__name__,
-            err_msg))
-        raise TemplateLoadingFailed(err_msg)
-
-    @property
-    def template_path(self):
-        """
-        Property returning template path. Avoiding setter.
-        Getting template path from open pype settings based on current avalon
-        session and solving the path variables if needed.
-        Returns:
-            str: Solved template path
-        Raises:
-            TemplateProfileNotFound: No profile found from settings for
-                current avalon session
-            KeyError: Could not solve path because a key does not exists
-                in avalon context
-            TemplateNotFound: Solved path does not exists on current filesystem
-        """
-        project_name = self.project_name
-        host_name = self.host_name
-        task_name = self.task_name
-        task_type = self.task_type
-
-        anatomy = Anatomy(project_name)
-        project_settings = get_project_settings(project_name)
-
-        build_info = project_settings[host_name]["templated_workfile_build"]
-        profile = filter_profiles(
-            build_info["profiles"],
-            {
-                "task_types": task_type,
-                "task_names": task_name
-            }
-        )
-
-        if not profile:
-            raise TemplateProfileNotFound(
-                "No matching profile found for task '{}' of type '{}' "
-                "with host '{}'".format(task_name, task_type, host_name)
-            )
-
-        path = profile["path"]
-        if not path:
-            raise TemplateLoadingFailed(
-                "Template path is not set.\n"
-                "Path need to be set in {}\\Template Workfile Build "
-                "Settings\\Profiles".format(host_name.title()))
-
-        # Try fill path with environments and anatomy roots
-        fill_data = {
-            key: value
-            for key, value in os.environ.items()
-        }
-        fill_data["root"] = anatomy.roots
-        result = StringTemplate.format_template(path, fill_data)
-        if result.solved:
-            path = result.normalized()
-
-        if path and os.path.exists(path):
-            self.log.info("Found template at: '{}'".format(path))
-            return path
-
-        solved_path = None
-        while True:
-            try:
-                solved_path = anatomy.path_remapper(path)
-            except KeyError as missing_key:
-                raise KeyError(
-                    "Could not solve key '{}' in template path '{}'".format(
-                        missing_key, path))
-
-            if solved_path is None:
-                solved_path = path
-            if solved_path == path:
-                break
-            path = solved_path
-
-        solved_path = os.path.normpath(solved_path)
-        if not os.path.exists(solved_path):
-            raise TemplateNotFound(
-                "Template found in openPype settings for task '{}' with host "
-                "'{}' does not exists. (Not found : {})".format(
-                    task_name, host_name, solved_path))
-
-        self.log.info("Found template at: '{}'".format(solved_path))
-
-        return solved_path
-
-    def populate_template(self, ignored_ids=None):
-        """
-        Use template placeholders to load assets and parent them in hierarchy
-        Arguments :
-            ignored_ids :
-        Returns:
-            None
-        """
-
-        loaders_by_name = self.loaders_by_name
-        current_asset_doc = self.current_asset_doc
-        linked_assets = get_linked_assets(current_asset_doc)
-
-        ignored_ids = ignored_ids or []
-        placeholders = self.get_placeholders()
-        self.log.debug("Placeholders found in template: {}".format(
-            [placeholder.name for placeholder in placeholders]
-        ))
-        for placeholder in placeholders:
-            self.log.debug("Start to processing placeholder {}".format(
-                placeholder.name
-            ))
-            placeholder_representations = self.get_placeholder_representations(
-                placeholder,
-                current_asset_doc,
-                linked_assets
-            )
-
-            if not placeholder_representations:
-                self.log.info(
-                    "There's no representation for this placeholder: "
-                    "{}".format(placeholder.name)
-                )
-                continue
-
-            for representation in placeholder_representations:
-                self.preload(placeholder, loaders_by_name, representation)
-
-                if self.load_data_is_incorrect(
-                        placeholder,
-                        representation,
-                        ignored_ids):
-                    continue
-
-                self.log.info(
-                    "Loading {}_{} with loader {}\n"
-                    "Loader arguments used : {}".format(
-                        representation['context']['asset'],
-                        representation['context']['subset'],
-                        placeholder.loader_name,
-                        placeholder.loader_args))
-
-                try:
-                    container = self.load(
-                        placeholder, loaders_by_name, representation)
-                except Exception:
-                    self.load_failed(placeholder, representation)
-                else:
-                    self.load_succeed(placeholder, container)
-                finally:
-                    self.postload(placeholder)
-
-    def get_placeholder_representations(
-        self, placeholder, current_asset_doc, linked_asset_docs
-    ):
-        placeholder_representations = placeholder.get_representations(
-            current_asset_doc,
-            linked_asset_docs
-        )
-        for repre_doc in reduce(
-            update_representations,
-            placeholder_representations,
-            dict()
-        ).values():
-            yield repre_doc
-
-    def load_data_is_incorrect(
-            self, placeholder, last_representation, ignored_ids):
-        if not last_representation:
-            self.log.warning(placeholder.err_message())
-            return True
-        if (str(last_representation['_id']) in ignored_ids):
-            print("Ignoring : ", last_representation['_id'])
-            return True
-        return False
-
-    def preload(self, placeholder, loaders_by_name, last_representation):
-        pass
-
-    def load(self, placeholder, loaders_by_name, last_representation):
-        repre = get_representation_context(last_representation)
-        return load_with_repre_context(
-            loaders_by_name[placeholder.loader_name],
-            repre,
-            options=parse_loader_args(placeholder.loader_args))
-
-    def load_succeed(self, placeholder, container):
-        placeholder.parent_in_hierarchy(container)
-
-    def load_failed(self, placeholder, last_representation):
-        self.log.warning(
-            "Got error trying to load {}:{} with {}".format(
-                last_representation['context']['asset'],
-                last_representation['context']['subset'],
-                placeholder.loader_name
-            ),
-            exc_info=True
-        )
-
-    def postload(self, placeholder):
-        placeholder.clean()
-
-    def update_missing_containers(self):
-        loaded_containers_ids = self.get_loaded_containers_by_id()
-        self.populate_template(ignored_ids=loaded_containers_ids)
-
-    def get_placeholders(self):
-        placeholders = map(self.placeholder_class, self.get_template_nodes())
-        valid_placeholders = filter(
-            lambda i: i.is_valid,
-            placeholders
-        )
-        sorted_placeholders = list(sorted(
-            valid_placeholders,
-            key=lambda i: i.order
-        ))
-        return sorted_placeholders
-
-    @abstractmethod
-    def get_loaded_containers_by_id(self):
-        """
-        Collect already loaded containers for updating scene
-        Return:
-            dict (string, node): A dictionnary id as key
-            and containers as value
-        """
-        pass
-
-    @abstractmethod
-    def import_template(self, template_path):
-        """
-        Import template in current host
-        Args:
-            template_path (str): fullpath to current task and
-                host's template file
-        Return:
-            None
-        """
-        pass
-
-    @abstractmethod
-    def get_template_nodes(self):
-        """
-        Returning a list of nodes acting as host placeholders for
-        templating. The data representation is by user.
-        AbstractLoadTemplate (and LoadTemplate) won't directly manipulate nodes
-        Args :
-            None
-        Returns:
-            list(AnyNode): Solved template path
-        """
-        pass
-
-
-@six.add_metaclass(ABCMeta)
-class AbstractPlaceholder:
-    """Abstraction of placeholders logic.
-
-    Properties:
-        required_keys: A list of mandatory keys to decribe placeholder
-            and assets to load.
-        optional_keys: A list of optional keys to decribe
-            placeholder and assets to load
-        loader_name: Name of linked loader to use while loading assets
-
-    Args:
-        identifier (str): Placeholder identifier. Should be possible to be
-            used as identifier in "a scene" (e.g. unique node name).
-    """
-
-    required_keys = {
-        "builder_type",
-        "family",
-        "representation",
-        "order",
-        "loader",
-        "loader_args"
-    }
-    optional_keys = {}
-
-    def __init__(self, identifier):
-        self._log = None
-        self._name = identifier
-        self.get_data(identifier)
-
-    @property
-    def log(self):
-        if self._log is None:
-            self._log = Logger.get_logger(repr(self))
-        return self._log
-
-    def __repr__(self):
-        return "< {} {} >".format(self.__class__.__name__, self.name)
-
-    @property
-    def name(self):
-        return self._name
-
-    @property
-    def loader_args(self):
-        return self.data["loader_args"]
-
-    @property
-    def builder_type(self):
-        return self.data["builder_type"]
-
-    @property
-    def order(self):
-        return self.data["order"]
-
-    @property
-    def loader_name(self):
-        """Return placeholder loader name.
-
-        Returns:
-            str: Loader name that will be used to load placeholder
-                representations.
-        """
-
-        return self.data["loader"]
-
-    @property
-    def is_valid(self):
-        """Test validity of placeholder.
-
-        i.e.: every required key exists in placeholder data
-
-        Returns:
-            bool: True if every key is in data
-        """
-
-        if set(self.required_keys).issubset(self.data.keys()):
-            self.log.debug("Valid placeholder : {}".format(self.name))
-            return True
-        self.log.info("Placeholder is not valid : {}".format(self.name))
-        return False
-
-    @abstractmethod
-    def parent_in_hierarchy(self, container):
-        """Place loaded container in correct hierarchy given by placeholder
-
-        Args:
-            container (Dict[str, Any]): Loaded container created by loader.
-        """
-
-        pass
-
-    @abstractmethod
-    def clean(self):
-        """Clean placeholder from hierarchy after loading assets."""
-
-        pass
-
-    @abstractmethod
-    def get_representations(self, current_asset_doc, linked_asset_docs):
-        """Query representations based on placeholder data.
-
-        Args:
-            current_asset_doc (Dict[str, Any]): Document of current
-                context asset.
-            linked_asset_docs (List[Dict[str, Any]]): Documents of assets
-                linked to current context asset.
-
-        Returns:
-            Iterable[Dict[str, Any]]: Representations that are matching
-                placeholder filters.
-        """
-
-        pass
-
-    @abstractmethod
-    def get_data(self, identifier):
-        """Collect information about placeholder by identifier.
-
-        Args:
-            identifier (str): A unique placeholder identifier defined by
-                implementation.
-        """
-
-        pass
diff --git a/openpype/pipeline/workfile/build_template.py b/openpype/pipeline/workfile/build_template.py
deleted file mode 100644
index 3328dfbc9e..0000000000
--- a/openpype/pipeline/workfile/build_template.py
+++ /dev/null
@@ -1,72 +0,0 @@
-import os
-from importlib import import_module
-from openpype.lib import classes_from_module
-from openpype.host import HostBase
-from openpype.pipeline import registered_host
-
-from .abstract_template_loader import (
-    AbstractPlaceholder,
-    AbstractTemplateLoader)
-
-from .build_template_exceptions import (
-    TemplateLoadingFailed,
-    TemplateAlreadyImported,
-    MissingHostTemplateModule,
-    MissingTemplatePlaceholderClass,
-    MissingTemplateLoaderClass
-)
-
-_module_path_format = 'openpype.hosts.{host}.api.template_loader'
-
-
-def build_workfile_template(*args):
-    template_loader = build_template_loader()
-    try:
-        template_loader.import_template(template_loader.template_path)
-    except TemplateAlreadyImported as err:
-        template_loader.template_already_imported(err)
-    except TemplateLoadingFailed as err:
-        template_loader.template_loading_failed(err)
-    else:
-        template_loader.populate_template()
-
-
-def update_workfile_template(*args):
-    template_loader = build_template_loader()
-    template_loader.update_missing_containers()
-
-
-def build_template_loader():
-    # TODO refactor to use advantage of 'HostBase' and don't import dynamically
-    #   - hosts should have methods that gives option to return builders
-    host = registered_host()
-    if isinstance(host, HostBase):
-        host_name = host.name
-    else:
-        host_name = os.environ.get("AVALON_APP")
-        if not host_name:
-            host_name = host.__name__.split(".")[-2]
-
-    module_path = _module_path_format.format(host=host_name)
-    module = import_module(module_path)
-    if not module:
-        raise MissingHostTemplateModule(
-            "No template loader found for host {}".format(host_name))
-
-    template_loader_class = classes_from_module(
-        AbstractTemplateLoader,
-        module
-    )
-    template_placeholder_class = classes_from_module(
-        AbstractPlaceholder,
-        module
-    )
-
-    if not template_loader_class:
-        raise MissingTemplateLoaderClass()
-    template_loader_class = template_loader_class[0]
-
-    if not template_placeholder_class:
-        raise MissingTemplatePlaceholderClass()
-    template_placeholder_class = template_placeholder_class[0]
-    return template_loader_class(template_placeholder_class)
diff --git a/openpype/pipeline/workfile/build_template_exceptions.py b/openpype/pipeline/workfile/build_template_exceptions.py
deleted file mode 100644
index 7a5075e3dc..0000000000
--- a/openpype/pipeline/workfile/build_template_exceptions.py
+++ /dev/null
@@ -1,35 +0,0 @@
-class MissingHostTemplateModule(Exception):
-    """Error raised when expected module does not exists"""
-    pass
-
-
-class MissingTemplatePlaceholderClass(Exception):
-    """Error raised when module doesn't implement a placeholder class"""
-    pass
-
-
-class MissingTemplateLoaderClass(Exception):
-    """Error raised when module doesn't implement a template loader class"""
-    pass
-
-
-class TemplateNotFound(Exception):
-    """Exception raised when template does not exist."""
-    pass
-
-
-class TemplateProfileNotFound(Exception):
-    """Exception raised when current profile
-    doesn't match any template profile"""
-    pass
-
-
-class TemplateAlreadyImported(Exception):
-    """Error raised when Template was already imported by host for
-    this session"""
-    pass
-
-
-class TemplateLoadingFailed(Exception):
-    """Error raised whend Template loader was unable to load the template"""
-    pass

From 1da23985a9e5e8845933d9eb8d239c39aca0f1ac Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 17:16:07 +0200
Subject: [PATCH 085/147] unified LoadPlaceholderItem

---
 .../maya/api/workfile_template_builder.py     | 40 +++++--------------
 .../nuke/api/workfile_template_builder.py     | 29 +-------------
 .../workfile/workfile_template_builder.py     | 40 +++++++++++++++++--
 3 files changed, 47 insertions(+), 62 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index 71e3e0ce4e..9163cf9a6f 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -7,7 +7,7 @@ from openpype.pipeline.workfile.workfile_template_builder import (
     TemplateAlreadyImported,
     AbstractTemplateBuilder,
     PlaceholderPlugin,
-    PlaceholderItem,
+    LoadPlaceholderItem,
     PlaceholderLoadMixin,
 )
 from openpype.tools.workfile_template_build import (
@@ -239,15 +239,10 @@ class MayaPlaceholderLoadPlugin(PlaceholderPlugin, PlaceholderLoadMixin):
         cmds.hide(node)
         cmds.setAttr(node + ".hiddenInOutliner", True)
 
+    def load_succeed(self, placeholder, container):
+        self._parent_in_hierarhchy(placeholder, container)
 
-class LoadPlaceholderItem(PlaceholderItem):
-    """Concrete implementation of PlaceholderItem for Maya load plugin."""
-
-    def __init__(self, *args, **kwargs):
-        super(LoadPlaceholderItem, self).__init__(*args, **kwargs)
-        self._failed_representations = []
-
-    def parent_in_hierarchy(self, container):
+    def _parent_in_hierarchy(self, placeholder, container):
         """Parent loaded container to placeholder's parent.
 
         ie : Set loaded content as placeholder's sibling
@@ -272,43 +267,26 @@ class LoadPlaceholderItem(PlaceholderItem):
             elif not cmds.sets(root, q=True):
                 return
 
-        if self.data["parent"]:
-            cmds.parent(nodes_to_parent, self.data["parent"])
+        if placeholder.data["parent"]:
+            cmds.parent(nodes_to_parent, placeholder.data["parent"])
         # Move loaded nodes to correct index in outliner hierarchy
         placeholder_form = cmds.xform(
-            self._scene_identifier,
+            placeholder.scene_identifier,
             q=True,
             matrix=True,
             worldSpace=True
         )
         for node in set(nodes_to_parent):
             cmds.reorder(node, front=True)
-            cmds.reorder(node, relative=self.data["index"])
+            cmds.reorder(node, relative=placeholder.data["index"])
             cmds.xform(node, matrix=placeholder_form, ws=True)
 
-        holding_sets = cmds.listSets(object=self._scene_identifier)
+        holding_sets = cmds.listSets(object=placeholder.scene_identifier)
         if not holding_sets:
             return
         for holding_set in holding_sets:
             cmds.sets(roots, forceElement=holding_set)
 
-    def get_errors(self):
-        if not self._failed_representations:
-            return []
-        message = (
-            "Failed to load {} representations using Loader {}"
-        ).format(
-            len(self._failed_representations),
-            self.data["loader"]
-        )
-        return [message]
-
-    def load_failed(self, representation):
-        self._failed_representations.append(representation)
-
-    def load_succeed(self, container):
-        self.parent_in_hierarchy(container)
-
 
 def build_workfile_template(*args):
     builder = MayaTemplateBuilder(registered_host())
diff --git a/openpype/hosts/nuke/api/workfile_template_builder.py b/openpype/hosts/nuke/api/workfile_template_builder.py
index ba0d975496..709ee3b743 100644
--- a/openpype/hosts/nuke/api/workfile_template_builder.py
+++ b/openpype/hosts/nuke/api/workfile_template_builder.py
@@ -6,7 +6,7 @@ from openpype.pipeline import registered_host
 from openpype.pipeline.workfile.workfile_template_builder import (
     AbstractTemplateBuilder,
     PlaceholderPlugin,
-    PlaceholderItem,
+    LoadPlaceholderItem,
     PlaceholderLoadMixin,
 )
 from openpype.tools.workfile_template_build import (
@@ -177,7 +177,7 @@ class NukePlaceholderLoadPlugin(NukePlaceholderPlugin, PlaceholderLoadMixin):
             placeholder_data = self._parse_placeholder_node_data(node)
             # TODO do data validations and maybe updgrades if are invalid
             output.append(
-                NukeLoadPlaceholderItem(node_name, placeholder_data, self)
+                LoadPlaceholderItem(node_name, placeholder_data, self)
             )
 
         return output
@@ -535,31 +535,6 @@ class NukePlaceholderLoadPlugin(NukePlaceholderPlugin, PlaceholderLoadMixin):
         siblings_input.setInput(0, copy_output)
 
 
-class NukeLoadPlaceholderItem(PlaceholderItem):
-    """Concrete implementation of PlaceholderItem for Maya load plugin."""
-
-    def __init__(self, *args, **kwargs):
-        super(NukeLoadPlaceholderItem, self).__init__(*args, **kwargs)
-        self._failed_representations = []
-
-    def get_errors(self):
-        if not self._failed_representations:
-            return []
-        message = (
-            "Failed to load {} representations using Loader {}"
-        ).format(
-            len(self._failed_representations),
-            self.data["loader"]
-        )
-        return [message]
-
-    def load_failed(self, representation):
-        self._failed_representations.append(representation)
-
-    def load_succeed(self, container):
-        pass
-
-
 def build_workfile_template(*args):
     builder = NukeTemplateBuilder(registered_host())
     builder.build_template()
diff --git a/openpype/pipeline/workfile/workfile_template_builder.py b/openpype/pipeline/workfile/workfile_template_builder.py
index f81849fbe4..582657c735 100644
--- a/openpype/pipeline/workfile/workfile_template_builder.py
+++ b/openpype/pipeline/workfile/workfile_template_builder.py
@@ -1064,10 +1064,9 @@ class PlaceholderLoadMixin(object):
 
     For placeholder population is implemented 'populate_load_placeholder'.
 
-    Requires that PlaceholderItem has implemented methods:
+    PlaceholderItem can have implemented methods:
     - 'load_failed' - called when loading of one representation failed
     - 'load_succeed' - called when loading of one representation succeeded
-    - 'clean' - called when placeholder processing finished
     """
 
     def get_load_plugin_options(self, options=None):
@@ -1397,13 +1396,21 @@ class PlaceholderLoadMixin(object):
 
             except Exception:
                 failed = True
-                placeholder.load_failed(representation)
+                self.load_failed(placeholder, representation)
 
             else:
                 failed = False
-                placeholder.load_succeed(container)
+                self.load_succeed(placeholder, container)
             self.cleanup_placeholder(placeholder, failed)
 
+    def load_failed(self, placeholder, representation):
+        if hasattr(placeholder, "load_failed"):
+            placeholder.load_failed(representation)
+
+    def load_succeed(self, placeholder, container):
+        if hasattr(placeholder, "load_succeed"):
+            placeholder.load_succeed(container)
+
     def cleanup_placeholder(self, placeholder, failed):
         """Cleanup placeholder after load of single representation.
 
@@ -1417,3 +1424,28 @@ class PlaceholderLoadMixin(object):
         """
 
         pass
+
+
+class LoadPlaceholderItem(PlaceholderItem):
+    """PlaceholderItem for plugin which is loading representations.
+
+    Connected to 'PlaceholderLoadMixin'.
+    """
+
+    def __init__(self, *args, **kwargs):
+        super(LoadPlaceholderItem, self).__init__(*args, **kwargs)
+        self._failed_representations = []
+
+    def get_errors(self):
+        if not self._failed_representations:
+            return []
+        message = (
+            "Failed to load {} representations using Loader {}"
+        ).format(
+            len(self._failed_representations),
+            self.data["loader"]
+        )
+        return [message]
+
+    def load_failed(self, representation):
+        self._failed_representations.append(representation)

From b151c04b00305c837f29dd4820c7e8a99c1a66b5 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 17:45:40 +0200
Subject: [PATCH 086/147] removed unused variables

---
 openpype/tools/workfile_template_build/window.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/tools/workfile_template_build/window.py b/openpype/tools/workfile_template_build/window.py
index 2e531026cf..757ccc0b4a 100644
--- a/openpype/tools/workfile_template_build/window.py
+++ b/openpype/tools/workfile_template_build/window.py
@@ -205,7 +205,7 @@ class WorkfileBuildPlaceholderDialog(QtWidgets.QDialog):
         try:
             plugin.update_placeholder(self._update_item, options)
             self.accept()
-        except Exception as exc:
+        except Exception:
             self.log.warning("Something went wrong", exc_info=True)
             dialog = QtWidgets.QMessageBox(self)
             dialog.setWindowTitle("Something went wrong")
@@ -221,7 +221,7 @@ class WorkfileBuildPlaceholderDialog(QtWidgets.QDialog):
         try:
             plugin.create_placeholder(options)
             self.accept()
-        except Exception as exc:
+        except Exception:
             self.log.warning("Something went wrong", exc_info=True)
             dialog = QtWidgets.QMessageBox(self)
             dialog.setWindowTitle("Something went wrong")

From b5682af9ac880cc91adad91b66720f15d47e3463 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 13 Sep 2022 17:46:27 +0200
Subject: [PATCH 087/147] fix variable usage

---
 openpype/tools/workfile_template_build/window.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/tools/workfile_template_build/window.py b/openpype/tools/workfile_template_build/window.py
index 757ccc0b4a..ea4e2fec5a 100644
--- a/openpype/tools/workfile_template_build/window.py
+++ b/openpype/tools/workfile_template_build/window.py
@@ -126,8 +126,8 @@ class WorkfileBuildPlaceholderDialog(QtWidgets.QDialog):
         self._last_selected_plugin = None
         self._plugins_combo.clear()
         for identifier, plugin in placeholder_plugins.items():
-            label = plugin.label or plugin.identifier
-            self._plugins_combo.addItem(label, plugin.identifier)
+            label = plugin.label or identifier
+            self._plugins_combo.addItem(label, identifier)
 
         index = self._plugins_combo.findData(last_selected_plugin)
         if index < 0:

From 6186c63c599822bddaf4fc2c2a437831f00e62b6 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Wed, 14 Sep 2022 13:50:01 +0200
Subject: [PATCH 088/147] added 'float2' type support

---
 openpype/lib/transcoding.py                                     | 2 +-
 .../plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/lib/transcoding.py b/openpype/lib/transcoding.py
index 60d5d3ed4a..71c12b3376 100644
--- a/openpype/lib/transcoding.py
+++ b/openpype/lib/transcoding.py
@@ -139,7 +139,7 @@ def convert_value_by_type_name(value_type, value, logger=None):
         return float(value)
 
     # Vectors will probably have more types
-    if value_type == "vec2f":
+    if value_type in ("vec2f", "float2"):
         return [float(item) for item in value.split(",")]
 
     # Matrix should be always have square size of element 3x3, 4x4
diff --git a/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py b/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py
index 05899de5e1..691c642e82 100644
--- a/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py
+++ b/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py
@@ -56,7 +56,7 @@ def convert_value_by_type_name(value_type, value):
         return float(value)
 
     # Vectors will probably have more types
-    if value_type == "vec2f":
+    if value_type in ("vec2f", "float2"):
         return [float(item) for item in value.split(",")]
 
     # Matrix should be always have square size of element 3x3, 4x4

From e5b82d112373905cc61e2030e3939a09eba90ee1 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Wed, 14 Sep 2022 13:50:21 +0200
Subject: [PATCH 089/147] lowered log level and modified messages on unknown
 value type

---
 openpype/lib/transcoding.py                               | 8 ++++----
 .../OpenPypeTileAssembler/OpenPypeTileAssembler.py        | 4 ++--
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/openpype/lib/transcoding.py b/openpype/lib/transcoding.py
index 71c12b3376..5b919b4111 100644
--- a/openpype/lib/transcoding.py
+++ b/openpype/lib/transcoding.py
@@ -204,8 +204,8 @@ def convert_value_by_type_name(value_type, value, logger=None):
             )
         return output
 
-    logger.info((
-        "MISSING IMPLEMENTATION:"
+    logger.debug((
+        "Dev note (missing implementation):"
         " Unknown attrib type \"{}\". Value: {}"
     ).format(value_type, value))
     return value
@@ -263,8 +263,8 @@ def parse_oiio_xml_output(xml_string, logger=None):
         # - feel free to add more tags
         else:
             value = child.text
-            logger.info((
-                "MISSING IMPLEMENTATION:"
+            logger.debug((
+                "Dev note (missing implementation):"
                 " Unknown tag \"{}\". Value \"{}\""
             ).format(tag_name, value))
 
diff --git a/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py b/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py
index 691c642e82..c5208590f2 100644
--- a/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py
+++ b/openpype/modules/deadline/repository/custom/plugins/OpenPypeTileAssembler/OpenPypeTileAssembler.py
@@ -127,7 +127,7 @@ def convert_value_by_type_name(value_type, value):
         return output
 
     print((
-        "MISSING IMPLEMENTATION:"
+        "Dev note (missing implementation):"
         " Unknown attrib type \"{}\". Value: {}"
     ).format(value_type, value))
     return value
@@ -183,7 +183,7 @@ def parse_oiio_xml_output(xml_string):
         else:
             value = child.text
             print((
-                "MISSING IMPLEMENTATION:"
+                "Dev note (missing implementation):"
                 " Unknown tag \"{}\". Value \"{}\""
             ).format(tag_name, value))
 

From 790d350d7f0c9a90fae28a02e0bfea57d1746e4a Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Wed, 14 Sep 2022 22:17:50 +0200
Subject: [PATCH 090/147] fix: retimed attributes integration

---
 .../publish/extract_subset_resources.py       | 27 +++++++++++--------
 .../publish/collect_otio_frame_ranges.py      | 12 +++++++--
 2 files changed, 26 insertions(+), 13 deletions(-)

diff --git a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
index 1d42330e23..0774c401c0 100644
--- a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
+++ b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
@@ -90,7 +90,7 @@ class ExtractSubsetResources(openpype.api.Extractor):
         handle_end = instance.data["handleEnd"]
         handles = max(handle_start, handle_end)
         include_handles = instance.data.get("includeHandles")
-        retimed_handles = instance.data.get("retimedHandles")
+        not_retimed_handles = instance.data.get("notRetimedHandles")
 
         # get media source range with handles
         source_start_handles = instance.data["sourceStartH"]
@@ -98,7 +98,15 @@ class ExtractSubsetResources(openpype.api.Extractor):
 
         # retime if needed
         if r_speed != 1.0:
-            if retimed_handles:
+            if not_retimed_handles:
+                # handles are not retimed
+                source_end_handles = (
+                    source_start_handles
+                    + (r_source_dur - 1)
+                    + handle_start
+                    + handle_end
+                )
+            else:
                 # handles are retimed
                 source_start_handles = (
                     instance.data["sourceStart"] - r_handle_start)
@@ -108,20 +116,12 @@ class ExtractSubsetResources(openpype.api.Extractor):
                     + r_handle_start
                     + r_handle_end
                 )
-            else:
-                # handles are not retimed
-                source_end_handles = (
-                    source_start_handles
-                    + (r_source_dur - 1)
-                    + handle_start
-                    + handle_end
-                )
 
         # get frame range with handles for representation range
         frame_start_handle = frame_start - handle_start
         repre_frame_start = frame_start_handle
         if include_handles:
-            if r_speed == 1.0 or not retimed_handles:
+            if r_speed == 1.0 or not_retimed_handles:
                 frame_start_handle = frame_start
             else:
                 frame_start_handle = (
@@ -167,6 +167,11 @@ class ExtractSubsetResources(openpype.api.Extractor):
                     - (r_handle_start + r_handle_end)
                 )
             })
+            if not_retimed_handles:
+                instance.data["versionData"].update({
+                    "handleStart": handle_start,
+                    "handleEnd": handle_end
+                })
         self.log.debug("_ i_version_data: {}".format(
             instance.data["versionData"]
         ))
diff --git a/openpype/plugins/publish/collect_otio_frame_ranges.py b/openpype/plugins/publish/collect_otio_frame_ranges.py
index cfb0318950..bfd5320c25 100644
--- a/openpype/plugins/publish/collect_otio_frame_ranges.py
+++ b/openpype/plugins/publish/collect_otio_frame_ranges.py
@@ -10,6 +10,7 @@ import opentimelineio as otio
 import pyblish.api
 from pprint import pformat
 from openpype.pipeline.editorial import (
+    get_media_range_with_retimes,
     otio_range_to_frame_range,
     otio_range_with_handles
 )
@@ -57,8 +58,15 @@ class CollectOtioFrameRanges(pyblish.api.InstancePlugin):
 
         # in case of retimed clip and frame range should not be retimed
         if workfile_source_duration:
-            frame_end = frame_start + otio.opentime.to_frames(
-                otio_src_range.duration, otio_src_range.duration.rate) - 1
+            # get available range trimmed with processed retimes
+            retimed_attributes = get_media_range_with_retimes(
+                otio_clip, 0, 0)
+            self.log.debug(
+                ">> retimed_attributes: {}".format(retimed_attributes))
+            media_in = int(retimed_attributes["mediaIn"])
+            media_out = int(retimed_attributes["mediaOut"])
+            frame_end = frame_start + (media_out - media_in) + 1
+            self.log.debug(frame_end)
 
         data = {
             "frameStart": frame_start,

From be0734684918130469a775fc67d21c8684620f5b Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Wed, 14 Sep 2022 22:18:07 +0200
Subject: [PATCH 091/147] flame: settings for retimed attributes

---
 .../hosts/flame/plugins/create/create_shot_clip.py     |  4 ++--
 openpype/settings/defaults/project_settings/flame.json |  4 +++-
 .../schemas/projects_schema/schema_project_flame.json  | 10 ++++++++++
 3 files changed, 15 insertions(+), 3 deletions(-)

diff --git a/openpype/hosts/flame/plugins/create/create_shot_clip.py b/openpype/hosts/flame/plugins/create/create_shot_clip.py
index b03a39a7ca..7622ff217c 100644
--- a/openpype/hosts/flame/plugins/create/create_shot_clip.py
+++ b/openpype/hosts/flame/plugins/create/create_shot_clip.py
@@ -23,10 +23,10 @@ class CreateShotClip(opfapi.Creator):
                 # nested dictionary (only one level allowed
                 # for sections and dict)
                 for _k, _v in v["value"].items():
-                    if presets.get(_k):
+                    if presets.get(_k, None) is not None:
                         gui_inputs[k][
                             "value"][_k]["value"] = presets[_k]
-            if presets.get(k):
+            if presets.get(_k, None) is not None:
                 gui_inputs[k]["value"] = presets[k]
 
         # open widget for plugins inputs
diff --git a/openpype/settings/defaults/project_settings/flame.json b/openpype/settings/defaults/project_settings/flame.json
index bfdc58d9ee..c90193fe13 100644
--- a/openpype/settings/defaults/project_settings/flame.json
+++ b/openpype/settings/defaults/project_settings/flame.json
@@ -17,7 +17,9 @@
             "workfileFrameStart": 1001,
             "handleStart": 5,
             "handleEnd": 5,
-            "includeHandles": false
+            "includeHandles": false,
+            "retimedHandles": true,
+            "retimedFramerange": true
         }
     },
     "publish": {
diff --git a/openpype/settings/entities/schemas/projects_schema/schema_project_flame.json b/openpype/settings/entities/schemas/projects_schema/schema_project_flame.json
index ca62679b3d..5f05bef0e1 100644
--- a/openpype/settings/entities/schemas/projects_schema/schema_project_flame.json
+++ b/openpype/settings/entities/schemas/projects_schema/schema_project_flame.json
@@ -128,6 +128,16 @@
                                 "type": "boolean",
                                 "key": "includeHandles",
                                 "label": "Enable handles including"
+                            },
+                            {
+                                "type": "boolean",
+                                "key": "retimedHandles",
+                                "label": "Enable retimed handles"
+                            },
+                            {
+                                "type": "boolean",
+                                "key": "retimedFramerange",
+                                "label": "Enable retimed shot frameranges"
                             }
                           ]
                         }

From c97602341fbeb6ef40c46143619f56f693c36588 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 11:53:49 +0200
Subject: [PATCH 092/147] flame: fix creator preset detection

---
 openpype/hosts/flame/plugins/create/create_shot_clip.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/openpype/hosts/flame/plugins/create/create_shot_clip.py b/openpype/hosts/flame/plugins/create/create_shot_clip.py
index 7622ff217c..835201cd3b 100644
--- a/openpype/hosts/flame/plugins/create/create_shot_clip.py
+++ b/openpype/hosts/flame/plugins/create/create_shot_clip.py
@@ -26,7 +26,8 @@ class CreateShotClip(opfapi.Creator):
                     if presets.get(_k, None) is not None:
                         gui_inputs[k][
                             "value"][_k]["value"] = presets[_k]
-            if presets.get(_k, None) is not None:
+
+            if presets.get(k, None) is not None:
                 gui_inputs[k]["value"] = presets[k]
 
         # open widget for plugins inputs

From fa65e20ff7f4ff843ca54ac97897f33567c89eee Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 12:09:59 +0200
Subject: [PATCH 093/147] Flame: open folder and files after project is created

---
 openpype/hosts/flame/hooks/pre_flame_setup.py | 35 ++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/openpype/hosts/flame/hooks/pre_flame_setup.py b/openpype/hosts/flame/hooks/pre_flame_setup.py
index ad2b0dc897..9c2ad709c7 100644
--- a/openpype/hosts/flame/hooks/pre_flame_setup.py
+++ b/openpype/hosts/flame/hooks/pre_flame_setup.py
@@ -22,6 +22,7 @@ class FlamePrelaunch(PreLaunchHook):
     in environment var FLAME_SCRIPT_DIR.
     """
     app_groups = ["flame"]
+    permisisons = 0o777
 
     wtc_script_path = os.path.join(
         opflame.HOST_DIR, "api", "scripts", "wiretap_com.py")
@@ -38,6 +39,7 @@ class FlamePrelaunch(PreLaunchHook):
         """Hook entry method."""
         project_doc = self.data["project_doc"]
         project_name = project_doc["name"]
+        volume_name = _env.get("FLAME_WIRETAP_VOLUME")
 
         # get image io
         project_anatomy = self.data["anatomy"]
@@ -81,7 +83,7 @@ class FlamePrelaunch(PreLaunchHook):
         data_to_script = {
             # from settings
             "host_name": _env.get("FLAME_WIRETAP_HOSTNAME") or hostname,
-            "volume_name": _env.get("FLAME_WIRETAP_VOLUME"),
+            "volume_name": volume_name,
             "group_name": _env.get("FLAME_WIRETAP_GROUP"),
             "color_policy": str(imageio_flame["project"]["colourPolicy"]),
 
@@ -99,8 +101,39 @@ class FlamePrelaunch(PreLaunchHook):
 
         app_arguments = self._get_launch_arguments(data_to_script)
 
+        # fix project data permission issue
+        self._fix_permissions(project_name, volume_name)
+
         self.launch_context.launch_args.extend(app_arguments)
 
+    def _fix_permissions(self, project_name, volume_name):
+        """Work around for project data permissions
+
+        Reported issue: when project is created locally on one machine,
+        it is impossible to migrate it to other machine. Autodesk Flame
+        is crating some unmanagable files which needs to be opened to 0o777.
+
+        Args:
+            project_name (str): project name
+            volume_name (str): studio volume
+        """
+        dirs_to_modify = [
+            "/usr/discreet/project/{}".format(project_name),
+            "/opt/Autodesk/clip/{}/{}.prj".format(volume_name, project_name),
+            "/usr/discreet/clip/{}/{}.prj".format(volume_name, project_name)
+        ]
+
+        for dirtm in dirs_to_modify:
+            for root, dirs, files in os.walk(dirtm):
+                try:
+                    for d in dirs:
+                        os.chmod(os.path.join(root, d), self.permisisons)
+                    for f in files:
+                        os.chmod(os.path.join(root, f), self.permisisons)
+                except OSError as _E:
+                    self.log.warning("Not able to open files: {}".format(_E))
+
+
     def _get_flame_fps(self, fps_num):
         fps_table = {
             float(23.976): "23.976 fps",

From 8a21fdfcf25a3294b53e742dff84eb82950768e7 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 15 Sep 2022 12:48:35 +0200
Subject: [PATCH 094/147] OP-3682 - Hound

---
 common/openpype_common/distribution/addon_distribution.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/common/openpype_common/distribution/addon_distribution.py b/common/openpype_common/distribution/addon_distribution.py
index e39ce66a0a..ac9c69deca 100644
--- a/common/openpype_common/distribution/addon_distribution.py
+++ b/common/openpype_common/distribution/addon_distribution.py
@@ -71,7 +71,7 @@ class AddonDownloader:
         Args:
             source (dict): {type:"http", "url":"https://} ...}
             destination (str): local folder to unzip
-        Retursn:
+        Returns:
             (str) local path to addon zip file
         """
         pass
@@ -235,4 +235,4 @@ def check_addons(server_endpoint, addon_folder, downloaders):
 
 
 def cli(*args):
-    raise NotImplemented
+    raise NotImplementedError

From ed29c38cdcaa446bdfa0d0f8300e987d253e09f1 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 13:11:42 +0200
Subject: [PATCH 095/147] flame: turn double negative logic to readable code

---
 .../publish/extract_subset_resources.py       | 24 +++++++++----------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
index 0774c401c0..a8d3201896 100644
--- a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
+++ b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
@@ -1,7 +1,6 @@
 import os
 import re
 import tempfile
-from pprint import pformat
 from copy import deepcopy
 
 import pyblish.api
@@ -90,7 +89,7 @@ class ExtractSubsetResources(openpype.api.Extractor):
         handle_end = instance.data["handleEnd"]
         handles = max(handle_start, handle_end)
         include_handles = instance.data.get("includeHandles")
-        not_retimed_handles = instance.data.get("notRetimedHandles")
+        retimed_handles = instance.data.get("retimedHandles")
 
         # get media source range with handles
         source_start_handles = instance.data["sourceStartH"]
@@ -98,15 +97,7 @@ class ExtractSubsetResources(openpype.api.Extractor):
 
         # retime if needed
         if r_speed != 1.0:
-            if not_retimed_handles:
-                # handles are not retimed
-                source_end_handles = (
-                    source_start_handles
-                    + (r_source_dur - 1)
-                    + handle_start
-                    + handle_end
-                )
-            else:
+            if retimed_handles:
                 # handles are retimed
                 source_start_handles = (
                     instance.data["sourceStart"] - r_handle_start)
@@ -117,11 +108,20 @@ class ExtractSubsetResources(openpype.api.Extractor):
                     + r_handle_end
                 )
 
+            else:
+                # handles are not retimed
+                source_end_handles = (
+                    source_start_handles
+                    + (r_source_dur - 1)
+                    + handle_start
+                    + handle_end
+                )
+
         # get frame range with handles for representation range
         frame_start_handle = frame_start - handle_start
         repre_frame_start = frame_start_handle
         if include_handles:
-            if r_speed == 1.0 or not_retimed_handles:
+            if r_speed == 1.0 or not retimed_handles:
                 frame_start_handle = frame_start
             else:
                 frame_start_handle = (

From ecc6f3ae0e2e4a24cafde6cd13f4959403bc9ada Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 13:12:04 +0200
Subject: [PATCH 096/147] flame: fixing logic

---
 .../flame/plugins/publish/collect_timeline_instances.py      | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/openpype/hosts/flame/plugins/publish/collect_timeline_instances.py b/openpype/hosts/flame/plugins/publish/collect_timeline_instances.py
index d6ff13b059..76d48dded2 100644
--- a/openpype/hosts/flame/plugins/publish/collect_timeline_instances.py
+++ b/openpype/hosts/flame/plugins/publish/collect_timeline_instances.py
@@ -131,9 +131,8 @@ class CollectTimelineInstances(pyblish.api.ContextPlugin):
                 "fps": self.fps,
                 "workfileFrameStart": workfile_start,
                 "sourceFirstFrame": int(first_frame),
-                "notRetimedHandles": (
-                    not marker_data.get("retimedHandles")),
-                "notRetimedFramerange": (
+                "retimedHandles": marker_data.get("retimedHandles"),
+                "shotDurationFromSource": (
                     not marker_data.get("retimedFramerange")),
                 "path": file_path,
                 "flameAddTasks": self.add_tasks,

From b635749a7748880df74ea65927148e833c7d7e98 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 13:12:23 +0200
Subject: [PATCH 097/147] global: improving code readibility

---
 openpype/plugins/publish/collect_otio_frame_ranges.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/plugins/publish/collect_otio_frame_ranges.py b/openpype/plugins/publish/collect_otio_frame_ranges.py
index bfd5320c25..9a68b6e43d 100644
--- a/openpype/plugins/publish/collect_otio_frame_ranges.py
+++ b/openpype/plugins/publish/collect_otio_frame_ranges.py
@@ -30,7 +30,7 @@ class CollectOtioFrameRanges(pyblish.api.InstancePlugin):
         # get basic variables
         otio_clip = instance.data["otioClip"]
         workfile_start = instance.data["workfileFrameStart"]
-        workfile_source_duration = instance.data.get("notRetimedFramerange")
+        workfile_source_duration = instance.data.get("shotDurationFromSource")
 
         # get ranges
         otio_tl_range = otio_clip.range_in_parent()

From 4c0f629e386794b26c8b48fbe30ea0b6599f752d Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 13:13:54 +0200
Subject: [PATCH 098/147] flame: missing variable fix

---
 .../hosts/flame/plugins/publish/extract_subset_resources.py     | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
index a8d3201896..7adcd1453e 100644
--- a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
+++ b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
@@ -167,7 +167,7 @@ class ExtractSubsetResources(openpype.api.Extractor):
                     - (r_handle_start + r_handle_end)
                 )
             })
-            if not_retimed_handles:
+            if not retimed_handles:
                 instance.data["versionData"].update({
                     "handleStart": handle_start,
                     "handleEnd": handle_end

From cfe997dac7a519500ec19834ead6963d7e01ebc8 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 14:16:40 +0200
Subject: [PATCH 099/147] flame: fixing ls()

---
 openpype/hosts/flame/api/pipeline.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/flame/api/pipeline.py b/openpype/hosts/flame/api/pipeline.py
index da44be1b15..324d13bc3f 100644
--- a/openpype/hosts/flame/api/pipeline.py
+++ b/openpype/hosts/flame/api/pipeline.py
@@ -90,8 +90,7 @@ def containerise(flame_clip_segment,
 def ls():
     """List available containers.
     """
-    # TODO: ls
-    pass
+    return []
 
 
 def parse_container(tl_segment, validate=True):
@@ -107,6 +106,7 @@ def update_container(tl_segment, data=None):
     # TODO: update_container
     pass
 
+
 def on_pyblish_instance_toggled(instance, old_value, new_value):
     """Toggle node passthrough states on instance toggles."""
 

From d1d2d05ec6b8e62e6765b9e1b17ef6f7d9ba950d Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 15 Sep 2022 16:15:14 +0200
Subject: [PATCH 100/147] flame: version frame start was wrong if handles
 included was off

---
 .../publish/extract_subset_resources.py       | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
index 7adcd1453e..1b7e9b88b5 100644
--- a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
+++ b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
@@ -136,6 +136,9 @@ class ExtractSubsetResources(openpype.api.Extractor):
         source_duration_handles = (
             source_end_handles - source_start_handles) + 1
 
+        self.log.debug("_ source_duration_handles: {}".format(
+            source_duration_handles))
+
         # create staging dir path
         staging_dir = self.staging_dir(instance)
 
@@ -159,18 +162,28 @@ class ExtractSubsetResources(openpype.api.Extractor):
         if version_data:
             instance.data["versionData"].update(version_data)
 
+        # version data start frame
+        vd_frame_start = frame_start
+        if include_handles:
+            vd_frame_start = frame_start_handle
+
         if r_speed != 1.0:
             instance.data["versionData"].update({
-                "frameStart": frame_start_handle,
+                "frameStart": vd_frame_start,
                 "frameEnd": (
-                    (frame_start_handle + source_duration_handles - 1)
+                    (vd_frame_start + source_duration_handles - 1)
                     - (r_handle_start + r_handle_end)
                 )
             })
             if not retimed_handles:
                 instance.data["versionData"].update({
                     "handleStart": handle_start,
-                    "handleEnd": handle_end
+                    "handleEnd": handle_end,
+                    "frameStart": vd_frame_start,
+                    "frameEnd": (
+                        (vd_frame_start + source_duration_handles - 1)
+                        - (handle_start + handle_end)
+                    )
                 })
         self.log.debug("_ i_version_data: {}".format(
             instance.data["versionData"]

From 0fb1b9be93de9fe690afc4b1ca6fca2b1f8ce2fd Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Thu, 15 Sep 2022 17:59:02 +0200
Subject: [PATCH 101/147] OP-3682 - updated AddonSource

---
 .../distribution/addon_distribution.py        | 33 +++++++++++++++++--
 .../tests/test_addon_distributtion.py         |  8 ++---
 2 files changed, 35 insertions(+), 6 deletions(-)

diff --git a/common/openpype_common/distribution/addon_distribution.py b/common/openpype_common/distribution/addon_distribution.py
index ac9c69deca..be6faab3e6 100644
--- a/common/openpype_common/distribution/addon_distribution.py
+++ b/common/openpype_common/distribution/addon_distribution.py
@@ -32,21 +32,50 @@ class MultiPlatformPath(object):
 @attr.s
 class AddonSource(object):
     type = attr.ib()
-    url = attr.ib(default=None)
+
+
+@attr.s
+class LocalAddonSource(AddonSource):
     path = attr.ib(default=attr.Factory(MultiPlatformPath))
 
 
+@attr.s
+class WebAddonSource(AddonSource):
+    url = attr.ib(default=None)
+
+
 @attr.s
 class AddonInfo(object):
     """Object matching json payload from Server"""
     name = attr.ib()
     version = attr.ib()
-    sources = attr.ib(default=attr.Factory(list), type=AddonSource)
+    sources = attr.ib(default=attr.Factory(list))
     hash = attr.ib(default=None)
     description = attr.ib(default=None)
     license = attr.ib(default=None)
     authors = attr.ib(default=None)
 
+    @classmethod
+    def from_dict(cls, data):
+        sources = []
+        for source in data.get("sources", []):
+            if source.get("type") == UrlType.FILESYSTEM.value:
+                source_addon = LocalAddonSource(type=source["type"],
+                                                path=source["path"])
+            if source.get("type") == UrlType.HTTP.value:
+                source_addon = WebAddonSource(type=source["type"],
+                                              url=source["url"])
+
+            sources.append(source_addon)
+
+        return cls(name=data.get("name"),
+                   version=data.get("version"),
+                   hash=data.get("hash"),
+                   description=data.get("description"),
+                   sources=sources,
+                   license=data.get("license"),
+                   authors=data.get("authors"))
+
 
 class AddonDownloader:
     log = logging.getLogger(__name__)
diff --git a/common/openpype_common/distribution/tests/test_addon_distributtion.py b/common/openpype_common/distribution/tests/test_addon_distributtion.py
index 7dd27fd44f..faf4e01e22 100644
--- a/common/openpype_common/distribution/tests/test_addon_distributtion.py
+++ b/common/openpype_common/distribution/tests/test_addon_distributtion.py
@@ -75,7 +75,7 @@ def test_get_downloader(printer, addon_downloader):
 def test_addon_info(printer, sample_addon_info):
     valid_minimum = {"name": "openpype_slack", "version": "1.0.0"}
 
-    assert AddonInfo(**valid_minimum), "Missing required fields"
+    assert AddonInfo.from_dict(valid_minimum), "Missing required fields"
     assert AddonInfo(name=valid_minimum["name"],
                      version=valid_minimum["version"]), \
         "Missing required fields"
@@ -84,7 +84,7 @@ def test_addon_info(printer, sample_addon_info):
         # TODO should be probably implemented
         assert AddonInfo(valid_minimum), "Wrong argument format"
 
-    addon = AddonInfo(**sample_addon_info)
+    addon = AddonInfo.from_dict(sample_addon_info)
     assert addon, "Should be created"
     assert addon.name == "openpype_slack", "Incorrect name"
     assert addon.version == "1.0.0", "Incorrect version"
@@ -95,10 +95,10 @@ def test_addon_info(printer, sample_addon_info):
     addon_as_dict = attr.asdict(addon)
     assert addon_as_dict["name"], "Dict approach should work"
 
-    with pytest.raises(AttributeError):
+    with pytest.raises(TypeError):
         # TODO should be probably implemented as . not dict
         first_source = addon.sources[0]
-        assert first_source.type == "http", "Not implemented"
+        assert first_source["type"] == "http", "Not implemented"
 
 
 def test_update_addon_state(printer, sample_addon_info,

From 9c6d0b1d7e10a9d5d56832f8b0bb25952f25ad38 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Fri, 16 Sep 2022 11:20:52 +0200
Subject: [PATCH 102/147] OP-3682 - changed to relative import

---
 common/openpype_common/distribution/addon_distribution.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/openpype_common/distribution/addon_distribution.py b/common/openpype_common/distribution/addon_distribution.py
index be6faab3e6..ad17a831d8 100644
--- a/common/openpype_common/distribution/addon_distribution.py
+++ b/common/openpype_common/distribution/addon_distribution.py
@@ -7,7 +7,7 @@ import requests
 import platform
 import shutil
 
-from common.openpype_common.distribution.file_handler import RemoteFileHandler
+from .file_handler import RemoteFileHandler
 
 
 class UrlType(Enum):

From 3161d3d8debb64bdd3c5705d7d4ab0c0c0a70cdc Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 16 Sep 2022 19:13:31 +0200
Subject: [PATCH 103/147] use explicit float conversions for decimal
 calculations

---
 openpype/widgets/nice_checkbox.py | 48 ++++++++++++++++---------------
 1 file changed, 25 insertions(+), 23 deletions(-)

diff --git a/openpype/widgets/nice_checkbox.py b/openpype/widgets/nice_checkbox.py
index ccd079c0fb..56e6d2ac24 100644
--- a/openpype/widgets/nice_checkbox.py
+++ b/openpype/widgets/nice_checkbox.py
@@ -111,14 +111,14 @@ class NiceCheckbox(QtWidgets.QFrame):
         return QtCore.QSize(width, height)
 
     def get_width_hint_by_height(self, height):
-        return (
-            height / self._base_size.height()
-        ) * self._base_size.width()
+        return int((
+            float(height) / self._base_size.height()
+        ) * self._base_size.width())
 
     def get_height_hint_by_width(self, width):
-        return (
-            width / self._base_size.width()
-        ) * self._base_size.height()
+        return int((
+            float(width) / self._base_size.width()
+        ) * self._base_size.height())
 
     def setFixedHeight(self, *args, **kwargs):
         self._fixed_height_set = True
@@ -321,7 +321,7 @@ class NiceCheckbox(QtWidgets.QFrame):
             bg_color = self.unchecked_bg_color
 
         else:
-            offset_ratio = self._current_step / self._steps
+            offset_ratio = float(self._current_step) / self._steps
             # Animation bg
             bg_color = self.steped_color(
                 self.checked_bg_color,
@@ -332,7 +332,8 @@ class NiceCheckbox(QtWidgets.QFrame):
         margins_ratio = self._checker_margins_divider
         if margins_ratio > 0:
             size_without_margins = int(
-                (frame_rect.height() / margins_ratio) * (margins_ratio - 2)
+                (float(frame_rect.height()) / margins_ratio)
+                * (margins_ratio - 2)
             )
             size_without_margins -= size_without_margins % 2
             margin_size_c = ceil(
@@ -434,21 +435,21 @@ class NiceCheckbox(QtWidgets.QFrame):
     def _get_enabled_icon_path(
         self, painter, checker_rect, step=None, half_steps=None
     ):
-        fifteenth = checker_rect.height() / 15
+        fifteenth = float(checker_rect.height()) / 15
         # Left point
         p1 = QtCore.QPoint(
-            checker_rect.x() + (5 * fifteenth),
-            checker_rect.y() + (9 * fifteenth)
+            int(checker_rect.x() + (5 * fifteenth)),
+            int(checker_rect.y() + (9 * fifteenth))
         )
         # Middle bottom point
         p2 = QtCore.QPoint(
             checker_rect.center().x(),
-            checker_rect.y() + (11 * fifteenth)
+            int(checker_rect.y() + (11 * fifteenth))
         )
         # Top right point
         p3 = QtCore.QPoint(
-            checker_rect.x() + (10 * fifteenth),
-            checker_rect.y() + (5 * fifteenth)
+            int(checker_rect.x() + (10 * fifteenth)),
+            int(checker_rect.y() + (5 * fifteenth))
         )
         if step is not None:
             multiplier = (half_steps - step)
@@ -458,16 +459,16 @@ class NiceCheckbox(QtWidgets.QFrame):
             p3c = p3 - checker_rect.center()
 
             p1o = QtCore.QPoint(
-                (p1c.x() / half_steps) * multiplier,
-                (p1c.y() / half_steps) * multiplier
+                int((float(p1c.x()) / half_steps) * multiplier),
+                int((float(p1c.y()) / half_steps) * multiplier)
             )
             p2o = QtCore.QPoint(
-                (p2c.x() / half_steps) * multiplier,
-                (p2c.y() / half_steps) * multiplier
+                int((float(p2c.x()) / half_steps) * multiplier),
+                int((float(p2c.y()) / half_steps) * multiplier)
             )
             p3o = QtCore.QPoint(
-                (p3c.x() / half_steps) * multiplier,
-                (p3c.y() / half_steps) * multiplier
+                int((float(p3c.x()) / half_steps) * multiplier),
+                int((float(p3c.y()) / half_steps) * multiplier)
             )
 
             p1 -= p1o
@@ -484,11 +485,12 @@ class NiceCheckbox(QtWidgets.QFrame):
         self, painter, checker_rect, step=None, half_steps=None
     ):
         center_point = QtCore.QPointF(
-            checker_rect.width() / 2, checker_rect.height() / 2
+            float(checker_rect.width()) / 2,
+            float(checker_rect.height()) / 2
         )
-        offset = (
+        offset = float((
             (center_point + QtCore.QPointF(0, 0)) / 2
-        ).x() / 4 * 5
+        ).x()) / 4 * 5
         if step is not None:
             diff = center_point.x() - offset
             diff_offset = (diff / half_steps) * (half_steps - step)

From 8dc0f6f011c17c455f62269768fe0c728f76631b Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Mon, 19 Sep 2022 13:15:27 +0200
Subject: [PATCH 104/147] change return value of
 'rename_filepaths_by_frame_start' when frame start is same as mark in

---
 openpype/hosts/tvpaint/lib.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/tvpaint/lib.py b/openpype/hosts/tvpaint/lib.py
index c67ab1e4fb..bf47e725cb 100644
--- a/openpype/hosts/tvpaint/lib.py
+++ b/openpype/hosts/tvpaint/lib.py
@@ -648,7 +648,7 @@ def rename_filepaths_by_frame_start(
     """Change frames in filenames of finished images to new frame start."""
     # Skip if source first frame is same as destination first frame
     if range_start == new_frame_start:
-        return
+        return {}
 
     # Calculate frame end
     new_frame_end = range_end + (new_frame_start - range_start)

From 2dba044e48c5670fffe0562754dc108212d2e193 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Mon, 19 Sep 2022 13:49:01 +0200
Subject: [PATCH 105/147] OP-3943 - added publish field to Settings for PS
 CollectReview

Customer wants to configure if review should be published by default for Photoshop.
---
 .../defaults/project_settings/photoshop.json        |  3 +++
 .../projects_schema/schema_project_photoshop.json   | 13 +++++++++++++
 2 files changed, 16 insertions(+)

diff --git a/openpype/settings/defaults/project_settings/photoshop.json b/openpype/settings/defaults/project_settings/photoshop.json
index 552c2c9cad..3477d185a6 100644
--- a/openpype/settings/defaults/project_settings/photoshop.json
+++ b/openpype/settings/defaults/project_settings/photoshop.json
@@ -15,6 +15,9 @@
         "CollectInstances": {
             "flatten_subset_template": ""
         },
+        "CollectReview": {
+            "publish": true
+        },
         "ValidateContainers": {
             "enabled": true,
             "optional": true,
diff --git a/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json b/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
index 7aa49c99a4..7294ba8608 100644
--- a/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
+++ b/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
@@ -131,6 +131,19 @@
                         }
                     ]
                 },
+                {
+                    "type": "dict",
+                    "collapsible": true,
+                    "key": "CollectReview",
+                    "label": "Collect Review",
+                    "children": [
+                        {
+                            "type": "boolean",
+                            "key": "publish",
+                            "label": "Publish review"
+                        }
+                    ]
+                },
                 {
                     "type": "schema_template",
                     "name": "template_publish_plugin",

From 0d4549f7bf5af630eb1a6072471f0cd543e52ddb Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Mon, 19 Sep 2022 13:50:07 +0200
Subject: [PATCH 106/147] OP-3943 - added publish field to PS CollectReview

Customer wants to configure if review should be published by default for Photoshop.
Default could be set in Settings, artist might decide to override it for particular publish.
---
 openpype/hosts/photoshop/plugins/publish/collect_review.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/openpype/hosts/photoshop/plugins/publish/collect_review.py b/openpype/hosts/photoshop/plugins/publish/collect_review.py
index 7f395b46d7..7e598a8250 100644
--- a/openpype/hosts/photoshop/plugins/publish/collect_review.py
+++ b/openpype/hosts/photoshop/plugins/publish/collect_review.py
@@ -25,6 +25,8 @@ class CollectReview(pyblish.api.ContextPlugin):
     hosts = ["photoshop"]
     order = pyblish.api.CollectorOrder + 0.1
 
+    publish = True
+
     def process(self, context):
         family = "review"
         subset = get_subset_name(
@@ -45,5 +47,6 @@ class CollectReview(pyblish.api.ContextPlugin):
             "family": family,
             "families": [],
             "representations": [],
-            "asset": os.environ["AVALON_ASSET"]
+            "asset": os.environ["AVALON_ASSET"],
+            "publish": self.publish
         })

From cefe853cc6c932771ffd9f2325c783942fbff3da Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Tue, 20 Sep 2022 11:29:23 +0200
Subject: [PATCH 107/147] OP-3943 - changed label to Active

Active label matches configuration for optional plugins. Collector cannot be optional, but Active matches to "Instance is collected but won't get published by default."
---
 .../schemas/projects_schema/schema_project_photoshop.json       | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json b/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
index 7294ba8608..26b38fa2c6 100644
--- a/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
+++ b/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
@@ -140,7 +140,7 @@
                         {
                             "type": "boolean",
                             "key": "publish",
-                            "label": "Publish review"
+                            "label": "Active"
                         }
                     ]
                 },

From b0f7db52c84e40fa7fadfeb2fd180e2874fe950c Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Tue, 20 Sep 2022 17:09:58 +0200
Subject: [PATCH 108/147] make sure the output is always the same

---
 openpype/hosts/tvpaint/lib.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/openpype/hosts/tvpaint/lib.py b/openpype/hosts/tvpaint/lib.py
index bf47e725cb..95653b6ecb 100644
--- a/openpype/hosts/tvpaint/lib.py
+++ b/openpype/hosts/tvpaint/lib.py
@@ -646,9 +646,6 @@ def rename_filepaths_by_frame_start(
     filepaths_by_frame, range_start, range_end, new_frame_start
 ):
     """Change frames in filenames of finished images to new frame start."""
-    # Skip if source first frame is same as destination first frame
-    if range_start == new_frame_start:
-        return {}
 
     # Calculate frame end
     new_frame_end = range_end + (new_frame_start - range_start)
@@ -669,14 +666,17 @@ def rename_filepaths_by_frame_start(
         source_range = range(range_start, range_end + 1)
         output_range = range(new_frame_start, new_frame_end + 1)
 
+    # Skip if source first frame is same as destination first frame
     new_dst_filepaths = {}
     for src_frame, dst_frame in zip(source_range, output_range):
-        src_filepath = filepaths_by_frame[src_frame]
-        src_dirpath = os.path.dirname(src_filepath)
+        src_filepath = os.path.normpath(filepaths_by_frame[src_frame])
+        dirpath, src_filename = os.path.split(src_filepath)
         dst_filename = filename_template.format(frame=dst_frame)
-        dst_filepath = os.path.join(src_dirpath, dst_filename)
+        dst_filepath = os.path.join(dirpath, dst_filename)
 
-        os.rename(src_filepath, dst_filepath)
+        if src_filename != dst_filename:
+            os.rename(src_filepath, dst_filepath)
 
         new_dst_filepaths[dst_frame] = dst_filepath
+
     return new_dst_filepaths

From c693af79cf374efb04b9d113f747e02baaf95ed1 Mon Sep 17 00:00:00 2001
From: OpenPype <info@openpype.io>
Date: Wed, 21 Sep 2022 04:19:54 +0000
Subject: [PATCH 109/147] [Automated] Bump version

---
 CHANGELOG.md        | 26 +++++++++++---------------
 openpype/version.py |  2 +-
 2 files changed, 12 insertions(+), 16 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index af347cadfe..f868e6ed6e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,13 +1,18 @@
 # Changelog
 
-## [3.14.3-nightly.2](https://github.com/pypeclub/OpenPype/tree/HEAD)
+## [3.14.3-nightly.3](https://github.com/pypeclub/OpenPype/tree/HEAD)
 
 [Full Changelog](https://github.com/pypeclub/OpenPype/compare/3.14.2...HEAD)
 
 **🚀 Enhancements**
 
+- Maya: better logging in Maketx [\#3886](https://github.com/pypeclub/OpenPype/pull/3886)
+- TrayPublisher: added persisting of last selected project [\#3871](https://github.com/pypeclub/OpenPype/pull/3871)
+- TrayPublisher: added text filter on project name to Tray Publisher [\#3867](https://github.com/pypeclub/OpenPype/pull/3867)
 - Github issues adding `running version` section [\#3864](https://github.com/pypeclub/OpenPype/pull/3864)
 - Publisher: Increase size of main window [\#3862](https://github.com/pypeclub/OpenPype/pull/3862)
+- Photoshop: synchronize image version with workfile [\#3854](https://github.com/pypeclub/OpenPype/pull/3854)
+- General: Simple script for getting license information about used packages [\#3843](https://github.com/pypeclub/OpenPype/pull/3843)
 - Houdini: Increment current file on workfile publish [\#3840](https://github.com/pypeclub/OpenPype/pull/3840)
 - Publisher: Add new publisher to host tools [\#3833](https://github.com/pypeclub/OpenPype/pull/3833)
 - General: lock task workfiles when they are working on [\#3810](https://github.com/pypeclub/OpenPype/pull/3810)
@@ -28,11 +33,10 @@
 - Hiero: Use new Extractor location [\#3851](https://github.com/pypeclub/OpenPype/pull/3851)
 - Maya: Remove old legacy \(ftrack\) plug-ins that are of no use anymore [\#3819](https://github.com/pypeclub/OpenPype/pull/3819)
 - Nuke: Use new Extractor location [\#3799](https://github.com/pypeclub/OpenPype/pull/3799)
-- Maya: Use new Extractor location [\#3775](https://github.com/pypeclub/OpenPype/pull/3775)
-- General: Change publish template settings location [\#3755](https://github.com/pypeclub/OpenPype/pull/3755)
 
 **Merged pull requests:**
 
+- Maya: RenderSettings set default image format for V-Ray+Redshift to exr [\#3879](https://github.com/pypeclub/OpenPype/pull/3879)
 - Remove lockfile during publish [\#3874](https://github.com/pypeclub/OpenPype/pull/3874)
 
 ## [3.14.2](https://github.com/pypeclub/OpenPype/tree/3.14.2) (2022-09-12)
@@ -51,7 +55,6 @@
 - Photoshop: attempt to speed up ExtractImage [\#3793](https://github.com/pypeclub/OpenPype/pull/3793)
 - SyncServer: Added cli commands for sync server [\#3765](https://github.com/pypeclub/OpenPype/pull/3765)
 - Kitsu: Drop 'entities root' setting. [\#3739](https://github.com/pypeclub/OpenPype/pull/3739)
-- git: update gitignore [\#3722](https://github.com/pypeclub/OpenPype/pull/3722)
 
 **🐛 Bug fixes**
 
@@ -71,16 +74,18 @@
 - Photoshop: Use new Extractor location [\#3789](https://github.com/pypeclub/OpenPype/pull/3789)
 - Blender: Use new Extractor location [\#3787](https://github.com/pypeclub/OpenPype/pull/3787)
 - AfterEffects: Use new Extractor location [\#3784](https://github.com/pypeclub/OpenPype/pull/3784)
+- Maya: Use new Extractor location [\#3775](https://github.com/pypeclub/OpenPype/pull/3775)
 - General: Remove unused teshost [\#3773](https://github.com/pypeclub/OpenPype/pull/3773)
 - General: Copied 'Extractor' plugin to publish pipeline [\#3771](https://github.com/pypeclub/OpenPype/pull/3771)
 - General: Move queries of asset and representation links [\#3770](https://github.com/pypeclub/OpenPype/pull/3770)
 - General: Move create project folders to pipeline [\#3768](https://github.com/pypeclub/OpenPype/pull/3768)
 - General: Create project function moved to client code [\#3766](https://github.com/pypeclub/OpenPype/pull/3766)
 - Maya: Refactor submit deadline to use AbstractSubmitDeadline [\#3759](https://github.com/pypeclub/OpenPype/pull/3759)
+- General: Change publish template settings location [\#3755](https://github.com/pypeclub/OpenPype/pull/3755)
 - General: Move hostdirname functionality into host [\#3749](https://github.com/pypeclub/OpenPype/pull/3749)
-- General: Move publish utils to pipeline [\#3745](https://github.com/pypeclub/OpenPype/pull/3745)
 - Houdini: Define houdini as addon [\#3735](https://github.com/pypeclub/OpenPype/pull/3735)
 - Fusion: Defined fusion as addon [\#3733](https://github.com/pypeclub/OpenPype/pull/3733)
+- Flame: Defined flame as addon [\#3732](https://github.com/pypeclub/OpenPype/pull/3732)
 - Resolve: Define resolve as addon [\#3727](https://github.com/pypeclub/OpenPype/pull/3727)
 
 **Merged pull requests:**
@@ -95,7 +100,6 @@
 **🚀 Enhancements**
 
 - General: Thumbnail can use project roots [\#3750](https://github.com/pypeclub/OpenPype/pull/3750)
-- Settings: Remove settings lock on tray exit [\#3720](https://github.com/pypeclub/OpenPype/pull/3720)
 
 **🐛 Bug fixes**
 
@@ -103,29 +107,21 @@
 - General: Smaller fixes of imports [\#3748](https://github.com/pypeclub/OpenPype/pull/3748)
 - General: Logger tweaks [\#3741](https://github.com/pypeclub/OpenPype/pull/3741)
 - Nuke: missing job dependency if multiple bake streams [\#3737](https://github.com/pypeclub/OpenPype/pull/3737)
-- Nuke: color-space settings from anatomy is working [\#3721](https://github.com/pypeclub/OpenPype/pull/3721)
-- Settings: Fix studio default anatomy save [\#3716](https://github.com/pypeclub/OpenPype/pull/3716)
 
 **🔀 Refactored code**
 
 - General: Move delivery logic to pipeline [\#3751](https://github.com/pypeclub/OpenPype/pull/3751)
+- General: Move publish utils to pipeline [\#3745](https://github.com/pypeclub/OpenPype/pull/3745)
 - General: Host addons cleanup [\#3744](https://github.com/pypeclub/OpenPype/pull/3744)
 - Webpublisher: Webpublisher is used as addon [\#3740](https://github.com/pypeclub/OpenPype/pull/3740)
 - Photoshop: Defined photoshop as addon [\#3736](https://github.com/pypeclub/OpenPype/pull/3736)
 - Harmony: Defined harmony as addon [\#3734](https://github.com/pypeclub/OpenPype/pull/3734)
-- Flame: Defined flame as addon [\#3732](https://github.com/pypeclub/OpenPype/pull/3732)
 - General: Module interfaces cleanup [\#3731](https://github.com/pypeclub/OpenPype/pull/3731)
 - AfterEffects: Move AE functions from general lib [\#3730](https://github.com/pypeclub/OpenPype/pull/3730)
 - Blender: Define blender as module [\#3729](https://github.com/pypeclub/OpenPype/pull/3729)
 - AfterEffects: Define AfterEffects as module [\#3728](https://github.com/pypeclub/OpenPype/pull/3728)
 - General: Replace PypeLogger with Logger [\#3725](https://github.com/pypeclub/OpenPype/pull/3725)
 - Nuke: Define nuke as module [\#3724](https://github.com/pypeclub/OpenPype/pull/3724)
-- General: Move subset name functionality [\#3723](https://github.com/pypeclub/OpenPype/pull/3723)
-- General: Move creators plugin getter [\#3714](https://github.com/pypeclub/OpenPype/pull/3714)
-
-**Merged pull requests:**
-
-- Hiero: Define hiero as module [\#3717](https://github.com/pypeclub/OpenPype/pull/3717)
 
 ## [3.14.0](https://github.com/pypeclub/OpenPype/tree/3.14.0) (2022-08-18)
 
diff --git a/openpype/version.py b/openpype/version.py
index a2335b696b..26b145f1db 100644
--- a/openpype/version.py
+++ b/openpype/version.py
@@ -1,3 +1,3 @@
 # -*- coding: utf-8 -*-
 """Package declaring Pype version."""
-__version__ = "3.14.3-nightly.2"
+__version__ = "3.14.3-nightly.3"

From dc920e1a035d1140bf34491810ab79ffb12b5604 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Je=C5=BEek?= <jakubjezek001@gmail.com>
Date: Wed, 21 Sep 2022 13:15:18 +0200
Subject: [PATCH 110/147] Update openpype/hosts/flame/hooks/pre_flame_setup.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
---
 openpype/hosts/flame/hooks/pre_flame_setup.py | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/openpype/hosts/flame/hooks/pre_flame_setup.py b/openpype/hosts/flame/hooks/pre_flame_setup.py
index 9c2ad709c7..218fecfd2c 100644
--- a/openpype/hosts/flame/hooks/pre_flame_setup.py
+++ b/openpype/hosts/flame/hooks/pre_flame_setup.py
@@ -126,12 +126,14 @@ class FlamePrelaunch(PreLaunchHook):
         for dirtm in dirs_to_modify:
             for root, dirs, files in os.walk(dirtm):
                 try:
-                    for d in dirs:
-                        os.chmod(os.path.join(root, d), self.permisisons)
-                    for f in files:
-                        os.chmod(os.path.join(root, f), self.permisisons)
-                except OSError as _E:
-                    self.log.warning("Not able to open files: {}".format(_E))
+                    for name in set(dirs) | set(files):
+                        path = os.path.join(root, name)
+                        st = os.stat(path)
+                        if oct(st.st_mode) != self.permissions:
+                            os.chmod(path, self.permisisons)
+
+                except OSError as exc:
+                    self.log.warning("Not able to open files: {}".format(exc))
 
 
     def _get_flame_fps(self, fps_num):

From 1ec87dde38e844de4820f5aac44dd54f0b79a373 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Wed, 21 Sep 2022 13:28:08 +0200
Subject: [PATCH 111/147] typo

---
 openpype/hosts/flame/hooks/pre_flame_setup.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/flame/hooks/pre_flame_setup.py b/openpype/hosts/flame/hooks/pre_flame_setup.py
index 218fecfd2c..2dc11d94ae 100644
--- a/openpype/hosts/flame/hooks/pre_flame_setup.py
+++ b/openpype/hosts/flame/hooks/pre_flame_setup.py
@@ -129,7 +129,7 @@ class FlamePrelaunch(PreLaunchHook):
                     for name in set(dirs) | set(files):
                         path = os.path.join(root, name)
                         st = os.stat(path)
-                        if oct(st.st_mode) != self.permissions:
+                        if oct(st.st_mode) != self.permisisons:
                             os.chmod(path, self.permisisons)
 
                 except OSError as exc:

From f7033e716e2b078be8aff7b9cbc1dfc2d539589d Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Wed, 21 Sep 2022 13:29:32 +0200
Subject: [PATCH 112/147] typo

finally correct spelling
---
 openpype/hosts/flame/hooks/pre_flame_setup.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/openpype/hosts/flame/hooks/pre_flame_setup.py b/openpype/hosts/flame/hooks/pre_flame_setup.py
index 2dc11d94ae..0173eb8e3b 100644
--- a/openpype/hosts/flame/hooks/pre_flame_setup.py
+++ b/openpype/hosts/flame/hooks/pre_flame_setup.py
@@ -22,7 +22,7 @@ class FlamePrelaunch(PreLaunchHook):
     in environment var FLAME_SCRIPT_DIR.
     """
     app_groups = ["flame"]
-    permisisons = 0o777
+    permissions = 0o777
 
     wtc_script_path = os.path.join(
         opflame.HOST_DIR, "api", "scripts", "wiretap_com.py")
@@ -129,8 +129,8 @@ class FlamePrelaunch(PreLaunchHook):
                     for name in set(dirs) | set(files):
                         path = os.path.join(root, name)
                         st = os.stat(path)
-                        if oct(st.st_mode) != self.permisisons:
-                            os.chmod(path, self.permisisons)
+                        if oct(st.st_mode) != self.permissions:
+                            os.chmod(path, self.permissions)
 
                 except OSError as exc:
                     self.log.warning("Not able to open files: {}".format(exc))

From 73e05fba071d4e43ea8cd71e0682c0bd16f48b75 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Je=C5=BEek?= <jakubjezek001@gmail.com>
Date: Wed, 21 Sep 2022 14:10:56 +0200
Subject: [PATCH 113/147] Update
 openpype/hosts/flame/plugins/create/create_shot_clip.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
---
 openpype/hosts/flame/plugins/create/create_shot_clip.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/flame/plugins/create/create_shot_clip.py b/openpype/hosts/flame/plugins/create/create_shot_clip.py
index 835201cd3b..a16e8d394f 100644
--- a/openpype/hosts/flame/plugins/create/create_shot_clip.py
+++ b/openpype/hosts/flame/plugins/create/create_shot_clip.py
@@ -23,7 +23,7 @@ class CreateShotClip(opfapi.Creator):
                 # nested dictionary (only one level allowed
                 # for sections and dict)
                 for _k, _v in v["value"].items():
-                    if presets.get(_k, None) is not None:
+                    if presets.get(_k) is not None:
                         gui_inputs[k][
                             "value"][_k]["value"] = presets[_k]
 

From 764c844db8daa8465bbe4c8ff85006cec51039d1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jakub=20Je=C5=BEek?= <jakubjezek001@gmail.com>
Date: Wed, 21 Sep 2022 14:11:04 +0200
Subject: [PATCH 114/147] Update
 openpype/hosts/flame/plugins/create/create_shot_clip.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>
---
 openpype/hosts/flame/plugins/create/create_shot_clip.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/flame/plugins/create/create_shot_clip.py b/openpype/hosts/flame/plugins/create/create_shot_clip.py
index a16e8d394f..4fb041a4b2 100644
--- a/openpype/hosts/flame/plugins/create/create_shot_clip.py
+++ b/openpype/hosts/flame/plugins/create/create_shot_clip.py
@@ -27,7 +27,7 @@ class CreateShotClip(opfapi.Creator):
                         gui_inputs[k][
                             "value"][_k]["value"] = presets[_k]
 
-            if presets.get(k, None) is not None:
+            if presets.get(k) is not None:
                 gui_inputs[k]["value"] = presets[k]
 
         # open widget for plugins inputs

From a317c8f5fd3766eddf11cc414643eff5fc975def Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 21 Sep 2022 15:21:10 +0200
Subject: [PATCH 115/147] OP-3943 - fix broken Settins schema

---
 .../schemas/projects_schema/schema_project_photoshop.json        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json b/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
index 6668406336..b768db30ee 100644
--- a/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
+++ b/openpype/settings/entities/schemas/projects_schema/schema_project_photoshop.json
@@ -145,6 +145,7 @@
                      ]
                  },
                  {
+                    "type": "dict",
                     "key": "CollectVersion",
                     "label": "Collect Version",
                     "children": [

From 86a7eb91e15be069193755b1bd4392f6486ccafe Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Wed, 21 Sep 2022 15:23:27 +0200
Subject: [PATCH 116/147] Fix - updated missed import after refactor

Error would occur in Webpublisher.
---
 openpype/pype_commands.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/pype_commands.py b/openpype/pype_commands.py
index f65d969c53..d08a812c61 100644
--- a/openpype/pype_commands.py
+++ b/openpype/pype_commands.py
@@ -218,7 +218,7 @@ class PypeCommands:
             RuntimeError: When there is no path to process.
         """
 
-        from openpype.hosts.webpublisher.cli_functions import (
+        from openpype.hosts.webpublisher.publish_functions import (
             cli_publish
         )
 

From bae5a0799b1e220f1b6b6f7ab3deb8ba3a422331 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 10:37:06 +0200
Subject: [PATCH 117/147] fix import of RepairAction

---
 .../hosts/houdini/plugins/publish/collect_remote_publish.py   | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/houdini/plugins/publish/collect_remote_publish.py b/openpype/hosts/houdini/plugins/publish/collect_remote_publish.py
index c635a53074..d56d389be0 100644
--- a/openpype/hosts/houdini/plugins/publish/collect_remote_publish.py
+++ b/openpype/hosts/houdini/plugins/publish/collect_remote_publish.py
@@ -1,7 +1,7 @@
 import pyblish.api
-import openpype.api
 
 import hou
+from openpype.pipeline.publish import RepairAction
 from openpype.hosts.houdini.api import lib
 
 
@@ -13,7 +13,7 @@ class CollectRemotePublishSettings(pyblish.api.ContextPlugin):
     hosts = ["houdini"]
     targets = ["deadline"]
     label = "Remote Publish Submission Settings"
-    actions = [openpype.api.RepairAction]
+    actions = [RepairAction]
 
     def process(self, context):
 

From c35dde88ee2ce3e5522010fd44838722d7bbd2c8 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 10:49:01 +0200
Subject: [PATCH 118/147] kix kwarg in hiero representations query

---
 openpype/hosts/hiero/api/lib.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/hiero/api/lib.py b/openpype/hosts/hiero/api/lib.py
index e288cea2b1..7c27f2ebdc 100644
--- a/openpype/hosts/hiero/api/lib.py
+++ b/openpype/hosts/hiero/api/lib.py
@@ -1089,7 +1089,7 @@ def check_inventory_versions(track_items=None):
     # Find representations based on found containers
     repre_docs = get_representations(
         project_name,
-        repre_ids=repre_ids,
+        representation_ids=repre_ids,
         fields=["_id", "parent"]
     )
     # Store representations by id and collect version ids

From d1f77b7383029a3269583803258adb946d44a8a2 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 22 Sep 2022 10:57:32 +0200
Subject: [PATCH 119/147] multichannel openclip create

---
 openpype/hosts/flame/api/plugin.py | 20 +++++++++++---------
 1 file changed, 11 insertions(+), 9 deletions(-)

diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index 145b1f0921..a76e5ccc84 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -751,17 +751,18 @@ class OpenClipSolver(flib.MediaInfoFile):
         self.log.info("Building new openClip")
         self.log.debug(">> self.clip_data: {}".format(self.clip_data))
 
-        # clip data comming from MediaInfoFile
-        tmp_xml_feeds = self.clip_data.find('tracks/track/feeds')
-        tmp_xml_feeds.set('currentVersion', self.feed_version_name)
-        for tmp_feed in tmp_xml_feeds:
-            tmp_feed.set('vuid', self.feed_version_name)
+        for tmp_xml_track in self.clip_data.iter("track"):
+            tmp_xml_feeds = tmp_xml_track.find('feeds')
+            tmp_xml_feeds.set('currentVersion', self.feed_version_name)
 
-            # add colorspace if any is set
-            if self.feed_colorspace:
-                self._add_colorspace(tmp_feed, self.feed_colorspace)
+            for tmp_feed in tmp_xml_track.iter("feed"):
+                tmp_feed.set('vuid', self.feed_version_name)
 
-            self._clear_handler(tmp_feed)
+                # add colorspace if any is set
+                if self.feed_colorspace:
+                    self._add_colorspace(tmp_feed, self.feed_colorspace)
+
+                self._clear_handler(tmp_feed)
 
         tmp_xml_versions_obj = self.clip_data.find('versions')
         tmp_xml_versions_obj.set('currentVersion', self.feed_version_name)
@@ -812,6 +813,7 @@ class OpenClipSolver(flib.MediaInfoFile):
 
         feed_added = False
         if not self._feed_exists(out_xml, new_path):
+
             tmp_xml_feed.set('vuid', self.feed_version_name)
             # Append new temp file feed to .clip source out xml
             out_track = out_xml.find("tracks/track")

From 2502cb8f59fe4ed4a1e3a9c7a9a05db6d141035b Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 11:08:15 +0200
Subject: [PATCH 120/147] added 'lifetime_data' to instance object

---
 openpype/pipeline/create/context.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/openpype/pipeline/create/context.py b/openpype/pipeline/create/context.py
index eaaed39357..070e0fb2c2 100644
--- a/openpype/pipeline/create/context.py
+++ b/openpype/pipeline/create/context.py
@@ -404,6 +404,9 @@ class CreatedInstance:
         # Instance members may have actions on them
         self._members = []
 
+        # Data that can be used for lifetime of object
+        self._lifetime_data = {}
+
         # Create a copy of passed data to avoid changing them on the fly
         data = copy.deepcopy(data or {})
         # Store original value of passed data
@@ -596,6 +599,26 @@ class CreatedInstance:
 
         return self
 
+    @property
+    def lifetime_data(self):
+        """Data stored for lifetime of instance object.
+
+        These data are not stored to scene and will be lost on object
+        deletion.
+
+        Can be used to store objects. In some host implementations is not
+        possible to reference to object in scene with some unique identifier
+        (e.g. node in Fusion.). In that case it is handy to store the object
+        here. Should be used that way only if instance data are stored on the
+        node itself.
+
+        Returns:
+            Dict[str, Any]: Dictionary object where you can store data related
+                to instance for lifetime of instance object.
+        """
+
+        return self._lifetime_data
+
     def changes(self):
         """Calculate and return changes."""
 

From 5b26d07624b1369a280a99c8211ad5d5dddbf2bd Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 11:17:23 +0200
Subject: [PATCH 121/147] added 'apply_settings' method to creators so they
 don't have to override '__init__'

---
 openpype/pipeline/create/creator_plugins.py | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/openpype/pipeline/create/creator_plugins.py b/openpype/pipeline/create/creator_plugins.py
index bf2fdd2c5f..5b0532c60a 100644
--- a/openpype/pipeline/create/creator_plugins.py
+++ b/openpype/pipeline/create/creator_plugins.py
@@ -81,6 +81,13 @@ class BaseCreator:
         # - we may use UI inside processing this attribute should be checked
         self.headless = headless
 
+        self.apply_settings(project_settings, system_settings)
+
+    def apply_settings(self, project_settings, system_settings):
+        """Method called on initialization of plugin to apply settings."""
+
+        pass
+
     @property
     def identifier(self):
         """Identifier of creator (must be unique).

From 316a8efeb1f85908b6f07c61dfc7f830898f9bba Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 11:17:28 +0200
Subject: [PATCH 122/147] changed imports

---
 openpype/pipeline/create/context.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/openpype/pipeline/create/context.py b/openpype/pipeline/create/context.py
index 070e0fb2c2..9b7b6f8903 100644
--- a/openpype/pipeline/create/context.py
+++ b/openpype/pipeline/create/context.py
@@ -7,6 +7,10 @@ from uuid import uuid4
 from contextlib import contextmanager
 
 from openpype.client import get_assets
+from openpype.settings import (
+    get_system_settings,
+    get_project_settings
+)
 from openpype.host import INewPublisher
 from openpype.pipeline import legacy_io
 from openpype.pipeline.mongodb import (
@@ -20,11 +24,6 @@ from .creator_plugins import (
     discover_creator_plugins,
 )
 
-from openpype.api import (
-    get_system_settings,
-    get_project_settings
-)
-
 UpdateData = collections.namedtuple("UpdateData", ["instance", "changes"])
 
 
@@ -402,6 +401,7 @@ class CreatedInstance:
         self.creator = creator
 
         # Instance members may have actions on them
+        # TODO implement members logic
         self._members = []
 
         # Data that can be used for lifetime of object

From 09d7617c7344add9c9035cf4fd39615fcb9fbec0 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 11:19:33 +0200
Subject: [PATCH 123/147] renamed 'INewPublisher' to 'IPublishHost'

---
 openpype/host/__init__.py                    |  2 ++
 openpype/host/interfaces.py                  | 10 +++++++---
 openpype/hosts/traypublisher/api/pipeline.py |  4 ++--
 openpype/pipeline/create/context.py          |  4 ++--
 4 files changed, 13 insertions(+), 7 deletions(-)

diff --git a/openpype/host/__init__.py b/openpype/host/__init__.py
index 519888fce3..da1237c739 100644
--- a/openpype/host/__init__.py
+++ b/openpype/host/__init__.py
@@ -5,6 +5,7 @@ from .host import (
 from .interfaces import (
     IWorkfileHost,
     ILoadHost,
+    IPublishHost,
     INewPublisher,
 )
 
@@ -16,6 +17,7 @@ __all__ = (
 
     "IWorkfileHost",
     "ILoadHost",
+    "IPublishHost",
     "INewPublisher",
 
     "HostDirmap",
diff --git a/openpype/host/interfaces.py b/openpype/host/interfaces.py
index cbf12b0d13..e9008262c8 100644
--- a/openpype/host/interfaces.py
+++ b/openpype/host/interfaces.py
@@ -282,7 +282,7 @@ class IWorkfileHost:
         return self.workfile_has_unsaved_changes()
 
 
-class INewPublisher:
+class IPublishHost:
     """Functions related to new creation system in new publisher.
 
     New publisher is not storing information only about each created instance
@@ -306,7 +306,7 @@ class INewPublisher:
                 workflow.
         """
 
-        if isinstance(host, INewPublisher):
+        if isinstance(host, IPublishHost):
             return []
 
         required = [
@@ -330,7 +330,7 @@ class INewPublisher:
             MissingMethodsError: If there are missing methods on host
                 implementation.
         """
-        missing = INewPublisher.get_missing_publish_methods(host)
+        missing = IPublishHost.get_missing_publish_methods(host)
         if missing:
             raise MissingMethodsError(host, missing)
 
@@ -368,3 +368,7 @@ class INewPublisher:
         """
 
         pass
+
+
+class INewPublisher(IPublishHost):
+    pass
diff --git a/openpype/hosts/traypublisher/api/pipeline.py b/openpype/hosts/traypublisher/api/pipeline.py
index 2d9db7801e..0a8ddaa343 100644
--- a/openpype/hosts/traypublisher/api/pipeline.py
+++ b/openpype/hosts/traypublisher/api/pipeline.py
@@ -9,7 +9,7 @@ from openpype.pipeline import (
     register_creator_plugin_path,
     legacy_io,
 )
-from openpype.host import HostBase, INewPublisher
+from openpype.host import HostBase, IPublishHost
 
 
 ROOT_DIR = os.path.dirname(os.path.dirname(
@@ -19,7 +19,7 @@ PUBLISH_PATH = os.path.join(ROOT_DIR, "plugins", "publish")
 CREATE_PATH = os.path.join(ROOT_DIR, "plugins", "create")
 
 
-class TrayPublisherHost(HostBase, INewPublisher):
+class TrayPublisherHost(HostBase, IPublishHost):
     name = "traypublisher"
 
     def install(self):
diff --git a/openpype/pipeline/create/context.py b/openpype/pipeline/create/context.py
index 9b7b6f8903..a1b11d08c5 100644
--- a/openpype/pipeline/create/context.py
+++ b/openpype/pipeline/create/context.py
@@ -11,7 +11,7 @@ from openpype.settings import (
     get_system_settings,
     get_project_settings
 )
-from openpype.host import INewPublisher
+from openpype.host import IPublishHost
 from openpype.pipeline import legacy_io
 from openpype.pipeline.mongodb import (
     AvalonMongoDB,
@@ -794,7 +794,7 @@ class CreateContext:
         """
 
         missing = set(
-            INewPublisher.get_missing_publish_methods(host)
+            IPublishHost.get_missing_publish_methods(host)
         )
         return missing
 

From 6ca895906d1eafff6f8157f8f18aa42294086e6b Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 11:26:33 +0200
Subject: [PATCH 124/147] added docstring to 'INewPublisher'

---
 openpype/host/interfaces.py | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/openpype/host/interfaces.py b/openpype/host/interfaces.py
index e9008262c8..cfd089a0ad 100644
--- a/openpype/host/interfaces.py
+++ b/openpype/host/interfaces.py
@@ -371,4 +371,14 @@ class IPublishHost:
 
 
 class INewPublisher(IPublishHost):
+    """Legacy interface replaced by 'IPublishHost'.
+
+    Deprecated:
+        'INewPublisher' is replaced by 'IPublishHost' please change your
+        imports.
+        There is no "reasonable" way hot mark these classes as deprecated
+        to show warning of wrong import. Deprecated since 3.14.* will be
+        removed in 3.15.*
+    """
+
     pass

From c4127208d24d58b048773f16465d6ad208f3a35e Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Thu, 22 Sep 2022 11:29:01 +0200
Subject: [PATCH 125/147] Fix typo in ContainersFilterResult namedtuple
 `not_foud` -> `not_found`

---
 openpype/pipeline/load/utils.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/pipeline/load/utils.py b/openpype/pipeline/load/utils.py
index 83b904e4a7..363120600c 100644
--- a/openpype/pipeline/load/utils.py
+++ b/openpype/pipeline/load/utils.py
@@ -37,7 +37,7 @@ log = logging.getLogger(__name__)
 
 ContainersFilterResult = collections.namedtuple(
     "ContainersFilterResult",
-    ["latest", "outdated", "not_foud", "invalid"]
+    ["latest", "outdated", "not_found", "invalid"]
 )
 
 
@@ -808,7 +808,7 @@ def filter_containers(containers, project_name):
 
     Categories are 'latest', 'outdated', 'invalid' and 'not_found'.
     The 'lastest' containers are from last version, 'outdated' are not,
-    'invalid' are invalid containers (invalid content) and 'not_foud' has
+    'invalid' are invalid containers (invalid content) and 'not_found' has
     some missing entity in database.
 
     Args:

From 46c2a354f65569b9a7944d8120b41cb3e7536f4f Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 11:29:12 +0200
Subject: [PATCH 126/147] publish instance has access to lifetime data

---
 openpype/plugins/publish/collect_from_create_context.py | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/openpype/plugins/publish/collect_from_create_context.py b/openpype/plugins/publish/collect_from_create_context.py
index 9236c698ed..b5e3225c34 100644
--- a/openpype/plugins/publish/collect_from_create_context.py
+++ b/openpype/plugins/publish/collect_from_create_context.py
@@ -25,7 +25,9 @@ class CollectFromCreateContext(pyblish.api.ContextPlugin):
         for created_instance in create_context.instances:
             instance_data = created_instance.data_to_store()
             if instance_data["active"]:
-                self.create_instance(context, instance_data)
+                self.create_instance(
+                    context, instance_data, created_instance.lifetime_data
+                )
 
         # Update global data to context
         context.data.update(create_context.context_data_to_store())
@@ -37,7 +39,7 @@ class CollectFromCreateContext(pyblish.api.ContextPlugin):
                 legacy_io.Session[key] = value
                 os.environ[key] = value
 
-    def create_instance(self, context, in_data):
+    def create_instance(self, context, in_data, lifetime_data):
         subset = in_data["subset"]
         # If instance data already contain families then use it
         instance_families = in_data.get("families") or []
@@ -56,5 +58,8 @@ class CollectFromCreateContext(pyblish.api.ContextPlugin):
         for key, value in in_data.items():
             if key not in instance.data:
                 instance.data[key] = value
+
+        instance.data["lifetimeData"] = lifetime_data
+
         self.log.info("collected instance: {}".format(instance.data))
         self.log.info("parsing data: {}".format(in_data))

From 806865e7d7d45639cb5c7948a697490b21680d0a Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Thu, 22 Sep 2022 11:42:15 +0200
Subject: [PATCH 127/147] refactor 'check_inventory_versions' to use
 'filter_containers' from load utils

---
 openpype/hosts/hiero/api/lib.py | 71 ++++++++-------------------------
 1 file changed, 16 insertions(+), 55 deletions(-)

diff --git a/openpype/hosts/hiero/api/lib.py b/openpype/hosts/hiero/api/lib.py
index 7c27f2ebdc..895e95e0c0 100644
--- a/openpype/hosts/hiero/api/lib.py
+++ b/openpype/hosts/hiero/api/lib.py
@@ -13,14 +13,10 @@ import hiero
 
 from Qt import QtWidgets
 
-from openpype.client import (
-    get_project,
-    get_versions,
-    get_last_versions,
-    get_representations,
-)
+from openpype.client import get_project
 from openpype.settings import get_anatomy_settings
 from openpype.pipeline import legacy_io, Anatomy
+from openpype.pipeline.load import filter_containers
 from openpype.lib import Logger
 from . import tags
 
@@ -1055,6 +1051,10 @@ def sync_clip_name_to_data_asset(track_items_list):
             print("asset was changed in clip: {}".format(ti_name))
 
 
+def set_track_color(track_item, color):
+    track_item.source().binItem().setColor(color)
+
+
 def check_inventory_versions(track_items=None):
     """
     Actual version color idetifier of Loaded containers
@@ -1066,68 +1066,29 @@ def check_inventory_versions(track_items=None):
     """
     from . import parse_container
 
-    track_item = track_items or get_track_items()
+    track_items = track_items or get_track_items()
     # presets
     clip_color_last = "green"
     clip_color = "red"
 
-    item_with_repre_id = []
-    repre_ids = set()
+    containers = []
     # Find all containers and collect it's node and representation ids
-    for track_item in track_item:
+    for track_item in track_items:
         container = parse_container(track_item)
         if container:
-            repre_id = container["representation"]
-            repre_ids.add(repre_id)
-            item_with_repre_id.append((track_item, repre_id))
+            containers.append(container)
 
     # Skip if nothing was found
-    if not repre_ids:
+    if not containers:
         return
 
     project_name = legacy_io.active_project()
-    # Find representations based on found containers
-    repre_docs = get_representations(
-        project_name,
-        representation_ids=repre_ids,
-        fields=["_id", "parent"]
-    )
-    # Store representations by id and collect version ids
-    repre_docs_by_id = {}
-    version_ids = set()
-    for repre_doc in repre_docs:
-        # Use stringed representation id to match value in containers
-        repre_id = str(repre_doc["_id"])
-        repre_docs_by_id[repre_id] = repre_doc
-        version_ids.add(repre_doc["parent"])
+    filter_result = filter_containers(containers, project_name)
+    for container in filter_result.latest:
+        set_track_color(container["_track_item"], clip_color)
 
-    version_docs = get_versions(
-        project_name, version_ids, fields=["_id", "name", "parent"]
-    )
-    # Store versions by id and collect subset ids
-    version_docs_by_id = {}
-    subset_ids = set()
-    for version_doc in version_docs:
-        version_docs_by_id[version_doc["_id"]] = version_doc
-        subset_ids.add(version_doc["parent"])
-
-    # Query last versions based on subset ids
-    last_versions_by_subset_id = get_last_versions(
-        project_name, subset_ids=subset_ids, fields=["_id", "parent"]
-    )
-
-    for item in item_with_repre_id:
-        # Some python versions of nuke can't unfold tuple in for loop
-        track_item, repre_id = item
-
-        repre_doc = repre_docs_by_id[repre_id]
-        version_doc = version_docs_by_id[repre_doc["parent"]]
-        last_version_doc = last_versions_by_subset_id[version_doc["parent"]]
-        # Check if last version is same as current version
-        if version_doc["_id"] == last_version_doc["_id"]:
-            track_item.source().binItem().setColor(clip_color_last)
-        else:
-            track_item.source().binItem().setColor(clip_color)
+    for container in filter_result.outdated:
+        set_track_color(container["_track_item"], clip_color_last)
 
 
 def selection_changed_timeline(event):

From fb121844300e904038d33ad4b34989a6244b6a6c Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 22 Sep 2022 12:17:40 +0200
Subject: [PATCH 128/147] updating multichannel openclip

---
 openpype/hosts/flame/api/plugin.py | 105 +++++++++++++++++++----------
 1 file changed, 68 insertions(+), 37 deletions(-)

diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index a76e5ccc84..9f09fa13ce 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -775,6 +775,15 @@ class OpenClipSolver(flib.MediaInfoFile):
 
         self.write_clip_data_to_file(self.out_file, self.clip_data)
 
+    def _get_xml_track_obj_by_uid(self, xml_data, uid):
+        # loop all tracks of input xml data
+        for xml_track in xml_data.iter("track"):
+            track_uid = xml_track.get("uid")
+
+            # get matching uids
+            if uid == track_uid:
+                return xml_track
+
     def _update_open_clip(self):
         self.log.info("Updating openClip ..")
 
@@ -784,53 +793,75 @@ class OpenClipSolver(flib.MediaInfoFile):
         self.log.debug(">> out_xml: {}".format(out_xml))
         self.log.debug(">> self.clip_data: {}".format(self.clip_data))
 
-        # Get new feed from tmp file
-        tmp_xml_feed = self.clip_data.find('tracks/track/feeds/feed')
+        # loop tmp tracks
+        updated_any = []
+        for tmp_xml_track in self.clip_data.iter("track"):
+            # get tmp track uid
+            tmp_track_uid = tmp_xml_track.get("uid")
+            # get out data track by uid
+            out_track_element = self._get_xml_track_obj_by_uid(
+                out_xml, tmp_track_uid)
 
-        self._clear_handler(tmp_xml_feed)
+            # loop tmp feeds
+            for tmp_xml_feed in tmp_xml_track.iter("feed"):
+                new_path_obj = tmp_xml_feed.find(
+                    "spans/span/path")
+                new_path = new_path_obj.text
 
-        # update fps from MediaInfoFile class
-        if self.fps:
-            tmp_feed_fps_obj = tmp_xml_feed.find(
-                "startTimecode/rate")
-            tmp_feed_fps_obj.text = str(self.fps)
+                # check if feed path already exists in track's feeds
+                if (
+                    out_track_element
+                    and not self._feed_exists(out_track_element, new_path)
+                ):
+                    continue
 
-        # update start_frame from MediaInfoFile class
-        if self.start_frame:
-            tmp_feed_nb_ticks_obj = tmp_xml_feed.find(
-                "startTimecode/nbTicks")
-            tmp_feed_nb_ticks_obj.text = str(self.start_frame)
+                # rename versions on feeds
+                tmp_xml_feed.set('vuid', self.feed_version_name)
+                self._clear_handler(tmp_xml_feed)
 
-        # update drop_mode from MediaInfoFile class
-        if self.drop_mode:
-            tmp_feed_drop_mode_obj = tmp_xml_feed.find(
-                "startTimecode/dropMode")
-            tmp_feed_drop_mode_obj.text = str(self.drop_mode)
+                # update fps from MediaInfoFile class
+                if self.fps:
+                    tmp_feed_fps_obj = tmp_xml_feed.find(
+                        "startTimecode/rate")
+                    tmp_feed_fps_obj.text = str(self.fps)
 
-        new_path_obj = tmp_xml_feed.find(
-            "spans/span/path")
-        new_path = new_path_obj.text
+                # update start_frame from MediaInfoFile class
+                if self.start_frame:
+                    tmp_feed_nb_ticks_obj = tmp_xml_feed.find(
+                        "startTimecode/nbTicks")
+                    tmp_feed_nb_ticks_obj.text = str(self.start_frame)
 
-        feed_added = False
-        if not self._feed_exists(out_xml, new_path):
+                # update drop_mode from MediaInfoFile class
+                if self.drop_mode:
+                    tmp_feed_drop_mode_obj = tmp_xml_feed.find(
+                        "startTimecode/dropMode")
+                    tmp_feed_drop_mode_obj.text = str(self.drop_mode)
 
-            tmp_xml_feed.set('vuid', self.feed_version_name)
-            # Append new temp file feed to .clip source out xml
-            out_track = out_xml.find("tracks/track")
-            # add colorspace if any is set
-            if self.feed_colorspace:
-                self._add_colorspace(tmp_xml_feed, self.feed_colorspace)
+                # add colorspace if any is set
+                if self.feed_colorspace:
+                    self._add_colorspace(tmp_xml_feed, self.feed_colorspace)
 
-            out_feeds = out_track.find('feeds')
-            out_feeds.set('currentVersion', self.feed_version_name)
-            out_feeds.append(tmp_xml_feed)
+                # then append/update feed to correct track in output
+                if out_track_element:
+                    # update already present track
+                    out_feeds = out_track_element.find('feeds')
+                    out_feeds.set('currentVersion', self.feed_version_name)
+                    out_feeds.append(tmp_xml_feed)
 
-            self.log.info(
-                "Appending new feed: {}".format(
-                    self.feed_version_name))
-            feed_added = True
+                    self.log.info(
+                        "Appending new feed: {}".format(
+                            self.feed_version_name))
+                else:
+                    # create new track as it doesnt exists yet
+                    # set current version to feeds on tmp
+                    tmp_xml_feeds = tmp_xml_track.find('feeds')
+                    tmp_xml_feeds.set('currentVersion', self.feed_version_name)
+                    out_tracks = out_xml.find("tracks")
+                    out_tracks.append(tmp_xml_track)
 
-        if feed_added:
+                updated_any.append(True)
+
+        if any(updated_any):
             # Append vUID to versions
             out_xml_versions_obj = out_xml.find('versions')
             out_xml_versions_obj.set(

From fa3409d30258ba9dcbaec48cec0995e494560778 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 22 Sep 2022 12:37:49 +0200
Subject: [PATCH 129/147] fix logging in plugin

---
 openpype/hosts/flame/api/lib.py                      | 6 +++---
 openpype/hosts/flame/api/plugin.py                   | 8 ++++++--
 openpype/hosts/flame/plugins/load/load_clip.py       | 6 +++---
 openpype/hosts/flame/plugins/load/load_clip_batch.py | 5 ++---
 4 files changed, 14 insertions(+), 11 deletions(-)

diff --git a/openpype/hosts/flame/api/lib.py b/openpype/hosts/flame/api/lib.py
index 94c46fe937..b7f7b24e51 100644
--- a/openpype/hosts/flame/api/lib.py
+++ b/openpype/hosts/flame/api/lib.py
@@ -766,11 +766,11 @@ class MediaInfoFile(object):
     _drop_mode = None
     _file_pattern = None
 
-    def __init__(self, path, **kwargs):
+    def __init__(self, path, logger=None):
 
         # replace log if any
-        if kwargs.get("logger"):
-            self.log = kwargs["logger"]
+        if logger:
+            self.log = logger
 
         # test if `dl_get_media_info` paht exists
         self._validate_media_script_path()
diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index 9f09fa13ce..205acf51b0 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -694,16 +694,20 @@ class OpenClipSolver(flib.MediaInfoFile):
 
     log = log
 
-    def __init__(self, openclip_file_path, feed_data):
+    def __init__(self, openclip_file_path, feed_data, logger=None):
         self.out_file = openclip_file_path
 
+        # replace log if any
+        if logger:
+            self.log = logger
+
         # new feed variables:
         feed_path = feed_data.pop("path")
 
         # initialize parent class
         super(OpenClipSolver, self).__init__(
             feed_path,
-            **feed_data
+            logger=logger
         )
 
         # get other metadata
diff --git a/openpype/hosts/flame/plugins/load/load_clip.py b/openpype/hosts/flame/plugins/load/load_clip.py
index b12f2f9690..0843dde76a 100644
--- a/openpype/hosts/flame/plugins/load/load_clip.py
+++ b/openpype/hosts/flame/plugins/load/load_clip.py
@@ -4,6 +4,7 @@ from pprint import pformat
 import openpype.hosts.flame.api as opfapi
 from openpype.lib import StringTemplate
 
+
 class LoadClip(opfapi.ClipLoader):
     """Load a subset to timeline as clip
 
@@ -60,8 +61,6 @@ class LoadClip(opfapi.ClipLoader):
             "path": self.fname.replace("\\", "/"),
             "colorspace": colorspace,
             "version": "v{:0>3}".format(version_name),
-            "logger": self.log
-
         }
         self.log.debug(pformat(
             loading_context
@@ -69,7 +68,8 @@ class LoadClip(opfapi.ClipLoader):
         self.log.debug(openclip_path)
 
         # make openpype clip file
-        opfapi.OpenClipSolver(openclip_path, loading_context).make()
+        opfapi.OpenClipSolver(
+            openclip_path, loading_context, logger=self.log).make()
 
         # prepare Reel group in actual desktop
         opc = self._get_clip(
diff --git a/openpype/hosts/flame/plugins/load/load_clip_batch.py b/openpype/hosts/flame/plugins/load/load_clip_batch.py
index fb4a3dc6e9..3b049b861b 100644
--- a/openpype/hosts/flame/plugins/load/load_clip_batch.py
+++ b/openpype/hosts/flame/plugins/load/load_clip_batch.py
@@ -64,8 +64,6 @@ class LoadClipBatch(opfapi.ClipLoader):
             "path": self.fname.replace("\\", "/"),
             "colorspace": colorspace,
             "version": "v{:0>3}".format(version_name),
-            "logger": self.log
-
         }
         self.log.debug(pformat(
             loading_context
@@ -73,7 +71,8 @@ class LoadClipBatch(opfapi.ClipLoader):
         self.log.debug(openclip_path)
 
         # make openpype clip file
-        opfapi.OpenClipSolver(openclip_path, loading_context).make()
+        opfapi.OpenClipSolver(
+            openclip_path, loading_context, logger=self.log).make()
 
         # prepare Reel group in actual desktop
         opc = self._get_clip(

From 3ac038760645bb76c5c60c473b7aa4dc6880e292 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 22 Sep 2022 12:45:46 +0200
Subject: [PATCH 130/147] fix future warning

add logging from lib
---
 openpype/hosts/flame/api/plugin.py                   | 2 +-
 openpype/hosts/flame/plugins/load/load_clip_batch.py | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index 205acf51b0..59c8dab631 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -814,7 +814,7 @@ class OpenClipSolver(flib.MediaInfoFile):
 
                 # check if feed path already exists in track's feeds
                 if (
-                    out_track_element
+                    out_track_element is not None
                     and not self._feed_exists(out_track_element, new_path)
                 ):
                     continue
diff --git a/openpype/hosts/flame/plugins/load/load_clip_batch.py b/openpype/hosts/flame/plugins/load/load_clip_batch.py
index 3b049b861b..c17e060f5b 100644
--- a/openpype/hosts/flame/plugins/load/load_clip_batch.py
+++ b/openpype/hosts/flame/plugins/load/load_clip_batch.py
@@ -2,7 +2,7 @@ import os
 import flame
 from pprint import pformat
 import openpype.hosts.flame.api as opfapi
-from openpype.lib import StringTemplate
+from openpype.lib import StringTemplate, Logger
 
 
 class LoadClipBatch(opfapi.ClipLoader):
@@ -24,6 +24,8 @@ class LoadClipBatch(opfapi.ClipLoader):
     reel_name = "OP_LoadedReel"
     clip_name_template = "{asset}_{subset}<_{output}>"
 
+    log = Logger.get_logger(__file__)
+
     def load(self, context, name, namespace, options):
 
         # get flame objects

From 7e35fdcdedf583c8a58ff9cbb93c9067189149dd Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 22 Sep 2022 12:52:08 +0200
Subject: [PATCH 131/147] abstracting logger

---
 openpype/hosts/flame/api/plugin.py                   | 1 +
 openpype/hosts/flame/plugins/load/load_clip_batch.py | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index 59c8dab631..a3f2f5f2fc 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -678,6 +678,7 @@ class ClipLoader(LoaderPlugin):
     `update` logic.
 
     """
+    log = log
 
     options = [
         qargparse.Boolean(
diff --git a/openpype/hosts/flame/plugins/load/load_clip_batch.py b/openpype/hosts/flame/plugins/load/load_clip_batch.py
index c17e060f5b..3b049b861b 100644
--- a/openpype/hosts/flame/plugins/load/load_clip_batch.py
+++ b/openpype/hosts/flame/plugins/load/load_clip_batch.py
@@ -2,7 +2,7 @@ import os
 import flame
 from pprint import pformat
 import openpype.hosts.flame.api as opfapi
-from openpype.lib import StringTemplate, Logger
+from openpype.lib import StringTemplate
 
 
 class LoadClipBatch(opfapi.ClipLoader):
@@ -24,8 +24,6 @@ class LoadClipBatch(opfapi.ClipLoader):
     reel_name = "OP_LoadedReel"
     clip_name_template = "{asset}_{subset}<_{output}>"
 
-    log = Logger.get_logger(__file__)
-
     def load(self, context, name, namespace, options):
 
         # get flame objects

From 7063d21450607bf07bd430af06fef517044338a3 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 22 Sep 2022 12:58:20 +0200
Subject: [PATCH 132/147] adding logging

---
 openpype/hosts/flame/api/plugin.py | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index a3f2f5f2fc..044e86b17f 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -784,6 +784,8 @@ class OpenClipSolver(flib.MediaInfoFile):
         # loop all tracks of input xml data
         for xml_track in xml_data.iter("track"):
             track_uid = xml_track.get("uid")
+            self.log.debug(
+                ">> track_uid:uid: {}:{}".format(track_uid, uid))
 
             # get matching uids
             if uid == track_uid:
@@ -803,9 +805,13 @@ class OpenClipSolver(flib.MediaInfoFile):
         for tmp_xml_track in self.clip_data.iter("track"):
             # get tmp track uid
             tmp_track_uid = tmp_xml_track.get("uid")
+            self.log.debug(">> tmp_track_uid: {}".format(tmp_track_uid))
+
             # get out data track by uid
             out_track_element = self._get_xml_track_obj_by_uid(
                 out_xml, tmp_track_uid)
+            self.log.debug(
+                ">> out_track_element: {}".format(out_track_element))
 
             # loop tmp feeds
             for tmp_xml_feed in tmp_xml_track.iter("feed"):
@@ -848,6 +854,7 @@ class OpenClipSolver(flib.MediaInfoFile):
 
                 # then append/update feed to correct track in output
                 if out_track_element:
+                    self.log.debug("updating track element ..")
                     # update already present track
                     out_feeds = out_track_element.find('feeds')
                     out_feeds.set('currentVersion', self.feed_version_name)
@@ -857,6 +864,7 @@ class OpenClipSolver(flib.MediaInfoFile):
                         "Appending new feed: {}".format(
                             self.feed_version_name))
                 else:
+                    self.log.debug("adding new track element ..")
                     # create new track as it doesnt exists yet
                     # set current version to feeds on tmp
                     tmp_xml_feeds = tmp_xml_track.find('feeds')

From ca7300a95fd1db17ef6656c6884be7157627c8f8 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 22 Sep 2022 13:41:01 +0200
Subject: [PATCH 133/147] fixing logic

---
 openpype/hosts/flame/api/plugin.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index 044e86b17f..6ad33f16a3 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -822,7 +822,7 @@ class OpenClipSolver(flib.MediaInfoFile):
                 # check if feed path already exists in track's feeds
                 if (
                     out_track_element is not None
-                    and not self._feed_exists(out_track_element, new_path)
+                    and self._feed_exists(out_track_element, new_path)
                 ):
                     continue
 

From 54d5724d6ac1ad7478e4df61de10e33833c1dba9 Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Fri, 23 Sep 2022 11:59:06 +0200
Subject: [PATCH 134/147] Fix log formatting (global file format and aov file
 format were previously swapped)

---
 openpype/hosts/maya/plugins/publish/validate_rendersettings.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
index 7f0985f69b..bfb72c7012 100644
--- a/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
+++ b/openpype/hosts/maya/plugins/publish/validate_rendersettings.py
@@ -201,7 +201,7 @@ class ValidateRenderSettings(pyblish.api.InstancePlugin):
                     labels = get_redshift_image_format_labels()
                     cls.log.error(
                         "AOV file format {} does not match global file format "
-                        "{}".format(labels[default_ext], labels[aov_ext])
+                        "{}".format(labels[aov_ext], labels[default_ext])
                     )
                     invalid = True
 

From da7d4cb1d7d792ae4c2398d64bdd3e1d9036d81c Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Fri, 23 Sep 2022 12:57:17 +0200
Subject: [PATCH 135/147] OP-3682 - updates to match to v4 payload

Parsing should match payload from localhost:5000/api/addons?details=1
---
 .../distribution/addon_distribution.py        |  29 ++++-
 .../tests/test_addon_distributtion.py         | 104 +++++++++++++-----
 2 files changed, 98 insertions(+), 35 deletions(-)

diff --git a/common/openpype_common/distribution/addon_distribution.py b/common/openpype_common/distribution/addon_distribution.py
index ad17a831d8..fec8cb762b 100644
--- a/common/openpype_common/distribution/addon_distribution.py
+++ b/common/openpype_common/distribution/addon_distribution.py
@@ -44,12 +44,18 @@ class WebAddonSource(AddonSource):
     url = attr.ib(default=None)
 
 
+@attr.s
+class VersionData(object):
+    version_data = attr.ib(default=None)
+
+
 @attr.s
 class AddonInfo(object):
     """Object matching json payload from Server"""
     name = attr.ib()
     version = attr.ib()
-    sources = attr.ib(default=attr.Factory(list))
+    title = attr.ib(default=None)
+    sources = attr.ib(default=attr.Factory(dict))
     hash = attr.ib(default=None)
     description = attr.ib(default=None)
     license = attr.ib(default=None)
@@ -58,7 +64,16 @@ class AddonInfo(object):
     @classmethod
     def from_dict(cls, data):
         sources = []
-        for source in data.get("sources", []):
+
+        production_version = data.get("productionVersion")
+        if not production_version:
+            return
+
+        # server payload contains info about all versions
+        # active addon must have 'productionVersion' and matching version info
+        version_data = data.get("versions", {})[production_version]
+
+        for source in version_data.get("clientSourceInfo", []):
             if source.get("type") == UrlType.FILESYSTEM.value:
                 source_addon = LocalAddonSource(type=source["type"],
                                                 path=source["path"])
@@ -69,10 +84,11 @@ class AddonInfo(object):
             sources.append(source_addon)
 
         return cls(name=data.get("name"),
-                   version=data.get("version"),
+                   version=production_version,
+                   sources=sources,
                    hash=data.get("hash"),
                    description=data.get("description"),
-                   sources=sources,
+                   title=data.get("title"),
                    license=data.get("license"),
                    authors=data.get("authors"))
 
@@ -228,8 +244,9 @@ def update_addon_state(addon_infos, destination_folder, factory,
         for source in addon.sources:
             download_states[full_name] = UpdateState.FAILED.value
             try:
-                downloader = factory.get_downloader(source["type"])
-                zip_file_path = downloader.download(source, addon_dest)
+                downloader = factory.get_downloader(source.type)
+                zip_file_path = downloader.download(attr.asdict(source),
+                                                    addon_dest)
                 downloader.check_hash(zip_file_path, addon.hash)
                 downloader.unzip(zip_file_path, addon_dest)
                 download_states[full_name] = UpdateState.UPDATED.value
diff --git a/common/openpype_common/distribution/tests/test_addon_distributtion.py b/common/openpype_common/distribution/tests/test_addon_distributtion.py
index faf4e01e22..46bcd276cd 100644
--- a/common/openpype_common/distribution/tests/test_addon_distributtion.py
+++ b/common/openpype_common/distribution/tests/test_addon_distributtion.py
@@ -35,23 +35,50 @@ def temp_folder():
 @pytest.fixture
 def sample_addon_info():
     addon_info = {
-        "name": "openpype_slack",
-        "version": "1.0.0",
-        "sources": [
-            {
-                "type": "http",
-                "url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing"  # noqa
-            },
-            {
-                "type": "filesystem",
-                "path": {
-                    "windows": ["P:/sources/some_file.zip", "W:/sources/some_file.zip"],  # noqa
-                    "linux": ["/mnt/srv/sources/some_file.zip"],
-                    "darwin": ["/Volumes/srv/sources/some_file.zip"]
-                }
+       "versions": {
+            "1.0.0": {
+                 "clientPyproject": {
+                      "tool": {
+                           "poetry": {
+                            "dependencies": {
+                             "nxtools": "^1.6",
+                             "orjson": "^3.6.7",
+                             "typer": "^0.4.1",
+                             "email-validator": "^1.1.3",
+                             "python": "^3.10",
+                             "fastapi": "^0.73.0"
+                            }
+                       }
+                  }
+                 },
+                 "hasSettings": True,
+                 "clientSourceInfo": [
+                     {
+                         "type": "http",
+                         "url": "https://drive.google.com/file/d/1TcuV8c2OV8CcbPeWi7lxOdqWsEqQNPYy/view?usp=sharing"  # noqa
+                     },
+                     {
+                         "type": "filesystem",
+                         "path": {
+                             "windows": ["P:/sources/some_file.zip",
+                                         "W:/sources/some_file.zip"],  # noqa
+                             "linux": ["/mnt/srv/sources/some_file.zip"],
+                             "darwin": ["/Volumes/srv/sources/some_file.zip"]
+                         }
+                     }
+                 ],
+                 "frontendScopes": {
+                      "project": {
+                       "sidebar": "hierarchy"
+                      }
+                 }
             }
-        ],
-        "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"  # noqa
+       },
+       "description": "",
+       "title": "Slack addon",
+       "name": "openpype_slack",
+       "productionVersion": "1.0.0",
+       "hash": "4be25eb6215e91e5894d3c5475aeb1e379d081d3f5b43b4ee15b0891cf5f5658"  # noqa
     }
     yield addon_info
 
@@ -73,16 +100,39 @@ def test_get_downloader(printer, addon_downloader):
 
 
 def test_addon_info(printer, sample_addon_info):
-    valid_minimum = {"name": "openpype_slack", "version": "1.0.0"}
+    """Tests parsing of expected payload from v4 server into AadonInfo."""
+    valid_minimum = {
+        "name": "openpype_slack",
+         "productionVersion": "1.0.0",
+         "versions": {
+             "1.0.0": {
+                 "clientSourceInfo": [
+                     {
+                         "type": "filesystem",
+                         "path": {
+                             "windows": [
+                                 "P:/sources/some_file.zip",
+                                 "W:/sources/some_file.zip"],
+                             "linux": [
+                                 "/mnt/srv/sources/some_file.zip"],
+                             "darwin": [
+                                 "/Volumes/srv/sources/some_file.zip"]  # noqa
+                         }
+                     }
+                 ]
+             }
+         }
+    }
 
     assert AddonInfo.from_dict(valid_minimum), "Missing required fields"
-    assert AddonInfo(name=valid_minimum["name"],
-                     version=valid_minimum["version"]), \
-        "Missing required fields"
 
-    with pytest.raises(TypeError):
-        # TODO should be probably implemented
-        assert AddonInfo(valid_minimum), "Wrong argument format"
+    valid_minimum["versions"].pop("1.0.0")
+    with pytest.raises(KeyError):
+        assert not AddonInfo.from_dict(valid_minimum), "Must fail without version data"  # noqa
+
+    valid_minimum.pop("productionVersion")
+    assert not AddonInfo.from_dict(
+        valid_minimum), "none if not productionVersion"  # noqa
 
     addon = AddonInfo.from_dict(sample_addon_info)
     assert addon, "Should be created"
@@ -95,15 +145,11 @@ def test_addon_info(printer, sample_addon_info):
     addon_as_dict = attr.asdict(addon)
     assert addon_as_dict["name"], "Dict approach should work"
 
-    with pytest.raises(TypeError):
-        # TODO should be probably implemented as . not dict
-        first_source = addon.sources[0]
-        assert first_source["type"] == "http", "Not implemented"
-
 
 def test_update_addon_state(printer, sample_addon_info,
                             temp_folder, addon_downloader):
-    addon_info = AddonInfo(**sample_addon_info)
+    """Tests possible cases of addon update."""
+    addon_info = AddonInfo.from_dict(sample_addon_info)
     orig_hash = addon_info.hash
 
     addon_info.hash = "brokenhash"

From c659dcfce6393972aa0443f03f67950b1e9fdc45 Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Fri, 23 Sep 2022 13:05:50 +0200
Subject: [PATCH 136/147] OP-3682 - extracted AddonInfo to separate file

Parsing of v4 payload info will be required in Dependencies tool also.
---
 .../distribution/addon_distribution.py        | 78 +-----------------
 .../distribution/addon_info.py                | 80 +++++++++++++++++++
 .../tests/test_addon_distributtion.py         |  2 +-
 3 files changed, 82 insertions(+), 78 deletions(-)
 create mode 100644 common/openpype_common/distribution/addon_info.py

diff --git a/common/openpype_common/distribution/addon_distribution.py b/common/openpype_common/distribution/addon_distribution.py
index fec8cb762b..5e48639dec 100644
--- a/common/openpype_common/distribution/addon_distribution.py
+++ b/common/openpype_common/distribution/addon_distribution.py
@@ -8,12 +8,7 @@ import platform
 import shutil
 
 from .file_handler import RemoteFileHandler
-
-
-class UrlType(Enum):
-    HTTP = "http"
-    GIT = "git"
-    FILESYSTEM = "filesystem"
+from .addon_info import AddonInfo
 
 
 class UpdateState(Enum):
@@ -22,77 +17,6 @@ class UpdateState(Enum):
     FAILED = "failed"
 
 
-@attr.s
-class MultiPlatformPath(object):
-    windows = attr.ib(default=None)
-    linux = attr.ib(default=None)
-    darwin = attr.ib(default=None)
-
-
-@attr.s
-class AddonSource(object):
-    type = attr.ib()
-
-
-@attr.s
-class LocalAddonSource(AddonSource):
-    path = attr.ib(default=attr.Factory(MultiPlatformPath))
-
-
-@attr.s
-class WebAddonSource(AddonSource):
-    url = attr.ib(default=None)
-
-
-@attr.s
-class VersionData(object):
-    version_data = attr.ib(default=None)
-
-
-@attr.s
-class AddonInfo(object):
-    """Object matching json payload from Server"""
-    name = attr.ib()
-    version = attr.ib()
-    title = attr.ib(default=None)
-    sources = attr.ib(default=attr.Factory(dict))
-    hash = attr.ib(default=None)
-    description = attr.ib(default=None)
-    license = attr.ib(default=None)
-    authors = attr.ib(default=None)
-
-    @classmethod
-    def from_dict(cls, data):
-        sources = []
-
-        production_version = data.get("productionVersion")
-        if not production_version:
-            return
-
-        # server payload contains info about all versions
-        # active addon must have 'productionVersion' and matching version info
-        version_data = data.get("versions", {})[production_version]
-
-        for source in version_data.get("clientSourceInfo", []):
-            if source.get("type") == UrlType.FILESYSTEM.value:
-                source_addon = LocalAddonSource(type=source["type"],
-                                                path=source["path"])
-            if source.get("type") == UrlType.HTTP.value:
-                source_addon = WebAddonSource(type=source["type"],
-                                              url=source["url"])
-
-            sources.append(source_addon)
-
-        return cls(name=data.get("name"),
-                   version=production_version,
-                   sources=sources,
-                   hash=data.get("hash"),
-                   description=data.get("description"),
-                   title=data.get("title"),
-                   license=data.get("license"),
-                   authors=data.get("authors"))
-
-
 class AddonDownloader:
     log = logging.getLogger(__name__)
 
diff --git a/common/openpype_common/distribution/addon_info.py b/common/openpype_common/distribution/addon_info.py
new file mode 100644
index 0000000000..00ece11f3b
--- /dev/null
+++ b/common/openpype_common/distribution/addon_info.py
@@ -0,0 +1,80 @@
+import attr
+from enum import Enum
+
+
+class UrlType(Enum):
+    HTTP = "http"
+    GIT = "git"
+    FILESYSTEM = "filesystem"
+
+
+@attr.s
+class MultiPlatformPath(object):
+    windows = attr.ib(default=None)
+    linux = attr.ib(default=None)
+    darwin = attr.ib(default=None)
+
+
+@attr.s
+class AddonSource(object):
+    type = attr.ib()
+
+
+@attr.s
+class LocalAddonSource(AddonSource):
+    path = attr.ib(default=attr.Factory(MultiPlatformPath))
+
+
+@attr.s
+class WebAddonSource(AddonSource):
+    url = attr.ib(default=None)
+
+
+@attr.s
+class VersionData(object):
+    version_data = attr.ib(default=None)
+
+
+@attr.s
+class AddonInfo(object):
+    """Object matching json payload from Server"""
+    name = attr.ib()
+    version = attr.ib()
+    title = attr.ib(default=None)
+    sources = attr.ib(default=attr.Factory(dict))
+    hash = attr.ib(default=None)
+    description = attr.ib(default=None)
+    license = attr.ib(default=None)
+    authors = attr.ib(default=None)
+
+    @classmethod
+    def from_dict(cls, data):
+        sources = []
+
+        production_version = data.get("productionVersion")
+        if not production_version:
+            return
+
+        # server payload contains info about all versions
+        # active addon must have 'productionVersion' and matching version info
+        version_data = data.get("versions", {})[production_version]
+
+        for source in version_data.get("clientSourceInfo", []):
+            if source.get("type") == UrlType.FILESYSTEM.value:
+                source_addon = LocalAddonSource(type=source["type"],
+                                                path=source["path"])
+            if source.get("type") == UrlType.HTTP.value:
+                source_addon = WebAddonSource(type=source["type"],
+                                              url=source["url"])
+
+            sources.append(source_addon)
+
+        return cls(name=data.get("name"),
+                   version=production_version,
+                   sources=sources,
+                   hash=data.get("hash"),
+                   description=data.get("description"),
+                   title=data.get("title"),
+                   license=data.get("license"),
+                   authors=data.get("authors"))
+
diff --git a/common/openpype_common/distribution/tests/test_addon_distributtion.py b/common/openpype_common/distribution/tests/test_addon_distributtion.py
index 46bcd276cd..765ea0596a 100644
--- a/common/openpype_common/distribution/tests/test_addon_distributtion.py
+++ b/common/openpype_common/distribution/tests/test_addon_distributtion.py
@@ -4,13 +4,13 @@ import tempfile
 
 from common.openpype_common.distribution.addon_distribution import (
     AddonDownloader,
-    UrlType,
     OSAddonDownloader,
     HTTPAddonDownloader,
     AddonInfo,
     update_addon_state,
     UpdateState
 )
+from common.openpype_common.distribution.addon_info import UrlType
 
 
 @pytest.fixture

From a25b951607239984719acb550506571025682069 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Fri, 23 Sep 2022 13:12:04 +0200
Subject: [PATCH 137/147] making the code more appealing

---
 .../publish/extract_subset_resources.py       | 54 +++++++++----------
 1 file changed, 27 insertions(+), 27 deletions(-)

diff --git a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
index 1b7e9b88b5..5482af973c 100644
--- a/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
+++ b/openpype/hosts/flame/plugins/publish/extract_subset_resources.py
@@ -79,10 +79,10 @@ class ExtractSubsetResources(openpype.api.Extractor):
         retimed_data = self._get_retimed_attributes(instance)
 
         # get individual keys
-        r_handle_start = retimed_data["handle_start"]
-        r_handle_end = retimed_data["handle_end"]
-        r_source_dur = retimed_data["source_duration"]
-        r_speed = retimed_data["speed"]
+        retimed_handle_start = retimed_data["handle_start"]
+        retimed_handle_end = retimed_data["handle_end"]
+        retimed_source_duration = retimed_data["source_duration"]
+        retimed_speed = retimed_data["speed"]
 
         # get handles value - take only the max from both
         handle_start = instance.data["handleStart"]
@@ -96,23 +96,23 @@ class ExtractSubsetResources(openpype.api.Extractor):
         source_end_handles = instance.data["sourceEndH"]
 
         # retime if needed
-        if r_speed != 1.0:
+        if retimed_speed != 1.0:
             if retimed_handles:
                 # handles are retimed
                 source_start_handles = (
-                    instance.data["sourceStart"] - r_handle_start)
+                    instance.data["sourceStart"] - retimed_handle_start)
                 source_end_handles = (
                     source_start_handles
-                    + (r_source_dur - 1)
-                    + r_handle_start
-                    + r_handle_end
+                    + (retimed_source_duration - 1)
+                    + retimed_handle_start
+                    + retimed_handle_end
                 )
 
             else:
                 # handles are not retimed
                 source_end_handles = (
                     source_start_handles
-                    + (r_source_dur - 1)
+                    + (retimed_source_duration - 1)
                     + handle_start
                     + handle_end
                 )
@@ -121,11 +121,11 @@ class ExtractSubsetResources(openpype.api.Extractor):
         frame_start_handle = frame_start - handle_start
         repre_frame_start = frame_start_handle
         if include_handles:
-            if r_speed == 1.0 or not retimed_handles:
+            if retimed_speed == 1.0 or not retimed_handles:
                 frame_start_handle = frame_start
             else:
                 frame_start_handle = (
-                    frame_start - handle_start) + r_handle_start
+                    frame_start - handle_start) + retimed_handle_start
 
         self.log.debug("_ frame_start_handle: {}".format(
             frame_start_handle))
@@ -163,29 +163,29 @@ class ExtractSubsetResources(openpype.api.Extractor):
             instance.data["versionData"].update(version_data)
 
         # version data start frame
-        vd_frame_start = frame_start
+        version_frame_start = frame_start
         if include_handles:
-            vd_frame_start = frame_start_handle
-
-        if r_speed != 1.0:
-            instance.data["versionData"].update({
-                "frameStart": vd_frame_start,
-                "frameEnd": (
-                    (vd_frame_start + source_duration_handles - 1)
-                    - (r_handle_start + r_handle_end)
-                )
-            })
-            if not retimed_handles:
+            version_frame_start = frame_start_handle
+        if retimed_speed != 1.0:
+            if retimed_handles:
+                instance.data["versionData"].update({
+                    "frameStart": version_frame_start,
+                    "frameEnd": (
+                        (version_frame_start + source_duration_handles - 1)
+                        - (retimed_handle_start + retimed_handle_end)
+                    )
+                })
+            else:
                 instance.data["versionData"].update({
                     "handleStart": handle_start,
                     "handleEnd": handle_end,
-                    "frameStart": vd_frame_start,
+                    "frameStart": version_frame_start,
                     "frameEnd": (
-                        (vd_frame_start + source_duration_handles - 1)
+                        (version_frame_start + source_duration_handles - 1)
                         - (handle_start + handle_end)
                     )
                 })
-        self.log.debug("_ i_version_data: {}".format(
+        self.log.debug("_ version_data: {}".format(
             instance.data["versionData"]
         ))
 

From 68ef0e35066c6a2eaff185665d6fd30749a164b5 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Fri, 23 Sep 2022 13:23:18 +0200
Subject: [PATCH 138/147] making code more appealing

---
 openpype/hosts/flame/api/plugin.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/openpype/hosts/flame/api/plugin.py b/openpype/hosts/flame/api/plugin.py
index 6ad33f16a3..1a26e96c79 100644
--- a/openpype/hosts/flame/api/plugin.py
+++ b/openpype/hosts/flame/api/plugin.py
@@ -801,7 +801,7 @@ class OpenClipSolver(flib.MediaInfoFile):
         self.log.debug(">> self.clip_data: {}".format(self.clip_data))
 
         # loop tmp tracks
-        updated_any = []
+        updated_any = False
         for tmp_xml_track in self.clip_data.iter("track"):
             # get tmp track uid
             tmp_track_uid = tmp_xml_track.get("uid")
@@ -831,25 +831,25 @@ class OpenClipSolver(flib.MediaInfoFile):
                 self._clear_handler(tmp_xml_feed)
 
                 # update fps from MediaInfoFile class
-                if self.fps:
+                if self.fps is not None:
                     tmp_feed_fps_obj = tmp_xml_feed.find(
                         "startTimecode/rate")
                     tmp_feed_fps_obj.text = str(self.fps)
 
                 # update start_frame from MediaInfoFile class
-                if self.start_frame:
+                if self.start_frame is not None:
                     tmp_feed_nb_ticks_obj = tmp_xml_feed.find(
                         "startTimecode/nbTicks")
                     tmp_feed_nb_ticks_obj.text = str(self.start_frame)
 
                 # update drop_mode from MediaInfoFile class
-                if self.drop_mode:
+                if self.drop_mode is not None:
                     tmp_feed_drop_mode_obj = tmp_xml_feed.find(
                         "startTimecode/dropMode")
                     tmp_feed_drop_mode_obj.text = str(self.drop_mode)
 
                 # add colorspace if any is set
-                if self.feed_colorspace:
+                if self.feed_colorspace is not None:
                     self._add_colorspace(tmp_xml_feed, self.feed_colorspace)
 
                 # then append/update feed to correct track in output
@@ -872,9 +872,9 @@ class OpenClipSolver(flib.MediaInfoFile):
                     out_tracks = out_xml.find("tracks")
                     out_tracks.append(tmp_xml_track)
 
-                updated_any.append(True)
+                updated_any = True
 
-        if any(updated_any):
+        if updated_any:
             # Append vUID to versions
             out_xml_versions_obj = out_xml.find('versions')
             out_xml_versions_obj.set(

From 00995475d9c9471dda3923287a8295f64687d4ce Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 23 Sep 2022 13:23:32 +0200
Subject: [PATCH 139/147] added function to get default values of attribute
 definitions

---
 openpype/lib/attribute_definitions.py | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/openpype/lib/attribute_definitions.py b/openpype/lib/attribute_definitions.py
index cbd53d1f07..37446f01f8 100644
--- a/openpype/lib/attribute_definitions.py
+++ b/openpype/lib/attribute_definitions.py
@@ -30,6 +30,28 @@ def get_attributes_keys(attribute_definitions):
     return keys
 
 
+def get_default_values(attribute_definitions):
+    """Receive default values for attribute definitions.
+
+    Args:
+        attribute_definitions (List[AbtractAttrDef]): Attribute definitions for
+            which default values should be collected.
+
+    Returns:
+        Dict[str, Any]: Default values for passet attribute definitions.
+    """
+
+    output = {}
+    if not attribute_definitions:
+        return output
+
+    for attr_def in attribute_definitions:
+        # Skip UI definitions
+        if not isinstance(attr_def, UIDef):
+            output[attr_def.key] = attr_def.default
+    return output
+
+
 class AbstractAttrDefMeta(ABCMeta):
     """Meta class to validate existence of 'key' attribute.
 

From 2db3aa131cc0920ff6050c8bca55997cd3c50f21 Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 23 Sep 2022 13:24:17 +0200
Subject: [PATCH 140/147] fix typo

---
 openpype/hosts/nuke/api/workfile_template_builder.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/nuke/api/workfile_template_builder.py b/openpype/hosts/nuke/api/workfile_template_builder.py
index 709ee3b743..7317f6726b 100644
--- a/openpype/hosts/nuke/api/workfile_template_builder.py
+++ b/openpype/hosts/nuke/api/workfile_template_builder.py
@@ -55,7 +55,7 @@ class NukeTemplateBuilder(AbstractTemplateBuilder):
 
 
 class NukePlaceholderPlugin(PlaceholderPlugin):
-    noce_color = 4278190335
+    node_color = 4278190335
 
     def _collect_scene_placeholders(self):
         # Cache placeholder data to shared data

From d6c7509150d695b7c7e5a60d8bc13889e71b01af Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 23 Sep 2022 13:27:28 +0200
Subject: [PATCH 141/147] fix 'get_load_plugin_options' in maya

---
 openpype/hosts/maya/api/workfile_template_builder.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index 9163cf9a6f..be5dc3db61 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -212,7 +212,7 @@ class MayaPlaceholderLoadPlugin(PlaceholderPlugin, PlaceholderLoadMixin):
         self.populate_load_placeholder(placeholder, repre_ids)
 
     def get_placeholder_options(self, options=None):
-        return self.get_load_plugin_options(self, options)
+        return self.get_load_plugin_options(options)
 
     def cleanup_placeholder(self, placeholder):
         """Hide placeholder, parent them to root

From 654b5744de733ebebd045a0b2614a8d40e7c41bd Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 23 Sep 2022 14:06:39 +0200
Subject: [PATCH 142/147] fix arguments for 'cleanup_placeholder'

---
 openpype/hosts/maya/api/workfile_template_builder.py | 2 +-
 openpype/hosts/nuke/api/workfile_template_builder.py | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/maya/api/workfile_template_builder.py b/openpype/hosts/maya/api/workfile_template_builder.py
index be5dc3db61..ef043ed0f4 100644
--- a/openpype/hosts/maya/api/workfile_template_builder.py
+++ b/openpype/hosts/maya/api/workfile_template_builder.py
@@ -214,7 +214,7 @@ class MayaPlaceholderLoadPlugin(PlaceholderPlugin, PlaceholderLoadMixin):
     def get_placeholder_options(self, options=None):
         return self.get_load_plugin_options(options)
 
-    def cleanup_placeholder(self, placeholder):
+    def cleanup_placeholder(self, placeholder, failed):
         """Hide placeholder, parent them to root
         add them to placeholder set and register placeholder's parent
         to keep placeholder info available for future use
diff --git a/openpype/hosts/nuke/api/workfile_template_builder.py b/openpype/hosts/nuke/api/workfile_template_builder.py
index 7317f6726b..7a2e442e32 100644
--- a/openpype/hosts/nuke/api/workfile_template_builder.py
+++ b/openpype/hosts/nuke/api/workfile_template_builder.py
@@ -192,7 +192,7 @@ class NukePlaceholderLoadPlugin(NukePlaceholderPlugin, PlaceholderLoadMixin):
     def get_placeholder_options(self, options=None):
         return self.get_load_plugin_options(options)
 
-    def cleanup_placeholder(self, placeholder):
+    def cleanup_placeholder(self, placeholder, failed):
         # deselect all selected nodes
         placeholder_node = nuke.toNode(placeholder.scene_identifier)
 

From 9c1ee5b79c90fd3db25857661a39a21e97b9d5ad Mon Sep 17 00:00:00 2001
From: Jakub Trllo <jakub.trllo@gmail.com>
Date: Fri, 23 Sep 2022 17:11:40 +0200
Subject: [PATCH 143/147] renamed 'lifetime_data' to 'transient_data'

---
 openpype/pipeline/create/context.py                     | 6 +++---
 openpype/plugins/publish/collect_from_create_context.py | 6 +++---
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/openpype/pipeline/create/context.py b/openpype/pipeline/create/context.py
index a1b11d08c5..a7e43cb2f2 100644
--- a/openpype/pipeline/create/context.py
+++ b/openpype/pipeline/create/context.py
@@ -405,7 +405,7 @@ class CreatedInstance:
         self._members = []
 
         # Data that can be used for lifetime of object
-        self._lifetime_data = {}
+        self._transient_data = {}
 
         # Create a copy of passed data to avoid changing them on the fly
         data = copy.deepcopy(data or {})
@@ -600,7 +600,7 @@ class CreatedInstance:
         return self
 
     @property
-    def lifetime_data(self):
+    def transient_data(self):
         """Data stored for lifetime of instance object.
 
         These data are not stored to scene and will be lost on object
@@ -617,7 +617,7 @@ class CreatedInstance:
                 to instance for lifetime of instance object.
         """
 
-        return self._lifetime_data
+        return self._transient_data
 
     def changes(self):
         """Calculate and return changes."""
diff --git a/openpype/plugins/publish/collect_from_create_context.py b/openpype/plugins/publish/collect_from_create_context.py
index b5e3225c34..fc0f97b187 100644
--- a/openpype/plugins/publish/collect_from_create_context.py
+++ b/openpype/plugins/publish/collect_from_create_context.py
@@ -26,7 +26,7 @@ class CollectFromCreateContext(pyblish.api.ContextPlugin):
             instance_data = created_instance.data_to_store()
             if instance_data["active"]:
                 self.create_instance(
-                    context, instance_data, created_instance.lifetime_data
+                    context, instance_data, created_instance.transient_data
                 )
 
         # Update global data to context
@@ -39,7 +39,7 @@ class CollectFromCreateContext(pyblish.api.ContextPlugin):
                 legacy_io.Session[key] = value
                 os.environ[key] = value
 
-    def create_instance(self, context, in_data, lifetime_data):
+    def create_instance(self, context, in_data, transient_data):
         subset = in_data["subset"]
         # If instance data already contain families then use it
         instance_families = in_data.get("families") or []
@@ -59,7 +59,7 @@ class CollectFromCreateContext(pyblish.api.ContextPlugin):
             if key not in instance.data:
                 instance.data[key] = value
 
-        instance.data["lifetimeData"] = lifetime_data
+        instance.data["transientData"] = transient_data
 
         self.log.info("collected instance: {}".format(instance.data))
         self.log.info("parsing data: {}".format(in_data))

From 50b850ec17e37b720b21d1c80e87320465d3db05 Mon Sep 17 00:00:00 2001
From: OpenPype <info@openpype.io>
Date: Sat, 24 Sep 2022 04:19:03 +0000
Subject: [PATCH 144/147] [Automated] Bump version

---
 CHANGELOG.md        | 31 ++++++++++++++-----------------
 openpype/version.py |  2 +-
 2 files changed, 15 insertions(+), 18 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index f868e6ed6e..24e02acc6f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,17 +1,20 @@
 # Changelog
 
-## [3.14.3-nightly.3](https://github.com/pypeclub/OpenPype/tree/HEAD)
+## [3.14.3-nightly.4](https://github.com/pypeclub/OpenPype/tree/HEAD)
 
 [Full Changelog](https://github.com/pypeclub/OpenPype/compare/3.14.2...HEAD)
 
 **🚀 Enhancements**
 
 - Maya: better logging in Maketx [\#3886](https://github.com/pypeclub/OpenPype/pull/3886)
+- Photoshop: review can be turned off [\#3885](https://github.com/pypeclub/OpenPype/pull/3885)
 - TrayPublisher: added persisting of last selected project [\#3871](https://github.com/pypeclub/OpenPype/pull/3871)
 - TrayPublisher: added text filter on project name to Tray Publisher [\#3867](https://github.com/pypeclub/OpenPype/pull/3867)
 - Github issues adding `running version` section [\#3864](https://github.com/pypeclub/OpenPype/pull/3864)
 - Publisher: Increase size of main window [\#3862](https://github.com/pypeclub/OpenPype/pull/3862)
+- Flame: make migratable projects after creation [\#3860](https://github.com/pypeclub/OpenPype/pull/3860)
 - Photoshop: synchronize image version with workfile [\#3854](https://github.com/pypeclub/OpenPype/pull/3854)
+- General: Transcoding handle float2 attr type [\#3849](https://github.com/pypeclub/OpenPype/pull/3849)
 - General: Simple script for getting license information about used packages [\#3843](https://github.com/pypeclub/OpenPype/pull/3843)
 - Houdini: Increment current file on workfile publish [\#3840](https://github.com/pypeclub/OpenPype/pull/3840)
 - Publisher: Add new publisher to host tools [\#3833](https://github.com/pypeclub/OpenPype/pull/3833)
@@ -20,9 +23,15 @@
 
 **🐛 Bug fixes**
 
+- Flame: loading multilayer exr to batch/reel is working [\#3901](https://github.com/pypeclub/OpenPype/pull/3901)
+- Hiero: Fix inventory check on launch [\#3895](https://github.com/pypeclub/OpenPype/pull/3895)
+- WebPublisher: Fix import after refactor [\#3891](https://github.com/pypeclub/OpenPype/pull/3891)
+- TVPaint: Fix renaming of rendered files [\#3882](https://github.com/pypeclub/OpenPype/pull/3882)
+- Publisher: Nice checkbox visible in Python 2 [\#3877](https://github.com/pypeclub/OpenPype/pull/3877)
 - Settings: Add missing default settings [\#3870](https://github.com/pypeclub/OpenPype/pull/3870)
 - General: Copy of workfile does not use 'copy' function but 'copyfile' [\#3869](https://github.com/pypeclub/OpenPype/pull/3869)
 - Tray Publisher: skip plugin if otioTimeline is missing [\#3856](https://github.com/pypeclub/OpenPype/pull/3856)
+- Flame: retimed attributes are integrated with settings [\#3855](https://github.com/pypeclub/OpenPype/pull/3855)
 - Maya: Extract Playblast fix textures + labelize viewport show settings [\#3852](https://github.com/pypeclub/OpenPype/pull/3852)
 - Ftrack: Url validation does not require ftrackapp [\#3834](https://github.com/pypeclub/OpenPype/pull/3834)
 - Maya+Ftrack: Change typo in family name `mayaascii` -\> `mayaAscii` [\#3820](https://github.com/pypeclub/OpenPype/pull/3820)
@@ -30,9 +39,12 @@
 
 **🔀 Refactored code**
 
+- Houdini: Use new Extractor location [\#3894](https://github.com/pypeclub/OpenPype/pull/3894)
+- Harmony: Use new Extractor location [\#3893](https://github.com/pypeclub/OpenPype/pull/3893)
 - Hiero: Use new Extractor location [\#3851](https://github.com/pypeclub/OpenPype/pull/3851)
 - Maya: Remove old legacy \(ftrack\) plug-ins that are of no use anymore [\#3819](https://github.com/pypeclub/OpenPype/pull/3819)
 - Nuke: Use new Extractor location [\#3799](https://github.com/pypeclub/OpenPype/pull/3799)
+- Maya: Use new Extractor location [\#3775](https://github.com/pypeclub/OpenPype/pull/3775)
 
 **Merged pull requests:**
 
@@ -54,7 +66,6 @@
 - General: Better pixmap scaling [\#3809](https://github.com/pypeclub/OpenPype/pull/3809)
 - Photoshop: attempt to speed up ExtractImage [\#3793](https://github.com/pypeclub/OpenPype/pull/3793)
 - SyncServer: Added cli commands for sync server [\#3765](https://github.com/pypeclub/OpenPype/pull/3765)
-- Kitsu: Drop 'entities root' setting. [\#3739](https://github.com/pypeclub/OpenPype/pull/3739)
 
 **🐛 Bug fixes**
 
@@ -74,7 +85,6 @@
 - Photoshop: Use new Extractor location [\#3789](https://github.com/pypeclub/OpenPype/pull/3789)
 - Blender: Use new Extractor location [\#3787](https://github.com/pypeclub/OpenPype/pull/3787)
 - AfterEffects: Use new Extractor location [\#3784](https://github.com/pypeclub/OpenPype/pull/3784)
-- Maya: Use new Extractor location [\#3775](https://github.com/pypeclub/OpenPype/pull/3775)
 - General: Remove unused teshost [\#3773](https://github.com/pypeclub/OpenPype/pull/3773)
 - General: Copied 'Extractor' plugin to publish pipeline [\#3771](https://github.com/pypeclub/OpenPype/pull/3771)
 - General: Move queries of asset and representation links [\#3770](https://github.com/pypeclub/OpenPype/pull/3770)
@@ -83,10 +93,7 @@
 - Maya: Refactor submit deadline to use AbstractSubmitDeadline [\#3759](https://github.com/pypeclub/OpenPype/pull/3759)
 - General: Change publish template settings location [\#3755](https://github.com/pypeclub/OpenPype/pull/3755)
 - General: Move hostdirname functionality into host [\#3749](https://github.com/pypeclub/OpenPype/pull/3749)
-- Houdini: Define houdini as addon [\#3735](https://github.com/pypeclub/OpenPype/pull/3735)
-- Fusion: Defined fusion as addon [\#3733](https://github.com/pypeclub/OpenPype/pull/3733)
-- Flame: Defined flame as addon [\#3732](https://github.com/pypeclub/OpenPype/pull/3732)
-- Resolve: Define resolve as addon [\#3727](https://github.com/pypeclub/OpenPype/pull/3727)
+- General: Move publish utils to pipeline [\#3745](https://github.com/pypeclub/OpenPype/pull/3745)
 
 **Merged pull requests:**
 
@@ -106,22 +113,12 @@
 - Maya: Fix typo in getPanel argument `with\_focus` -\> `withFocus` [\#3753](https://github.com/pypeclub/OpenPype/pull/3753)
 - General: Smaller fixes of imports [\#3748](https://github.com/pypeclub/OpenPype/pull/3748)
 - General: Logger tweaks [\#3741](https://github.com/pypeclub/OpenPype/pull/3741)
-- Nuke: missing job dependency if multiple bake streams [\#3737](https://github.com/pypeclub/OpenPype/pull/3737)
 
 **🔀 Refactored code**
 
 - General: Move delivery logic to pipeline [\#3751](https://github.com/pypeclub/OpenPype/pull/3751)
-- General: Move publish utils to pipeline [\#3745](https://github.com/pypeclub/OpenPype/pull/3745)
 - General: Host addons cleanup [\#3744](https://github.com/pypeclub/OpenPype/pull/3744)
 - Webpublisher: Webpublisher is used as addon [\#3740](https://github.com/pypeclub/OpenPype/pull/3740)
-- Photoshop: Defined photoshop as addon [\#3736](https://github.com/pypeclub/OpenPype/pull/3736)
-- Harmony: Defined harmony as addon [\#3734](https://github.com/pypeclub/OpenPype/pull/3734)
-- General: Module interfaces cleanup [\#3731](https://github.com/pypeclub/OpenPype/pull/3731)
-- AfterEffects: Move AE functions from general lib [\#3730](https://github.com/pypeclub/OpenPype/pull/3730)
-- Blender: Define blender as module [\#3729](https://github.com/pypeclub/OpenPype/pull/3729)
-- AfterEffects: Define AfterEffects as module [\#3728](https://github.com/pypeclub/OpenPype/pull/3728)
-- General: Replace PypeLogger with Logger [\#3725](https://github.com/pypeclub/OpenPype/pull/3725)
-- Nuke: Define nuke as module [\#3724](https://github.com/pypeclub/OpenPype/pull/3724)
 
 ## [3.14.0](https://github.com/pypeclub/OpenPype/tree/3.14.0) (2022-08-18)
 
diff --git a/openpype/version.py b/openpype/version.py
index 26b145f1db..fd6e894fe2 100644
--- a/openpype/version.py
+++ b/openpype/version.py
@@ -1,3 +1,3 @@
 # -*- coding: utf-8 -*-
 """Package declaring Pype version."""
-__version__ = "3.14.3-nightly.3"
+__version__ = "3.14.3-nightly.4"

From 2e3e799f34955a31a946b939411cdb477eb33da6 Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Sat, 24 Sep 2022 11:33:03 +0200
Subject: [PATCH 145/147] Fix PublishIconButton drawing disabled icon with the
 color specified

- Previously the color to draw was ignored when button was disabled because default color was applied to the disabled state
---
 openpype/tools/publisher/widgets/widgets.py | 40 +++++++--------------
 1 file changed, 12 insertions(+), 28 deletions(-)

diff --git a/openpype/tools/publisher/widgets/widgets.py b/openpype/tools/publisher/widgets/widgets.py
index aa7e3be687..1b081cc4a1 100644
--- a/openpype/tools/publisher/widgets/widgets.py
+++ b/openpype/tools/publisher/widgets/widgets.py
@@ -125,28 +125,19 @@ class PublishIconBtn(IconButton):
     def __init__(self, pixmap_path, *args, **kwargs):
         super(PublishIconBtn, self).__init__(*args, **kwargs)
 
-        loaded_image = QtGui.QImage(pixmap_path)
+        icon = self.generate_icon(pixmap_path,
+                                  enabled_color=QtCore.Qt.white,
+                                  disabled_color=QtGui.QColor("#5b6779"))
+        self.setIcon(icon)
 
-        pixmap = self.paint_image_with_color(loaded_image, QtCore.Qt.white)
-
-        self._base_image = loaded_image
-        self._enabled_icon = QtGui.QIcon(pixmap)
-        self._disabled_icon = None
-
-        self.setIcon(self._enabled_icon)
-
-    def get_enabled_icon(self):
-        """Enabled icon."""
-        return self._enabled_icon
-
-    def get_disabled_icon(self):
-        """Disabled icon."""
-        if self._disabled_icon is None:
-            pixmap = self.paint_image_with_color(
-                self._base_image, QtCore.Qt.gray
-            )
-            self._disabled_icon = QtGui.QIcon(pixmap)
-        return self._disabled_icon
+    def generate_icon(self, pixmap_path, enabled_color, disabled_color):
+        icon = QtGui.QIcon()
+        image = QtGui.QImage(pixmap_path)
+        enabled_pixmap = self.paint_image_with_color(image, enabled_color)
+        icon.addPixmap(enabled_pixmap, icon.Normal)
+        disabled_pixmap = self.paint_image_with_color(image, disabled_color)
+        icon.addPixmap(disabled_pixmap, icon.Disabled)
+        return icon
 
     @staticmethod
     def paint_image_with_color(image, color):
@@ -187,13 +178,6 @@ class PublishIconBtn(IconButton):
 
         return pixmap
 
-    def setEnabled(self, enabled):
-        super(PublishIconBtn, self).setEnabled(enabled)
-        if self.isEnabled():
-            self.setIcon(self.get_enabled_icon())
-        else:
-            self.setIcon(self.get_disabled_icon())
-
 
 class ResetBtn(PublishIconBtn):
     """Publish reset button."""

From d6949754a1e6bff33d85df0a2012d15dbf825214 Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Mon, 26 Sep 2022 11:07:17 +0200
Subject: [PATCH 146/147] Use colors from style/data.json

---
 openpype/tools/publisher/widgets/widgets.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/openpype/tools/publisher/widgets/widgets.py b/openpype/tools/publisher/widgets/widgets.py
index 1b081cc4a1..d1fa71343c 100644
--- a/openpype/tools/publisher/widgets/widgets.py
+++ b/openpype/tools/publisher/widgets/widgets.py
@@ -16,6 +16,7 @@ from openpype.tools.utils import (
     BaseClickableFrame,
     set_style_property,
 )
+from openpype.style import get_objected_colors
 from openpype.pipeline.create import (
     SUBSET_NAME_ALLOWED_SYMBOLS,
     TaskNotSetError,
@@ -125,9 +126,11 @@ class PublishIconBtn(IconButton):
     def __init__(self, pixmap_path, *args, **kwargs):
         super(PublishIconBtn, self).__init__(*args, **kwargs)
 
-        icon = self.generate_icon(pixmap_path,
-                                  enabled_color=QtCore.Qt.white,
-                                  disabled_color=QtGui.QColor("#5b6779"))
+        colors = get_objected_colors()
+        icon = self.generate_icon(
+            pixmap_path,
+            enabled_color=colors["font"].get_qcolor(),
+            disabled_color=colors["font-disabled"].get_qcolor())
         self.setIcon(icon)
 
     def generate_icon(self, pixmap_path, enabled_color, disabled_color):

From 6237c4ae8204f044da371594814f34eefd1e91f3 Mon Sep 17 00:00:00 2001
From: Roy Nieterau <roy_nieterau@hotmail.com>
Date: Mon, 26 Sep 2022 11:07:34 +0200
Subject: [PATCH 147/147] Update "font-disabled" color

---
 openpype/style/data.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/openpype/style/data.json b/openpype/style/data.json
index 15d9472e3e..adda49de23 100644
--- a/openpype/style/data.json
+++ b/openpype/style/data.json
@@ -20,7 +20,7 @@
     "color": {
         "font": "#D3D8DE",
         "font-hover": "#F0F2F5",
-        "font-disabled": "#99A3B2",
+        "font-disabled": "#5b6779",
         "font-view-selection": "#ffffff",
         "font-view-hover": "#F0F2F5",