Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-24 21:04:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

move instance review key check earlier and move the logic to method

Browse source
This commit is contained in:
Jakub Trllo 2022-07-25 12:43:10 +02:00
parent 7905d18e67
commit 89705a69d1
1 changed files with 12 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
openpype/plugins/publish/extract_thumbnail.py
View file

@ -41,6 +41,11 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
"Processing instance with subset name {}".format(subset_name)
)
# Skip if instance does not have review
if not self._is_review_instance(instance):
self.log.info("Skipping - no review set on instance.")
return
# skip crypto passes.
# TODO: This is just a quick fix and has its own side-effects - it is
# affecting every subset name with `crypto` in its name.
@ -51,11 +56,6 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
self.log.info("Skipping crypto passes.")
return
# Skip if review not set.
if not instance.data.get("review", True):
self.log.info("Skipping - no review set on instance.")
return
if self._already_has_thumbnail(instance):
self.log.info("Thumbnail representation already present.")
return
@ -116,6 +116,13 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
# There is no need to create more then one thumbnail
break
def _is_review_instance(self, instance):
# TODO: We should probably handle "not creating" of thumbnail
# other way then checking for "review" key on instance data?
if instance.data.get("review", True):
return True
return False
def _already_has_thumbnail(self, instance):
for repre in instance.data.get("representations", []):
self.log.info("repre {}".format(repre))