Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-25 05:14:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Merge pull request #4023 from pypeclub/feature/extract_review_settings_compatibility

Browse source 
General: Extract review does not crash with old settings overrides
This commit is contained in:
Jakub Trllo 2022-10-24 15:17:34 +02:00 • committed by GitHub
commit 8b0ec2ad54
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 18 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

41
openpype/plugins/publish/extract_review.py
View file

@ -1731,38 +1731,33 @@ class ExtractReview(pyblish.api.InstancePlugin):
Returns:
list: Containg all output definitions matching entered tags.
"""
filtered_outputs = []
repre_c_tags_low = [tag.lower() for tag in (custom_tags or [])]
for output_def in outputs:
valid = False
tag_filters = output_def.get("filter", {}).get("custom_tags")
if (
# if any of tag filter is empty, skip
custom_tags and not tag_filters
or not custom_tags and tag_filters
):
continue
elif not custom_tags and not tag_filters:
if not custom_tags and not tag_filters:
# Definition is valid if both tags are empty
valid = True
# lower all filter tags
tag_filters_low = [tag.lower() for tag in tag_filters]
elif not custom_tags or not tag_filters:
# Invalid if one is empty
valid = False
self.log.debug("__ tag_filters: {}".format(tag_filters))
self.log.debug("__ repre_c_tags_low: {}".format(
repre_c_tags_low))
else:
# Check if output definition tags are in representation tags
valid = False
# lower all filter tags
tag_filters_low = [tag.lower() for tag in tag_filters]
# check if any repre tag is not in filter tags
for tag in repre_c_tags_low:
if tag in tag_filters_low:
valid = True
break
# check if any repre tag is not in filter tags
for tag in repre_c_tags_low:
if tag in tag_filters_low:
valid = True
break
if not valid:
continue
filtered_outputs.append(output_def)
if valid:
filtered_outputs.append(output_def)
self.log.debug("__ filtered_outputs: {}".format(
[_o["filename_suffix"] for _o in filtered_outputs]