From 8e284aaa4dc7e0e272c00432f8a8f5b21ee37e23 Mon Sep 17 00:00:00 2001
From: Oscar Domingo <oscardomingo@gmail.com>
Date: Wed, 31 Jan 2024 16:25:53 +0000
Subject: [PATCH] `settings.maya` Rename Alembic settings This commit attempts
 to better name and label the Alembic settings, used in the creation and
 extraction of Alembic pointcaches.

---
 .../defaults/project_settings/maya.json       |  8 +++----
 .../schemas/schema_maya_create.json           | 16 ++++++-------
 server_addon/maya/server/settings/creators.py | 24 +++++++++----------
 3 files changed, 24 insertions(+), 24 deletions(-)

diff --git a/openpype/settings/defaults/project_settings/maya.json b/openpype/settings/defaults/project_settings/maya.json
index 28e8cfefa4..214a4f737a 100644
--- a/openpype/settings/defaults/project_settings/maya.json
+++ b/openpype/settings/defaults/project_settings/maya.json
@@ -559,12 +559,12 @@
         "CreateAnimation": {
             "default_variants": [],
             "step": 1.0,
-            "abc_boolean_args": [
+            "abc_export_flags": [
                 "writeColorSets",
                 "worldSpace",
                 "writeNormals"
             ],
-            "abc_args_overrides": [
+            "abc_export_overrides": [
                 "step",
                 "includeParentHierarchy",
                 "writeNormals",
@@ -598,13 +598,13 @@
                 "Main"
             ],
             "step": 1.0,
-            "abc_boolean_args": [
+            "abc_export_flags": [
                 "selection",
                 "uvWrite",
                 "writeCreases",
                 "writeVisibility"
             ],
-            "abc_args_overrides": [
+            "abc_export_overrides": [
                 "attr",
                 "attrPrefix",
                 "step",
diff --git a/openpype/settings/entities/schemas/projects_schema/schemas/schema_maya_create.json b/openpype/settings/entities/schemas/projects_schema/schemas/schema_maya_create.json
index 5ae4397a87..6f9ead7fec 100644
--- a/openpype/settings/entities/schemas/projects_schema/schemas/schema_maya_create.json
+++ b/openpype/settings/entities/schemas/projects_schema/schemas/schema_maya_create.json
@@ -160,9 +160,9 @@
                 },
                 {
                     "type": "enum",
-                    "key": "abc_boolean_args",
+                    "key": "abc_export_flags",
                     "multiselection": true,
-                    "label": "Alembic Boolean Args",
+                    "label": "Export Flags (.abc)",
                     "enum_items": [
                         {"autoSubd": "autoSubd"},
                         {"dontSkipUnwrittenFrames": "dontSkipUnwrittenFrames"},
@@ -186,9 +186,9 @@
                 },
                 {
                     "type": "enum",
-                    "key": "abc_args_overrides",
+                    "key": "abc_export_overrides",
                     "multiselection": true,
-                    "label": "Alembic Arguments Overrides:\nChoose which arguments\nthe user can modify.",
+                    "label": "Export Overrides (.abc)",
                     "enum_items": [
                         {"attr": "attr"},
                         {"attrPrefix": "attrPrefix"},
@@ -319,9 +319,9 @@
                 },
                 {
                     "type": "enum",
-                    "key": "abc_boolean_args",
+                    "key": "abc_export_flags",
                     "multiselection": true,
-                    "label": "Alembic Boolean Args",
+                    "label": "Export Flags (.abc)",
                     "enum_items": [
                         {"autoSubd": "autoSubd"},
                         {"dontSkipUnwrittenFrames": "dontSkipUnwrittenFrames"},
@@ -345,9 +345,9 @@
                 },
                 {
                     "type": "enum",
-                    "key": "abc_args_overrides",
+                    "key": "abc_export_overrides",
                     "multiselection": true,
-                    "label": "Alembic Arguments Overrides:\nChoose which arguments\nthe user can modify.",
+                    "label": "Export Overrides (.abc)",
                     "enum_items": [
                         {"attr": "attr"},
                         {"attrPrefix": "attrPrefix"},
diff --git a/server_addon/maya/server/settings/creators.py b/server_addon/maya/server/settings/creators.py
index 7e26980b92..2fc5a66818 100644
--- a/server_addon/maya/server/settings/creators.py
+++ b/server_addon/maya/server/settings/creators.py
@@ -150,15 +150,15 @@ class CreateAnimationModel(BaseSettingsModel):
         enum_resolver=alembic_data_formats,
         title="Data Format",
     )
-    abc_boolean_args: list[str] = SettingsField(
+    abc_export_flags: list[str] = SettingsField(
         default_factory=list,
         enum_resolver=alembic_booleans_enum,
-        title="Alembic Boolean Args",
+        title="Export Flags (.abc)",
     )
-    abc_args_overrides: list[str] = SettingsField(
+    abc_export_overrides: list[str] = SettingsField(
         default_factory=list,
         enum_resolver=alembic_arguments_enum,
-        title="Alembic Arguments Overrides",
+        title="Export Overrides (.abc)",
     )
 
 
@@ -187,15 +187,15 @@ class CreatePointCacheModel(BaseSettingsModel):
         enum_resolver=alembic_data_formats,
         title="Data Format",
     )
-    abc_boolean_args: list[str] = SettingsField(
+    abc_export_flags: list[str] = SettingsField(
         default_factory=list,
         enum_resolver=alembic_booleans_enum,
-        title="Alembic Boolean Args",
+        title="Export Flags (.abc)",
     )
-    abc_args_overrides: list[str] = SettingsField(
+    abc_export_overrides: list[str] = SettingsField(
         default_factory=list,
         enum_resolver=alembic_arguments_enum,
-        title="Alembic Arguments Overrides",
+        title="Export Overrides (.abc)",
     )
 
 
@@ -399,13 +399,13 @@ DEFAULT_CREATORS_SETTINGS = {
             "Main"
         ],
         "step": 1.0,
-        "abc_boolean_args": [
+        "abc_export_flags": [
             "writeColorSets",
             "visibleOnly",
             "worldSpace",
             "writeNormals"
         ],
-        "abc_args_overrides": [
+        "abc_export_overrides": [
             "step",
             "includeParentHierarchy",
             "writeNormals",
@@ -439,13 +439,13 @@ DEFAULT_CREATORS_SETTINGS = {
             "Main"
         ],
         "step": 1.0,
-        "abc_boolean_args": [
+        "abc_export_flags": [
             "selection",
             "uvWrite",
             "writeCreases",
             "writeVisibility"
         ],
-        "abc_args_overrides": [
+        "abc_export_overrides": [
             "attr",
             "attrPrefix",
             "step",