Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-24 21:04:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Added todo note to get rid of instance variable

Browse source
This commit is contained in:
Petr Kalis 2024-09-05 12:48:32 +02:00
parent 4faf71b8e7
commit 916c9a6257
1 changed files with 8 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

13
client/ayon_core/plugins/publish/extract_otio_review.py
View file

@ -61,7 +61,8 @@ class ExtractOTIOReview(publish.Extractor):
make_sequence_collection
)
self.temp_file_head = self._get_unique_file_prefix(instance)
# TODO refactore from using instance variable
self.temp_file_head = self._get_folder_name_based_prefix(instance)
# TODO: convert resulting image sequence to mp4
@ -493,11 +494,13 @@ class ExtractOTIOReview(publish.Extractor):
return output_path, out_frame_start
def _get_unique_file_prefix(self, instance):
"""Creates unique human readable file prefix to differentiate.
def _get_folder_name_based_prefix(self, instance):
"""Creates 'unique' human readable file prefix to differentiate.
Multiple instances might share same temp folder, this will provide
unique prefix for intermediate file for burnins.
Multiple instances might share same temp folder, but each instance
would be differentiated by asset, eg. folder name.
It ix expected that there won't be multiple instances for same asset.
"""
folder_path = instance.data["folderPath"]
folder_name = folder_path.split("/")[-1]