From a3e8828ad1759b8ed943d5edb1fcb2e45d79388e Mon Sep 17 00:00:00 2001 From: Jakub Jezek Date: Mon, 10 Aug 2020 16:39:06 +0200 Subject: [PATCH] hound(sp): suggestions --- pype/plugins/global/publish/extract_burnin.py | 3 --- pype/plugins/global/publish/extract_review.py | 3 --- .../publish/collect_hierarchy.py | 1 + .../publish/extract_shot_data.py | 1 - .../publish/validate_clips.py | 24 ------------------- 5 files changed, 1 insertion(+), 31 deletions(-) delete mode 100644 pype/plugins/standalonepublisher/publish/validate_clips.py diff --git a/pype/plugins/global/publish/extract_burnin.py b/pype/plugins/global/publish/extract_burnin.py index 08aa2c2d05..e1508b9131 100644 --- a/pype/plugins/global/publish/extract_burnin.py +++ b/pype/plugins/global/publish/extract_burnin.py @@ -49,9 +49,6 @@ class ExtractBurnin(pype.api.Extractor): fields = None def process(self, instance): - representation = instance.data["representations"] - self.log.debug(f"_ representation: {representation}") - # ffmpeg doesn't support multipart exrs if instance.data.get("multipartExr") is True: instance_label = ( diff --git a/pype/plugins/global/publish/extract_review.py b/pype/plugins/global/publish/extract_review.py index 46de467b2c..a16c3ce256 100644 --- a/pype/plugins/global/publish/extract_review.py +++ b/pype/plugins/global/publish/extract_review.py @@ -50,9 +50,6 @@ class ExtractReview(pyblish.api.InstancePlugin): to_height = 1080 def process(self, instance): - representation = instance.data["representations"] - self.log.debug(f"_ representation: {representation}") - # ffmpeg doesn't support multipart exrs if instance.data.get("multipartExr") is True: instance_label = ( diff --git a/pype/plugins/standalonepublisher/publish/collect_hierarchy.py b/pype/plugins/standalonepublisher/publish/collect_hierarchy.py index 7c66f21966..b5d37d0a6c 100644 --- a/pype/plugins/standalonepublisher/publish/collect_hierarchy.py +++ b/pype/plugins/standalonepublisher/publish/collect_hierarchy.py @@ -3,6 +3,7 @@ import re import os from avalon import io + class CollectHierarchyInstance(pyblish.api.ContextPlugin): """Collecting hierarchy context from `parents` and `hierarchy` data present in `clip` family instances coming from the request json data file diff --git a/pype/plugins/standalonepublisher/publish/extract_shot_data.py b/pype/plugins/standalonepublisher/publish/extract_shot_data.py index 8c626b277c..6cbc2c7882 100644 --- a/pype/plugins/standalonepublisher/publish/extract_shot_data.py +++ b/pype/plugins/standalonepublisher/publish/extract_shot_data.py @@ -1,7 +1,6 @@ import os import clique import pype.api -import pype.lib as plib from pprint import pformat diff --git a/pype/plugins/standalonepublisher/publish/validate_clips.py b/pype/plugins/standalonepublisher/publish/validate_clips.py deleted file mode 100644 index 35b81da5c1..0000000000 --- a/pype/plugins/standalonepublisher/publish/validate_clips.py +++ /dev/null @@ -1,24 +0,0 @@ - # Check for clips with the same range - # this is for testing if any vertically neighbouring - # clips has been already processed - clip_matching_with_range = next( - (k for k, v in context.data["assetsShared"].items() - if (v.get("_clipIn", 0) == clip_in) - and (v.get("_clipOut", 0) == clip_out) - ), False) - - # check if clip name is the same in matched - # vertically neighbouring clip - # if it is then it is correct and resent variable to False - # not to be rised wrong name exception - if asset in str(clip_matching_with_range): - clip_matching_with_range = False - - # rise wrong name exception if found one - assert (not clip_matching_with_range), ( - "matching clip: {asset}" - " timeline range ({clip_in}:{clip_out})" - " conflicting with {clip_matching_with_range}" - " >> rename any of clips to be the same as the other <<" - ).format( - **locals())