From aa5ecbc08f459f229309179e37c413e7b3cf79b4 Mon Sep 17 00:00:00 2001 From: Milan Kolar Date: Tue, 26 Feb 2019 17:37:24 +0100 Subject: [PATCH] fix session rollback on event --- pype/ftrack/events/event_del_avalon_id_from_new.py | 1 + pype/ftrack/events/event_next_task_update.py | 1 - pype/ftrack/events/event_radio_buttons.py | 1 - pype/ftrack/events/event_sync_to_avalon.py | 1 - pype/ftrack/events/event_test.py | 2 +- pype/ftrack/events/event_thumbnail_updates.py | 1 + pype/ftrack/events/event_version_to_task_statuses.py | 2 +- 7 files changed, 4 insertions(+), 5 deletions(-) diff --git a/pype/ftrack/events/event_del_avalon_id_from_new.py b/pype/ftrack/events/event_del_avalon_id_from_new.py index 43812675e5..c449739800 100644 --- a/pype/ftrack/events/event_del_avalon_id_from_new.py +++ b/pype/ftrack/events/event_del_avalon_id_from_new.py @@ -49,6 +49,7 @@ class DelAvalonIdFromNew(BaseEvent): except Exception: continue + def register(self): '''Registers the event, subscribing the discover and launch topics.''' self.session.event_hub.subscribe( diff --git a/pype/ftrack/events/event_next_task_update.py b/pype/ftrack/events/event_next_task_update.py index 3391b3516f..8be146fc36 100644 --- a/pype/ftrack/events/event_next_task_update.py +++ b/pype/ftrack/events/event_next_task_update.py @@ -78,7 +78,6 @@ class NextTaskUpdate(BaseEvent): session.commit() - def register(session, **kw): '''Register plugin. Called when used as an plugin.''' if not isinstance(session, ftrack_api.session.Session): diff --git a/pype/ftrack/events/event_radio_buttons.py b/pype/ftrack/events/event_radio_buttons.py index 6d06326365..7af720d95d 100644 --- a/pype/ftrack/events/event_radio_buttons.py +++ b/pype/ftrack/events/event_radio_buttons.py @@ -31,7 +31,6 @@ class Radio_buttons(BaseEvent): session.commit() - def register(session): '''Register plugin. Called when used as an plugin.''' if not isinstance(session, ftrack_api.session.Session): diff --git a/pype/ftrack/events/event_sync_to_avalon.py b/pype/ftrack/events/event_sync_to_avalon.py index 994c58637d..2c740c1955 100644 --- a/pype/ftrack/events/event_sync_to_avalon.py +++ b/pype/ftrack/events/event_sync_to_avalon.py @@ -5,7 +5,6 @@ from pype.ftrack import BaseEvent, lib class Sync_to_Avalon(BaseEvent): def launch(self, session, entities, event): - ca_mongoid = lib.get_ca_mongoid() # If mongo_id textfield has changed: RETURN! # - infinite loop diff --git a/pype/ftrack/events/event_test.py b/pype/ftrack/events/event_test.py index 43c805119e..f1917addf0 100644 --- a/pype/ftrack/events/event_test.py +++ b/pype/ftrack/events/event_test.py @@ -17,7 +17,7 @@ class Test_Event(BaseEvent): '''just a testing event''' - self.log.info(event) + # self.log.info(event) return True diff --git a/pype/ftrack/events/event_thumbnail_updates.py b/pype/ftrack/events/event_thumbnail_updates.py index b6e0b12d56..b7429bcfaf 100644 --- a/pype/ftrack/events/event_thumbnail_updates.py +++ b/pype/ftrack/events/event_thumbnail_updates.py @@ -38,6 +38,7 @@ class ThumbnailEvents(BaseEvent): session.commit() + pass def register(session, **kw): '''Register plugin. Called when used as an plugin.''' diff --git a/pype/ftrack/events/event_version_to_task_statuses.py b/pype/ftrack/events/event_version_to_task_statuses.py index 471c3c9bc8..fabf8c2859 100644 --- a/pype/ftrack/events/event_version_to_task_statuses.py +++ b/pype/ftrack/events/event_version_to_task_statuses.py @@ -6,8 +6,8 @@ class VersionToTaskStatus(BaseEvent): def launch(self, session, entities, event): '''Propagates status from version to task when changed''' + session.commit() - # self.log.info(event) # start of event procedure ---------------------------------- for entity in event['data'].get('entities', []): # Filter non-assetversions