Merge pull request #1431 from pypeclub/bugfix/extract_review_ignore_empty_strings

ExtractReview skip empty strings from settings
This commit is contained in:
Milan Kolar 2021-04-29 16:35:10 +02:00 committed by GitHub
commit abbe5359c8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -333,10 +333,24 @@ class ExtractReview(pyblish.api.InstancePlugin):
# Get FFmpeg arguments from profile presets
out_def_ffmpeg_args = output_def.get("ffmpeg_args") or {}
ffmpeg_input_args = out_def_ffmpeg_args.get("input") or []
ffmpeg_output_args = out_def_ffmpeg_args.get("output") or []
ffmpeg_video_filters = out_def_ffmpeg_args.get("video_filters") or []
ffmpeg_audio_filters = out_def_ffmpeg_args.get("audio_filters") or []
_ffmpeg_input_args = out_def_ffmpeg_args.get("input") or []
_ffmpeg_output_args = out_def_ffmpeg_args.get("output") or []
_ffmpeg_video_filters = out_def_ffmpeg_args.get("video_filters") or []
_ffmpeg_audio_filters = out_def_ffmpeg_args.get("audio_filters") or []
# Cleanup empty strings
ffmpeg_input_args = [
value for value in _ffmpeg_input_args if value.strip()
]
ffmpeg_output_args = [
value for value in _ffmpeg_output_args if value.strip()
]
ffmpeg_video_filters = [
value for value in _ffmpeg_video_filters if value.strip()
]
ffmpeg_audio_filters = [
value for value in _ffmpeg_audio_filters if value.strip()
]
if isinstance(new_repre['files'], list):
input_files_urls = [os.path.join(new_repre["stagingDir"], f) for f