From abc266e9e5868277b47c2dabdd1697ec13d1a024 Mon Sep 17 00:00:00 2001
From: Jakub Jezek <jakubjezek001@gmail.com>
Date: Thu, 1 Jun 2023 16:14:29 +0200
Subject: [PATCH] refactor the script to be frame number rather then  frame
 range

---
 .../startup/frame_setting_for_read_nodes.py   | 47 ++++++++++++++++++
 .../startup/ops_frame_setting_for_read.py     | 49 -------------------
 .../defaults/project_settings/nuke.json       |  6 +--
 3 files changed, 50 insertions(+), 52 deletions(-)
 create mode 100644 openpype/hosts/nuke/startup/frame_setting_for_read_nodes.py
 delete mode 100644 openpype/hosts/nuke/startup/ops_frame_setting_for_read.py

diff --git a/openpype/hosts/nuke/startup/frame_setting_for_read_nodes.py b/openpype/hosts/nuke/startup/frame_setting_for_read_nodes.py
new file mode 100644
index 0000000000..f0cbabe20f
--- /dev/null
+++ b/openpype/hosts/nuke/startup/frame_setting_for_read_nodes.py
@@ -0,0 +1,47 @@
+""" OpenPype custom script for resetting read nodes start frame values """
+
+import nuke
+import nukescripts
+
+
+class FrameSettingsPanel(nukescripts.PythonPanel):
+    """ Frame Settings Panel """
+    def __init__(self):
+        nukescripts.PythonPanel.__init__(self, "Set Frame Start (Read Node)")
+
+        # create knobs
+        self.frame = nuke.Int_Knob(
+            'frame', 'Frame Number')
+        self.selected = nuke.Boolean_Knob("selection")
+        # add knobs to panel
+        self.addKnob(self.selected)
+        self.addKnob(self.frame)
+
+        # set values
+        self.selected.setValue(False)
+        self.frame.setValue(nuke.root().firstFrame())
+
+    def process(self):
+        """ Process the panel values. """
+        # get values
+        frame = self.frame.value()
+        if self.selected.value():
+            # selected nodes processing
+            if not nuke.selectedNodes():
+                return
+            for rn_ in nuke.selectedNodes():
+                if rn_.Class() != "Read":
+                    continue
+                rn_["frame_mode"].setValue("start_at")
+                rn_["frame"].setValue(str(frame))
+        else:
+            # all nodes processing
+            for rn_ in nuke.allNodes(filter="Read"):
+                rn_["frame_mode"].setValue("start_at")
+                rn_["frame"].setValue(str(frame))
+
+
+def main():
+    p_ = FrameSettingsPanel()
+    if p_.showModalDialog():
+        print(p_.process())
diff --git a/openpype/hosts/nuke/startup/ops_frame_setting_for_read.py b/openpype/hosts/nuke/startup/ops_frame_setting_for_read.py
deleted file mode 100644
index bf98ef83f6..0000000000
--- a/openpype/hosts/nuke/startup/ops_frame_setting_for_read.py
+++ /dev/null
@@ -1,49 +0,0 @@
-import nuke
-import nukescripts
-import re
-
-
-class FrameSettingsPanel(nukescripts.PythonPanel):
-    def __init__(self, node):
-        nukescripts.PythonPanel.__init__(self, 'Frame Range')
-        self.read_node = node
-        # CREATE KNOBS
-        self.range = nuke.String_Knob('fRange', 'Frame Range', '%s-%s' %
-                                      (nuke.root().firstFrame(),
-                                       nuke.root().lastFrame()))
-        self.selected = nuke.Boolean_Knob("selection")
-        self.info = nuke.Help_Knob("Instruction")
-        # ADD KNOBS
-        self.addKnob(self.selected)
-        self.addKnob(self.range)
-        self.addKnob(self.info)
-        self.selected.setValue(False)
-
-    def knobChanged(self, knob):
-        frame_range = self.range.value()
-        pattern = r"^(?P<start>-?[0-9]+)(?:(?:-+)(?P<end>-?[0-9]+))?$"
-        match = re.match(pattern, frame_range)
-        frame_start = int(match.group("start"))
-        frame_end = int(match.group("end"))
-        if not self.read_node:
-            return
-        for r in self.read_node:
-            if self.onchecked():
-                if not nuke.selectedNodes():
-                    return
-                if r in nuke.selectedNodes():
-                    r["frame_mode"].setValue("start_at")
-                    r["frame"].setValue(frame_range)
-                    r["first"].setValue(frame_start)
-                    r["last"].setValue(frame_end)
-            else:
-                r["frame_mode"].setValue("start_at")
-                r["frame"].setValue(frame_range)
-                r["first"].setValue(frame_start)
-                r["last"].setValue(frame_end)
-
-    def onchecked(self):
-        if self.selected.value():
-            return True
-        else:
-            return False
diff --git a/openpype/settings/defaults/project_settings/nuke.json b/openpype/settings/defaults/project_settings/nuke.json
index a0caa40396..3f8be4c872 100644
--- a/openpype/settings/defaults/project_settings/nuke.json
+++ b/openpype/settings/defaults/project_settings/nuke.json
@@ -226,9 +226,9 @@
             {
                 "type": "action",
                 "sourcetype": "python",
-                "title": "Set Frame Range (Read Node)",
-                "command": "import openpype.hosts.nuke.startup.ops_frame_setting_for_read as popup;import nuke;popup.FrameSettingsPanel(nuke.allNodes('Read')).showModalDialog();",
-                "tooltip": "Set Frame Range for Read Node(s)"
+                "title": "Set Frame Start (Read Node)",
+                "command": "from openpype.hosts.nuke.startup.frame_setting_for_read_nodes import main;main();",
+                "tooltip": "Set frame start for read node(s)"
             }
         ]
     },