From ad3dfa872e8fd5b88b1581e0a32eccfe6c2e335c Mon Sep 17 00:00:00 2001
From: Petr Kalis <petr.kalis@gmail.com>
Date: Mon, 11 Apr 2022 12:30:33 +0200
Subject: [PATCH] OP-2951 - refactor sync loaders

Changed structure of loaders bit, cannot use isinstance check though.
---
 openpype/plugins/load/add_site.py    |  1 +
 openpype/plugins/load/remove_site.py | 26 +++++++++++++++-----------
 openpype/tools/utils/lib.py          |  4 ++--
 3 files changed, 18 insertions(+), 13 deletions(-)

diff --git a/openpype/plugins/load/add_site.py b/openpype/plugins/load/add_site.py
index ae765c81b7..55fda55d17 100644
--- a/openpype/plugins/load/add_site.py
+++ b/openpype/plugins/load/add_site.py
@@ -23,6 +23,7 @@ class AddSyncSite(load.LoaderPlugin):
     color = "#999999"
 
     _sync_server = None
+    is_add_site_loader = True
 
     @property
     def sync_server(self):
diff --git a/openpype/plugins/load/remove_site.py b/openpype/plugins/load/remove_site.py
index adffec9986..c5f442b2f5 100644
--- a/openpype/plugins/load/remove_site.py
+++ b/openpype/plugins/load/remove_site.py
@@ -12,22 +12,26 @@ class RemoveSyncSite(load.LoaderPlugin):
     icon = "download"
     color = "#999999"
 
+    _sync_server = None
+    is_remove_site_loader = True
+
+    @property
+    def sync_server(self):
+        if not self._sync_server:
+            manager = ModulesManager()
+            self._sync_server = manager.modules_by_name["sync_server"]
+
+        return self._sync_server
+
     def load(self, context, name=None, namespace=None, data=None):
         self.log.info("Removing {} on representation: {}".format(
             data["site_name"], data["_id"]))
-        self.remove_site_on_representation(data["project_name"],
-                                           data["_id"],
-                                           data["site_name"])
+        self.sync_server.remove_site(data["project_name"],
+                                     data["_id"],
+                                     data["site_name"],
+                                     True)
         self.log.debug("Site added.")
 
-    @staticmethod
-    def remove_site_on_representation(project_name, representation_id,
-                                      site_name):
-        manager = ModulesManager()
-        sync_server = manager.modules_by_name["sync_server"]
-        sync_server.remove_site(project_name, representation_id,
-                                site_name, True)
-
     def filepath_from_context(self, context):
         """No real file loading"""
         return ""
diff --git a/openpype/tools/utils/lib.py b/openpype/tools/utils/lib.py
index 422d0f5389..e5d978c3b2 100644
--- a/openpype/tools/utils/lib.py
+++ b/openpype/tools/utils/lib.py
@@ -719,11 +719,11 @@ def is_sync_loader(loader):
 
 
 def is_remove_site_loader(loader):
-    return hasattr(loader, "remove_site_on_representation")
+    return hasattr(loader, "is_remove_site_loader")
 
 
 def is_add_site_loader(loader):
-    return hasattr(loader, "add_site_to_representation")
+    return hasattr(loader, "is_add_site_loader")
 
 
 class WrappedCallbackItem: