From bdaf86700bc33f85f13ee0f9fb5897770cef1aba Mon Sep 17 00:00:00 2001
From: Mustafa Zarkash <mustafataherzaky@outlook.com>
Date: Fri, 4 Aug 2023 15:28:33 +0300
Subject: [PATCH] Bugfix: houdini hard coded project settings (#5400)

* get poject settings in creator

* add comment about reading ext from project settings

* update validator to get project settings

* update comment about reading ext from project settings

* revert explicit edits it's automated

* remove redundant line
---
 openpype/hosts/houdini/api/plugin.py          | 19 +++++++++++++++++++
 .../plugins/create/create_arnold_ass.py       |  2 ++
 .../publish/validate_workfile_paths.py        |  2 --
 3 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/openpype/hosts/houdini/api/plugin.py b/openpype/hosts/houdini/api/plugin.py
index 05e52e2478..70c837205e 100644
--- a/openpype/hosts/houdini/api/plugin.py
+++ b/openpype/hosts/houdini/api/plugin.py
@@ -167,6 +167,7 @@ class HoudiniCreatorBase(object):
 class HoudiniCreator(NewCreator, HoudiniCreatorBase):
     """Base class for most of the Houdini creator plugins."""
     selected_nodes = []
+    settings_name = None
 
     def create(self, subset_name, instance_data, pre_create_data):
         try:
@@ -294,3 +295,21 @@ class HoudiniCreator(NewCreator, HoudiniCreatorBase):
 
         """
         return [hou.ropNodeTypeCategory()]
+
+    def apply_settings(self, project_settings, system_settings):
+        """Method called on initialization of plugin to apply settings."""
+
+        settings_name = self.settings_name
+        if settings_name is None:
+            settings_name = self.__class__.__name__
+
+        settings = project_settings["houdini"]["create"]
+        settings = settings.get(settings_name)
+        if settings is None:
+            self.log.debug(
+                "No settings found for {}".format(self.__class__.__name__)
+            )
+            return
+
+        for key, value in settings.items():
+            setattr(self, key, value)
diff --git a/openpype/hosts/houdini/plugins/create/create_arnold_ass.py b/openpype/hosts/houdini/plugins/create/create_arnold_ass.py
index 8b310753d0..45ef9ea82f 100644
--- a/openpype/hosts/houdini/plugins/create/create_arnold_ass.py
+++ b/openpype/hosts/houdini/plugins/create/create_arnold_ass.py
@@ -13,6 +13,8 @@ class CreateArnoldAss(plugin.HoudiniCreator):
     defaults = ["Main"]
 
     # Default extension: `.ass` or `.ass.gz`
+    # however calling HoudiniCreator.create()
+    # will override it by the value in the project settings
     ext = ".ass"
 
     def create(self, subset_name, instance_data, pre_create_data):
diff --git a/openpype/hosts/houdini/plugins/publish/validate_workfile_paths.py b/openpype/hosts/houdini/plugins/publish/validate_workfile_paths.py
index 543c8e1407..afe05e3173 100644
--- a/openpype/hosts/houdini/plugins/publish/validate_workfile_paths.py
+++ b/openpype/hosts/houdini/plugins/publish/validate_workfile_paths.py
@@ -7,8 +7,6 @@ from openpype.pipeline import (
 )
 from openpype.pipeline.publish import RepairAction
 
-from openpype.pipeline.publish import RepairAction
-
 
 class ValidateWorkfilePaths(
         pyblish.api.InstancePlugin, OptionalPyblishPluginMixin):