Frame13/ayon-core
1
0
Fork 1
mirror of https://github.com/ynput/ayon-core.git synced 2025-12-24 12:54:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Improves thumbnail extraction reliability

Browse source 
Ensures thumbnail extraction falls back to the first frame if the initial attempt fails, handling potential issues with seek position calculation or output file creation. This enhances the robustness of the thumbnail creation process.
This commit is contained in:
Jakub Jezek 2025-04-17 12:55:02 +02:00
parent ca12d13a40
commit bf44622c05
No known key found for this signature in database
GPG key ID: 06DBD609ADF27FD9
1 changed files with 18 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

24
client/ayon_core/plugins/publish/extract_thumbnail.py
View file

@ -498,7 +498,8 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
# For very short videos, just use the first frame
# Calculate seek position safely
seek_position = 0
if duration > 0.1: # Only use timestamp calculation for videos longer than 0.1 seconds
# Only use timestamp calculation for videos longer than 0.1 seconds
if duration > 0.1:
seek_position = duration * self.duration_split
# Build command args
@ -531,13 +532,17 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
run_subprocess(cmd, logger=self.log)
# Verify the output file was created
if os.path.exists(output_thumb_file_path) and os.path.getsize(output_thumb_file_path) > 0:
if (
os.path.exists(output_thumb_file_path)
and os.path.getsize(output_thumb_file_path) > 0
):
self.log.debug(
"Thumbnail created: {}".format(output_thumb_file_path))
return output_thumb_file_path
else:
self.log.warning(
"Output file was not created or is empty: {}".format(output_thumb_file_path))
"Output file was not created or is empty: {}".format(
output_thumb_file_path))
# Fallback to extracting the first frame without seeking
if "-ss" in cmd_args:
@ -549,11 +554,18 @@ class ExtractThumbnail(pyblish.api.InstancePlugin):
# Create new command and try again
cmd = get_ffmpeg_tool_args("ffmpeg", *cmd_args)
self.log.debug("Fallback command: {}".format(" ".join(cmd)))
self.log.debug("Fallback command: {}".format(
" ".join(cmd)))
run_subprocess(cmd, logger=self.log)
if os.path.exists(output_thumb_file_path) and os.path.getsize(output_thumb_file_path) > 0:
self.log.debug("Fallback thumbnail created: {}".format(output_thumb_file_path))
if (
os.path.exists(output_thumb_file_path)
and os.path.getsize(output_thumb_file_path) > 0
):
self.log.debug(
"Fallback thumbnail created: {}".format(
output_thumb_file_path)
)
return output_thumb_file_path
return None