BigRoy's comments

openpype/hosts/houdini/plugins/publish/validate_review_colorspace.py

@@ -37,47 +37,30 @@ class ValidateReviewColorspace(pyblish.api.InstancePlugin,
         if not self.is_active(instance.data):
             return
 
-        invalid_nodes, message = self.get_invalid_with_message(instance)
-        if invalid_nodes:
-            raise PublishValidationError(
-                message,
-                title=self.label
-            )
-
-    @classmethod
-    def get_invalid_with_message(cls, instance):
-
-        rop_node = hou.node(instance.data["instance_node"])
         if os.getenv("OCIO") is None:
-            cls.log.debug(
+            self.log.debug(
                 "Default Houdini colorspace is used, "
                 " skipping check.."
             )
-            return None, None
+            return
 
+        rop_node = hou.node(instance.data["instance_node"])
         if rop_node.evalParm("colorcorrect") != 2:
             # any colorspace settings other than default requires
             # 'Color Correct' parm to be set to 'OpenColorIO'
-            error = (
+            raise PublishValidationError(
                 "'Color Correction' parm on '{}' ROP must be set to"
                 " 'OpenColorIO'".format(rop_node.path())
             )
-            return rop_node, error
 
         if rop_node.evalParm("ociocolorspace") not in \
                 hou.Color.ocio_spaces():
 
-            error = (
+            raise PublishValidationError(
                 "Invalid value: Colorspace name doesn't exist.\n"
                 "Check 'OCIO Colorspace' parameter on '{}' ROP"
                 .format(rop_node.path())
             )
-            return rop_node, error
-
-    @classmethod
-    def get_invalid(cls, instance):
-        nodes, _ = cls.get_invalid_with_message(instance)
-        return nodes
 
     @classmethod
     def repair(cls, instance):