From d5d3ec2f901707150ab6fec3484391b47b295fcd Mon Sep 17 00:00:00 2001 From: iLLiCiTiT Date: Thu, 29 Apr 2021 19:23:22 +0200 Subject: [PATCH] fix install thread --- igniter/install_dialog.py | 3 ++- igniter/install_thread.py | 3 +-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/igniter/install_dialog.py b/igniter/install_dialog.py index d8a80d9fe4..ee1ba7ba7c 100644 --- a/igniter/install_dialog.py +++ b/igniter/install_dialog.py @@ -407,7 +407,8 @@ class InstallDialog(QtWidgets.QDialog): install_thread.start() - def _installation_finished(self, status): + def _installation_finished(self): + status = self._install_thread.result() if status >= 0: self._update_progress(100) QtWidgets.QApplication.processEvents() diff --git a/igniter/install_thread.py b/igniter/install_thread.py index 8505e9b4ba..383012b88b 100644 --- a/igniter/install_thread.py +++ b/igniter/install_thread.py @@ -30,7 +30,6 @@ class InstallThread(QThread): """ progress = Signal(int) message = Signal((str, bool)) - finished = Signal(int) def __init__(self, parent=None,): self._mongo = None @@ -47,7 +46,6 @@ class InstallThread(QThread): if self._result is not None: raise AssertionError("BUG: Result was set more than once!") self._result = value - self.finished.emit(value) def run(self): """Thread entry point. @@ -162,6 +160,7 @@ class InstallThread(QThread): self.message.emit(f"Installed as {local_openpype}", False) self.progress.emit(100) + self._set_result(1) return else: # if we have mongo connection string, validate it, set it to