From d8c3535b6b3d3c3983995d314322828ecbd5c1c5 Mon Sep 17 00:00:00 2001
From: "clement.hector" <clement.hector@gmail.com>
Date: Mon, 4 Oct 2021 18:06:23 +0200
Subject: [PATCH] fix djv view for openpype3

---
 openpype/plugins/load/open_djv.py | 38 +++++++++++++++----------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/openpype/plugins/load/open_djv.py b/openpype/plugins/load/open_djv.py
index 39b54364d9..5b49bb58d0 100644
--- a/openpype/plugins/load/open_djv.py
+++ b/openpype/plugins/load/open_djv.py
@@ -1,26 +1,28 @@
 import os
-import subprocess
 from avalon import api
+from openpype.api import ApplicationManager
 
 
 def existing_djv_path():
-    djv_paths = os.environ.get("DJV_PATH") or ""
-    for path in djv_paths.split(os.pathsep):
-        if os.path.exists(path):
-            return path
-    return None
+    app_manager = ApplicationManager()
+    djv_list = []
 
+    for app_name, app in app_manager.applications.items():
+        if 'djv' in app_name and app.find_executable():
+            djv_list.append(app_name)
+
+    return djv_list
 
 class OpenInDJV(api.Loader):
     """Open Image Sequence with system default"""
 
-    djv_path = existing_djv_path()
-    families = ["*"] if djv_path else []
+    djv_list = existing_djv_path()
+    families = ["*"] if djv_list else []
     representations = [
         "cin", "dpx", "avi", "dv", "gif", "flv", "mkv", "mov", "mpg", "mpeg",
         "mp4", "m4v", "mxf", "iff", "z", "ifl", "jpeg", "jpg", "jfif", "lut",
         "1dl", "exr", "pic", "png", "ppm", "pnm", "pgm", "pbm", "rla", "rpf",
-        "sgi", "rgba", "rgb", "bw", "tga", "tiff", "tif", "img"
+        "sgi", "rgba", "rgb", "bw", "tga", "tiff", "tif", "img", "h264",
     ]
 
     label = "Open in DJV"
@@ -41,20 +43,18 @@ class OpenInDJV(api.Loader):
         )
 
         if not remainder:
-            seqeunce = collections[0]
-            first_image = list(seqeunce)[0]
+            sequence = collections[0]
+            first_image = list(sequence)[0]
         else:
             first_image = self.fname
         filepath = os.path.normpath(os.path.join(directory, first_image))
 
         self.log.info("Opening : {}".format(filepath))
 
-        cmd = [
-            # DJV path
-            os.path.normpath(self.djv_path),
-            # PATH TO COMPONENT
-            os.path.normpath(filepath)
-        ]
+        last_djv_version = sorted(self.djv_list)[-1]
 
-        # Run DJV with these commands
-        subprocess.Popen(cmd)
+        app_manager = ApplicationManager()
+        djv = app_manager.applications.get(last_djv_version)
+        djv.arguments.append(filepath)
+
+        app_manager.launch(last_djv_version)