From db5d997ce74ca264b7e0be996966534c4e2363e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ond=C5=99ej=20Samohel?= <ondrej.samohel@ynput.io>
Date: Fri, 8 Nov 2024 09:46:47 +0100
Subject: [PATCH] :art: add `get_versionless_id()` helper (and test)

---
 client/ayon_core/pipeline/traits/trait.py     | 13 ++++++++++++
 .../ayon_core/pipeline/traits/test_traits.py  | 20 +++++++++++++++++++
 2 files changed, 33 insertions(+)

diff --git a/client/ayon_core/pipeline/traits/trait.py b/client/ayon_core/pipeline/traits/trait.py
index 6c37f40a45..22e7fc6d64 100644
--- a/client/ayon_core/pipeline/traits/trait.py
+++ b/client/ayon_core/pipeline/traits/trait.py
@@ -94,6 +94,16 @@ class TraitBase(ABC, BaseModel):
         match = re.search(version_regex, str(cls.id))
         return int(match[1]) if match else None
 
+    @classmethod
+    def get_versionless_id(cls) -> str:
+        """Get trait ID without version.
+
+        Returns:
+            str: Trait ID without version.
+
+        """
+        return re.sub(r"\.v\d+$", "", str(cls.id))
+
 
 class Representation:
     """Representation of products.
@@ -416,6 +426,9 @@ class Representation:
             bool: True if the representations are equal, False otherwise.
 
         """
+        if self.representation_id != other.representation_id:
+            return False
+
         if not isinstance(other, Representation):
             return False
 
diff --git a/tests/client/ayon_core/pipeline/traits/test_traits.py b/tests/client/ayon_core/pipeline/traits/test_traits.py
index 43d8301e00..8a6e210b78 100644
--- a/tests/client/ayon_core/pipeline/traits/test_traits.py
+++ b/tests/client/ayon_core/pipeline/traits/test_traits.py
@@ -252,6 +252,26 @@ def test_get_version_from_id() -> None:
 
     assert TestMimeType(mime_type="foo/bar").get_version() is None
 
+def test_get_versionless_id() -> None:
+    """Test getting versionless trait ID."""
+    assert Image().get_versionless_id() == "ayon.2d.Image"
+
+    class TestOverscan(Overscan):
+        id = "ayon.2d.Overscan.v2"
+
+    assert TestOverscan(
+        left=0,
+        right=0,
+        top=0,
+        bottom=0
+    ).get_versionless_id() == "ayon.2d.Overscan"
+
+    class TestMimeType(MimeType):
+        id = "ayon.content.MimeType"
+
+    assert TestMimeType(mime_type="foo/bar").get_versionless_id() == \
+           "ayon.content.MimeType"
+
 
 def test_from_dict() -> None:
     """Test creating representation from dictionary."""